@@ -1,3 +1,5 @@ +* Optimize Function#bind and Function#bindAsEventListener to avoid using Array#concat when only the context argument is given. [kangax] + * Ensure Selector.handlers.id finds the proper element even when it's not attached to the document. [jddalton] * Fix Position.within in IE. [jddalton] CHANGELOG @@ -168,16 +168,30 @@ Object.extend(Function.prototype, { bind: function() { if (arguments.length < 2 && Object.isUndefined(arguments[0])) return this; var __method = this, args = $A(arguments), object = args.shift(); - return function() { - return __method.apply(object, args.concat($A(arguments))); + + // Avoid using Array#concat when only the context argument is given. + if (args.length) { + return function() { + return __method.apply(object, args.concat($A(arguments))); + }; } + return function() { + return __method.apply(object, arguments); + }; }, bindAsEventListener: function() { var __method = this, args = $A(arguments), object = args.shift(); - return function(event) { - return __method.apply(object, [event || window.event].concat(args)); + + // Avoid using Array#concat when only the context argument is given. + if (args.length) { + return function(event) { + return __method.apply(object, [event || window.event].concat(args)); + }; } + return function(event) { + return __method.apply(object, [event || window.event]); + }; }, curry: function() { src/base.js 4b2913c79f9d57e96360294d7a134593a8819c91 Andrew Dupont prototype@andrewdupont.net http://github.com/sstephenson/prototype/commit/76e6f9fa46e45c8131d549621684a3d473ba0653 76e6f9fa46e45c8131d549621684a3d473ba0653 2008-07-17T13:18:43-07:00 2008-07-17T13:18:43-07:00 Optimize Function#bind and Function#bindAsEventListener to avoid using Array#concat when only the context argument is given. [#215 state:resolved] e2c793823ed144acded77361150832f1bf360d13 Andrew Dupont prototype@andrewdupont.net