@@ -1,3 +1,5 @@ +* Use different tactic to sniff for Opera in order to avoid false positives in IE. [Tobie Langel, jddalton] + * Optimize Function#bind and Function#bindAsEventListener to avoid using Array#concat when only the context argument is given. [kangax] * Ensure Selector.handlers.id finds the proper element even when it's not attached to the document. [jddalton] CHANGELOG @@ -475,7 +475,7 @@ Element.Methods = { element.style.position = 'relative'; // Opera returns the offset relative to the positioning context, when an // element is position relative but top and left have not been defined - if (window.opera) { + if (Prototype.Browser.Opera) { element.style.top = 0; element.style.left = 0; } src/dom.js @@ -4,10 +4,12 @@ var Prototype = { Version: '<%= PROTOTYPE_VERSION %>', Browser: { - IE: !!(window.attachEvent && !window.opera), - Opera: !!window.opera, + IE: !!(window.attachEvent && + navigator.userAgent.indexOf('Opera') === -1), + Opera: navigator.userAgent.indexOf('Opera') > -1, WebKit: navigator.userAgent.indexOf('AppleWebKit/') > -1, - Gecko: navigator.userAgent.indexOf('Gecko') > -1 && navigator.userAgent.indexOf('KHTML') == -1, + Gecko: navigator.userAgent.indexOf('Gecko') > -1 && + navigator.userAgent.indexOf('KHTML') === -1, MobileSafari: !!navigator.userAgent.match(/Apple.*Mobile.*Safari/) }, src/prototype.js 76e6f9fa46e45c8131d549621684a3d473ba0653 Andrew Dupont prototype@andrewdupont.net http://github.com/sstephenson/prototype/commit/9f00912b52125f3bdaee4aa544a885a1cae993e0 9f00912b52125f3bdaee4aa544a885a1cae993e0 2008-07-17T13:22:18-07:00 2008-07-17T13:22:18-07:00 Use different tactic to sniff for Opera in order to avoid false positives in IE. [#176 state:resolved] 228aee29b7eb48c94122782aab50f0cf3786b36e Andrew Dupont prototype@andrewdupont.net