@@ -12,7 +12,7 @@ var Form = { var data = elements.inject({ }, function(result, element) { if (!element.disabled && element.name) { key = element.name; value = $(element).getValue(); - if (value != null && (element.type != 'submit' || (!submitted && + if (value != null && element.type != 'file' && (element.type != 'submit' || (!submitted && submit !== false && (!submit || key == submit) && (submitted = true)))) { if (key in result) { // a key is already present; construct an array of values src/form.js @@ -79,6 +79,10 @@ <input type="text" /> </form> +<form id="form_with_file_input"> + <input type="file" name="file_name" value="foo" /> +</form> + <!-- tabindexed forms --> <div id="tabindex"> <form id="ffe"> test/unit/fixtures/form.html @@ -271,7 +271,9 @@ new Test.Unit.Runner({ $('form').serialize({ submit: false })); this.assertHashEqual({ val1:4, action:'blah' }, $('form').serialize({ submit: 'inexistent' })); - + + // file input should not be serialized + this.assertEqual('', $('form_with_file_input').serialize()); }, testFormMethodsOnExtendedElements: function() { test/unit/form_test.js 34fa0557d93cddeb4462d307204a320b38f6ca5e Andrew Dupont prototype@andrewdupont.net http://github.com/sstephenson/prototype/commit/bc60b6d207ef30201f34ae2716386602db4cc70a bc60b6d207ef30201f34ae2716386602db4cc70a 2008-05-06T13:12:18-07:00 2008-05-06T13:12:18-07:00 Form#serializeElements should not serialize file inputs. (cherry picked from commit 49f2f08b31c853d1639a56d0d78cf8a14bb8d848) cd70cbb8594d525cdff74e51652853421b1965c2 Andrew Dupont prototype@andrewdupont.net