@@ -1,8 +1,6 @@ require File.dirname(__FILE__) + '/../spec_helper' -# Be sure to include AuthenticatedTestHelper in spec/spec_helper.rb instead -# Then, you can remove it from this and the units test. -include AuthenticatedTestHelper +include OpenIdAuthentication describe SessionsController do fixtures :users @@ -10,7 +8,6 @@ describe SessionsController do @user = mock_user @login_params = { :login => 'quentin', :password => 'test' } User.stub!(:authenticate).with(@login_params[:login], @login_params[:password]).and_return(@user) - controller.stub!(:using_open_id?).and_return(false) end def do_create post :create, @login_params @@ -98,6 +95,39 @@ describe SessionsController do it 'redirects me to the home page' do do_destroy; response.should be_redirect end end + describe "with OpenID" do + describe "successful return" do + before(:each) do + controller.should_receive(:authenticate_with_open_id). + and_yield(Result[:successful], 'http://openid.yahoo.com/me/blah') + end + + it "should load the user based on identity url and log in" do + User.should_receive(:find_by_identity_url).with('http://openid.yahoo.com/me/blah').and_return(users(:quentin)) + controller.should_receive(:successful_login) + get :create, 'openid.identity' => 'http://openid.yahoo.com/me/blah', :open_id_complete => 1 + end + + it "should fail the login without a user found" do + User.should_receive(:find_by_identity_url).with('http://openid.yahoo.com/me/blah').and_return(nil) + controller.should_not_receive(:successful_login) + get :create, 'openid.identity' => 'http://openid.yahoo.com/me/blah', :open_id_complete => 1 + flash[:error].should == "Sorry, no user by that identity URL exists (http://openid.yahoo.com/me/blah)" + response.should render_template('new') + end + end + + describe "failed return" do + it "should fail the login" do + controller.should_receive(:authenticate_with_open_id). + and_yield(Result[:failed], 'http://openid.yahoo.com/me/blah') + controller.should_not_receive(:successful_login) + get :create, 'openid.identity' => 'http://openid.yahoo.com/me/blah', :open_id_complete => 1 + response.should render_template('new') + end + end + end + end describe SessionsController do spec/controllers/sessions_controller_spec.rb @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + '/../spec_helper' +include OpenIdAuthentication describe UsersController do fixtures :users @@ -10,9 +11,6 @@ describe UsersController do end.should change(User, :count).by(1) end - - - it 'requires login on signup' do lambda do create_user(:login => nil) @@ -45,11 +43,44 @@ describe UsersController do end.should_not change(User, :count) end + describe "with OpenID" do + it "should not require login" do + controller.should_receive(:authenticate_with_open_id).with('yahoo.com', {:return_to=>"http://test.host/opencreate"}) + create_user({:login => nil}, :openid_url => 'yahoo.com') + end + + it "should put the user info in the session" do + controller.should_receive(:authenticate_with_open_id).with('yahoo.com', {:return_to=>"http://test.host/opencreate"}) + create_user({:login => nil}, :openid_url => 'yahoo.com') + session[:user_params].should == { 'email' => 'quire@example.com', + 'password' => 'quire69', 'password_confirmation' => 'quire69', 'login' => nil } + end + + it "should create the user after returning from the provider" do + controller.should_receive(:authenticate_with_open_id). + with('http://openid.yahoo.com/me/blah', {:return_to=>"http://test.host/opencreate"}). + and_yield(Result[:successful], 'http://openid.yahoo.com/me/blah') + controller.should_receive(:create_new_user). + with({ 'email' => 'quire@example.com', :identity_url => 'http://openid.yahoo.com/me/blah' }) + request.session[:user_params] = { 'email' => 'quire@example.com' } + get :create, { :openid_url => 'http://openid.yahoo.com/me/blah', :open_id_complete => 1 } + end + + it "should warn on failing to create a user after returning from the provider" do + controller.should_receive(:authenticate_with_open_id). + with('http://openid.yahoo.com/me/blah', {:return_to=>"http://test.host/opencreate"}). + and_yield(Result[:failed], 'http://openid.yahoo.com/me/blah') + controller.should_not_receive(:create_new_user) + controller.should_receive(:failed_creation) + request.session[:user_params] = { 'email' => 'quire@example.com' } + get :create, { :openid_url => 'http://openid.yahoo.com/me/blah', :open_id_complete => 1 } + end + end - def create_user(options = {}) - post :create, :user => { :login => 'quire', :email => 'quire@example.com', - :password => 'quire69', :password_confirmation => 'quire69' }.merge(options) + def create_user(options = {}, extra_params = {}) + post :create, {:user => { :login => 'quire', :email => 'quire@example.com', + :password => 'quire69', :password_confirmation => 'quire69' }.merge(options)}.merge(extra_params) end end spec/controllers/users_controller_spec.rb @@ -213,6 +213,27 @@ describe User do users(:quentin).remember_token_expires_at.should_not be_nil users(:quentin).remember_token_expires_at.between?(before, after).should be_true end + + describe "with OpenID" do + before(:each) do + @user = User.new(:email => 'quire@example.com', :identity_url => 'http://yahoo.com') + end + + it "should not require a login or password" do + @user.should be_valid + end + + it "should indicate using OpenID" do + @user.not_using_openid?.should be_false + end + + it "should require a password if the user attempts to change the password" do + @user = users(:quentin) + @user.identity_url = 'http://yahoo.com' + @user.password = 'foo' + @user.password_required?.should be_true + end + end protected def create_user(options = {}) spec/models/user_spec.rb dc3cf3c0b5b8b21560ad592874c9aa52ee132f39 Benjamin Curtis benjamin.curtis@gmail.com http://github.com/stympy/openid-rails-kit/commit/22a3be9989c1fc1f137283c91c6264f7080520de 22a3be9989c1fc1f137283c91c6264f7080520de 2008-05-27T15:29:19-07:00 2008-05-27T15:29:19-07:00 Added some tests 4190be7187d3c0dc71f75ebddf007440af41e11b Benjamin Curtis benjamin.curtis@gmail.com