<#@ include file="Settings.ttinclude" #>
<#@ assembly name="MySql.Data" #>
<#@ import namespace="MySql.Data.MySqlClient" #>
<#+
const string FKSql=@"SELECT
        C.TABLE_NAME as ThisTable,
        C.COLUMN_NAME as ThisColumn,
        (SELECT DISTINCT FC.TABLE_NAME FROM information_schema.KEY_COLUMN_USAGE FC WHERE LOWER(C.REFERENCED_TABLE_NAME) = LOWER(FC.TABLE_NAME)) as OtherTable,
        C.REFERENCED_COLUMN_NAME as OtherColumn,
        C.CONSTRAINT_NAME as Constraint_Name,
        C.TABLE_SCHEMA as Owner
        FROM information_schema.KEY_COLUMN_USAGE C
        WHERE
        (C.REFERENCED_TABLE_SCHEMA = '{0}'
        AND C.REFERENCED_TABLE_NAME ='{1}'
        AND C.TABLE_NAME is not null
        )
        OR
        (C.TABLE_SCHEMA = '{2}'
        AND C.TABLE_NAME ='{3}'
        AND C.REFERENCED_TABLE_NAME is not null
        )
        ORDER BY C.TABLE_NAME, C.COLUMN_NAME;";
    
MySqlConnection conn;

MySqlCommand GetCommand(string sql){
    MySqlConnection conn=new MySqlConnection(ConnectionString);
    MySqlCommand cmd=new MySqlCommand(sql,conn);
    conn.Open();
    return cmd;
}

List LoadTables(){

    var result=new List();
    
    using(conn=new MySqlConnection(ConnectionString)){
             
        conn.Open();
        
        //this will return everything for the DB
        var schema  = conn.GetSchema("COLUMNS");
        conn.Close();
        
        //spin through once to get all the tables
        foreach (DataRow row in schema.Rows)
        {
            if(!result.Any(x=>x.Name.Equals(row["TABLE_NAME"].ToString(),StringComparison.InvariantCultureIgnoreCase)))
            {

                //add it
                Table tbl = new Table();
                tbl.PrimaryKey="";
                tbl.Name = row["TABLE_NAME"].ToString();
                tbl.Schema = row["TABLE_SCHEMA"].ToString();
                tbl.FKTables=LoadFKTables(tbl.Name);
                tbl.CleanName=CleanUp(tbl.Name);
                tbl.ClassName=Inflector.MakeSingular(tbl.CleanName);
                tbl.QueryableName=Inflector.MakePlural(tbl.ClassName);
                result.Add(tbl);
            }
        }
        
        //loop again - but this time pull by table name
        foreach (var item in result) {
            item.Columns=new List();
            //pull the columns from the schema
            var columns = schema.Select("TABLE_NAME='" + item.Name + "'");

            foreach (var row in columns) {
                Column col=new Column();
                col.Name=row["COLUMN_NAME"].ToString();
                col.CleanName=CleanUp(col.Name);
                col.DataType=row["DATA_TYPE"].ToString();
                col.SysType=GetSysType(col.DataType);
                col.DbType=GetDbType(col.DataType);
                
                col.AutoIncrement=row["EXTRA"].ToString()=="auto_increment";
                col.IsNullable=row["IS_NULLABLE"].ToString()=="YES";
                col.IsPK=row["COLUMN_KEY"].ToString()=="PRI";
                
                if(col.IsPK){
                    item.PrimaryKey=col.Name ?? "";
                }
                
                int.TryParse(row["CHARACTER_MAXIMUM_LENGTH"].ToString(),out col.MaxLength);
                
                item.Columns.Add(col);
            
            }
        }
        
foreach(Table tbl in result){
        //loop the FK tables and see if there's a match for our FK columns
        foreach(Column col in tbl.Columns){
            col.IsForeignKey=tbl.FKTables.Any(
                x=>x.ThisColumn.Equals(col.Name,StringComparison.InvariantCultureIgnoreCase)
            );
        }
    }
    
    }
        

    return result;
}

List LoadFKTables(string tableName){
    
    //this is a "bi-directional" scheme
    //which pulls both 1-many and many-1

    var result=new List();
    var cmd=GetCommand(string.Format(FKSql, DatabaseName, tableName, DatabaseName, tableName));
    //cmd.Parameters.AddWithValue("@tableName",tableName);
    using(IDataReader rdr=cmd.ExecuteReader(CommandBehavior.CloseConnection)){
        while(rdr.Read()){
            FKTable fk=new FKTable();
            string thisTable=rdr["ThisTable"].ToString();
            
            if(tableName.ToLower()==thisTable.ToLower()){
                fk.ThisTable=rdr["ThisTable"].ToString();
                fk.ThisColumn=rdr["ThisColumn"].ToString();
                fk.OtherTable=rdr["OtherTable"].ToString();
                fk.OtherColumn=rdr["OtherColumn"].ToString();
            
            }else{
                fk.ThisTable=rdr["OtherTable"].ToString();
                fk.ThisColumn=rdr["OtherColumn"].ToString();
                fk.OtherTable=rdr["ThisTable"].ToString();
                fk.OtherColumn=rdr["ThisColumn"].ToString();
          
            }
            
            fk.OtherClass=Inflector.MakeSingular(CleanUp(fk.OtherTable));
            fk.OtherQueryable=Inflector.MakePlural(CleanUp(fk.OtherTable)/*fk.OtherClass*/);
            
            result.Add(fk);
        }
    }
    return result;

}

string GetSysType(string sqlType){
    string sysType="string";
    switch (sqlType) {
        case "bigint":
            sysType= "long";
            break;
        case "int":
            sysType= "int";
            break;
        case "smallint":
            sysType= "short";
            break;
        case "guid":
            sysType=  "Guid";
             break;
        case "smalldatetime":
        case "date":
        case "datetime":
        case "timestamp":
            sysType=  "DateTime";
              break;
        case "double":
        case "float":
            sysType="double";
            break;
        case "real":
        case "numeric":
        case "smallmoney":
        case "decimal":
        case "money":
            sysType=  "decimal";
             break;
        case "tinyint":
        case "bit":
            sysType=  "bool";
               break;
        case "image":
        case "binary":
        case "varbinary":
            sysType=  "byte[]";
             break;
    }
    return sysType;
}
DbType GetDbType(string sqlType){
    switch(sqlType)
    {
        case "varchar":
            return DbType.AnsiString;
        case "nvarchar":
            return DbType.String;
        case "integer":
            return DbType.Int32;
        case "guid":
            return DbType.Guid;
        case "date":
        case "timestamp":
        case "datetime":
            return DbType.DateTime;
        case "bigint":
            return DbType.Int64;
        case "binary":
            return DbType.Binary;
        case "bit":
            return DbType.Boolean;
        case "char":
            return DbType.AnsiStringFixedLength;
        case "decimal":
            return DbType.Decimal;
        case "double":
        case "float":
            return DbType.Double;
        case "image":
            return DbType.Binary;
        case "money":
            return DbType.Currency;
        case "nchar":
            return DbType.String;
        case "longtext":
            return DbType.String;
        case "numeric":
            return DbType.Decimal;
        case "real":
            return DbType.Single;
        case "smalldatetime":
            return DbType.DateTime;
        case "smallint":
            return DbType.Int16;
        case "smallmoney":
            return DbType.Currency;
        case "sql_variant":
            return DbType.String;
        case "sysname":
            return DbType.String;
        case "text":
            return DbType.AnsiString;
        case "tinyint":
            return DbType.Byte;
        case "varbinary":
            return DbType.Binary;
        default:
            return DbType.AnsiString;
    }

}
#>
Comment
I think this bug need to be posted here: http://github.com/subsonic/SubSonic-3.0-Templates/issues.

Yes, in MySQL referenced tables stored in lower case. Our team modify MySQL.ttinclude. You can try to replace it with this:

<pre><code><#@ include file="Settings.ttinclude" #>
<#@ assembly name="MySql.Data" #>
<#@ import namespace="MySql.Data.MySqlClient" #>
<#+
const string FKSql=@"SELECT
        C.TABLE_NAME as ThisTable,
        C.COLUMN_NAME as ThisColumn,
        (SELECT DISTINCT FC.TABLE_NAME FROM information_schema.KEY_COLUMN_USAGE FC WHERE LOWER(C.REFERENCED_TABLE_NAME) = LOWER(FC.TABLE_NAME)) as OtherTable,
        C.REFERENCED_COLUMN_NAME as OtherColumn,
        C.CONSTRAINT_NAME as Constraint_Name,
        C.TABLE_SCHEMA as Owner
        FROM information_schema.KEY_COLUMN_USAGE C
        WHERE
        (C.REFERENCED_TABLE_SCHEMA = '{0}'
        AND C.REFERENCED_TABLE_NAME ='{1}'
        AND C.TABLE_NAME is not null
        )
        OR
        (C.TABLE_SCHEMA = '{2}'
        AND C.TABLE_NAME ='{3}'
        AND C.REFERENCED_TABLE_NAME is not null
        )
        ORDER BY C.TABLE_NAME, C.COLUMN_NAME;";
    
MySqlConnection conn;

MySqlCommand GetCommand(string sql){
    MySqlConnection conn=new MySqlConnection(ConnectionString);
    MySqlCommand cmd=new MySqlCommand(sql,conn);
    conn.Open();
    return cmd;
}

List<Table> LoadTables(){

    var result=new List<Table>();
    
    using(conn=new MySqlConnection(ConnectionString)){
             
        conn.Open();
        
        //this will return everything for the DB
        var schema  = conn.GetSchema("COLUMNS");
        conn.Close();
        
        //spin through once to get all the tables
        foreach (DataRow row in schema.Rows)
        {
            if(!result.Any(x=>x.Name.Equals(row["TABLE_NAME"].ToString(),StringComparison.InvariantCultureIgnoreCase)))
            {

                //add it
                Table tbl = new Table();
                tbl.PrimaryKey="";
                tbl.Name = row["TABLE_NAME"].ToString();
                tbl.Schema = row["TABLE_SCHEMA"].ToString();
				tbl.FKTables=LoadFKTables(tbl.Name);
                tbl.CleanName=CleanUp(tbl.Name);
                tbl.ClassName=Inflector.MakeSingular(tbl.CleanName);
                tbl.QueryableName=Inflector.MakePlural(tbl.ClassName);
                result.Add(tbl);
            }
        }
        
        //loop again - but this time pull by table name
        foreach (var item in result) {
            item.Columns=new List<Column>();
            //pull the columns from the schema
            var columns = schema.Select("TABLE_NAME='" + item.Name + "'");

            foreach (var row in columns) {
                Column col=new Column();
                col.Name=row["COLUMN_NAME"].ToString();
                col.CleanName=CleanUp(col.Name);
                col.DataType=row["DATA_TYPE"].ToString();
                col.SysType=GetSysType(col.DataType);
                col.DbType=GetDbType(col.DataType);
                
                col.AutoIncrement=row["EXTRA"].ToString()=="auto_increment";
                col.IsNullable=row["IS_NULLABLE"].ToString()=="YES";
                col.IsPK=row["COLUMN_KEY"].ToString()=="PRI";
                
                if(col.IsPK){
                    item.PrimaryKey=col.Name ?? "";
                }
                
                int.TryParse(row["CHARACTER_MAXIMUM_LENGTH"].ToString(),out col.MaxLength);
                
                item.Columns.Add(col);
            
            }
        }
        
foreach(Table tbl in result){
        //loop the FK tables and see if there's a match for our FK columns
        foreach(Column col in tbl.Columns){
            col.IsForeignKey=tbl.FKTables.Any(
                x=>x.ThisColumn.Equals(col.Name,StringComparison.InvariantCultureIgnoreCase)
            );
        }
    }
    
    }
        

    return result;
}

List<FKTable> LoadFKTables(string tableName){
    
    //this is a "bi-directional" scheme
    //which pulls both 1-many and many-1

    var result=new List<FKTable>();
    var cmd=GetCommand(string.Format(FKSql, DatabaseName, tableName, DatabaseName, tableName));
    //cmd.Parameters.AddWithValue("@tableName",tableName);
    using(IDataReader rdr=cmd.ExecuteReader(CommandBehavior.CloseConnection)){
        while(rdr.Read()){
            FKTable fk=new FKTable();
            string thisTable=rdr["ThisTable"].ToString();
            
            if(tableName.ToLower()==thisTable.ToLower()){
                fk.ThisTable=rdr["ThisTable"].ToString();
                fk.ThisColumn=rdr["ThisColumn"].ToString();
                fk.OtherTable=rdr["OtherTable"].ToString();
                fk.OtherColumn=rdr["OtherColumn"].ToString();
            
            }else{
                fk.ThisTable=rdr["OtherTable"].ToString();
                fk.ThisColumn=rdr["OtherColumn"].ToString();
                fk.OtherTable=rdr["ThisTable"].ToString();
                fk.OtherColumn=rdr["ThisColumn"].ToString();
          
            }
            
            fk.OtherClass=Inflector.MakeSingular(CleanUp(fk.OtherTable));
            fk.OtherQueryable=Inflector.MakePlural(CleanUp(fk.OtherTable)/*fk.OtherClass*/);
            
            result.Add(fk);
        }
    }
    return result;

}

string GetSysType(string sqlType){
	string sysType="string";
	switch (sqlType) {
		case "bigint":
			sysType= "long";
			break;
		case "int":
			sysType= "int";
			break;
		case "smallint":
			sysType= "short";
			break;
		case "guid":
			sysType=  "Guid";
			 break;
		case "smalldatetime":
		case "date":
		case "datetime":
		case "timestamp":
			sysType=  "DateTime";
			  break;
		case "double":
		case "float":
			sysType="double";
			break;
		case "real":
		case "numeric":
		case "smallmoney":
		case "decimal":
		case "money":
			sysType=  "decimal";
			 break;
		case "tinyint":
		case "bit":
			sysType=  "bool";
			   break;
		case "image":
		case "binary":
		case "varbinary":
			sysType=  "byte[]";
			 break;
	}
	return sysType;
}
DbType GetDbType(string sqlType){
	switch(sqlType)
    {
        case "varchar":
            return DbType.AnsiString;
        case "nvarchar":
            return DbType.String;
        case "integer":
            return DbType.Int32;
        case "guid":
            return DbType.Guid;
        case "date":
        case "timestamp":
        case "datetime":
            return DbType.DateTime;
        case "bigint":
            return DbType.Int64;
        case "binary":
            return DbType.Binary;
        case "bit":
            return DbType.Boolean;
        case "char":
            return DbType.AnsiStringFixedLength;
        case "decimal":
            return DbType.Decimal;
        case "double":
        case "float":
            return DbType.Double;
        case "image":
            return DbType.Binary;
        case "money":
            return DbType.Currency;
        case "nchar":
            return DbType.String;
        case "longtext":
            return DbType.String;
        case "numeric":
            return DbType.Decimal;
        case "real":
            return DbType.Single;
        case "smalldatetime":
            return DbType.DateTime;
        case "smallint":
            return DbType.Int16;
        case "smallmoney":
            return DbType.Currency;
        case "sql_variant":
            return DbType.String;
        case "sysname":
            return DbType.String;
        case "text":
            return DbType.AnsiString;
        case "tinyint":
            return DbType.Byte;
        case "varbinary":
            return DbType.Binary;
        default:
            return DbType.AnsiString;
    }

}
#>
</code></pre>
 or cancel

          

            
            
              vhakti
              Tue Jul 21 19:08:20 -0700 2009
              | link
              
            
          
          

            
I replaced the file, and run the process again but still getting the same error:



region ' Schemas '

        if(DataProvider.Schema.Tables.Count == 0)
        {
            DataProvider.Schema.Tables.Add(new citytownTable(DataProvider));
            DataProvider.Schema.Tables.Add(new countryTable(DataProvider));

        }
        #endregion


the 'citytownTable' and 'countryTable' are not valid types. I still receive an error about missing reference or directive ...

thanks a lot.

          

          

            Comment

            I replaced the file, and run the process again but still getting the same error:
#region ' Schemas '
        	if(DataProvider.Schema.Tables.Count == 0)
			{
            	DataProvider.Schema.Tables.Add(new citytownTable(DataProvider));
            	DataProvider.Schema.Tables.Add(new countryTable(DataProvider));
            	
            }
            #endregion

the 'citytownTable' and 'countryTable' are not valid types. I still receive an error about missing reference or directive ...

thanks a lot.



             or cancel
          
        

          

            
            
              Settler
              Wed Jul 22 03:33:16 -0700 2009
              | link
              
            
          
          

            
Are you run process in Structs.tt file? Because for class names there and in Context.tt used  same names. Or what names for tables you have in Structs.xx generated file?

          

          

            Comment

            Are you run process in Structs.tt file? Because for class names there and in Context.tt used  same names. Or what names for tables you have in Structs.xx generated file?

             or cancel
          
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        

  

    

      
      
71.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Defined type in a LINQ query expression fails
      
      
        1 comment
        Created 5 months ago by jimzim
        
          
        
      
    

    

      Title

      

      Body

      We found a nasty bug today when updating to the new version and not the alpha one we had been using.  It seems that the method:

public virtual IEnumerable<T> Execute<T>(QueryCommand<T> query, object[] paramValues)


inside of DBQueryProvider on line 266 and below this comment:

////this is so hacky - the issue is that the Projector below uses Expression.Convert, which is a bottleneck
            ////it's about 10x slower than our ToEnumerable. Our ToEnumerable, however, stumbles on Anon types and groupings
            ////since it doesn't know how to instantiate them (I tried - not smart enough). So we do some trickery here.

The problem is that when we are running this kind of query:

var divisions =
                from org in db.Groups
                join sport in db.Groups on org.Id equals sport.GroupId
                join season in db.SportSeasons on sport.Id equals season.SupportedSportId
                join sd in db.SeasonalDivisions on season.id equals sd.SportSeasonId
                join division in db.Groups on sd.DivisonId equals division.Id
                select new Division()
                {
                    Id = division.Id,
                    Name = division.Name,
                    SeasonId = season.id,
                    SeasonName = season.Name,
                    SportId = sport.Id,
                    SportName = sport.Name,
                    OrganizationId = org.Id,
                    IsRetired = division.IsRetired.GetValueOrDefault()
                };


which we have in a lot of places, it fails, so I just commented out the lines of code below the comment, but I would like to understand the enhancement this creates before I write a breaking test to make sure these kind of queries will work in the future and if I need to make a patch to make my query work with the optimization or just comment out the optimazation so that these queries will work in the future.


       or cancel
    
  

  

    

      
We found a nasty bug today when updating to the new version and not the alpha one we had been using.  It seems that the method:

public virtual IEnumerable Execute(QueryCommand query, object[] paramValues)

inside of DBQueryProvider on line 266 and below this comment:

////this is so hacky - the issue is that the Projector below uses Expression.Convert, which is a bottleneck

        ////it's about 10x slower than our ToEnumerable. Our ToEnumerable, however, stumbles on Anon types and groupings
        ////since it doesn't know how to instantiate them (I tried - not smart enough). So we do some trickery here.


The problem is that when we are running this kind of query:

var divisions =



            from org in db.Groups
            join sport in db.Groups on org.Id equals sport.GroupId
            join season in db.SportSeasons on sport.Id equals season.SupportedSportId
            join sd in db.SeasonalDivisions on season.id equals sd.SportSeasonId
            join division in db.Groups on sd.DivisonId equals division.Id
            select new Division()
            {
                Id = division.Id,
                Name = division.Name,
                SeasonId = season.id,
                SeasonName = season.Name,
                SportId = sport.Id,
                SportName = sport.Name,
                OrganizationId = org.Id,
                IsRetired = division.IsRetired.GetValueOrDefault()
            };


which we have in a lot of places, it fails, so I just commented out the lines of code below the comment, but I would like to understand the enhancement this creates before I write a breaking test to make sure these kind of queries will work in the future and if I need to make a patch to make my query work with the optimization or just comment out the optimazation so that these queries will work in the future.



    

    
Comments
    

      
        

          

            
            
              subsonic
              Wed Oct 28 15:29:17 -0700 2009
              | link
              
            
          
          

            
Calling Convert() is about 10 times slower then the reflection code we're using. Please open an issue about the failure if you don't mind.

Closing.

          

          

            Comment

            Calling Convert() is about 10 times slower then the reflection code we're using. Please open an issue about the failure if you don't mind.

Closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
70.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        SubSonic MVC template ported to release. Edit issue.
      
      
        4 comments
        Created 5 months ago by fde
        
          
        
      
    

    

      Title

      

      Body

      Hi Rob,

I've migrated my test project created using SubSonic MVC template.

Everything working fine with minor changes except the update operation.

We have the next code as a result of T4 work:
 if(ModelState.IsValid)
            {
                string resultMessage = "";
                try {
                    _repository.Update(item);
                    resultMessage = item.DescriptorValue() + " updated!";
                } catch(Exception x) {
                    //edit this to return a message
                    resultMessage = "ERROR: "+ item.DescriptorValue() + " failed: "+x.Message;

                }
                //if this is an Ajax request - just send back a message
                if (Request.IsAjaxRequest()) {
                    return Content(resultMessage);
                } else {
                    return RedirectToAction("Index");
                }
            } 

The exception takes place in  _repository.Update(item); line. The message "Incorrect syntax near the keyword 'WHERE'."

I've figured out that the this line generates the UPDATE SQL command without SET sentances.

The item.update(); works well. 

I haven't a chance to take a look into source code using debugger yet. But I'll try.
Thanks,
Dmitry.

       or cancel
    
  

  

    

      
Hi Rob,

I've migrated my test project created using SubSonic MVC template.

Everything working fine with minor changes except the update operation.

We have the next code as a result of T4 work:

 if(ModelState.IsValid)

        {
            string resultMessage = "";
            try {
                _repository.Update(item);
                resultMessage = item.DescriptorValue() + " updated!";
            } catch(Exception x) {
                //edit this to return a message
                resultMessage = "ERROR: "+ item.DescriptorValue() + " failed: "+x.Message;

            }
            //if this is an Ajax request - just send back a message
            if (Request.IsAjaxRequest()) {
                return Content(resultMessage);
            } else {
                return RedirectToAction("Index");
            }
        } 


The exception takes place in  _repository.Update(item); line. The message "Incorrect syntax near the keyword 'WHERE'."

I've figured out that the this line generates the UPDATE SQL command without SET sentances.

The item.update(); works well.

I haven't a chance to take a look into source code using debugger yet. But I'll try.

Thanks,

Dmitry.

    

    
Comments
    

      
        

          

            
            
              jchannon
              Mon Jul 20 08:18:45 -0700 2009
              | link
              
            
          
          

            
I came across this and its because you probably have model binding in your controller action Edit(int ID, Person p). Because the model binder has used reflection it therefore is a new instance and has no dirty columns to process in the repo.Update call. You have to change it to Edit(int ID, FormCollection coll) and then do Person p = Person.SingleOrDefault(x => x.ID == ID); TryUpdateModel(p, coll.ToValueProvider())

I had this discussion with Rob quite a while ago on the Subsonic Google forums

          

          

            Comment

            I came across this and its because you probably have model binding in your controller action Edit(int ID, Person p). Because the model binder has used reflection it therefore is a new instance and has no dirty columns to process in the repo.Update call. You have to change it to Edit(int ID, FormCollection coll) and then do Person p = Person.SingleOrDefault(x => x.ID == ID); TryUpdateModel(p, coll.ToValueProvider())

I had this discussion with Rob quite a while ago on the Subsonic Google forums 

             or cancel
          
        
      
        

          

            
            
              fde
              Mon Jul 20 08:32:13 -0700 2009
              | link
              
            
          
          

            
Thanks for the answer. It's clear for me why it doesn't work as it should.

Unfortunately I didn't find the discussion you are refferenced to. May be it has the answers to my questions.

1) The alpha had worked well. May be it could be interesting to fix this point?

2) Why the item.update() work in this case fine? It shouldn't have dirty columns too.

3) Is it interesting to update MVC Starter Template up to the release of the Subsonic?

Thanks,

Dmitry.

          

          

            Comment

            Thanks for the answer. It's clear for me why it doesn't work as it should.

Unfortunately I didn't find the discussion you are refferenced to. May be it has the answers to my questions.
1) The alpha had worked well. May be it could be interesting to fix this point?
2) Why the item.update() work in this case fine? It shouldn't have dirty columns too.
3) Is it interesting to update MVC Starter Template up to the release of the Subsonic? 

Thanks,
Dmitry.



             or cancel
          
        
      
        

          

            
            
              jchannon
              Mon Jul 20 08:41:33 -0700 2009
              | link
              
            
          
          

            
Here is the post:

http://groups.google.com/group/subsonicproject/browse_thread/thread/cfe45a5c8ad00947?pli=1

          

          

            Comment

            Here is the post:

http://groups.google.com/group/subsonicproject/browse_thread/thread/cfe45a5c8ad00947?pli=1

             or cancel
          
        
      
        

          

            
            
              subsonic
              Wed Oct 28 15:27:41 -0700 2009
              | link
              
            
          
          

            
Not a SubSonic 3 core issue - closing

          

          

            Comment

            Not a SubSonic 3 core issue - closing

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
69.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Is Transactions working in SubSonic 3.0 and MySQL?
      
      
        8 comments
        Created 5 months ago by Settler
        
          
        
      
    

    

      Title

      

      Body

      I'm try to use transactions for saving entities and references in one transaction. But my transactions are not working...
What I'm do:
.......

try
			{
				using (SharedDbConnectionScope sharedConnectionScope = new SharedDbConnectionScope())
				{
					using (TransactionScope ts = new TransactionScope())
					{
						Test test = new Test();
						test.Name = "name";
						test.Save();

						SaveReferences(test);

						ts.Complete();
					}
				}
			}
			catch(Exception ex)
			{
				throw ex;
			}
......

private void SaveReferences(Test test)
{
    throw new Exception("Test must be not saved here");
}


where Test - is IActiveRecord.
I'm do somethig wrong?
(SubSonic 3.0.0.3, Windows XP SP3)

       or cancel
    
  

  

    

      
I'm try to use transactions for saving entities and references in one transaction. But my transactions are not working...

What I'm do:

.......

try



        {
            using (SharedDbConnectionScope sharedConnectionScope = new SharedDbConnectionScope())
            {
                using (TransactionScope ts = new TransactionScope())
                {
                    Test test = new Test();
                    test.Name = "name";
                    test.Save();

                    SaveReferences(test);

                    ts.Complete();
                }
            }
        }
        catch(Exception ex)
        {
            throw ex;
        }


......

private void SaveReferences(Test test)

{

throw new Exception("Test must be not saved here");


}

where Test - is IActiveRecord.

I'm do somethig wrong?

(SubSonic 3.0.0.3, Windows XP SP3)

    

    
Comments
    

      
        

          

            
            
              Settler
              Mon Jul 20 00:55:35 -0700 2009
              | link
              
            
          
          

            
And more... If I'm use this transaction mechanism, then I'm catch exception in ExecuteQuery of DbDataProvider: "There is already an open DataReader associated with this Connection which must be closed first.", when save many entities in TransactionScope.

          

          

            Comment

            And more... If I'm use this transaction mechanism, then I'm catch exception in ExecuteQuery of DbDataProvider: "There is already an open DataReader associated with this Connection which must be closed first.", when save many entities in TransactionScope.

             or cancel
          
        
      
        

          

            
            
              carlosklein
              Mon Jul 20 06:51:51 -0700 2009
              | link
              
            
          
          

            
Same problem:

http://stackoverflow.com/questions/1143409/subsonic-transaction-error/1144198#1144198

Can you try the use the BatchUpdate alternative to see if you get the same errors of this issue? http://github.com/subsonic/SubSonic-3.0/issues#issue/60



          

          

            Comment

            Same problem:
http://stackoverflow.com/questions/1143409/subsonic-transaction-error/1144198#1144198

	
Can you try the use the BatchUpdate alternative to see if you get the same errors of this issue? http://github.com/subsonic/SubSonic-3.0/issues#issue/60


             or cancel
          
        
      
        

          

            
            
              Settler
              Mon Jul 20 23:28:33 -0700 2009
              | link
              
            
          
          

            
I'm comment your issue, but BatchUpdate is not better way for me, because in method SaveReferences can be saved many types of data in different tables. Or there can be called other methods for save. And if I'm will use BatchUpdate tool, then I need to create it in head method and transfer to SaveReferences. And there it need to be transfered in other methods... Not beauty, I think. All my problems will be resolved, if TransactionScope style is start working...

          

          

            Comment

            I'm comment your issue, but BatchUpdate is not better way for me, because in method SaveReferences can be saved many types of data in different tables. Or there can be called other methods for save. And if I'm will use BatchUpdate tool, then I need to create it in head method and transfer to SaveReferences. And there it need to be transfered in other methods... Not beauty, I think. All my problems will be resolved, if TransactionScope style is start working...

             or cancel
          
        
      
        

          

            
            
              carlosklein
              Tue Jul 21 06:14:16 -0700 2009
              | link
              
            
          
          

            
Same here.

          

          

            Comment

            Same here.

             or cancel
          
        
      
        

          

            
            
              kamsar
              Thu Aug 06 09:05:42 -0700 2009
              | link
              
            
          
          

            
I'm having the same problem with SQL 2008. BatchQuery is less than optimal as I have to get generated IDs of some of the items in the transaction to populate others.

          

          

            Comment

            I'm having the same problem with SQL 2008. BatchQuery is less than optimal as I have to get generated IDs of some of the items in the transaction to populate others.

             or cancel
          
        
      
        

          

            
            
              kamsar
              Thu Aug 06 09:34:47 -0700 2009
              | link
              
            
          
          

            
I believe I've fixed it. The bug occurs when you are using ActiveRecord and are also inserting items in the transaction. When this occurs, the SubSonicRepository.Add(T item, IDataProvider provider) method is invoked, which returns the newly inserted item's primary key by using a DataReader - which is not closed before the method exits; thus the error about a reader being open.

Changing line 197 in SubSonicRepository.cs (3.0.0.3) to "using (DbDataReader rdr = provider.ExecuteReader(query))" (and wrapping the using in an appropriate scope to about like 218) seems to have solved it for me.

          

          

            Comment

            I believe I've fixed it. The bug occurs when you are using ActiveRecord and are also inserting items in the transaction. When this occurs, the SubSonicRepository.Add(T item, IDataProvider provider) method is invoked, which returns the newly inserted item's primary key by using a DataReader - which is not closed before the method exits; thus the error about a reader being open.

Changing line 197 in SubSonicRepository.cs (3.0.0.3) to "using (DbDataReader rdr = provider.ExecuteReader(query))" (and wrapping the using in an appropriate scope to about like 218) seems to have solved it for me.

             or cancel
          
        
      
        

          

            
            
              BatteryMan
              Thu Aug 20 22:07:37 -0700 2009
              | link
              
            
          
          

            
Kamsar's solution seems to have made it into the 2009-08-18 commit.  However, I am still experiencing the problem originally described by Settler, though I am using MS SQL 2005 Express Edition.

Anyone else still having problems?  Thanks.

          

          

            Comment

            Kamsar's solution seems to have made it into the 2009-08-18 commit.  However, I am still experiencing the problem originally described by Settler, though I am using MS SQL 2005 Express Edition.

Anyone else still having problems?  Thanks.

             or cancel
          
        
      
        

          

            
            
              subsonic
              Wed Oct 28 15:26:50 -0700 2009
              | link
              
            
          
          

            
Original issue fixed - closing



          

          

            Comment

            Original issue fixed - closing


             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
68.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        change type of test project
      
      
        1 comment
        Created 5 months ago by subnus
        
          
        
      
    

    

      Title

      

      Body

      can you change the type for the test project from test project to a normal class library 
so people with only visual studio 2008 standard can run the test 

       or cancel
    
  

  

    

      
can you change the type for the test project from test project to a normal class library

so people with only visual studio 2008 standard can run the test

    

    
Comments
    

      
        

          

            
            
              subsonic
              Wed Oct 28 15:25:49 -0700 2009
              | link
              
            
          
          

            
not a priority right now - closing.

          

          

            Comment

            not a priority right now - closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
67.
      

        
        3 votes
      
    

    

      

      

    

    

      

        
        projection looking at name only and not typename
      
      
        1 comment
        Created 5 months ago by subnus
        
          
        
      
    

    

      Title

      

      Body

      as discussed in 

http://groups.google.com/group/subsonicproject/browse_thread/thread/2b569539b7f67a34?hl=en

       or cancel
    
  

  

    

      
as discussed in

http://groups.google.com/group/subsonicproject/browse_thread/thread/2b569539b7f67a34?hl=en

    

    
Comments
    

      
        

          

            
            
              subsonic
              Wed Oct 28 15:25:23 -0700 2009
              | link
              
            
          
          

            
closing

          

          

            Comment

            closing

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
66.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        String comparisons in LINQ break under VB.NET
      
      
        3 comments
        Created 5 months ago by BlackMael
        
          
        
      
    

    

      Title

      

      Body

      SubSonic throws an exception when LINQ query contains a string comparison from VB.NET code.

VB.NET generates different expression than C# for string comparisons. It uses a special CompareString operator.

       or cancel
    
  

  

    

      
SubSonic throws an exception when LINQ query contains a string comparison from VB.NET code.

VB.NET generates different expression than C# for string comparisons. It uses a special CompareString operator.

    

    
Comments
    

      
        

          

            
            
              BlackMael
              Sat Jul 18 00:02:26 -0700 2009
              | link
              
            
          
          

            
See http://blogs.msdn.com/vbteam/archive/2007/09/18/vb-expression-trees-string-comparisons.aspx for explanation and solution.

I have implemented the fix in SubSonic myself.  Just need to merge it into the solution

          

          

            Comment

            See http://blogs.msdn.com/vbteam/archive/2007/09/18/vb-expression-trees-string-comparisons.aspx for explanation and solution.
I have implemented the fix in SubSonic myself.  Just need to merge it into the solution

             or cancel
          
        
      
        

          

            
            
              BlackMael
              Sat Jul 18 03:09:41 -0700 2009
              | link
              
            
          
          

            
  Dim result = From c In Customer.All() _
               Where String.Equals(c.ContactName, contactName) _
               Select c

  myCustomer = result.FirstOrDefault


Also broke which required a little more work. I have a fix but not sure if it is the best solution

          

          

            Comment

                  Dim result = From c In Customer.All() _
                   Where String.Equals(c.ContactName, contactName) _
                   Select c

      myCustomer = result.FirstOrDefault

Also broke which required a little more work. I have a fix but not sure if it is the best solution

             or cancel
          
        
      
        

          

            
            
              subsonic
              Wed Oct 28 15:24:00 -0700 2009
              | link
              
            
          
          

            
Closing

          

          

            Comment

            Closing

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
65.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        ActiveRecort - dirty columns not cleared on update()
      
      
        1 comment
        Created 5 months ago by awbacker
        
          
        
      
    

    

      Title

      

      Body

      The dirtyColumns are not being cleared by the Update() method.  This means that the object is is still reported as IsDirty after the changes have been committed to the database.

Currently we have this:
    if (this._dirtyColumns.Count > 0) {
        _repo.Update(this, provider);

Something along these lines would fix that up:
    if (this._dirtyColumns.Count > 0) {
        _repo.Update(this, provider);
        _dirtyColumns.Clear();
    }

       or cancel
    
  

  

    

      
The dirtyColumns are not being cleared by the Update() method.  This means that the object is is still reported as IsDirty after the changes have been committed to the database.

Currently we have this:



if (this._dirtyColumns.Count > 0) {
    _repo.Update(this, provider);


Something along these lines would fix that up:



if (this._dirtyColumns.Count > 0) {
    _repo.Update(this, provider);
    _dirtyColumns.Clear();
}


    

    
Comments
    

      
        

          

            
            
              subsonic
              Wed Oct 28 15:23:41 -0700 2009
              | link
              
            
          
          

            
Added - thank you.

          

          

            Comment

            Added - thank you.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
64.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Extra semi colon breaking updates
      
      
        2 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      I'm not on the machine where I can fix this right now. This line: http://github.com/subsonic/SubSonic-3.0/blob/0f6248f9ee1e30287140932ca051e1992c70da0d/SubSonic.Core/Query/Update.cs#L230

Has an extra ; that's forcing the next line to run every time, instead of only when the condition is met.

       or cancel
    
  

  

    

      
I'm not on the machine where I can fix this right now. This line: http://github.com/subsonic/SubSonic-3.0/blob/0f6248f9ee1e30287140932ca051e1992c70da0d/SubSonic.Core/Query/Update.cs#L230

Has an extra ; that's forcing the next line to run every time, instead of only when the condition is met.

    

    
Comments
    

      
        

          

            
            
              erickemp
              Fri Jul 17 11:21:13 -0700 2009
              | link
              
            
          
          

            
Thanks John... Fixed... Commit coming in a few minutes...

          

          

            Comment

            Thanks John... Fixed... Commit coming in a few minutes...

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Tue Jul 21 21:47:48 -0700 2009
              | link
              
            
          
          

            
Thanks Eric

          

          

            Comment

            Thanks Eric

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
63.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        <IQueryable>.Skip() method does not return values
      
      
        2 comments
        Created 5 months ago by tring
        
          
        
      
    

    

      Title

      

      Body

      Hello,

I created a very simple Linq:
var result = (from p in Customers.All()
                  select p).Skip(1);
but it does not return any values from database. When I try with Take() it works?

Issue or...

       or cancel
    
  

  

    

      
Hello,

I created a very simple Linq:

var result = (from p in Customers.All()



              select p).Skip(1);


but it does not return any values from database. When I try with Take() it works?

Issue or...

    

    
Comments
    

      
        

          

            
            
              tring
              Fri Jul 17 10:06:42 -0700 2009
              | link
              
            
          
          

            
Sorry, I didn't update the latest master from git. It is working now :)

          

          

            Comment

            Sorry, I didn't update the latest master from git. It is working now :)

             or cancel
          
        
      
        

          

            
            
              subsonic
              Wed Oct 28 15:32:52 -0700 2009
              | link
              
            
          
          

            
Closing

          

          

            Comment

            Closing

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
62.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        Delete issue with Lambda expression
      
      
        1 comment
        Created 5 months ago by jchannon
        
          
        
      
    

    

      Title

      

      Body

      I have posted a number of scenarios when trying to do something to replicate a DELETE FROM TABLE WHERE COLUMN NOT IN (1,2,3) on stackoverflow.

http://stackoverflow.com/questions/1136415/reproduce-a-delete-not-in-sql-statement-via-linq-subsonic

My last attempt to do a Class.Delete(lamda threw an exception) as you will see in the post.

       or cancel
    
  

  

    

      
I have posted a number of scenarios when trying to do something to replicate a DELETE FROM TABLE WHERE COLUMN NOT IN (1,2,3) on stackoverflow.

http://stackoverflow.com/questions/1136415/reproduce-a-delete-not-in-sql-statement-via-linq-subsonic

My last attempt to do a Class.Delete(lamda threw an exception) as you will see in the post.

    

    
Comments
    

      
        

          

            
            
              subsonic
              Wed Oct 28 15:18:04 -0700 2009
              | link
              
            
          
          

            
I don't understand the issue - closing as it's 3 months old.

          

          

            Comment

            I don't understand the issue - closing as it's 3 months old.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
61.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        SimpleRepository Fail to Map Property of type Boolean (or bool) to SQLite
      
      
        6 comments
        Created 5 months ago by cfdelaune
        
          
        
      
    

    

      Title

      

      Body

      When I create an object with a Property of type Boolean (or bool) and use SimpleRepository to map it to SQLite, the column gets successfully created, but upon retrieval of the data, the following error gets thrown:

"Object of type 'System.Byte' cannot be converted to type 'System.Boolean'."

I posted this question on StackOverFlow and got an answer that I think might mean this is a bug.  Here is my post:

http://stackoverflow.com/questions/1137649/simplerepository-boolean-mapping-problem

Basically, in the SQLiteSchema.cs file, in the GetNativeType(DbType dbType) method, it looks like in the case of DbType.Boolean, the type was being set as "tinyint".  I checked this and indeed, the column in my SQLite database was of type "tinyint".  I changed this to "boolean", recompiled SubSonic and that seems to have resolved the problem.

Thanks!

       or cancel
    
  

  

    

      
When I create an object with a Property of type Boolean (or bool) and use SimpleRepository to map it to SQLite, the column gets successfully created, but upon retrieval of the data, the following error gets thrown:

"Object of type 'System.Byte' cannot be converted to type 'System.Boolean'."

I posted this question on StackOverFlow and got an answer that I think might mean this is a bug.  Here is my post:

http://stackoverflow.com/questions/1137649/simplerepository-boolean-mapping-problem

Basically, in the SQLiteSchema.cs file, in the GetNativeType(DbType dbType) method, it looks like in the case of DbType.Boolean, the type was being set as "tinyint".  I checked this and indeed, the column in my SQLite database was of type "tinyint".  I changed this to "boolean", recompiled SubSonic and that seems to have resolved the problem.

Thanks!

    

    
Comments
    

      
        

          

            
            
              awbacker
              Wed Jul 22 11:46:28 -0700 2009
              | link
              
            
          
          

            
For SQL Server at least, I found this is an issue with the GetSysType() function in SQLServer.ttinclude.   The "case 'tinyint':" falls through to the bit/boolean conversion.  Changing it to this fixed it for me:



case "tinyint":
    sysType=  "byte";
    break;


          

          

            Comment

            For SQL Server at least, I found this is an issue with the GetSysType() function in SQLServer.ttinclude.   The "case 'tinyint':" falls through to the bit/boolean conversion.  Changing it to this fixed it for me:
    case "tinyint":
        sysType=  "byte";
        break;


             or cancel
          
        
      
        

          

            
            
              Aristos
              Tue Aug 18 12:20:48 -0700 2009
              | link
              
            
          
          

            
Have the same problem, and solve it this way.

          

          

            Comment

            Have the same problem, and solve it this way.

             or cancel
          
        
      
        

          

            
            
              awbacker
              Tue Aug 18 13:47:03 -0700 2009
              | link
              
            
          
          

            
This is fixed (for sql server, and maybe sqlite) int the latest build.

          

          

            Comment

            This is fixed (for sql server, and maybe sqlite) int the latest build.

             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Aug 18 17:28:20 -0700 2009
              | link
              
            
          
          

            
If I have the tinyint/byte/bool discussion again, I'm going to lose it. Closing - this is a recursive bug....

          

          

            Comment

            If I have the tinyint/byte/bool discussion again, I'm going to lose it. Closing - this is a recursive bug....

             or cancel
          
        
      
        

          

            
            
              awbacker
              Tue Aug 18 17:39:00 -0700 2009
              | link
              
            
          
          

            
I don't see the problem.  This issue was posted ages ago, so it isn't really "again".  It got fixed (in sql from an issue submitted by me, dunno about sqlite).  Any special sauce we can provide for relaxation and restoration of your sanity?

          

          

            Comment

            I don't see the problem.  This issue was posted ages ago, so it isn't really "again".  It got fixed (in sql from an issue submitted by me, dunno about sqlite).  Any special sauce we can provide for relaxation and restoration of your sanity?

             or cancel
          
        
      
        

          

            
            
              ac2u
              Wed Aug 19 15:43:54 -0700 2009
              | link
              
            
          
          

            
To be fair... you did ask the this person to open the issue when he/she raised it in stackoverflow.

http://stackoverflow.com/questions/1137649/simplerepository-boolean-mapping-problem

          

          

            Comment

            To be fair... you did ask the this person to open the issue when he/she raised it in stackoverflow.

http://stackoverflow.com/questions/1137649/simplerepository-boolean-mapping-problem

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
60.
      

        
        8 votes
      
    

    

      

      

    

    

      

        
        Batch Update Query Error on MySql
      
      
        5 comments
        Created 5 months ago by carlosklein
        
          
        
      
    

    

      Title

      

      Body

      Considering the following code:
    var query2 = new Update<BoletoPagamento>(provider);
    query2.Set(x => x.DataLiberacao == boleto.DataLiberacao);
    query2.Where(x => x.BoletoPagamentoID == boleto.BoletoPagamentoID);
    batch.Queue(query2);
    batch.Execute();    

The batch.Execute() trown an "Object Reference Not Set" exception. Investigating, I arrived at the following line of the file Subsonic.core\Query\Update.cs, method GetCommand():
    var col= table.Columns.SingleOrDefault(x => x.Name.Equals(s.ColumnName,
     StringComparison.InvariantCultureIgnoreCase));

My column was in table.Columns but s.ColumnName was filled with 
<pre>
    `DataLiberacao`
</pre>
 This prevented the location of the column and resulted in null object reference set.
I do not know how to fix it.
	
Then i tried to use the old style query tool:
    SubSonic.Query.Update query = new Update<BoletoPagamento>(provider);
    query.Set("DataLiberacao").EqualTo(boleto.DataLiberacao);
    batch.Queue(query);
    batch.Execute();

In this case, the Subsonic build a command to update with an "s" at the end of the table name. Instead of "Update BoletoPagamento," was "BoletoPagamentos" and table "BoletoPagamentos" does not exist.
In the source SubSonicCore\Extensions\Object.cs, method ToSchemaTable(this Type type, IDataProvider provider):  In this method, my tablename is modified with "tableName = tableName.MakePlural();".

Then I tried a simple  Save () in my BoletoPagamento object, the command is generated correctly, without the "s" at the end of the table name.
But, as I need to save several objects of this type, this is not a good ideia and another problem doing this: the subsonic not reuse the connection to the database, opening an connection for each object. 

I am using the 3.0.0.3 sources, windows Vista, VS2008 and MySql.

       or cancel
    
  

  

    

      
Considering the following code:



var query2 = new Update<BoletoPagamento>(provider);
query2.Set(x => x.DataLiberacao == boleto.DataLiberacao);
query2.Where(x => x.BoletoPagamentoID == boleto.BoletoPagamentoID);
batch.Queue(query2);
batch.Execute();    


The batch.Execute() trown an "Object Reference Not Set" exception. Investigating, I arrived at the following line of the file Subsonic.core\Query\Update.cs, method GetCommand():



var col= table.Columns.SingleOrDefault(x => x.Name.Equals(s.ColumnName,
 StringComparison.InvariantCultureIgnoreCase));


My column was in table.Columns but s.ColumnName was filled with



    `DataLiberacao`



 This prevented the location of the column and resulted in null object reference set.
I do not know how to fix it.



Then i tried to use the old style query tool:



SubSonic.Query.Update query = new Update<BoletoPagamento>(provider);
query.Set("DataLiberacao").EqualTo(boleto.DataLiberacao);
batch.Queue(query);
batch.Execute();


In this case, the Subsonic build a command to update with an "s" at the end of the table name. Instead of "Update BoletoPagamento," was "BoletoPagamentos" and table "BoletoPagamentos" does not exist.

In the source SubSonicCore\Extensions\Object.cs, method ToSchemaTable(this Type type, IDataProvider provider):  In this method, my tablename is modified with "tableName = tableName.MakePlural();".

Then I tried a simple  Save () in my BoletoPagamento object, the command is generated correctly, without the "s" at the end of the table name.

But, as I need to save several objects of this type, this is not a good ideia and another problem doing this: the subsonic not reuse the connection to the database, opening an connection for each object.

I am using the 3.0.0.3 sources, windows Vista, VS2008 and MySql.

    

    
Comments
    

      
        

          

            
            
              Settler
              Mon Jul 20 23:24:00 -0700 2009
              | link
              
            
          
          

            
Well. The LINQ Query tool not working for me too. Because s.ColumnName - is full name of column in database i think... Like: 'DBName'.'TableName'.'ColumnName'.

Old query style is working. I think you're not properly get "provider". I'm store provider in static variable. And initialize it like this:

protected static IDataProvider provider = new TestDB().Provider;

Where TestDB - is generated class from Context.tt

          

          

            Comment

            Well. The LINQ Query tool not working for me too. Because s.ColumnName - is full name of column in database i think... Like: 'DBName'.'TableName'.'ColumnName'.

Old query style is working. I think you're not properly get "provider". I'm store provider in static variable. And initialize it like this:

protected static IDataProvider provider = new TestDB().Provider;

Where TestDB - is generated class from Context.tt

             or cancel
          
        
      
        

          

            
            
              Settler
              Mon Jul 20 23:36:14 -0700 2009
              | link
              
            
          
          

            
Damn!!! :) :) :)

Check this block of code in public QueryCommand GetCommand() in Update class:

if (table != null) {



                var col= table.Columns.SingleOrDefault(x => x.Name.Equals(s.ColumnName, StringComparison.InvariantCultureIgnoreCase));
                if (col != null) ;
                    s.DataType = col.DataType;
            }


And check the "if" statment. There is !!!!! " ; " !!!!! at the end of line :) Very nasty bug :) But, i think, this is not solve the problem, because "col" will be always null.

          

          

            Comment

            Damn!!! :) :) :)
Check this block of code in public QueryCommand GetCommand() in Update class:

if (table != null) {
                    var col= table.Columns.SingleOrDefault(x => x.Name.Equals(s.ColumnName, StringComparison.InvariantCultureIgnoreCase));
                    if (col != null) ;
                        s.DataType = col.DataType;
                }

And check the "if" statment. There is !!!!! " ; " !!!!! at the end of line :) Very nasty bug :) But, i think, this is not solve the problem, because "col" will be always null.

             or cancel
          
        
      
        

          

            
            
              carlosklein
              Tue Jul 21 06:04:39 -0700 2009
              | link
              
            
          
          

            
Its Grave Accent fault. In debug mode, if i cut the accent, works.

The old query style its not working because i use this code to correct table names in the method CleanUp of Setting.ttinclude (ex: table name = agendamento_horario, corrected name = AgendamentoHorario.)

 string[] parts = result.Split('_');
 string tabela = String.Empty;
 foreach(String part in parts)
 {
      tabela += part.Substring(0,1).ToUpper() + part.Substring(1,part.Length -1);
  }
 result = tabela;


Probably, there is a problem there too.

          

          

            Comment

            Its Grave Accent fault. In debug mode, if i cut the accent, works.

The old query style its not working because i use this code to correct table names in the method CleanUp of Setting.ttinclude (ex: table name = agendamento_horario, corrected name = AgendamentoHorario.)

     string[] parts = result.Split('_');
     string tabela = String.Empty;
     foreach(String part in parts)
     {
          tabela += part.Substring(0,1).ToUpper() + part.Substring(1,part.Length -1);
      }
     result = tabela;

Probably, there is a problem there too.

             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Aug 18 17:26:48 -0700 2009
              | link
              
            
          
          

            
I'm not clear on the problem here

          

          

            Comment

            I'm not clear on the problem here

             or cancel
          
        
      
        

          

            
            
              subsonic
              Wed Oct 28 15:16:48 -0700 2009
              | link
              
            
          
          

            
Closing...

          

          

            Comment

            Closing...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
58.
      

        
        -2 votes
      
    

    

      

      

    

    

      

        
        Active Record Lamda Expression Issue with String Array value
      
      
        1 comment
        Created 5 months ago by jchannon
        
          
        
      
    

    

      Title

      

      Body

      I have the following:

var contentdata = value.Split(',');
//contentdata contains 2 items

//Find item using contentdata[0]
WebPageContent item = new WebPageContent(x => x.PageID == ID && x.ControlType == contentdata[0]);

**Error thrown in SQLQuery::Where method** As it loops through constraints it thinks a the column name is called contentdata.

I can fix it by doing this:

string sitem = contentdata[0];
WebPageContent item = new WebPageContent(x => x.PageID == ID && x.ControlType == sitem);

Not sure what the difference is!

       or cancel
    
  

  

    

      
I have the following:

var contentdata = value.Split(',');

//contentdata contains 2 items

//Find item using contentdata[0]
WebPageContent item = new WebPageContent(x => x.PageID == ID && x.ControlType == contentdata[0]);

Error thrown in SQLQuery::Where method As it loops through constraints it thinks a the column name is called contentdata.

I can fix it by doing this:

string sitem = contentdata[0];

WebPageContent item = new WebPageContent(x => x.PageID == ID && x.ControlType == sitem);

Not sure what the difference is!

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Aug 18 17:21:00 -0700 2009
              | link
              
            
          
          

            
I can't repro this...

          

          

            Comment

            I can't repro this...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
57.
      

        
        6 votes
      
    

    

      

      

    

    

      

        
        Simple Repository fails on update
      
      
        6 comments
        Created 5 months ago by friesencr
        
          
        
      
    

    

      Title

      

      Body

      the linq statement doesnt find a column so i changed x.Name to x.QualifiedName and it seemed to fix it for me!?!?

public QueryCommand GetCommand() {
            QueryCommand cmd = new QueryCommand(BuildSqlStatement(), _provider);

            //add in the commands
            foreach (Setting s in _query.SetStatements) {

                //Fix the data type!
                var table = _query.FromTables.FirstOrDefault();
                if (table != null) {
                    var col= table.Columns.SingleOrDefault(x => x.QualifiedName.Equals(s.ColumnName, StringComparison.InvariantCultureIgnoreCase));
                    if (col != null)
                        s.DataType = col.DataType;
                }
                cmd.Parameters.Add(s.ParameterName, s.Value, s.DataType);
            }

            //set the contstraints
            _query.SetConstraintParams(cmd);

            return cmd;
        }

       or cancel
    
  

  

    

      
the linq statement doesnt find a column so i changed x.Name to x.QualifiedName and it seemed to fix it for me!?!?

public QueryCommand GetCommand() {



        QueryCommand cmd = new QueryCommand(BuildSqlStatement(), _provider);

        //add in the commands
        foreach (Setting s in _query.SetStatements) {

            //Fix the data type!
            var table = _query.FromTables.FirstOrDefault();
            if (table != null) {
                var col= table.Columns.SingleOrDefault(x => x.QualifiedName.Equals(s.ColumnName, StringComparison.InvariantCultureIgnoreCase));
                if (col != null)
                    s.DataType = col.DataType;
            }
            cmd.Parameters.Add(s.ParameterName, s.Value, s.DataType);
        }

        //set the contstraints
        _query.SetConstraintParams(cmd);

        return cmd;
    }


    

    
Comments
    

      
        

          

            
            
              Digvijay
              Tue Jul 21 06:34:53 -0700 2009
              | link
              
            
          
          

            
Yes, that worked. Release 3.0.0.3 seems to still have that ; on line if (col != null)



          

          

            Comment

            Yes, that worked. Release 3.0.0.3 seems to still have that ; on line if (col != null)


             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Aug 18 17:19:54 -0700 2009
              | link
              
            
          
          

            
I can't find this code

          

          

            Comment

            I can't find this code

             or cancel
          
        
      
        

          

            
            
              friesencr
              Tue Aug 18 17:29:42 -0700 2009
              | link
              
            
          
          

            
SubSonic.Core\Query\Update.cs

public QueryCommand GetCommand()

line 220

          

          

            Comment

            SubSonic.Core\Query\Update.cs
public QueryCommand GetCommand()
line 220

             or cancel
          
        
      
        

          

            
            
              CamSoper
              Fri Oct 09 14:05:36 -0700 2009
              | link
              
            
          
          

            
Why did this issue get closed?  It seems to still be a bug with the current version of the source.

          

          

            Comment

            Why did this issue get closed?  It seems to still be a bug with the current version of the source.

             or cancel
          
        
      
        

          

            
            
              larsko
              Thu Nov 05 11:39:08 -0800 2009
              | link
              
            
          
          

            
Chanding "Name" to "QualifiedName" in GetCommand() does the trick. I tried it on SQLite.

Is this the way to fix it?

          

          

            Comment

            Chanding "Name" to "QualifiedName" in GetCommand() does the trick. I tried it on SQLite.
Is this the way to fix it?

             or cancel
          
        
      
        

          

            
            
              friesencr
              Thu Nov 05 15:26:07 -0800 2009
              | link
              
            
          
          

            
I think it depends on what the purpose of each of those variables are.  Anyone know what the purpose of the Name variable is and the purpose of the QualifiedName is?

          

          

            Comment

            I think it depends on what the purpose of each of those variables are.  Anyone know what the purpose of the Name variable is and the purpose of the QualifiedName is?

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
56.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Wrong type using Sqlite + AutoMigrations
      
      
        1 comment
        Created 5 months ago by alextakitani
        
          
        
      
    

    

      Title

      

      Body

      Using 3.0.2

My class:

public class Conta
    {
        public int ContaID { get; set;}
        public string Nome { get; set; }
        public bool Publica { get; set; }
    }

The code:

_repo = new SimpleRepository("Contas", SimpleRepositoryOptions.RunMigrations);
            var contas = _repo.All<Conta>();
            return View(contas);

The Error:

Object of type 'System.Int64' cannot be converted to type 'System.Int32'.

Works if i declare ContaID as a Int64
Works fine with Sql Server.







       or cancel
    
  

  

    

      
Using 3.0.2

My class:

public class Conta



{
    public int ContaID { get; set;}
    public string Nome { get; set; }
    public bool Publica { get; set; }
}


The code:

_repo = new SimpleRepository("Contas", SimpleRepositoryOptions.RunMigrations);



        var contas = _repo.All<Conta>();
        return View(contas);


The Error:

Object of type 'System.Int64' cannot be converted to type 'System.Int32'.

Works if i declare ContaID as a Int64

Works fine with Sql Server.

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 14:26:40 -0700 2009
              | link
              
            
          
          

            
This is correct - SQLite expects an Int64 as the key (this is their DB design choice) so you need to declare your ContaID as "long".

Closing.

          

          

            Comment

            This is correct - SQLite expects an Int64 as the key (this is their DB design choice) so you need to declare your ContaID as "long".

Closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
55.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        ActiveRecord lambda expression partially ignored on delete
      
      
        1 comment
        Created 5 months ago by gbd
        
          
        
      
    

    

      Title

      

      Body

      I have tables **Users**, **Widgets** and **Layouts**. **Users** have many-to-many relationship with **Widgets** via **Layouts**. Each **Layout** has `UserID` and `WidgetID`. I want to delete a **Layout** that matches specific `UserID` and `WidgetID`.

Using SubSonic 3 ActiveRecord I write:

    Layout.Delete(x => x.UserID == user.id && x.WidgetID == id);

However, SubSonic deletes *all* widget layouts for the user, ignoring the second part of the condition.

I fixed it temporarily in *Context.tt* in my project's *Models* subdirectory:

    diff --git a/Models/Context.tt b/Models/Context.tt
    index ee64200..dd47510 100644
    --- a/Models/Context.tt
    +++ b/Models/Context.tt
    @@ -162,8 +162,8 @@ namespace <#=Namespace#>
             LambdaExpression lamda = column;
             SqlQuery result = new Delete<T>(this.Provider);
             result = result.From<T>();
    -        SubSonic.Query.Constraint c = lamda.ParseConstraint();
    -        result.Constraints.Add(c);
    +        var q = new QueryVisitor();
    +        result.Constraints.AddRange(q.GetConstraints(lamda));
             return result;
         }

       or cancel
    
  

  

    

      
I have tables Users, Widgets and Layouts. Users have many-to-many relationship with Widgets via Layouts. Each Layout has UserID and WidgetID. I want to delete a Layout that matches specific UserID and WidgetID.

Using SubSonic 3 ActiveRecord I write:

Layout.Delete(x => x.UserID == user.id && x.WidgetID == id);


However, SubSonic deletes all widget layouts for the user, ignoring the second part of the condition.

I fixed it temporarily in Context.tt in my project's Models subdirectory:

diff --git a/Models/Context.tt b/Models/Context.tt
index ee64200..dd47510 100644
--- a/Models/Context.tt
+++ b/Models/Context.tt
@@ -162,8 +162,8 @@ namespace <#=Namespace#>
         LambdaExpression lamda = column;
         SqlQuery result = new Delete<T>(this.Provider);
         result = result.From<T>();
-        SubSonic.Query.Constraint c = lamda.ParseConstraint();
-        result.Constraints.Add(c);
+        var q = new QueryVisitor();
+        result.Constraints.AddRange(q.GetConstraints(lamda));
         return result;
     }


    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 13:32:29 -0700 2009
              | link
              
            
          
          

            
OMG what a dumb bug. I fixed this months ago and... eek regression. Fixed with latest push - thank you!

          

          

            Comment

            OMG what a dumb bug. I fixed this months ago and... eek regression. Fixed with latest push - thank you!

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
54.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Looping List<T> and calling <T>.Update fails
      
      
        1 comment
        Created 5 months ago by jchannon
        
          
        
      
    

    

      Title

      

      Body

      This method works fine:

Person p = new Person(3);
p.Name = "Bob";
p.Update();

However if I have an IQueryable foreign key collection the below fails

var foreignItems = Person.Find(x => x.ID == 3)
foreach(Person p in foreignItems)
{
  p.Name = "Bob";
  p.Update(); /*THROWS EXCEPTION */
}

Exception is thrown in Repository Update as it executes a query from BuildUpdateQuery such as - UPDATE PERSON WHERE ID = {0} which is wrong syntax!


       or cancel
    
  

  

    

      
This method works fine:

Person p = new Person(3);

p.Name = "Bob";

p.Update();

However if I have an IQueryable foreign key collection the below fails

var foreignItems = Person.Find(x => x.ID == 3)

foreach(Person p in foreignItems)

{
  p.Name = "Bob";
  p.Update(); /THROWS EXCEPTION /
}

Exception is thrown in Repository Update as it executes a query from BuildUpdateQuery such as - UPDATE PERSON WHERE ID = {0} which is wrong syntax!



    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 13:21:06 -0700 2009
              | link
              
            
          
          

            
I can't repro this - here is my code:

        var list = Product.Find(x => x.ProductID < 10);
        foreach(Product p in list){
            p.UnitPrice=100;
            p.Update();
        }


I'm guessing it was fixed or there's more going on here than SubSonic.



          

          

            Comment

            I can't repro this - here is my code:

            var list = Product.Find(x => x.ProductID < 10);
            foreach(Product p in list){
                p.UnitPrice=100;
                p.Update();
            }

I'm guessing it was fixed or there's more going on here than SubSonic.


             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
53.
      

        
        3 votes
      
    

    

      

      

    

    

      

        
        DateTime fields updates cause exception
      
      
        3 comments
        Created 5 months ago by demonru
        
          
        
      
    

    

      Title

      

      Body

      Using ActiveRecord templates on updating record with a date field causes exception: [SqlException (0x80131904): The conversion of a char data type to a datetime data type resulted in an out-of-range datetime value.The statement has been terminated.]

Based on this question from stackoverflow 
http://stackoverflow.com/questions/1124670/datetime-fields-updates-cause-exception

Here is the schema

	CREATE TABLE [dbo].[stPost](
	[postID] [int] IDENTITY(1,1) NOT NULL,
	[postGuid] [uniqueidentifier] NOT NULL,
	[postCreatedDate] [datetime] NOT NULL,
	[postUpdatedDate] [datetime] NOT NULL,
	[postTitle] [nvarchar](50) COLLATE Cyrillic_General_CI_AS NOT NULL,
	[postDescription] [nvarchar](max) COLLATE Cyrillic_General_CI_AS NOT NULL,
	[deleted] [bit] NOT NULL CONSTRAINT [DF_stPost_deleted]  DEFAULT ((0)),
	CONSTRAINT [PK_stPost] PRIMARY KEY CLUSTERED 
	(
	[postID] ASC
	)WITH (PAD_INDEX  = OFF, STATISTICS_NORECOMPUTE  = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON) ON [PRIMARY]
	) ON [PRIMARY]

And here is a test

            DateTime currentDateTime = DateTime.Now;
            currentDateTime = new DateTime(currentDateTime.Ticks - (currentDateTime.Ticks % TimeSpan.TicksPerSecond), currentDateTime.Kind);

            stPost post = new stPost();
            post.postCreatedDate = currentDateTime;
            post.postDescription = "cool post at " + currentDateTime.ToString();
            post.postGuid = Guid.NewGuid();
            post.postTitle = "Post title";
            post.postUpdatedDate = currentDateTime;
            post.Save();
            
            post = new stPost(p => p.postID == post.postID);

            Assert.IsTrue(currentDateTime.Equals(post.postUpdatedDate));

            DateTime updatedDateTime = DateTime.Now.AddMinutes(1);
            updatedDateTime = new DateTime(updatedDateTime.Ticks - (updatedDateTime.Ticks % TimeSpan.TicksPerSecond), updatedDateTime.Kind);
            post.postDescription = "cool post UPDATED at " + DateTime.Now.ToString();
            post.postTitle = "Post title Updated";
            post.postUpdatedDate = updatedDateTime;
            post.Save();

            post = new stPost(p => p.postID == post.postID);

            Assert.AreEqual(updatedDateTime, post.postUpdatedDate);

       or cancel
    
  

  

    

      
Using ActiveRecord templates on updating record with a date field causes exception: [SqlException (0x80131904): The conversion of a char data type to a datetime data type resulted in an out-of-range datetime value.The statement has been terminated.]

Based on this question from stackoverflow

http://stackoverflow.com/questions/1124670/datetime-fields-updates-cause-exception

Here is the schema

CREATE TABLE [dbo].[stPost](
[postID] [int] IDENTITY(1,1) NOT NULL,
[postGuid] [uniqueidentifier] NOT NULL,
[postCreatedDate] [datetime] NOT NULL,
[postUpdatedDate] [datetime] NOT NULL,
[postTitle] [nvarchar](50) COLLATE Cyrillic_General_CI_AS NOT NULL,
[postDescription] [nvarchar](max) COLLATE Cyrillic_General_CI_AS NOT NULL,
[deleted] [bit] NOT NULL CONSTRAINT [DF_stPost_deleted]  DEFAULT ((0)),
CONSTRAINT [PK_stPost] PRIMARY KEY CLUSTERED 
(
[postID] ASC
)WITH (PAD_INDEX  = OFF, STATISTICS_NORECOMPUTE  = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON) ON [PRIMARY]
) ON [PRIMARY]


And here is a test

        DateTime currentDateTime = DateTime.Now;
        currentDateTime = new DateTime(currentDateTime.Ticks - (currentDateTime.Ticks % TimeSpan.TicksPerSecond), currentDateTime.Kind);

        stPost post = new stPost();
        post.postCreatedDate = currentDateTime;
        post.postDescription = "cool post at " + currentDateTime.ToString();
        post.postGuid = Guid.NewGuid();
        post.postTitle = "Post title";
        post.postUpdatedDate = currentDateTime;
        post.Save();

        post = new stPost(p => p.postID == post.postID);

        Assert.IsTrue(currentDateTime.Equals(post.postUpdatedDate));

        DateTime updatedDateTime = DateTime.Now.AddMinutes(1);
        updatedDateTime = new DateTime(updatedDateTime.Ticks - (updatedDateTime.Ticks % TimeSpan.TicksPerSecond), updatedDateTime.Kind);
        post.postDescription = "cool post UPDATED at " + DateTime.Now.ToString();
        post.postTitle = "Post title Updated";
        post.postUpdatedDate = updatedDateTime;
        post.Save();

        post = new stPost(p => p.postID == post.postID);

        Assert.AreEqual(updatedDateTime, post.postUpdatedDate);


    

    
Comments
    

      
        

          

            
            
              carlosklein
              Wed Jul 15 06:59:14 -0700 2009
              | link
              
            
          
          

            
The lastest source solved the problem for me.

          

          

            Comment

            The lastest source solved the problem for me.

             or cancel
          
        
      
        

          

            
            
              demonru
              Wed Jul 15 07:44:22 -0700 2009
              | link
              
            
          
          

            
Thanks. I just got latest sources and it's really fixed. :) I've been using 3.0.0.2 before and it was not working. I guess someone fixed this problem in the past few days.

          

          

            Comment

            Thanks. I just got latest sources and it's really fixed. :) I've been using 3.0.0.2 before and it was not working. I guess someone fixed this problem in the past few days. 

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:17:41 -0700 2009
              | link
              
            
          
          

            
Yep - that would be me :). Closing...

          

          

            Comment

            Yep - that would be me :). Closing...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
52.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Solution examples exception for editing
      
      
        2 comments
        Created 5 months ago by micmit
        
          
        
      
    

    

      Title

      

      Body

      When we are in read-only mode for browsing details click on "Edit" link causes exception 

System.FormatException was unhandled by user code
  Message="Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)."

id is empty in the following code snippet 

       [AcceptVerbs(HttpVerbs.Get)]
        public ActionResult Edit(string id) {

            var postID = new Guid(id);



       or cancel
    
  

  

    

      
When we are in read-only mode for browsing details click on "Edit" link causes exception

System.FormatException was unhandled by user code

  Message="Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)."

id is empty in the following code snippet

   [AcceptVerbs(HttpVerbs.Get)]
    public ActionResult Edit(string id) {

        var postID = new Guid(id);


    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 13:17:17 -0700 2009
              | link
              
            
          
          

            
I don't know what this means.

          

          

            Comment

            I don't know what this means.

             or cancel
          
        
      
        

          

            
            
              micmit
              Wed Jul 15 17:02:30 -0700 2009
              | link
              
            
          
          

            
It is not related to SubSonic itself and may be  ignored.  Just a bug in  SubSonic 3 Final\Examples\Examples.sln

Click "Details" then click "Edit"  at the bottom  causes  this exception.

          

          

            Comment

            It is not related to SubSonic itself and may be  ignored.  Just a bug in  SubSonic 3 Final\Examples\Examples.sln 
Click "Details" then click "Edit"  at the bottom  causes  this exception.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
51.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        Mysql BIT(1) problem
      
      
        4 comments
        Created 5 months ago by carlosklein
        
          
        
      
    

    

      Title

      

      Body

      When I add a column of type Bit (1) in a table, the querie hang when i call ToLit<ClassName>() Or .SingleOrDefault(). If I remove the column, everything returns to normal.

       or cancel
    
  

  

    

      
When I add a column of type Bit (1) in a table, the querie hang when i call ToLit() Or .SingleOrDefault(). If I remove the column, everything returns to normal.

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 14 14:18:13 -0700 2009
              | link
              
            
          
          

            
This doesn't make sense.

          

          

            Comment

            This doesn't make sense.

             or cancel
          
        
      
        

          

            
            
              adamnoffie
              Tue Jul 14 15:39:09 -0700 2009
              | link
              
            
          
          

            
Wow. That it does not.

          

          

            Comment

            Wow. That it does not.

             or cancel
          
        
      
        

          

            
            
              carlosklein
              Tue Jul 14 19:05:16 -0700 2009
              | link
              
            
          
          

            
I build a test project to reproduce the error.

In this case, I get an exception: Object of type 'System.UInt64' can not be converted to type 'System.Boolean'. In the sendspace link is  the zipped project (the database is in an account of db4free.net, username and password in the app.config of the project). At work, instead of this error, the application simply stopped.

http://www.sendspace.com/file/q4k1cp

          

          

            Comment

            I build a test project to reproduce the error.
In this case, I get an exception: Object of type 'System.UInt64' can not be converted to type 'System.Boolean'. In the sendspace link is  the zipped project (the database is in an account of db4free.net, username and password in the app.config of the project). At work, instead of this error, the application simply stopped.

http://www.sendspace.com/file/q4k1cp

             or cancel
          
        
      
        

          

            
            
              css
              Wed Aug 26 03:29:21 -0700 2009
              | link
              
            
          
          

            
Yes.



DB type -> .NET Type  

BIT -> UInt64

BOOL -> SByte

I hacked the source to "make it work". If the db type is TINYINT or BIT, and the property is typeof(Boolean), I .ToString() the value and compare with 1 or 0.

Hacked this in SubSonic.Core\Extensions\Database.cs:169, see the first "else if".



            //if the property is null, likely it's a Field
            if(currentProp == null)
                currentField = cachedFields.SingleOrDefault(x => x.Name.Equals(pName, StringComparison.InvariantCultureIgnoreCase));

            if(currentProp != null && !DBNull.Value.Equals(rdr.GetValue(i)))
            {
                Type valueType = rdr.GetValue(i).GetType();
                if(valueType == typeof(Boolean))
                {
                    string value = rdr.GetValue(i).ToString();
                    currentProp.SetValue(item, value == "1" || value == "True", null);
                }
                else if (valueType == typeof(SByte) && currentProp.PropertyType == typeof(Boolean) && (rdr.GetDataTypeName(i).Equals("TINYINT", StringComparison.OrdinalIgnoreCase) || rdr.GetDataTypeName(i).Equals("BIT", StringComparison.OrdinalIgnoreCase)) )
                {
                    string value = rdr.GetValue(i).ToString();
                    currentProp.SetValue(item, value == "1", null);
                }
                else if (currentProp.PropertyType == typeof(Guid))
                    currentProp.SetValue(item, rdr.GetGuid(i), null);
                else
                    currentProp.SetValue(item, rdr.GetValue(i).ChangeTypeTo(valueType), null);
            }


Also related: http://github.com/subsonic/SubSonic-3.0/issuesearch?state=open&q=BOOL#issue/110

And a heads-up for this problem too: http://github.com/subsonic/SubSonic-3.0/issuesearch?state=open&q=BOOL#issue/111

          

          

            Comment

            Yes.
DB type -> .NET Type
---------------------------------------------
BIT -> UInt64
BOOL -> SByte

I hacked the source to "make it work". If the db type is TINYINT or BIT, and the property is typeof(Boolean), I .ToString() the value and compare with 1 or 0.

Hacked this in SubSonic.Core\Extensions\Database.cs:169, see the first "else if".
                //if the property is null, likely it's a Field
                if(currentProp == null)
                    currentField = cachedFields.SingleOrDefault(x => x.Name.Equals(pName, StringComparison.InvariantCultureIgnoreCase));

                if(currentProp != null && !DBNull.Value.Equals(rdr.GetValue(i)))
                {
                    Type valueType = rdr.GetValue(i).GetType();
                    if(valueType == typeof(Boolean))
                    {
                        string value = rdr.GetValue(i).ToString();
                        currentProp.SetValue(item, value == "1" || value == "True", null);
                    }
                    else if (valueType == typeof(SByte) && currentProp.PropertyType == typeof(Boolean) && (rdr.GetDataTypeName(i).Equals("TINYINT", StringComparison.OrdinalIgnoreCase) || rdr.GetDataTypeName(i).Equals("BIT", StringComparison.OrdinalIgnoreCase)) )
                    {
                        string value = rdr.GetValue(i).ToString();
                        currentProp.SetValue(item, value == "1", null);
                    }
                    else if (currentProp.PropertyType == typeof(Guid))
                        currentProp.SetValue(item, rdr.GetGuid(i), null);
                    else
                        currentProp.SetValue(item, rdr.GetValue(i).ChangeTypeTo(valueType), null);
                }

Also related: http://github.com/subsonic/SubSonic-3.0/issuesearch?state=open&q=BOOL#issue/110

And a heads-up for this problem too: http://github.com/subsonic/SubSonic-3.0/issuesearch?state=open&q=BOOL#issue/111




             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
50.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Generated active records for vb got some errors
      
      
        2 comments
        Created 5 months ago by tuanvt
        
          
        
      
    

    

      Title

      

      Body

      When adding files for generating active records for a vb project, all of the class in activerecord.vb missing "implements IActiveRecord.SetIsNew"  in SetIsNew.
Generated:

 Public Sub SetIsNew(ByVal isNew As Boolean) 
            _isNew = isNew
        End Sub

Should be

            Public Sub SetIsNew(ByVal isNew As Boolean) Implements IActiveRecord.SetIsNew
            _isNew = isNew
        End Sub

       or cancel
    
  

  

    

      
When adding files for generating active records for a vb project, all of the class in activerecord.vb missing "implements IActiveRecord.SetIsNew"  in SetIsNew.

Generated:

 Public Sub SetIsNew(ByVal isNew As Boolean)

        _isNew = isNew
    End Sub


Should be

        Public Sub SetIsNew(ByVal isNew As Boolean) Implements IActiveRecord.SetIsNew
        _isNew = isNew
    End Sub


    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 14 14:17:55 -0700 2009
              | link
              
            
          
          

            
Patch me please - I don't know VB

          

          

            Comment

            Patch me please - I don't know VB

             or cancel
          
        
      
        

          

            
            
              Rickrat
              Tue Jul 14 17:06:40 -0700 2009
              | link
              
            
          
          

            
Tuanvt See http://github.com/subsonic/SubSonic-3.0/issues#issue/42 for the fix

          

          

            Comment

            Tuanvt See http://github.com/subsonic/SubSonic-3.0/issues#issue/42 for the fix

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
49.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Can Sql 2005 data type "XML" be unicode string instead of ansi string
      
      
        4 comments
        Created 5 months ago by ClarkKang
        
          
        
      
    

    

      Title

      

      Body

      SQL 2005 new data type "XML" is translate to ansi string. So, the unicode character cannot save back to SQL Server. It became "???" in the database.

       or cancel
    
  

  

    

      
SQL 2005 new data type "XML" is translate to ansi string. So, the unicode character cannot save back to SQL Server. It became "???" in the database.

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 14 14:17:32 -0700 2009
              | link
              
            
          
          

            
A string is a string - what you're seeing, I think, has more to do with the file type encoding and how your DB handles it.

          

          

            Comment

            A string is a string - what you're seeing, I think, has more to do with the file type encoding and how your DB handles it. 

             or cancel
          
        
      
        

          

            
            
              ClarkKang
              Wed Jul 15 00:48:48 -0700 2009
              | link
              
            
          
          

            
I think so at first time. But I try to insert data by QueryCommand, and set the parameter's data type as "DbType.XML". Then the data save to database correctly.

I can't find out where to modify the data type to DbType.XML.

Here is the string I try to save:

  <vcCustomer_Name>羅亦峻12</vcCustomer_Name>

          

          

            Comment

            I think so at first time. But I try to insert data by QueryCommand, and set the parameter's data type as "DbType.XML". Then the data save to database correctly.
I can't find out where to modify the data type to DbType.XML.
Here is the string I try to save:


  <vcCustomer_Name>羅亦峻12</vcCustomer_Name>


             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:13:44 -0700 2009
              | link
              
            
          
          

            
OK I've added a DBType.Xml switch to SQLServer.ttinclude - pushing now.

          

          

            Comment

            OK I've added a DBType.Xml switch to SQLServer.ttinclude - pushing now.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:13:59 -0700 2009
              | link
              
            
          
          

            
Closing...

          

          

            Comment

            Closing...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
48.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Incorrect Order when using paging with order by
      
      
        3 comments
        Created 5 months ago by ClarkKang
        
          
        
      
    

    

      Title

      

      Body

      When using paging and order by, the result of the query is in wrong order.
Is it possible to add order by "IndexId" to the sqlgenerator?

       or cancel
    
  

  

    

      
When using paging and order by, the result of the query is in wrong order.

Is it possible to add order by "IndexId" to the sqlgenerator?

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 14 14:16:20 -0700 2009
              | link
              
            
          
          

            
I don't understand what you're asking and what "wrong order" means.

          

          

            Comment

            I don't understand what you're asking and what "wrong order" means.

             or cancel
          
        
      
        

          

            
            
              ClarkKang
              Tue Jul 14 22:44:28 -0700 2009
              | link
              
            
          
          

            
I figure it out. I'll try to explain it clearly.

1. The data type of the table's pk is "uniqueidentifier"

2. I create a view base on the table.

3. Using query object to query the view with paging and order by

The query will generate the sql like :

SELECT  FROM #temp

WHERE _indexID BETWEEN ((@Page - 1)  @PageSize + 1) AND (@Page * @PageSize)

Because of the table's pk is a uniqueidentifier. So, without order by _indexID , the order of the result is unexpected.

I hope the information will help.



          

          

            Comment

            I figure it out. I'll try to explain it clearly. 
1. The data type of the table's pk is "uniqueidentifier"
2. I create a view base on the table.
3. Using query object to query the view with paging and order by

The query will generate the sql like :
SELECT * FROM #temp
WHERE _indexID BETWEEN ((@Page - 1) * @PageSize + 1) AND (@Page * @PageSize)

Because of the table's pk is a uniqueidentifier. So, without order by _indexID , the order of the result is unexpected.
I hope the information will help.


             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:05:56 -0700 2009
              | link
              
            
          
          

            
Right - if you don't supply an OrderBy in your query we default to the PK. If you want something other than that, you need to send it in. Closing.

          

          

            Comment

            Right - if you don't supply an OrderBy in your query we default to the PK. If you want something other than that, you need to send it in. Closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
47.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Incorrect datetime value for MySQL.
      
      
        3 comments
        Created 5 months ago by Settler
        
          
        
      
    

    

      Title

      

      Body

      MySQL datetime format is: 'YYYY-MM-DD HH:MM:SS' or 'YY-MM-DD HH:MM:SS'
When I'm save entity of ActiveRecord template that have, for example, column ModifiedOn, then I catch exception: "Incorrect datetime value: '13.07.2009 11:56:45' for column 'ModifiedOn' at row 1", beacause DateTime.Now.ToString(), for default, give value in CurrentCulture (CurrentUICulture?) format... For Russian culture is: 'DD-MM-YYYY HH:MM:SS'.

       or cancel
    
  

  

    

      
MySQL datetime format is: 'YYYY-MM-DD HH:MM:SS' or 'YY-MM-DD HH:MM:SS'

When I'm save entity of ActiveRecord template that have, for example, column ModifiedOn, then I catch exception: "Incorrect datetime value: '13.07.2009 11:56:45' for column 'ModifiedOn' at row 1", beacause DateTime.Now.ToString(), for default, give value in CurrentCulture (CurrentUICulture?) format... For Russian culture is: 'DD-MM-YYYY HH:MM:SS'.

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 14 14:14:52 -0700 2009
              | link
              
            
          
          

            
Try the latest source and see if this is fixed. I caught a couple of DbType errors in there.

          

          

            Comment

            Try the latest source and see if this is fixed. I caught a couple of DbType errors in there.

             or cancel
          
        
      
        

          

            
            
              carlosklein
              Wed Jul 15 06:49:14 -0700 2009
              | link
              
            
          
          

            
Nice! I was having the same problem here. Using the latest source, problem solved.

          

          

            Comment

            Nice! I was having the same problem here. Using the latest source, problem solved.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:04:32 -0700 2009
              | link
              
            
          
          

            
Great :)

          

          

            Comment

            Great :)

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
46.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Update() problem in MVC controller
      
      
        6 comments
        Created 5 months ago by dada730
        
          
        
      
    

    

      Title

      

      Body

      Hi, I am trying to transform the last tutorials of MVC into Subsonic 3.0 base in www.asp.net/MVC. When I edit an item and POST back to the Controller:
ContactController.cs
        [AcceptVerbs(HttpVerbs.Post)]
        public ActionResult Edit(Contact contactToEdit)
        {
            ValidateContact(contactToEdit);
            if (!ModelState.IsValid)
                return View();
            try
            {
                // TODO: Add update logic here
                _repository.EditContact(contactToEdit);

                //return View(contactToEdit);
                return RedirectToAction("Index");
            }
            catch
            {
                return View();
            }
        }
EntiryContactManagerRepository.cs
        public Contact EditContact(Contact contactToEdit)
        {
            var contactMe = Contact.SingleOrDefault(x => x.Id == contactToEdit.Id);
            contactMe.FirstName = contactToEdit.FirstName;
            contactMe.LastName = contactToEdit.LastName;
            contactMe.Phone = contactToEdit.Phone;
            contactMe.Email = contactToEdit.Email;
            contactMe.Update();
            return contactMe;
            //contactToEdit.Update();
            //return contactToEdit;
        }
I can't do the direct Update() from the POST back an "contact" that already contain an Id. so I need to do it in another repository class. Any idea about how to simplify it?
I love subsonic and I really want to see that doing with it is more simpler that doing with LINQToSql or entity framework.

       or cancel
    
  

  

    

      
Hi, I am trying to transform the last tutorials of MVC into Subsonic 3.0 base in www.asp.net/MVC. When I edit an item and POST back to the Controller:

ContactController.cs



    [AcceptVerbs(HttpVerbs.Post)]
    public ActionResult Edit(Contact contactToEdit)
    {
        ValidateContact(contactToEdit);
        if (!ModelState.IsValid)
            return View();
        try
        {
            // TODO: Add update logic here
            _repository.EditContact(contactToEdit);

            //return View(contactToEdit);
            return RedirectToAction("Index");
        }
        catch
        {
            return View();
        }
    }


EntiryContactManagerRepository.cs



    public Contact EditContact(Contact contactToEdit)
    {
        var contactMe = Contact.SingleOrDefault(x => x.Id == contactToEdit.Id);
        contactMe.FirstName = contactToEdit.FirstName;
        contactMe.LastName = contactToEdit.LastName;
        contactMe.Phone = contactToEdit.Phone;
        contactMe.Email = contactToEdit.Email;
        contactMe.Update();
        return contactMe;
        //contactToEdit.Update();
        //return contactToEdit;
    }


I can't do the direct Update() from the POST back an "contact" that already contain an Id. so I need to do it in another repository class. Any idea about how to simplify it?

I love subsonic and I really want to see that doing with it is more simpler that doing with LINQToSql or entity framework.

    

    
Comments
    

      
        

          

            
            
              dada730
              Sun Jul 12 19:33:25 -0700 2009
              | link
              
            
          
          

            
When I do it directly like this:

ContactController.cs



[AcceptVerbs(HttpVerbs.Post)]
public ActionResult Edit(Contact contactToEdit)
{
    ValidateContact(contactToEdit);
    if (!ModelState.IsValid)
        return View();
    try
    {
        // TODO: Add update logic here
        contactToEdit.Update();

        //return View(contactToEdit);
        return RedirectToAction("Index");
    }
    catch
    {
        return View();
    }
}


It just don't work!

          

          

            Comment

            When I do it directly like this:
ContactController.cs
    [AcceptVerbs(HttpVerbs.Post)]
    public ActionResult Edit(Contact contactToEdit)
    {
        ValidateContact(contactToEdit);
        if (!ModelState.IsValid)
            return View();
        try
        {
            // TODO: Add update logic here
            contactToEdit.Update();

            //return View(contactToEdit);
            return RedirectToAction("Index");
        }
        catch
        {
            return View();
        }
    }
It just don't work!

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 12 21:34:25 -0700 2009
              | link
              
            
          
          

            
I think this is more a StackOverflow type question since there doesn't appear to be an issue with SubSonic to me. As far as your comment goes, "It just don't work!" is not a very complete picture of the problem. You need to explain what you expected to happen and what happened instead (error?).

          

          

            Comment

            I think this is more a StackOverflow type question since there doesn't appear to be an issue with SubSonic to me. As far as your comment goes, "It just don't work!" is not a very complete picture of the problem. You need to explain what you expected to happen and what happened instead (error?).

             or cancel
          
        
      
        

          

            
            
              dada730
              Mon Jul 13 17:25:42 -0700 2009
              | link
              
            
          
          

            
That means I can't do an Update() in the active record method, the Update() doesn't work. When I click the Update button in the view, the “post” type "ActionResult Edit(Contact contactToEdit)" runs, the parameter class "contactToEdit" contain new values in its members being post back. But It seems that It's flaged IsNew or something. whenever I run it, it just do a new insert, but not an update operation. Yesterday I posted this issues When I was using 3.0.0.1, I did it in the first way it was still working. then I updated to 3.0.0.3, I found that the update() operation doesn't work anymore when ever I try:



    var contactMe = Contact.SingleOrDefault(x => x.Id == contactToEdit.Id);
    contactMe.FirstName = contactToEdit.FirstName;
    contactMe.LastName = contactToEdit.LastName;
    contactMe.Phone = contactToEdit.Phone;
    contactMe.Email = contactToEdit.Email;
    contactMe.Update();


or:



    contactToEdit.Update();


          

          

            Comment

            That means I can't do an Update() in the active record method, the Update() doesn't work. When I click the Update button in the view, the “post” type "ActionResult Edit(Contact contactToEdit)" runs, the parameter class "contactToEdit" contain new values in its members being post back. But It seems that It's flaged IsNew or something. whenever I run it, it just do a new insert, but not an update operation. Yesterday I posted this issues When I was using 3.0.0.1, I did it in the first way it was still working. then I updated to 3.0.0.3, I found that the update() operation doesn't work anymore when ever I try:
        var contactMe = Contact.SingleOrDefault(x => x.Id == contactToEdit.Id);
        contactMe.FirstName = contactToEdit.FirstName;
        contactMe.LastName = contactToEdit.LastName;
        contactMe.Phone = contactToEdit.Phone;
        contactMe.Email = contactToEdit.Email;
        contactMe.Update();
        
or:
        contactToEdit.Update();
        


             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 14 14:13:56 -0700 2009
              | link
              
            
          
          

            
I don't understand the problem. Also - you should use "UpdateModel(contact)" to avoid the left/right stuff.

When you say "doesn't work" - what do you mean?

          

          

            Comment

            I don't understand the problem. Also - you should use "UpdateModel(contact)" to avoid the left/right stuff.

When you say "doesn't work" - what do you mean?

             or cancel
          
        
      
        

          

            
            
              dada730
              Tue Jul 14 23:59:42 -0700 2009
              | link
              
            
          
          

            
I finally found that was my own mistake in my code to use repository pattern. During the test  I copied and pasted the code and forgot to changed it to "EditContact"



        _repository.CreateContact(contactToEdit);


So whenever I try to changed the code in the EditContact itself, it just didn't work, it calls the CreateContact instead  ...

Thanks Rob! The "UpdateModel" helps me a lot! I'm learning MVC with subsonic. I was thinking that Subsonic must have this kind of method, but when I tried the Update() method it doesn't appear to be what I want.I think the best practice is the fastest develop speed in small projects!

By the way, where's the class document in subsonicproject.com, I can't find that.



          

          

            Comment

            I finally found that was my own mistake in my code to use repository pattern. During the test  I copied and pasted the code and forgot to changed it to "EditContact"
            _repository.CreateContact(contactToEdit);
So whenever I try to changed the code in the EditContact itself, it just didn't work, it calls the CreateContact instead  ...
Thanks Rob! The "UpdateModel" helps me a lot! I'm learning MVC with subsonic. I was thinking that Subsonic must have this kind of method, but when I tried the Update() method it doesn't appear to be what I want.I think the best practice is the fastest develop speed in small projects!
By the way, where's the class document in subsonicproject.com, I can't find that.


             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:04:21 -0700 2009
              | link
              
            
          
          

            
Glad you found the problem. I don't know what you mean by class document (send a message to our mailing list at subsonicproject@googlegroups). Closing.

          

          

            Comment

            Glad you found the problem. I don't know what you mean by class document (send a message to our mailing list at subsonicproject@googlegroups). Closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
45.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Make it easy to override GetHashCode implementation
      
      
        2 comments
        Created 5 months ago by WillSullivan
        
          
        
      
    

    

      Title

      

      Body

      I've heard a couple people complain about the hashcode implementation in the T4 templates.  I've got a workaround that would allow people to easily override the implementation via partial classes and partial methods without having to extend the data models.

Here's some sample code that illustrates how to do this:
    public partial class Foo
    {
        public override int GetHashCode()
        {
            int? result = null;
            TryGetHashCode(ref result);
            if (result.HasValue)
                return result.Value;
            return new Random().Next();
        }

        partial void TryGetHashCode(ref int? result);
    }

    public partial class Foo
    {
        partial void TryGetHashCode(ref int? result)
        {
            result = 5;
        }
    }

If you don't create a partial class for Foo, or if your partial class doesn't provide an implementation of Foo, then execution of the default hashcode executes and the result is returned.  Simply providing the partial class with the implementation will override the default implementation.  You already know the benefits of using partial classes when dealing with generated code.

       or cancel
    
  

  

    

      
I've heard a couple people complain about the hashcode implementation in the T4 templates.  I've got a workaround that would allow people to easily override the implementation via partial classes and partial methods without having to extend the data models.

Here's some sample code that illustrates how to do this:



public partial class Foo
{
    public override int GetHashCode()
    {
        int? result = null;
        TryGetHashCode(ref result);
        if (result.HasValue)
            return result.Value;
        return new Random().Next();
    }

    partial void TryGetHashCode(ref int? result);
}

public partial class Foo
{
    partial void TryGetHashCode(ref int? result)
    {
        result = 5;
    }
}


If you don't create a partial class for Foo, or if your partial class doesn't provide an implementation of Foo, then execution of the default hashcode executes and the result is returned.  Simply providing the partial class with the implementation will override the default implementation.  You already know the benefits of using partial classes when dealing with generated code.

    

    
Comments
    

      
        

          

            
            
              Settler
              Sun Jul 12 21:37:22 -0700 2009
              | link
              
            
          
          

            
I think, GetHashCode override can be implemented in T4 template of ActiveRecord like this:



    public override int GetHashCode()
    {
        if(!isNew && KeyValue() != null)
        {
            return KeyValue().GetHashCode();
        }

        return base.GetHashCode();
    }


          

          

            Comment

            I think, GetHashCode override can be implemented in T4 template of ActiveRecord like this:
        public override int GetHashCode()
        {
            if(!isNew && KeyValue() != null)
            {
                return KeyValue().GetHashCode();
            }

            return base.GetHashCode();
        }

             or cancel
          
        
      
        

          

            
            
              WillSullivan
              Mon Jul 13 06:22:25 -0700 2009
              | link
              
            
          
          

            
It essentially is.  But that is going to rely on the framework's implementation of the hashing function for pretty much any key value you have, which is NOT a good thing.  A better implementation would hash it against the other state of the active record and return the result. If a developer needs a good hash code implementation they're going to have to do it themselves; it would be near impossible for a T4 to be dead on every time.

          

          

            Comment

            It essentially is.  But that is going to rely on the framework's implementation of the hashing function for pretty much any key value you have, which is NOT a good thing.  A better implementation would hash it against the other state of the active record and return the result. If a developer needs a good hash code implementation they're going to have to do it themselves; it would be near impossible for a T4 to be dead on every time.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
44.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        The member 'MemberName' is not supported.
      
      
        2 comments
        Created 5 months ago by Settler
        
          
        
      
    

    

      Title

      

      Body

      Version 3.0.0.2
I'm create basic interface, that help me create base classes for all entities. Here it is:
/// <summary>
    /// A basic record interface
    /// </summary>
    public interface IBasicRecord : IActiveRecord
    {
		long Id { get; set; }
    }

In ActiveRecord.tt almost all my classes implement IBasicRecord. For example:
public partial class Test : IBasicRecord
{
....
        private long idDbColumn;
        public long Id
        {
            get { return idDbColumn; }
            set
            {
                idDbColumn = value;
                var col=tbl.Columns.SingleOrDefault(x=>x.Name == "Id");
                if(col!=null)
                {
                    if(!dirtyColumns.Any(x=>x.Name == col.Name) && isLoaded)
                    {
                        dirtyColumns.Add(col);
                    }
                }
                OnChanged();
            }
        }
....
}

So, when I'm type code like this:
Test test = (new SubSonicRepository<Test> (new MyDB())).GetAll().SingleOrDefault(o => o.Id == entityId);
Everything work fine, but if I'm write:

public class Helper<T> where T : IBasicRecord, new()
{
    public T GetById(entityId)
    {
        T test = (new SubSonicRepository<T>(new MyDB())).GetAll().SingleOrDefault(o => o.Id == entityId);
    }
}

then I'm catch NotSupportedException. I'm do something wrong?

       or cancel
    
  

  

    

      
Version 3.0.0.2

I'm create basic interface, that help me create base classes for all entities. Here it is:

/// 

/// A basic record interface
/// </summary>
public interface IBasicRecord : IActiveRecord
{
    long Id { get; set; }
}


In ActiveRecord.tt almost all my classes implement IBasicRecord. For example:

public partial class Test : IBasicRecord

{
....

    private long idDbColumn;
    public long Id
    {
        get { return idDbColumn; }
        set
        {
            idDbColumn = value;
            var col=tbl.Columns.SingleOrDefault(x=>x.Name == "Id");
            if(col!=null)
            {
                if(!dirtyColumns.Any(x=>x.Name == col.Name) && isLoaded)
                {
                    dirtyColumns.Add(col);
                }
            }
            OnChanged();
        }
    }


....
}

So, when I'm type code like this:

Test test = (new SubSonicRepository (new MyDB())).GetAll().SingleOrDefault(o => o.Id == entityId);

Everything work fine, but if I'm write:

public class Helper where T : IBasicRecord, new()

{

public T GetById(entityId)
{
    T test = (new SubSonicRepository<T>(new MyDB())).GetAll().SingleOrDefault(o => o.Id == entityId);
}


}

then I'm catch NotSupportedException. I'm do something wrong?

    

    
Comments
    

      
        

          

            
            
              Settler
              Mon Jul 13 01:11:22 -0700 2009
              | link
              
            
          
          

            
Well. I'm fix this problem by changing method private static bool MembersMatch(MemberInfo a, MemberInfo b) of QueryBinder class from:



    private static bool MembersMatch(MemberInfo a, MemberInfo b)
    {
        if (a == b)
        {
            return true;
        }

    if (a is MethodInfo && b is PropertyInfo)
        {
            return a == ((PropertyInfo) b).GetGetMethod();
        }
        if (a is PropertyInfo && b is MethodInfo)
        {
            return ((PropertyInfo) a).GetGetMethod() == b;
        }
        return false;
    }


to:



    private static bool MembersMatch(MemberInfo a, MemberInfo b)
    {
        if (a == b)
        {
            return true;
        }

        if ((a.DeclaringType.IsAssignableFrom(b.DeclaringType) || b.DeclaringType.IsAssignableFrom(a.DeclaringType)) &&
            a.Name == b.Name)
        {
            return true;
        } 

        if (a is MethodInfo && b is PropertyInfo)
        {
            return a == ((PropertyInfo) b).GetGetMethod();
        }
        if (a is PropertyInfo && b is MethodInfo)
        {
            return ((PropertyInfo) a).GetGetMethod() == b;
        }
        return false;
    }


If some one approve this, then add to new versions of SubSonic... Or, if I'm someday examine Git, then I'm could do it with myself.



          

          

            Comment

            Well. I'm fix this problem by changing method private static bool MembersMatch(MemberInfo a, MemberInfo b) of QueryBinder class from:
        private static bool MembersMatch(MemberInfo a, MemberInfo b)
        {
            if (a == b)
            {
                return true;
            }
			
	    if (a is MethodInfo && b is PropertyInfo)
            {
                return a == ((PropertyInfo) b).GetGetMethod();
            }
            if (a is PropertyInfo && b is MethodInfo)
            {
                return ((PropertyInfo) a).GetGetMethod() == b;
            }
            return false;
        }
to:
        private static bool MembersMatch(MemberInfo a, MemberInfo b)
        {
            if (a == b)
            {
                return true;
            }
			
			if ((a.DeclaringType.IsAssignableFrom(b.DeclaringType) || b.DeclaringType.IsAssignableFrom(a.DeclaringType)) &&
				a.Name == b.Name)
			{
				return true;
			} 
			
			if (a is MethodInfo && b is PropertyInfo)
            {
                return a == ((PropertyInfo) b).GetGetMethod();
            }
            if (a is PropertyInfo && b is MethodInfo)
            {
                return ((PropertyInfo) a).GetGetMethod() == b;
            }
            return false;
        }

If some one approve this, then add to new versions of SubSonic... Or, if I'm someday examine Git, then I'm could do it with myself.


             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 14 14:09:16 -0700 2009
              | link
              
            
          
          

            
Thank you for the fix! I added it in... will push in a day or so

          

          

            Comment

            Thank you for the fix! I added it in... will push in a day or so

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
43.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        sqldatetime overflow on_repo.add(post)
      
      
        5 comments
        Created 5 months ago by coolcoder
        
          
        
      
    

    

      Title

      

      Body

      I get an overflow error message when create a new post .I am from the UK so my datetime settings might be causing this but I dont think the app should cause an error.

SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM.

This relates to 3.0.0.1

       or cancel
    
  

  

    

      
I get an overflow error message when create a new post .I am from the UK so my datetime settings might be causing this but I dont think the app should cause an error.

SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM.

This relates to 3.0.0.1

    

    
Comments
    

      
        

          

            
            
              johnsheehan
              Sun Jul 12 21:37:14 -0700 2009
              | link
              
            
          
          

            
You need to post some more details and sample code otherwise we can't determine the problem. I would also suggest that unless you believe it to be a SubSonic bug, you should post it on StackOverflow.com (with more details and sample code).

          

          

            Comment

            You need to post some more details and sample code otherwise we can't determine the problem. I would also suggest that unless you believe it to be a SubSonic bug, you should post it on StackOverflow.com (with more details and sample code).

             or cancel
          
        
      
        

          

            
            
              coolcoder
              Mon Jul 13 01:36:57 -0700 2009
              | link
              
            
          
          

            
Well, this is the SimpleRepository example untouched (apart from adding RunMigrations in the controller). Create new post from the interface and I get that error when you save the post. I kind of think its a bug in the code that doesnt handle international date formats as I have not changed anything in the example.

          

          

            Comment

            Well, this is the SimpleRepository example untouched (apart from adding RunMigrations in the controller). Create new post from the interface and I get that error when you save the post. I kind of think its a bug in the code that doesnt handle international date formats as I have not changed anything in the example.

             or cancel
          
        
      
        

          

            
            
              coolcoder
              Mon Jul 13 01:37:32 -0700 2009
              | link
              
            
          
          

            
UK English date format here.

          

          

            Comment

            UK English date format here.

             or cancel
          
        
      
        

          

            
            
              coolcoder
              Wed Jul 15 00:37:15 -0700 2009
              | link
              
            
          
          

            
Any idea why this was closed ? Was this fixed?

          

          

            Comment

            Any idea why this was closed ? Was this fixed?

             or cancel
          
        
      
        

          

            
            
              coolcoder
              Wed Jul 15 05:18:04 -0700 2009
              | link
              
            
          
          

            
I think this is an issue with the jquery picker used - perhaps its formatting the date incorrectly. I have managed to work around this, doesnt look like an issue with the Subsonic code.

          

          

            Comment

            I think this is an issue with the jquery picker used - perhaps its formatting the date incorrectly. I have managed to work around this, doesnt look like an issue with the Subsonic code.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
42.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        SubSonic 3 vb templates
      
      
        8 comments
        Created 5 months ago by Rickrat
        
          
        
      
    

    

      Title

      

      Body

      ActiveRecord.tt line 296 wrap property name with [] e.g.
Public ReadOnly Property [<#=propName #>] As IQueryable(Of <#=fk.OtherClass #>)

ActiveRecord.tt line 322 wrap property name with [] e.g.
Public Property [<#=col.CleanName #>] As <#=col.SysType #><#=CheckNullable(col)#>

ActiveRecord.tt line 76 needs Implements iActiveRecord.SetIsNew
Public Sub SetIsNew(isNew As Boolean) Implements IActiveRecord.SetIsNew

Structs.tt line 45 wrap property name with [] e.g.
Public ReadOnly Property [<#=col.CleanName#>] As IColumn


       or cancel
    
  

  

    

      
ActiveRecord.tt line 296 wrap property name with [] e.g.

Public ReadOnly Property [<#=propName #>] As IQueryable(Of <#=fk.OtherClass #>)

ActiveRecord.tt line 322 wrap property name with [] e.g.

Public Property [<#=col.CleanName #>] As <#=col.SysType #><#=CheckNullable(col)#>

ActiveRecord.tt line 76 needs Implements iActiveRecord.SetIsNew

Public Sub SetIsNew(isNew As Boolean) Implements IActiveRecord.SetIsNew

Structs.tt line 45 wrap property name with [] e.g.

Public ReadOnly Property [<#=col.CleanName#>] As IColumn



    

    
Comments
    

      
        

          

            
            
              Rickrat
              Sat Jul 11 21:23:55 -0700 2009
              | link
              
            
          
          

            
In adventureworks and northwind, lots of fields like "Name" that are protected, need to have [Name] instead of Name.

          

          

            Comment

            In adventureworks and northwind, lots of fields like "Name" that are protected, need to have [Name] instead of Name.

             or cancel
          
        
      
        

          

            
            
              Rickrat
              Sat Jul 11 21:44:41 -0700 2009
              | link
              
            
          
          

            
This is subsonic 3.0.0.2 downloaded today.

          

          

            Comment

            This is subsonic 3.0.0.2 downloaded today.

             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 14 14:15:49 -0700 2009
              | link
              
            
          
          

            
Hi Rick- I don't know VB and this template set is a contribution. I'd love your help here...

          

          

            Comment

            Hi Rick- I don't know VB and this template set is a contribution. I'd love your help here...

             or cancel
          
        
      
        

          

            
            
              Rickrat
              Tue Jul 14 15:26:58 -0700 2009
              | link
              
            
          
          

            
And I'd love to help. Can I send you the changes and have you post them to git hub?

          

          

            Comment

            And I'd love to help. Can I send you the changes and have you post them to git hub?

             or cancel
          
        
      
        

          

            
            
              Rickrat
              Tue Jul 14 15:52:54 -0700 2009
              | link
              
            
          
          

            
file is here: http://dl.activeaspsoftware.net/dl.aspx?f=ActiveRecordVB.zip

          

          

            Comment

            file is here: http://dl.activeaspsoftware.net/dl.aspx?f=ActiveRecordVB.zip

             or cancel
          
        
      
        

          

            
            
              tuanvt
              Wed Jul 15 01:49:36 -0700 2009
              | link
              
            
          
          

            
Nice one, thanks.

          

          

            Comment

            Nice one, thanks.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:03:03 -0700 2009
              | link
              
            
          
          

            
Closing this waiting for push. Also please put template issues in the Template project :). Thanks for your help!

          

          

            Comment

            Closing this waiting for push. Also please put template issues in the Template project :). Thanks for your help!

             or cancel
          
        
      
        

          

            
            
              BlackMael
              Sat Jul 18 00:42:34 -0700 2009
              | link
              
            
          
          

            
Not that it really matters but I had also noticed this issue and solved it in a slightly different manner.  I may be anal, but I didn't like the idea of escaping all properties with square brackets so I created a function to only add square brackets where the resulting name would conflict with known VB.net keywords (see http://github.com/BlackMael/SubSonic-3.0-Templates/commit/06b47692eae0b2f99bedab7a1c6e2e9f6fabb3d7 )

          

          

            Comment

            Not that it really matters but I had also noticed this issue and solved it in a slightly different manner.  I may be anal, but I didn't like the idea of escaping all properties with square brackets so I created a function to only add square brackets where the resulting name would conflict with known VB.net keywords (see http://github.com/BlackMael/SubSonic-3.0-Templates/commit/06b47692eae0b2f99bedab7a1c6e2e9f6fabb3d7 )

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
41.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        ActiveRecord.tt and numeric ModifiedBy / CreatedBy fields
      
      
        3 comments
        Created 5 months ago by kmckelvin
        
          
        
      
    

    

      Title

      

      Body

      My pre-existing DMS database has integer fields for ModifiedBy & CreatedBy, which relate back to user ids inside my database.

It appears the ActiveRecord.tt generates the Update and Add methods with the code

            if(String.IsNullOrEmpty(this.ModifiedBy))
                this.ModifiedBy=Environment.UserName;

Problem is that this.ModifiedBy is of type Int32 (mapped correctly from my database, but gives invalid argument on String.IsNullOrEmpty) and also the assignment to Environment.UserName is thus erroneous.

It also has created methods taking string arguments for username:

        public void Add(string username){
            
            this.CreatedBy=username;
            Add();

        }

and

        public void Update(string username, IDataProvider provider){

            this.ModifiedBy=username;
            Update(provider);
        }

Hope this has enough info for you guys :)
Best Regards

       or cancel
    
  

  

    

      
My pre-existing DMS database has integer fields for ModifiedBy & CreatedBy, which relate back to user ids inside my database.

It appears the ActiveRecord.tt generates the Update and Add methods with the code

        if(String.IsNullOrEmpty(this.ModifiedBy))
            this.ModifiedBy=Environment.UserName;


Problem is that this.ModifiedBy is of type Int32 (mapped correctly from my database, but gives invalid argument on String.IsNullOrEmpty) and also the assignment to Environment.UserName is thus erroneous.

It also has created methods taking string arguments for username:

    public void Add(string username){

        this.CreatedBy=username;
        Add();

    }


and

    public void Update(string username, IDataProvider provider){

        this.ModifiedBy=username;
        Update(provider);
    }


Hope this has enough info for you guys :)

Best Regards

    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 11 15:26:50 -0700 2009
              | link
              
            
          
          

            
Our convention is that these are strings with a name. If you want to change your templates to a different convention you can do that :)

Closing...

          

          

            Comment

            Our convention is that these are strings with a name. If you want to change your templates to a different convention you can do that :)

Closing...

             or cancel
          
        
      
        

          

            
            
              kmckelvin
              Sat Jul 11 17:18:30 -0700 2009
              | link
              
            
          
          

            
I may be rambling here, but I've found that by modifying the lambda expressions used in ActiveRecord.tt, that established conventions can be held, while catering for the case where we aren't working with strings.

I've tested this pretty thoroughly now on MSSQL, in both cases where i'm using int and varchar & nvarchar fields to hold my modifiedby / createdby user

This is what I did:

ActiveRecord.tt

Line 398



<#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 415



<#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 436



<#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 443



<#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 456



<#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 486



<#if(tbl.Columns.Any(x=>(x.Name=="CreatedBy" || x.Name=="ModifiedBy") && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 491



<#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


Line 497



<#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>


I sincerely hope this helps your project.  I'm very new to it, but it's making a HUGE impact on my overall development progress!

          

          

            Comment

            I may be rambling here, but I've found that by modifying the lambda expressions used in ActiveRecord.tt, that established conventions can be held, while catering for the case where we aren't working with strings.

I've tested this pretty thoroughly now on MSSQL, in both cases where i'm using int and varchar & nvarchar fields to hold my modifiedby / createdby user

This is what I did:
ActiveRecord.tt

Line 398
    <#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 415
    <#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 436
    <#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 443
    <#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 456
    <#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 486
    <#if(tbl.Columns.Any(x=>(x.Name=="CreatedBy" || x.Name=="ModifiedBy") && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 491
    <#if(tbl.Columns.Any(x=>x.Name=="CreatedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

Line 497
    <#if(tbl.Columns.Any(x=>x.Name=="ModifiedBy" && (x.DbType == DbType.String || x.DbType == DbType.AnsiString))){#>

I sincerely hope this helps your project.  I'm very new to it, but it's making a HUGE impact on my overall development progress!

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 13:43:45 -0700 2009
              | link
              
            
          
          

            
Thanks for this :). Conventions don't fit everyone - but if you'd like to push this to me in a branch I'll add it in :)

          

          

            Comment

            Thanks for this :). Conventions don't fit everyone - but if you'd like to push this to me in a branch I'll add it in :)

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
40.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        System.Double generates incorrect Create SQL for float
      
      
        1 comment
        Created 5 months ago by billnet
        
          
        
      
    

    

      Title

      

      Body

      SimpleRepository, SQL2005.
A property of type Double gets translated to float(10,2), which is not valid. This should be just float, or float(53) (I guess?).

For a quick fix, I changed line 146 in Sql2005Schema.cs from:
if(column.DataType == DbType.Double || column.DataType == DbType.Decimal)

to just:

if (column.DataType == DbType.Decimal)



       or cancel
    
  

  

    

      
SimpleRepository, SQL2005.

A property of type Double gets translated to float(10,2), which is not valid. This should be just float, or float(53) (I guess?).

For a quick fix, I changed line 146 in Sql2005Schema.cs from:

if(column.DataType == DbType.Double || column.DataType == DbType.Decimal)

to just:

if (column.DataType == DbType.Decimal)

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 13:02:31 -0700 2009
              | link
              
            
          
          

            
FIXED: Issue 40. Using Double resulted in bad migration type of float(10,2) which should just be float. Closed by 0f6248f

          

          

            Comment

            FIXED: Issue 40. Using Double resulted in bad migration type of float(10,2) which should just be float. Closed by 0f6248f9ee1e30287140932ca051e1992c70da0d

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
39.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Database names that aren't a valid identifier don't generate correctly
      
      
        2 comments
        Created 5 months ago by kamsar
        
          
        
      
    

    

      Title

      

      Body

      I have a database whose name contains hyphens. Whether this is good practice or not is beside the point, but when I generate subsonic ActiveRecord off of it, it will not compile as it uses the hyphens to create the code namespace, which is of course not valid.

I've got a patch for it that I put together that basically adds a simple method to strip nonalphanumeric characters from the database name before it's put into the namespaces and class names.

I will try to submit this patch once I figure out git a bit more :)

       or cancel
    
  

  

    

      
I have a database whose name contains hyphens. Whether this is good practice or not is beside the point, but when I generate subsonic ActiveRecord off of it, it will not compile as it uses the hyphens to create the code namespace, which is of course not valid.

I've got a patch for it that I put together that basically adds a simple method to strip nonalphanumeric characters from the database name before it's put into the namespaces and class names.

I will try to submit this patch once I figure out git a bit more :)

    

    
Comments
    

      
        

          

            
            
              kamsar
              Fri Jul 10 10:04:23 -0700 2009
              | link
              
            
          
          

            
Git's not working out very well for me.

In any case the patch consists of this added to the Settings.ttinclude:

string CleanDatabaseName(string rawName)



{
    return Regex.Replace(rawName, "[^A-Za-z0-9]", "_");
}


and a bunch of places in ActiveRecord.tt and Context.tt where <#=DatabaseName#> turns into <#=CleanDatabaseName(DatabaseName)#>

There might be a better way to do it but that's quick n dirty.

          

          

            Comment

            Git's not working out very well for me.

In any case the patch consists of this added to the Settings.ttinclude:

string CleanDatabaseName(string rawName)
    {
		return Regex.Replace(rawName, "[^A-Za-z0-9]", "_");
    }

and a bunch of places in ActiveRecord.tt and Context.tt where <#=DatabaseName#> turns into <#=CleanDatabaseName(DatabaseName)#>

There might be a better way to do it but that's quick n dirty.

             or cancel
          
        
      
        

          

            
            
              robconery
              Sat Jul 11 15:19:14 -0700 2009
              | link
              
            
          
          

            
Actually it's completely the point :). Naming is our biggest issue (always has been)  and I don't want to change the core templates to meet specific naming problems - this is for you to work out as needed.

Closing...

          

          

            Comment

            Actually it's completely the point :). Naming is our biggest issue (always has been)  and I don't want to change the core templates to meet specific naming problems - this is for you to work out as needed.

Closing...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
38.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        IsNew is set to true when any loading of record is processed. As a result - duplicate records.
      
      
        2 comments
        Created 5 months ago by aibatalov
        
          
        
      
    

    

      Title

      

      Body

      If records is loading using GetPaged() method of IRepository interface or using other methods to load record, property IsNew is still set to true, while must be set to false. In fact property IsNew must be set to false in method SetKeyValue(), but this is not doing (this is problem of template) and SetKeyValue() method is never called, however on my opinion method SetKeyValue() must been called while any loading of record is processed.

       or cancel
    
  

  

    

      
If records is loading using GetPaged() method of IRepository interface or using other methods to load record, property IsNew is still set to true, while must be set to false. In fact property IsNew must be set to false in method SetKeyValue(), but this is not doing (this is problem of template) and SetKeyValue() method is never called, however on my opinion method SetKeyValue() must been called while any loading of record is processed.

    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 11 15:19:51 -0700 2009
              | link
              
            
          
          

            
Which version are you using?

          

          

            Comment

            Which version are you using?

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 12:55:38 -0700 2009
              | link
              
            
          
          

            
This has been addressed already - closing.

          

          

            Comment

            This has been addressed already - closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
37.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        SimpleRepository Example causing an error if RunMigrations is added
      
      
        3 comments
        Created 5 months ago by coolcoder
        
          
        
      
    

    

      Title

      

      Body

      If you install Subsonic 3.0.0.2 (or 3/3.0.0.1) and just edit the Home Controller to:

_repo = new SimpleRepository("Blog",SimpleRepositoryOptions.RunMigrations);

It will error with a truncate message even though no changes have been made to the Models. Is this due to the db that is supplied with the example not being built originally from the Model ?

I am using VSTS 2008 (Database Edition). 


       or cancel
    
  

  

    

      
If you install Subsonic 3.0.0.2 (or 3/3.0.0.1) and just edit the Home Controller to:

_repo = new SimpleRepository("Blog",SimpleRepositoryOptions.RunMigrations);

It will error with a truncate message even though no changes have been made to the Models. Is this due to the db that is supplied with the example not being built originally from the Model ?

I am using VSTS 2008 (Database Edition).



    

    
Comments
    

      
        

          

            
            
              alaorneto
              Sat Jul 11 21:10:43 -0700 2009
              | link
              
            
          
          

            
Hello. What's happening is that the example database have the body field as a long string type, but the Post class does not have the SubSonicLongString attribute set to the Body property, what makes that with the RunMigrations enabled the Migrate() tries to convert the long string type to a shorter, but it already have some big example string there, so it would be truncated. You can workaround this by adding [SubSonic.SqlGeneration.Schema.SubSonicLongString] right before the Body property in the Post class.

Hope it helps.

          

          

            Comment

            Hello. What's happening is that the example database have the body field as a long string type, but the Post class does not have the SubSonicLongString attribute set to the Body property, what makes that with the RunMigrations enabled the Migrate() tries to convert the long string type to a shorter, but it already have some big example string there, so it would be truncated. You can workaround this by adding [SubSonic.SqlGeneration.Schema.SubSonicLongString] right before the Body property in the Post class.
Hope it helps.

             or cancel
          
        
      
        

          

            
            
              coolcoder
              Sun Jul 12 02:34:56 -0700 2009
              | link
              
            
          
          

            
Thank you, I thought it had something to do with the db not being created by the example project in the first instance. Perhaps the example project should be updated - surprised I am the only person to try this.

          

          

            Comment

            Thank you, I thought it had something to do with the db not being created by the example project in the first instance. Perhaps the example project should be updated - surprised I am the only person to try this.

             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 14 14:11:28 -0700 2009
              | link
              
            
          
          

            
I've added this fix (thank you!) and will push in a day or so.

          

          

            Comment

            I've added this fix (thank you!) and will push in a day or so.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
36.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        Subsonic 3 Linq Projection from joined query fails results in null values
      
      
        3 comments
        Created 5 months ago by jonhilt
        
          
        
      
    

    

      Title

      

      Body

      When using LINQ to execute a joined query across several ActiveRecord classes, projecting the results into a different class appears to result in several of the projected class's fields being null.

More information can be found on Stack Overflow here 

http://stackoverflow.com/questions/1105052/subsonic-3-linq-projection-issue

       or cancel
    
  

  

    

      
When using LINQ to execute a joined query across several ActiveRecord classes, projecting the results into a different class appears to result in several of the projected class's fields being null.

More information can be found on Stack Overflow here

http://stackoverflow.com/questions/1105052/subsonic-3-linq-projection-issue

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 15 12:55:10 -0700 2009
              | link
              
            
          
          

            
I can't repro this and I think you might have some reserved word conflicts in there. Here is a test I just ran that passes:

    [Fact]
    public void Joined_Projection_Should_Return_All_Values() {
        var qry = (from c in _db.Customers
                         join order in _db.Orders on c.CustomerID equals order.CustomerID
                         join details in _db.OrderDetails on order.OrderID equals details.OrderID
                         join products in _db.Products on details.ProductID equals products.ProductID
                         select new CustomerSummaryView
                         {
                             CustomerID = c.CustomerID,
                             OrderID = order.OrderID,
                             ProductName = products.ProductName
                         });

        Assert.True(qry.Count() > 0);

        foreach (var view in qry) {
            Assert.False(String.IsNullOrEmpty(view.ProductName));
            Assert.True(view.OrderID > 0);
            Assert.False(String.IsNullOrEmpty(view.CustomerID));
        }

    }


          

          

            Comment

            I can't repro this and I think you might have some reserved word conflicts in there. Here is a test I just ran that passes:

        [Fact]
        public void Joined_Projection_Should_Return_All_Values() {
            var qry = (from c in _db.Customers
                             join order in _db.Orders on c.CustomerID equals order.CustomerID
                             join details in _db.OrderDetails on order.OrderID equals details.OrderID
                             join products in _db.Products on details.ProductID equals products.ProductID
                             select new CustomerSummaryView
                             {
                                 CustomerID = c.CustomerID,
                                 OrderID = order.OrderID,
                                 ProductName = products.ProductName
                             });

            Assert.True(qry.Count() > 0);

            foreach (var view in qry) {
                Assert.False(String.IsNullOrEmpty(view.ProductName));
                Assert.True(view.OrderID > 0);
                Assert.False(String.IsNullOrEmpty(view.CustomerID));
            }

        }



             or cancel
          
        
      
        

          

            
            
              jonhilt
              Thu Jul 16 01:33:28 -0700 2009
              | link
              
            
          
          

            
Thanks.

It's strange, I've just made some changes to my original query to see if I can get this working and still get null customer types (now called categories).

[Fact]

    public void Joined_Projection_Should_Return_All_Values()
    {
        var db = new DemoDB();

        var customers = (from c in db.tblCustomers
                         join address in db.tblAddresses on c.Address equals address.AddressId
                         join category in db.tblCustomerCategories on c.CustomerCategory equals category.CustomerCategoryId
                         select new CustomerSummaryView
                         {
                             CustomerName = c.CustomerName,
                             CustomerCategory = category.CategoryDescription,
                             Postcode = address.Postcode
                         });

        Assert.True(customers.Count() > 0);

        foreach (var view in customers)
        {
            Console.WriteLine(view.CustomerName);
            Console.WriteLine(view.CustomerCategory);
            Console.WriteLine(view.Postcode);

            Assert.NotNull(view.CustomerName);
            Assert.NotNull(view.CustomerCategory);
            Assert.NotNull(view.Postcode);
        }
    }


          

          

            Comment

            Thanks. 

It's strange, I've just made some changes to my original query to see if I can get this working and still get null customer types (now called categories).

[Fact]
        public void Joined_Projection_Should_Return_All_Values()
        {
            var db = new DemoDB();

            var customers = (from c in db.tblCustomers
                             join address in db.tblAddresses on c.Address equals address.AddressId
                             join category in db.tblCustomerCategories on c.CustomerCategory equals category.CustomerCategoryId
                             select new CustomerSummaryView
                             {
                                 CustomerName = c.CustomerName,
                                 CustomerCategory = category.CategoryDescription,
                                 Postcode = address.Postcode
                             });

            Assert.True(customers.Count() > 0);

            foreach (var view in customers)
            {
                Console.WriteLine(view.CustomerName);
                Console.WriteLine(view.CustomerCategory);
                Console.WriteLine(view.Postcode);

                Assert.NotNull(view.CustomerName);
                Assert.NotNull(view.CustomerCategory);
                Assert.NotNull(view.Postcode);
            }
        }


             or cancel
          
        
      
        

          

            
            
              jonhilt
              Thu Jul 16 01:35:00 -0700 2009
              | link
              
            
          
          

            
I have a test project (including the generated subsonic classes, unit test and database creation script).

Is there any way I can send that up to GitHub for someone to take a look at?

          

          

            Comment

            I have a test project (including the generated subsonic classes, unit test and database creation script).

Is there any way I can send that up to GitHub for someone to take a look at?

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
35.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        Order by error when I use it in join query
      
      
        6 comments
        Created 5 months ago by suvad
        
          
        
      
    

    

      Title

      

      Body

      When I use join query like in this one: 
                             var result = from p in db.bih_Companys
                             join t in db.bih_CompanyCategories
                             on p.CompanyID equals t.CompanyID
                             where t.CategoryId == id
                             orderby p.CompanyID
                             select p; 

I get an error: Column "dbo.bih_Companys.CompanyID" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause.
When I remove ORDER BY from my query I get an error :

The ranking function "ROW_NUMBER" must have an ORDER BY clause

because it is missing an ORDER BY.

The problem is in result.ToPagedList() function When it counts the total records. In that query ORDER BY should not be there. 

in my case this is SQLquery that counts total records : SELECT COUNT(*) FROM [dbo].[bih_Companys] AS t0 INNER JOIN [dbo].[bih_CompanyCompanies] AS t1   ON ([t0].[CompanyID] = [t1].[CompanyId]) WHERE ([t1].[CategoryId] = 2) ORDER BY [t0].[FirmaID]

But when I remove order by from original query then the subsonic query has this error: 

"SELECT [t0].[AdminId], [t0].[Address], [t0].[Activ], [t0].[Email], [t0].[Fax], [t0].[CompanyID], [t0].[CompanyName], [t0].[CountyId], [t0].[Description], [t0].[PartnerStatus], [t0].[Priority], [t0].[Phone], [t0].[UserId], [t0].[Web] FROM (   SELECT [t1].[AdminId], [t1].[Address], [t1].[Activ], [t1].[Email], [t1].[Fax], [t1].[CompanyID], [t1].[CompanyName], [t1].[CountyId], [t1].[Description], [t1].[PartnerStatus], [t1].[Priority],
--here is an error row number function is missing order by
ROW_NUMBER() OVER() AS rownum,
 [t1].[Phone], [t1].[UserId], [t1].[Web]   FROM [dbo].[bih_Companys] AS t1   INNER JOIN [dbo].[bih_CompanyCategories] AS t2     ON ([t1].[CompanyID] = [t2].[CompanyId])   WHERE ([t2].[CategorieId] = 2)   ) AS t0 WHERE [t0].[rownum] BETWEEN (5 + 1) AND (5 + 5)"

Please Help


       or cancel
    
  

  

    

      
When I use join query like in this one:



                         var result = from p in db.bih_Companys
                         join t in db.bih_CompanyCategories
                         on p.CompanyID equals t.CompanyID
                         where t.CategoryId == id
                         orderby p.CompanyID
                         select p; 


I get an error: Column "dbo.bih_Companys.CompanyID" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause.

When I remove ORDER BY from my query I get an error :

The ranking function "ROW_NUMBER" must have an ORDER BY clause

because it is missing an ORDER BY.

The problem is in result.ToPagedList() function When it counts the total records. In that query ORDER BY should not be there.

in my case this is SQLquery that counts total records : SELECT COUNT(*) FROM [dbo].[bih_Companys] AS t0 INNER JOIN [dbo].[bih_CompanyCompanies] AS t1   ON ([t0].[CompanyID] = [t1].[CompanyId]) WHERE ([t1].[CategoryId] = 2) ORDER BY [t0].[FirmaID]

But when I remove order by from original query then the subsonic query has this error:

"SELECT [t0].[AdminId], [t0].[Address], [t0].[Activ], [t0].[Email], [t0].[Fax], [t0].[CompanyID], [t0].[CompanyName], [t0].[CountyId], [t0].[Description], [t0].[PartnerStatus], [t0].[Priority], [t0].[Phone], [t0].[UserId], [t0].[Web] FROM (   SELECT [t1].[AdminId], [t1].[Address], [t1].[Activ], [t1].[Email], [t1].[Fax], [t1].[CompanyID], [t1].[CompanyName], [t1].[CountyId], [t1].[Description], [t1].[PartnerStatus], [t1].[Priority],
--here is an error row number function is missing order by
ROW_NUMBER() OVER() AS rownum,

 [t1].[Phone], [t1].[UserId], [t1].[Web]   FROM [dbo].[bih_Companys] AS t1   INNER JOIN [dbo].[bih_CompanyCategories] AS t2     ON ([t1].[CompanyID] = [t2].[CompanyId])   WHERE ([t2].[CategorieId] = 2)   ) AS t0 WHERE [t0].[rownum] BETWEEN (5 + 1) AND (5 + 5)"

Please Help



    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 11 15:24:25 -0700 2009
              | link
              
            
          
          

            
This is an issue we know about - thanks for reporting :)

          

          

            Comment

            This is an issue we know about - thanks for reporting :)

             or cancel
          
        
      
        

          

            
            
              suvad
              Sun Jul 12 23:18:21 -0700 2009
              | link
              
            
          
          

            
Thanks for reply.

I have one more question.

Is this possible to solve?

Because I stuck here!

Or is there some other way to make join query's make work with paged results!

We are implementing Subsonic 3 instead Subsonic 2 because 3 simplifies paging allot more then Subsonic 2.

Please answer!

Thanks in advance!



          

          

            Comment

            Thanks for reply.
I have one more question.
Is this possible to solve? 
Because I stuck here!
Or is there some other way to make join query's make work with paged results!

We are implementing Subsonic 3 instead Subsonic 2 because 3 simplifies paging allot more then Subsonic 2. 
Please answer!

Thanks in advance! 


             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 14 14:05:54 -0700 2009
              | link
              
            
          
          

            
Yes you can use the old query syntax and use "ToPagedList()" on the reader

http://subsonicproject.com/docs/Simple_Query_Tool



          

          

            Comment

            Yes you can use the old query syntax and use "ToPagedList()" on the reader
http://subsonicproject.com/docs/Simple_Query_Tool


             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 12:46:47 -0700 2009
              | link
              
            
          
          

            
I fixed this today - will push tonight. You can get latest source if you like.

          

          

            Comment

            I fixed this today - will push tonight. You can get latest source if you like.

             or cancel
          
        
      
        

          

            
            
              runxc1
              Fri Sep 11 09:15:57 -0700 2009
              | link
              
            
          
          

            
Hey Rob what version is the fix found in.  I am still seeing this error in 3.0.0.3

          

          

            Comment

            Hey Rob what version is the fix found in.  I am still seeing this error in 3.0.0.3

             or cancel
          
        
      
        

          

            
            
              suvad
              Sun Sep 13 23:09:35 -0700 2009
              | link
              
            
          
          

            
That's solved  a long time ago.... Thank's to Rob.

          

          

            Comment

            That's solved  a long time ago.... Thank's to Rob.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
34.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Stored Procedure method parameters not in same order as defined in DB
      
      
        2 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      Minor issue, but broke some existing code I'm migrating from 2.2 to 3.0. The parameters for the generated SP proxies aren't in the same order as they're defined in the DB. I have limited evidence of this, but it appears they're being generated in alphabetical order.

       or cancel
    
  

  

    

      
Minor issue, but broke some existing code I'm migrating from 2.2 to 3.0. The parameters for the generated SP proxies aren't in the same order as they're defined in the DB. I have limited evidence of this, but it appears they're being generated in alphabetical order.

    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 11 15:24:58 -0700 2009
              | link
              
            
          
          

            
Grrr - that would be Connection.GetSchema :) having some fun with me.

          

          

            Comment

            Grrr - that would be Connection.GetSchema :) having some fun with me.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 15 12:46:21 -0700 2009
              | link
              
            
          
          

            
I'm going to close this issue here - can you please put into the templates project?

          

          

            Comment

            I'm going to close this issue here - can you please put into the templates project?

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
33.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        SubSonic.Schema.DatabaseTable.Name conflicts
      
      
        4 comments
        Created 5 months ago by lukesampson
        
          
        
      
    

    

      Title

      

      Body

      I get the compiler warning "'[ActiveRecord generated ClassName].Name' hides inherited member 'SubSonic.Schema.DatabaseTable.Name'. Use the new keyword if hiding was intended." compiler warning when the ActiveRecord templates generate code for my DB, because my table has a column called "Name".

Would it be possible to rename DatabaseTable.Name &gt; DatabaseTable.TableName or something similar that is less likely to conflict?

       or cancel
    
  

  

    

      
I get the compiler warning "'[ActiveRecord generated ClassName].Name' hides inherited member 'SubSonic.Schema.DatabaseTable.Name'. Use the new keyword if hiding was intended." compiler warning when the ActiveRecord templates generate code for my DB, because my table has a column called "Name".

Would it be possible to rename DatabaseTable.Name > DatabaseTable.TableName or something similar that is less likely to conflict?

    

    
Comments
    

      
        

          

            
            
              robconery
              Thu Jul 09 20:18:18 -0700 2009
              | link
              
            
          
          

            
You're asking me to rename a core class so you don't get naming conflicts in your DB? Ummm - no :p

          

          

            Comment

            You're asking me to rename a core class so you don't get naming conflicts in your DB? Ummm - no :p

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 20:20:47 -0700 2009
              | link
              
            
          
          

            
... and that came across a little too snarky :). Sorry bout that. You can re-engineer the templates as you need to. Naming, as always, is a major issue for us and it's why I made the T4 templates. So you can rename things as needed.

          

          

            Comment

            ... and that came across a little too snarky :). Sorry bout that. You can re-engineer the templates as you need to. Naming, as always, is a major issue for us and it's why I made the T4 templates. So you can rename things as needed.

             or cancel
          
        
      
        

          

            
            
              lukesampson
              Thu Jul 09 22:17:55 -0700 2009
              | link
              
            
          
          

            
Haha! That's ok - I guess it was a pretty annoying request :)

I'm not sure I understand - are you suggesting I modify ActiveRecord.tt and Structs.tt to watch out for database columns named "Name" and name the corresponding code properties something else? Or do you mean I should hand-edit the generated code and name the property something else, every time the T4 tool runs? Or something else?

How about if DatabaseTable implements the IDBObject.Name property explicitly instead of implicitly? Then when Structs.tt generates a table class for a table with a column named "Name" there won't be a conflict.

Feel free to tell me to get lost now!

          

          

            Comment

            Haha! That's ok - I guess it was a pretty annoying request :)

I'm not sure I understand - are you suggesting I modify ActiveRecord.tt and Structs.tt to watch out for database columns named "Name" and name the corresponding code properties something else? Or do you mean I should hand-edit the generated code and name the property something else, every time the T4 tool runs? Or something else?

How about if DatabaseTable implements the IDBObject.Name property explicitly instead of implicitly? Then when Structs.tt generates a table class for a table with a column named "Name" there won't be a conflict.

Feel free to tell me to get lost now!

             or cancel
          
        
      
        

          

            
            
              robconery
              Fri Jul 10 11:55:18 -0700 2009
              | link
              
            
          
          

            
LOL - well I guess I would probably start by saying "don't worry about the warning" but if you have FxCop going and it's messing up some reports (or something) then you could tweak the templates to get around it. It might be a tad involved - but basically it would be changing how Structs.tt does the schema thing and how Context.tt calls it.

          

          

            Comment

            LOL - well I guess I would probably start by saying "don't worry about the warning" but if you have FxCop going and it's messing up some reports (or something) then you could tweak the templates to get around it. It might be a tad involved - but basically it would be changing how Structs.tt does the schema thing and how Context.tt calls it.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
32.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        ActiveRecord - IsLoaded not set true when query is executed
      
      
        5 comments
        Created 5 months ago by awbacker
        
          
        
      
    

    

      Title

      

      Body

      Executing a linq query casues the IsNew flag to get True, but the IsLoaded flag to be False.  

I am not sure what that the isLoaded flag is intended to mean, but I take it that it refers to the object being loaded from the db.  The generated class's Load() method doesn't get called, it all happens in subsonic.extensions.database.ToEnumerable&lt;t&gt; (which creates the type, then calls database.Load&lt;t&gt;), which never sets the _isLoaded flag.  

Since &lt;t&gt; is IActiveRecord, should it be calling instance.Load(reader, false)?



       or cancel
    
  

  

    

      
Executing a linq query casues the IsNew flag to get True, but the IsLoaded flag to be False.



I am not sure what that the isLoaded flag is intended to mean, but I take it that it refers to the object being loaded from the db.  The generated class's Load() method doesn't get called, it all happens in subsonic.extensions.database.ToEnumerable<t> (which creates the type, then calls database.Load<t>), which never sets the _isLoaded flag.



Since <t> is IActiveRecord, should it be calling instance.Load(reader, false)?

    

    
Comments
    

      
        

          

            
            
              awbacker
              Thu Jul 09 13:05:06 -0700 2009
              | link
              
            
          
          

            
Perhaps this should actually be a call to item.SetIsLoaded(true) inside the database.Load<t>() call?

          

          

            Comment

            Perhaps this should actually be a call to item.SetIsLoaded(true) inside the database.Load&lt;t&gt;() call?

             or cancel
          
        
      
        

          

            
            
              spookytooth
              Thu Jul 09 13:09:14 -0700 2009
              | link
              
            
          
          

            
I don't follow you - I need to repro this.

          

          

            Comment

            I don't follow you - I need to repro this.

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 13:44:02 -0700 2009
              | link
              
            
          
          

            
(that's me btw)

          

          

            Comment

            (that's me btw)

             or cancel
          
        
      
        

          

            
            
              awbacker
              Thu Jul 09 14:23:15 -0700 2009
              | link
              
            
          
          

            
hehe :)  it goes like this for me...

var list = (from p in data.products.all() where p.createdOn > now select p).ToList()

stack:



Extensions.Database.Load /t/
Extensions.Database.ToEnumerable /t/
....
Linq.Structure.DbQueryProvider.Execute
Linq.Structure.Query...
....
System.Linq.ToEnumerable()


The object is created in Database.ToEnumerable(), calling the default constructor which sets IsNew=true.   The Database.Load() function then populates the object /t/.    The only places in the object that set IsLoaded are the Load(reader,...) functions and SetIsLoaded().  Since the object didn't load itself (database.load did), and SetIsLoaded did not get called, the object is not marked that way.   It also means that IsNew does not get reset to false.

I noticed this because it causes the IsDirty property to fail, since that reliese on dirtyColumns which is not populated by the setter since isLoaded is false.



          

          

            Comment

            hehe :)  it goes like this for me... 

var list = (from p in data.products.all() where p.createdOn > now select p).ToList()
stack:
    Extensions.Database.Load /t/
    Extensions.Database.ToEnumerable /t/
    ....
    Linq.Structure.DbQueryProvider.Execute
    Linq.Structure.Query...
    ....
    System.Linq.ToEnumerable()

The object is created in Database.ToEnumerable(), calling the default constructor which sets IsNew=true.   The Database.Load() function then populates the object /t/.    The only places in the object that set IsLoaded are the Load(reader,...) functions and SetIsLoaded().  Since the object didn't load itself (database.load did), and SetIsLoaded did not get called, the object is not marked that way.   It also means that IsNew does not get reset to false.

I noticed this because it causes the IsDirty property to fail, since that reliese on _dirtyColumns which is not populated by the setter since _isLoaded is false.  

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 16:42:02 -0700 2009
              | link
              
            
          
          

            
Great - thank you! Fixed...

          

          

            Comment

            Great - thank you! Fixed...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
31.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        ActiveRecord - Properties { set; } could use updated handler
      
      
        2 comments
        Created 5 months ago by awbacker
        
          
        
      
    

    

      Title

      

      Body

      The current handler calls onchanged, even though the value may not have changed.   A simple change to something like this would prevent that.  This will come in handy when INotifiyPropertyChange is implemented as well (either privately or publicly)

	if (_Amount != value) {
		_Amount = value;
		var col = tbl.Columns.SingleOrDefault(x => x.Name == "Amount");
		if (_isLoaded && col != null && !_dirtyColumns.Contains(col)) _dirtyColumns.Add(col);
		OnChanged();
	}

       or cancel
    
  

  

    

      
The current handler calls onchanged, even though the value may not have changed.   A simple change to something like this would prevent that.  This will come in handy when INotifiyPropertyChange is implemented as well (either privately or publicly)

if (_Amount != value) {
    _Amount = value;
    var col = tbl.Columns.SingleOrDefault(x => x.Name == "Amount");
    if (_isLoaded && col != null && !_dirtyColumns.Contains(col)) _dirtyColumns.Add(col);
    OnChanged();
}


    

    
Comments
    

      
        

          

            
            
              robconery
              Thu Jul 09 13:43:43 -0700 2009
              | link
              
            
          
          

            
Thanks! added.

          

          

            Comment

            Thanks! added.

             or cancel
          
        
      
        

          

            
            
              awbacker
              Thu Jul 09 14:14:58 -0700 2009
              | link
              
            
          
          

            
Hoooray :) And I was just getting git up and runnin so I could play with forking and such...

          

          

            Comment

            Hoooray :) And I was just getting git up and runnin so I could play with forking and such... 

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
30.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        == null generates invalid sql
      
      
        1 comment
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      Could be related to issue #3. Using LINQ templates and latest source.

See screenshot of code and generated SQL: http://screencast.com/t/EI77UERiT68

       or cancel
    
  

  

    

      
Could be related to issue #3. Using LINQ templates and latest source.

See screenshot of code and generated SQL: http://screencast.com/t/EI77UERiT68

    

    
Comments
    

      
        

          

            
            
              robconery
              Thu Jul 09 13:30:24 -0700 2009
              | link
              
            
          
          

            
Fixed issue with null equality incorrectly being set. Closed by e670ec5

          

          

            Comment

            Fixed issue with null equality incorrectly being set. Closed by e670ec59a5948b72c898b18643c0d13f01cdcb95

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
29.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Error executing sprocs (parameter SqlDbType is set to variant)
      
      
        2 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      I have a sproc with three int params. When I try to call it, I get this:

Implicit conversion from data type sql_variant to int is not allowed. Use the CONVERT function to run this query. 

Debugging the cmd object being called in DbDataProvider line 133 I see that all three params are DbType = object and SqlDbType is Variant.

It looks like QueryCommand.AddParameter(name, value) always sets the DbType to 'object' which then gets improperly translated to the SQL needed.

Database is SQL 2005

I'm trying to fix it, but if anyone else knows the fix, I'd be happy to save the time :)

       or cancel
    
  

  

    

      
I have a sproc with three int params. When I try to call it, I get this:

Implicit conversion from data type sql_variant to int is not allowed. Use the CONVERT function to run this query.

Debugging the cmd object being called in DbDataProvider line 133 I see that all three params are DbType = object and SqlDbType is Variant.

It looks like QueryCommand.AddParameter(name, value) always sets the DbType to 'object' which then gets improperly translated to the SQL needed.

Database is SQL 2005

I'm trying to fix it, but if anyone else knows the fix, I'd be happy to save the time :)

    

    
Comments
    

      
        

          

            
            
              johnsheehan
              Wed Jul 08 22:53:04 -0700 2009
              | link
              
            
          
          

            
If I update the generated StoredProcedures.cs file to use the overload that lets you specify DbType, it works. Is the QueryCommand.AddParamter overload without this supposed to try to determine the type before adding the parameter?

          

          

            Comment

            If I update the generated StoredProcedures.cs file to use the overload that lets you specify DbType, it works. Is the QueryCommand.AddParamter overload without this supposed to try to determine the type before adding the parameter?

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 13:22:20 -0700 2009
              | link
              
            
          
          

            
Hey john - I fixed this and just pushed...

          

          

            Comment

            Hey john - I fixed this and just pushed...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
28.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Context.cs: xTable not found
      
      
        2 comments
        Created 5 months ago by BatteryMan
        
          
        
      
    

    

      Title

      

      Body

      ------ Short Description ------

I am getting the following error message in Context.cs:

    The type or namespace name 'CustomerTable' could not be found (are you missing a using directive or an assembly reference?)

I get one of these errors for each of the tables in my database.

------ Long Version ------

- Using ActiveRecord
- My database has one table: Customer with two fields: CustomerID and CustomerName
- In the generated Context.cs, in the "void Init()" method, in the ' Schemas ' region
- The compiler is unable to find 'CustomerTable'

            #region ' Schemas '
        	if(DataProvider.Schema.Tables.Count == 0)
			{
            	DataProvider.Schema.Tables.Add(new CustomerTable(DataProvider));
            }
            #endregion

       or cancel
    
  

  

    

      
------ Short Description ------

I am getting the following error message in Context.cs:

The type or namespace name 'CustomerTable' could not be found (are you missing a using directive or an assembly reference?)


I get one of these errors for each of the tables in my database.

------ Long Version ------


Using ActiveRecord
My database has one table: Customer with two fields: CustomerID and CustomerName
In the generated Context.cs, in the "void Init()" method, in the ' Schemas ' region
The compiler is unable to find 'CustomerTable'

    #region ' Schemas '
    if(DataProvider.Schema.Tables.Count == 0)
    {
        DataProvider.Schema.Tables.Add(new CustomerTable(DataProvider));
    }
    #endregion




    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 20:06:14 -0700 2009
              | link
              
            
          
          

            
Make sure you regenerate your Structs.tt class - it defines this stuff.

          

          

            Comment

            Make sure you regenerate your Structs.tt class - it defines this stuff.

             or cancel
          
        
      
        

          

            
            
              BatteryMan
              Wed Jul 08 22:44:51 -0700 2009
              | link
              
            
          
          

            
Thanks.  It might be worth updating the ActiveRecord demo video to include the Structs.tt file (or place a comment somewhere on the page where the video is hosted).

          

          

            Comment

            Thanks.  It might be worth updating the ActiveRecord demo video to include the Structs.tt file (or place a comment somewhere on the page where the video is hosted).

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
27.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Guid as primary key is empty on insert with SimpleRepository
      
      
        3 comments
        Created 5 months ago by esp0
        
          
        
      
    

    

      Title

      

      Body

      Using this class:
	public class Task
	{
		public Guid ID { get; set; }
		public string Description { get; set; }
	}

The ID field is always <em>00000000-0000-0000-0000-000000000000</em> unless i explicitly set it to something else. Shouldn't it be NEWID() instead?

I see that this problem was avoided in the example by using a constructor (see c943d2b487bdbaeb7999ec2796a323c8016342f9), but should this be required?

       or cancel
    
  

  

    

      
Using this class:



public class Task
{
    public Guid ID { get; set; }
    public string Description { get; set; }
}


The ID field is always 00000000-0000-0000-0000-000000000000 unless i explicitly set it to something else. Shouldn't it be NEWID() instead?

I see that this problem was avoided in the example by using a constructor (see c943d2b), but should this be required?

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 20:05:20 -0700 2009
              | link
              
            
          
          

            
Yes - we can't default to knowing what you need :). You'll need to set the Guid in code (which is how it's usually done) or you can set the props in the DB as you need.

          

          

            Comment

            Yes - we can't default to knowing what you need :). You'll need to set the Guid in code (which is how it's usually done) or you can set the props in the DB as you need.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 08 20:23:57 -0700 2009
              | link
              
            
          
          

            
In thinking this over - I don't see a problem defaulting the SQL column to newID. I'll add this for SQL Server.

          

          

            Comment

            In thinking this over - I don't see a problem defaulting the SQL column to newID. I'll add this for SQL Server.

             or cancel
          
        
      
        

          

            
            
              esp0
              Wed Jul 08 22:59:38 -0700 2009
              | link
              
            
          
          

            
Great, thank you.

          

          

            Comment

            Great, thank you.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
26.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Renaming a column with SimpleRepository deletes content
      
      
        3 comments
        Created 5 months ago by esp0
        
          
        
      
    

    

      Title

      

      Body

      From http://blog.wekeroad.com/subsonic/subsonic-30-the-simplerepository/ :
    Yes – if you change your model then your DB will be synchronized. No, you will not lose data 

But if I rename a column, the data is lost. How can we solve this? With some kind of <em>[OldColumn("ColumnWithTypo")]</em> on the property?

       or cancel
    
  

  

    

      
From http://blog.wekeroad.com/subsonic/subsonic-30-the-simplerepository/ :



Yes – if you change your model then your DB will be synchronized. No, you will not lose data 


But if I rename a column, the data is lost. How can we solve this? With some kind of [OldColumn("ColumnWithTypo")] on the property?

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 20:04:25 -0700 2009
              | link
              
            
          
          

            
Renaming a column doesn't delete the data - it runs an ALTER statement which is not a DROP statement. Can you give me something to repro this please.

          

          

            Comment

            Renaming a column doesn't delete the data - it runs an ALTER statement which is not a DROP statement. Can you give me something to repro this please.

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 08 20:08:01 -0700 2009
              | link
              
            
          
          

            
Closing.

          

          

            Comment

            Closing.

             or cancel
          
        
      
        

          

            
            
              esp0
              Wed Jul 08 23:12:40 -0700 2009
              | link
              
            
          
          

            
Here is code to repro, hope this comment fields supports markdown:

Using SQL Server 2005 express on an ASP.NET app:

public class Task
{
    public int ID { get; set; }
    public string Description { get; set; }
}

protected void Page_Load(object sender, EventArgs e)
{
    var repo = new SimpleRepository("myDB", SimpleRepositoryOptions.RunMigrations);
    var task = new Task();
    task.Description = "This is now: " + DateTime.Now.ToString();
    repo.Add(task);

    Response.Write(task.Description);
}


After running the page_load 4 times, this is the table data:



select * from tasks:
ID          Description
----------- --------------------------------
111         This is now: 09.07.2009 08:06:16
112         This is now: 09.07.2009 08:06:17
113         This is now: 09.07.2009 08:06:17
114         This is now: 09.07.2009 08:06:18

(4 row(s) affected)


Now, after right-clicking on the Description-property, choosing refactor and then rename, i get this class:

public class Task
{
    public int ID { get; set; }
    public string TaskDescription { get; set; }
}


And then running the page-load gives me this data, notice that the description is gone for the old data:

select * from tasks:
ID          TaskDescription
----------- --------------------------------
111         
112         
113         
114         
115         This is now: 09.07.2009 08:08:04

(5 row(s) affected)


This produces the folowing SQL wich clearly is dropping the column (with the data)

IF  EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[DF_Tasks_Description]') AND type = 'D')
    ALTER TABLE Tasks DROP CONSTRAINT [DF_Tasks_Description]

ALTER TABLE [Tasks] DROP COLUMN Description;
ALTER TABLE [Tasks] ADD TaskDescription nvarchar(255) NOT NULL CONSTRAINT DF_Tasks_TaskDescription DEFAULT ('')
UPDATE Tasks SET TaskDescription=''


          

          

            Comment

            Here is code to repro, hope this comment fields supports markdown:

Using SQL Server 2005 express on an ASP.NET app:

	public class Task
	{
		public int ID { get; set; }
		public string Description { get; set; }
	}

    protected void Page_Load(object sender, EventArgs e)
    {
		var repo = new SimpleRepository("myDB", SimpleRepositoryOptions.RunMigrations);
		var task = new Task();
		task.Description = "This is now: " + DateTime.Now.ToString();
		repo.Add(task);

		Response.Write(task.Description);
	}


After running the page_load 4 times, this is the table data:
	select * from tasks:
	ID          Description
	----------- --------------------------------
	111         This is now: 09.07.2009 08:06:16
	112         This is now: 09.07.2009 08:06:17
	113         This is now: 09.07.2009 08:06:17
	114         This is now: 09.07.2009 08:06:18

	(4 row(s) affected)

Now, after right-clicking on the Description-property, choosing refactor and then rename, i get this class:

	public class Task
	{
		public int ID { get; set; }
		public string TaskDescription { get; set; }
	}

And then running the page-load gives me this data, notice that the description is gone for the old data:

	select * from tasks:
	ID          TaskDescription
	----------- --------------------------------
	111         
	112         
	113         
	114         
	115         This is now: 09.07.2009 08:08:04

	(5 row(s) affected)

This produces the folowing SQL wich clearly is dropping the column (with the data)

	IF  EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[DF_Tasks_Description]') AND type = 'D')
		ALTER TABLE Tasks DROP CONSTRAINT [DF_Tasks_Description]

	ALTER TABLE [Tasks] DROP COLUMN Description;
	ALTER TABLE [Tasks] ADD TaskDescription nvarchar(255) NOT NULL CONSTRAINT DF_Tasks_TaskDescription DEFAULT ('')
	UPDATE Tasks SET TaskDescription=''


             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
25.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
Fixed
x
            
          
        
        Error message when defining custom primary key with SimpleRepository
      
      
        2 comments
        Created 5 months ago by esp0
        
          
        
      
    

    

      Title

      

      Body

      The Folowing code generates an error from sql on an asp.net web site (sql express 2005) with an empty database:

	public class Task
	{
		[SubSonicPrimaryKey]
		public int myPK { get; set; }

		[SubSonicLongString]
		public string Description { get; set; }

	}

code-behind:
    protected void Page_Load(object sender, EventArgs e)
    {
			var task = new Task();
			task.Description = "This";
			var repo = new SimpleRepository("myDB", SimpleRepositoryOptions.RunMigrations);
			repo.Add(task);
    }

Errormessage:

	Cannot insert explicit value for identity column in table 'Tasks' when IDENTITY_INSERT is set to OFF.

I am using the latest binary from 3.0.0.1

       or cancel
    
  

  

    

      
The Folowing code generates an error from sql on an asp.net web site (sql express 2005) with an empty database:

public class Task
{
    [SubSonicPrimaryKey]
    public int myPK { get; set; }

    [SubSonicLongString]
    public string Description { get; set; }

}


code-behind:



protected void Page_Load(object sender, EventArgs e)
{
        var task = new Task();
        task.Description = "This";
        var repo = new SimpleRepository("myDB", SimpleRepositoryOptions.RunMigrations);
        repo.Add(task);
}


Errormessage:

Cannot insert explicit value for identity column in table 'Tasks' when IDENTITY_INSERT is set to OFF.


I am using the latest binary from 3.0.0.1

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 20:03:25 -0700 2009
              | link
              
            
          
          

            
Nice error report - knew exactly where the problem was :). Fixed...

          

          

            Comment

            Nice error report - knew exactly where the problem was :). Fixed...

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 08 20:07:52 -0700 2009
              | link
              
            
          
          

            
I'll push this next week with 3.0.0.2. You can pull from source if you need it sooner...

          

          

            Comment

            I'll push this next week with 3.0.0.2. You can pull from source if you need it sooner...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
24.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
Fixed
x
            
          
        
        Error on create post in SimpleRepo Example site
      
      
        1 comment
        Created 5 months ago by georgexcollins
        
          
        
      
    

    

      Title

      

      Body

      Creating a new post in the simple repo example site throws the following error:

SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM.

Line 138:                scope.Dispose();
Line 139:                //rethrow retaining stack trace.
Line 140:                throw;
Line 141:            }

in \SubSonic.Core\DataProviders\DbDataProvider.cs    Line:  140 

In debugger the values for the PostedOn dateTime seem reasonable so I'm not sure what the problem is.

       or cancel
    
  

  

    

      
Creating a new post in the simple repo example site throws the following error:

SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM.

Line 138:                scope.Dispose();

Line 139:                //rethrow retaining stack trace.

Line 140:                throw;

Line 141:            }

in \SubSonic.Core\DataProviders\DbDataProvider.cs    Line:  140

In debugger the values for the PostedOn dateTime seem reasonable so I'm not sure what the problem is.

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 19:56:37 -0700 2009
              | link
              
            
          
          

            
Thanks - fixed the bug.

          

          

            Comment

            Thanks - fixed the bug.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
23.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Subsonic 3 Active Record Testing
      
      
        1 comment
        Created 5 months ago by jonhilt
        
          
        
      
    

    

      Title

      

      Body

      If you call Update or Save when using the Active Record test mode you get an error.

System.NotImplementedException: The method or operation is not implemented. at SubSonic.Repository.TestRepository`1.Add(T item, IDataProvider provider) at Model.Generated.Product.Add(IDataProvider provider) in ActiveRecord.cs: line 708 at Model.Generated.Product.Save(IDataProvider provider) in ActiveRecord.cs: line 721 at Model.Generated.Product.Save() in ActiveRecord.cs: line 715 

See this question at Stack Overflow for more detail... 

http://stackoverflow.com/questions/1091041/subsonic-3-active-record-testing

       or cancel
    
  

  

    

      
If you call Update or Save when using the Active Record test mode you get an error.

System.NotImplementedException: The method or operation is not implemented. at SubSonic.Repository.TestRepository`1.Add(T item, IDataProvider provider) at Model.Generated.Product.Add(IDataProvider provider) in ActiveRecord.cs: line 708 at Model.Generated.Product.Save(IDataProvider provider) in ActiveRecord.cs: line 721 at Model.Generated.Product.Save() in ActiveRecord.cs: line 715

See this question at Stack Overflow for more detail...

http://stackoverflow.com/questions/1091041/subsonic-3-active-record-testing

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 19:51:37 -0700 2009
              | link
              
            
          
          

            
This should be fixed with the latest drop (3.0.0.01). I was having problems with a cached upload last night - please grab the latest drop and tell me if it fixes this for you.

          

          

            Comment

            This should be fixed with the latest drop (3.0.0.01). I was having problems with a cached upload last night - please grab the latest drop and tell me if it fixes this for you.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
22.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
Accepted
x
            
          
        
          

            

              
Fixed
x
            
          
        
        null varchar PK after ActiveRecord save
      
      
        6 comments
        Created 5 months ago by nathanb
        
          
        
      
    

    

      Title

      

      Body

      I'm working with the trunk as of 9:45PM CST. I'm using ActiveRecord templates against Sql 2008. My table has a varchar PK that is set externally. The insert works fine, but SCOPE_IDENTITY returns nothing and SubSonicRepository.Add() (line 204) sets my PK property to nothing.  (not null). When I ToString the result, it shows up as an empty string, which isn't caught by the null check. Later, this value is re-enforced to the entity in the ActiveRecord template where it SetKeyValue(the empty result).  

My hack fix for this is to compare the ToString() value to string.Empty and in the ActiveRecord template, check to see if it's numeric... (total hack for a quick fix). 

What are your thoughts? 



       or cancel
    
  

  

    

      
I'm working with the trunk as of 9:45PM CST. I'm using ActiveRecord templates against Sql 2008. My table has a varchar PK that is set externally. The insert works fine, but SCOPE_IDENTITY returns nothing and SubSonicRepository.Add() (line 204) sets my PK property to nothing.  (not null). When I ToString the result, it shows up as an empty string, which isn't caught by the null check. Later, this value is re-enforced to the entity in the ActiveRecord template where it SetKeyValue(the empty result).



My hack fix for this is to compare the ToString() value to string.Empty and in the ActiveRecord template, check to see if it's numeric... (total hack for a quick fix).

What are your thoughts?

    

    
Comments
    

      
        

          

            
            
              robconery
              Wed Jul 08 19:50:53 -0700 2009
              | link
              
            
          
          

            
It will be null no matter what so it's almost impossible to fix this issue. I reviewed your changes and SetKeyValue() already checks for null - so there's no choice as far as the stock templates are concerned.

You could create a partial for this class and override "OnSaved", then ping the DB for a reload - that would solve this problem.

          

          

            Comment

            It will be null no matter what so it's almost impossible to fix this issue. I reviewed your changes and SetKeyValue() already checks for null - so there's no choice as far as the stock templates are concerned.

You could create a partial for this class and override "OnSaved", then ping the DB for a reload - that would solve this problem.



             or cancel
          
        
      
        

          

            
            
              nathanb
              Wed Jul 08 23:02:35 -0700 2009
              | link
              
            
          
          

            
I see now. SetKeyValue also accommodates DBNull which is the value my PK is getting set to. The source of the problem now seems to be caused by the extra (if SqlClient) property set in SubSonicRepository.Add.  After the executescalar, it resets the primary key then returns the result. Since SetKeyValue works the way it should does this seem redundant?  Is it for one of the other template types?

I tested OnSaved().  In this case, by the time it fires, the PK has already been lost.

          

          

            Comment

            I see now. SetKeyValue also accommodates DBNull which is the value my PK is getting set to. The source of the problem now seems to be caused by the extra (if SqlClient) property set in SubSonicRepository.Add.  After the executescalar, it resets the primary key then returns the result. Since SetKeyValue works the way it should does this seem redundant?  Is it for one of the other template types? 

I tested OnSaved().  In this case, by the time it fires, the PK has already been lost. 

             or cancel
          
        
      
        

          

            
            
              nathanb
              Thu Jul 09 07:03:56 -0700 2009
              | link
              
            
          
          

            
You know another quick fix for this would be to just add a DBNull check on Line 204 in SubSonicRepository.Add(). Then it wouldn't be too invasive.

          

          

            Comment

            You know another quick fix for this would be to just add a DBNull check on Line 204 in SubSonicRepository.Add(). Then it wouldn't be too invasive. 

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 13:10:42 -0700 2009
              | link
              
            
          
          

            
This is already happening isn't it? Also - the PK "never was" so it can't be lost - it's in the DB so you'll need to pull it manually. Closing this (reopen if you think it needs to be)

          

          

            Comment

            This is already happening isn't it? Also - the PK "never was" so it can't be lost - it's in the DB so you'll need to pull it manually. Closing this (reopen if you think it needs to be)

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 09 14:13:45 -0700 2009
              | link
              
            
          
          

            
OK fixed up - just added a quick check to Add():



        var newKey=_repo.Add(this,provider);
        if(newKey!=KeyValue())
            this.SetKeyValue(newKey);


          

          

            Comment

            OK fixed up - just added a quick check to Add():
            var newKey=_repo.Add(this,provider);
            if(newKey!=KeyValue())
                this.SetKeyValue(newKey);


             or cancel
          
        
      
        

          

            
            
              nathanb
              Thu Jul 09 14:18:25 -0700 2009
              | link
              
            
          
          

            
Excellent!  I'll test it out tonight. Thanks!

          

          

            Comment

            Excellent!  I'll test it out tonight. Thanks! 

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
21.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        uteTypedList
      
      
        1 comment
        Created 5 months ago by bilf
        
          
        
      
    

    

      Title

      

      Body

      

       or cancel
    
  

  

    

      
    

    
Comments
    

      
        

          

            
            
              bilf
              Tue Jul 07 10:03:51 -0700 2009
              | link
              
            
          
          

            
mistake sorry

          

          

            Comment

            mistake sorry

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
20.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
Fixed
x
            
          
        
        Active Record generates strings for int 32 columns + mysql.
      
      
        1 comment
        Created 5 months ago by bilf
        
          
        
      
    

    

      Title

      

      Body

      Hi,

My int 32 id columns are being generated as strings, so the following doesnt compile unless I wrap my ID in quotes:

            var item = _webproject.SingleOrDefault(x => x.unique_ID == "16450000");

However, when debugging, this throws an error:
"Object of type 'System.UInt32' cannot be converted to type 'System.String'."
in  public static _webproject SingleOrDefault
single=results.ToList()[0];


Ta'

Bob




       or cancel
    
  

  

    

      
Hi,

My int 32 id columns are being generated as strings, so the following doesnt compile unless I wrap my ID in quotes:

        var item = _webproject.SingleOrDefault(x => x.unique_ID == "16450000");


However, when debugging, this throws an error:

"Object of type 'System.UInt32' cannot be converted to type 'System.String'."
in  public static _webproject SingleOrDefault

single=results.ToList()[0];

Ta'

Bob

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 07 12:40:57 -0700 2009
              | link
              
            
          
          

            
Fixed - thank you.

          

          

            Comment

            Fixed - thank you.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
19.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        SubSonic3, LINQ,  "Function evaluation timed out" when adding a watch to a linq result in VS2008
      
      
        1 comment
        Created 5 months ago by bilf
        
          
        
      
    

    

      Title

      

      Body

      HI,
I'm having a play with the SS3 linq features, but have the following error when trying to view the results from a simple query.  (Either by adding a breakpoint or a watch)

The code is:

var result = db._hotkeylayouts.Where(x => x.system_number == 4832934969383991);

The code executes fine, however when I try to view the result via Watch, I get the error  "Function evaluation timed out".

This is using mysql on vista x64

Bob



       or cancel
    
  

  

    

      
HI,

I'm having a play with the SS3 linq features, but have the following error when trying to view the results from a simple query.  (Either by adding a breakpoint or a watch)

The code is:

var result = db._hotkeylayouts.Where(x => x.system_number == 4832934969383991);

The code executes fine, however when I try to view the result via Watch, I get the error  "Function evaluation timed out".

This is using mysql on vista x64

Bob

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 07 12:22:45 -0700 2009
              | link
              
            
          
          

            
This would appear to be a VS issue yes? Not much I can do there (and I've seen it as well, seems to be spurious)

          

          

            Comment

            This would appear to be a VS issue yes? Not much I can do there (and I've seen it as well, seems to be spurious)

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
18.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        DbDataProvider.ExecuteReader doesn't allow allow access to the command object.
      
      
        6 comments
        Created 5 months ago by markkemper1
        
          
        
      
    

    

      Title

      

      Body

      

       or cancel
    
  

  

    

      
    

    
Comments
    

      
        

          

            
            
              markkemper1
              Tue Jul 07 00:55:55 -0700 2009
              | link
              
            
          
          

            
Currently when executing the ExecuteReader method there is no way to get the output parameters.

To get the output parameters first you need to read all the results and call reader.Close()

So there needs to be a way to get the actual parameters used on the command object to retrieve output values.

          

          

            Comment

            Currently when executing the ExecuteReader method there is no way to get the output parameters. 
To get the output parameters first you need to read all the results and call reader.Close()

So there needs to be a way to get the actual parameters used on the command object to retrieve output values. 



             or cancel
          
        
      
        

          

            
            
              markkemper1
              Tue Jul 07 01:10:10 -0700 2009
              | link
              
            
          
          

            
For the moment I have hacked this by..

1) adding a new method to the DbDataProvider

public DbDataReader ExecuteReader(QueryCommand qry, out DbCommand command)

2) Adding a property to the StoredProcedure class

public DbCommand DbCommand { get; private set; }

3) Modify the ExecuteReader of the storedProcedure class to

DbCommand cmd;

var result = Provider.ExecuteReader(Command, out cmd);

this.DbCommand = cmd;

return result;

So now , I can do the following and get my TotalRecords output parameter...

using (IDataReader reader = procedure.ExecuteReader())
{
    results = ExtractList<T>(reader, map, ExtractItem<T>);
     reader.Close();
}

procedure.Command.GetOutputParameters(procedure.DbCommand);


          

          

            Comment

            For the moment I have hacked this by..
1) adding a new method to the DbDataProvider
public DbDataReader ExecuteReader(QueryCommand qry, out DbCommand command)
2) Adding a property to the StoredProcedure class
public DbCommand DbCommand { get; private set; }
3) Modify the ExecuteReader of the storedProcedure class to 
DbCommand cmd;
var result = Provider.ExecuteReader(Command, out cmd);
this.DbCommand = cmd;
return result;

So now , I can do the following and get my TotalRecords output parameter...

    using (IDataReader reader = procedure.ExecuteReader())
    {
        results = ExtractList<T>(reader, map, ExtractItem<T>);
         reader.Close();
    }

    procedure.Command.GetOutputParameters(procedure.DbCommand);


             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 07 12:21:46 -0700 2009
              | link
              
            
          
          

            
Would you mind doing a Fork/Push?

          

          

            Comment

            Would you mind doing a Fork/Push? 

             or cancel
          
        
      
        

          

            
            
              markkemper1
              Tue Jul 07 19:16:47 -0700 2009
              | link
              
            
          
          

            
Hi Rob, I have tried (first time using git).

I actually modified the QueryCommand object to keep the reference to the actual dbCommand.

I also noted that there appears to be 2 places where a DbCommand is created from a QueryCommand.

There is the: AddParams(cmd,qry) inside DbDataProvider

and : ToDbCommand(trannie) inside QueryCommand.



          

          

            Comment

            Hi Rob, I have tried (first time using git). 
I actually modified the QueryCommand object to keep the reference to the actual dbCommand. 

I also noted that there appears to be 2 places where a DbCommand is created from a QueryCommand. 
There is the: AddParams(cmd,qry) inside DbDataProvider
and : ToDbCommand(trannie) inside QueryCommand. 


             or cancel
          
        
      
        

          

            
            
              gufranshaikh84
              Sun Jul 26 01:33:48 -0700 2009
              | link
              
            
          
          

            
Can you please update this in the source code, because I am not getting it to work.

Regards

Gufran Sheikh

          

          

            Comment

            Can you please update this in the source code, because I am not getting it to work.

Regards
Gufran Sheikh

             or cancel
          
        
      
        

          

            
            
              gufranshaikh84
              Mon Jul 27 12:34:17 -0700 2009
              | link
              
            
          
          

            
Is this issue really closed ? because I can't see the code mentioned above and not getting the OUTPUT parameter using ExecuteReader.

Rob, Please let me how to get OUTPUT parameter if this issue has already been fixed.

          

          

            Comment

            Is this issue really closed ? because I can't see the code mentioned above and not getting the OUTPUT parameter using ExecuteReader.

Rob, Please let me how to get OUTPUT parameter if this issue has already been fixed.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
17.
      

        
        2 votes
      
    

    

      

      

    

    

      

        
        No SQL Server Server Compact Edition templates
      
      
        3 comments
        Created 5 months ago by jswager
        
          
        
      
    

    

      Title

      

      Body

      There doesn't appear to be any templates for Windows SQL Server Compact Edition (SQL Server CE) yet.  I don't know if anyone else is working on them, but I'm working with some template code to see if I can submit something back to the project.

       or cancel
    
  

  

    

      
There doesn't appear to be any templates for Windows SQL Server Compact Edition (SQL Server CE) yet.  I don't know if anyone else is working on them, but I'm working with some template code to see if I can submit something back to the project.

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 23:20:41 -0700 2009
              | link
              
            
          
          

            
llllllllllllllllllllooooooooooooove youuuuuuuuuu



          

          

            Comment

            llllllllllllllllllllooooooooooooove youuuuuuuuuu


             or cancel
          
        
      
        

          

            
            
              jswager
              Tue Jul 07 07:24:12 -0700 2009
              | link
              
            
          
          

            
I wouldn't get too excited yet.  I'm having some problems with the sdf file location; keeps wanting to add App_Data to the path.  Tables and columns including primary keys seem to be generating, although not tested.  Foreign keys are giving me problems - the SQL to get the list of foreign key constraints uses an embedded SELECT, which SQLCE doesn't support.  So I'm going to have to some unwrapping and multiple SQL calls I suspect to get the actual foreign keys out.  Or I could just skip them for now; I'm not sure how a foreign key affects the generated code (being very much a SubSonic novice).

          

          

            Comment

            I wouldn't get too excited yet.  I'm having some problems with the sdf file location; keeps wanting to add App_Data to the path.  Tables and columns including primary keys seem to be generating, although not tested.  Foreign keys are giving me problems - the SQL to get the list of foreign key constraints uses an embedded SELECT, which SQLCE doesn't support.  So I'm going to have to some unwrapping and multiple SQL calls I suspect to get the actual foreign keys out.  Or I could just skip them for now; I'm not sure how a foreign key affects the generated code (being very much a SubSonic novice).

             or cancel
          
        
      
        

          

            
            
              robconery
              Wed Jul 08 20:07:29 -0700 2009
              | link
              
            
          
          

            
I'm going to close this as it's not an issue - do keep me updated!

          

          

            Comment

            I'm going to close this as it's not an issue - do keep me updated!

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
16.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        SimpleRepository - Lambda Parameter not in scope
      
      
        1 comment
        Created 5 months ago by adiomarin
        
          
        
      
    

    

      Title

      

      Body

      var posts = _repo.Find<Post>(p => p.IsVisible) // throws
var posts = _repo.Find<Post>(p => p.IsVisible == true) // works



       or cancel
    
  

  

    

      
var posts = repo.Find(p => p.IsVisible) // throws

var posts = repo.Find(p => p.IsVisible == true) // works

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 19:20:40 -0700 2009
              | link
              
            
          
          

            
That's the proper usage, correct

          

          

            Comment

            That's the proper usage, correct

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
15.
      

        
        -1 votes
      
    

    

      

      

    

    

      

        
          

            

              
Fixed
x
            
          
        
        SQLite Migrations - Pk Autoincrement is never applied
      
      
        1 comment
        Created 5 months ago by adiomarin
        
          
        
      
    

    

      Title

      

      Body

      Column sql is always generated OK like: [ID] integer NOT NULL PRIMARY KEY AUTOINCREMENT.

Column get's created but without AUTOINCREMENT. Think that square bracktes should be replaced with quotes.

       or cancel
    
  

  

    

      
Column sql is always generated OK like: [ID] integer NOT NULL PRIMARY KEY AUTOINCREMENT.

Column get's created but without AUTOINCREMENT. Think that square bracktes should be replaced with quotes.

    

    
Comments
    

      
        

          

            
            
              robconery
              Tue Jul 07 12:13:57 -0700 2009
              | link
              
            
          
          

            
Thanks - this is fixed

          

          

            Comment

            Thanks - this is fixed

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
14.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Minor improvement to Settings.ttinclude
      
      
        1 comment
        Created 5 months ago by mbp
        
          
        
      
    

    

      Title

      

      Body

      I made a pull request for a simple change to this .ttinclude to avoid string duplication.

       or cancel
    
  

  

    

      
I made a pull request for a simple change to this .ttinclude to avoid string duplication.

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 17:06:30 -0700 2009
              | link
              
            
          
          

            
got it!

          

          

            Comment

            got it!

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
13.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        IsNew is not working correctly in ActiveRecord Templates
      
      
        1 comment
        Created 5 months ago by jcoenen
        
          
        
      
    

    

      Title

      

      Body

      IsNew() is still true after a Save or a load from the database.  Causing subsequent calls to Save() to add new records instead of updating the existing record.

Below is a unit test to recreate the issue

Index: ActiveRecord.cs
===================================================================
--- ActiveRecord.cs	(revision 527)
+++ ActiveRecord.cs	(working copy)
@@ -18,5 +18,13 @@
             Assert.NotNull(table);
         }
 
+        [Fact]
+        public void IsNew_Should_Be_False_After_Save()
+        {
+          var category = new Southwind.Category();
+          category.CategoryName = "Test";          
+          category.Save();
+          Assert.False(category.IsNew());                   
+        }
+
+        [Fact]
+        public void IsNew_Should_Be_False_Load_From_DB()
+        {
+          var category = new Southwind.Category.SingleOrDefault(c => c.CategoryID== "1");
+          Assert.False(category.IsNew());                   
+        }
     }
 }



       or cancel
    
  

  

    

      
IsNew() is still true after a Save or a load from the database.  Causing subsequent calls to Save() to add new records instead of updating the existing record.

Below is a unit test to recreate the issue

Index: ActiveRecord.cs  

--- ActiveRecord.cs (revision 527)
+++ ActiveRecord.cs (working copy)
@@ -18,5 +18,13 @@

         Assert.NotNull(table);
     }



 [Fact]

 public void IsNew_Should_Be_False_After_Save()

 {

   var category = new Southwind.Category();

   category.CategoryName = "Test";          

   category.Save();

   Assert.False(category.IsNew());                   

 }


+
 [Fact]

 public void IsNew_Should_Be_False_Load_From_DB()

 {

   var category = new Southwind.Category.SingleOrDefault(c => c.CategoryID== "1");

   Assert.False(category.IsNew());                   

 }


 }
}



    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 12:24:12 -0700 2009
              | link
              
            
          
          

            
Thank you - added and fixed.

          

          

            Comment

            Thank you - added and fixed.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
12.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        View error in the SimpleRepo example
      
      
        1 comment
        Created 5 months ago by troethom
        
          
        
      
    

    

      Title

      

      Body

      The view `Home/Create.aspx` is causing a runtime error, as `Blog.Category.All()` isn't available.

I have sent a pull request for a solution to this issue.

       or cancel
    
  

  

    

      
The view Home/Create.aspx is causing a runtime error, as Blog.Category.All() isn't available.

I have sent a pull request for a solution to this issue.

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 12:13:07 -0700 2009
              | link
              
            
          
          

            
Thanks again!

          

          

            Comment

            Thanks again!

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
11.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        `SimpleRepository.All<T>()` doesn't run migrations
      
      
        1 comment
        Created 5 months ago by troethom
        
          
        
      
    

    

      Title

      

      Body

      When making a call to `SimpleRepository.All<T>()` it doesn't run automatic migration. I would expect this behaviour, because it is counterintuitive to require to add data before being able to perform a list operation.

Another solution would be to make `SimpleRepository.Migrate<T>()` public, which again would seem a bit off, as it makes the simple repository more complex.

I have sent a pull request for a solution to this issue.

       or cancel
    
  

  

    

      
When making a call to SimpleRepository.All<T>() it doesn't run automatic migration. I would expect this behaviour, because it is counterintuitive to require to add data before being able to perform a list operation.

Another solution would be to make SimpleRepository.Migrate<T>() public, which again would seem a bit off, as it makes the simple repository more complex.

I have sent a pull request for a solution to this issue.

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 12:12:50 -0700 2009
              | link
              
            
          
          

            
Thanks Troels - will pull today.

          

          

            Comment

            Thanks Troels - will pull today.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
10.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        fk, OtherColumn and ThisColumn Property
      
      
        1 comment
        Created 5 months ago by kYann
        
          
        
      
    

    

      Title

      

      Body

      Hi,

OtherColumn and ThisColumn are set to the raw version of the column name. They should use a CleanUp version of the column name.

ActiveRecord.tt, line 313 :
where items.<#=fk.OtherColumn#> == _<#=fk.ThisColumn#>

Can generate bad code if the column had a space in his name.

       or cancel
    
  

  

    

      
Hi,

OtherColumn and ThisColumn are set to the raw version of the column name. They should use a CleanUp version of the column name.

ActiveRecord.tt, line 313 :

where items.<#=fk.OtherColumn#> == _<#=fk.ThisColumn#>

Can generate bad code if the column had a space in his name.

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 12:11:49 -0700 2009
              | link
              
            
          
          

            
Thanks... added...

          

          

            Comment

            Thanks... added...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
9.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        Stored Procedures inside Express Database
      
      
        1 comment
        Created 5 months ago by markkemper1
        
          
        
      
    

    

      Title

      

      Body

      SQLServer.ttinclude: Line 62 : GetSPParams(string spName) : 
always returns an empty list if you use SQL Express. 
The database name seems to be really really long like "249823749822\downloads\blah\BLOG.MDF" however the actual variable just has "blog" .. Setting it to null i.e  string[] restrictions = new string[4] { null, null, spName, null }; resolves the issue. However this seems to be a fundamental issue with express..

       or cancel
    
  

  

    

      
SQLServer.ttinclude: Line 62 : GetSPParams(string spName) :

always returns an empty list if you use SQL Express.

The database name seems to be really really long like "249823749822\downloads\blah\BLOG.MDF" however the actual variable just has "blog" .. Setting it to null i.e  string[] restrictions = new string[4] { null, null, spName, null }; resolves the issue. However this seems to be a fundamental issue with express..

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 00:33:48 -0700 2009
              | link
              
            
          
          

            
Closing.

          

          

            Comment

            Closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
8.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        MySQL connection error setting up the project
      
      
        4 comments
        Created 5 months ago by vhakti
        
          
        
      
    

    

      Title

      

      Body

      I got this Error when i am trying to configure the project:
Error	3	.. System.ArgumentException: Keyword not admitted: 'userid'.
   in System.Data.Common.DbConnectionOptions.ParseInternal.....etc

the connection string is:
server=localhost; userid=root;password=sa;pooling=yes;Database=NorthwindMySql

i got another error when i use trusted connection and set persist security =true;

thanks

       or cancel
    
  

  

    

      
I got this Error when i am trying to configure the project:

Error   3   .. System.ArgumentException: Keyword not admitted: 'userid'.

   in System.Data.Common.DbConnectionOptions.ParseInternal.....etc

the connection string is:

server=localhost; userid=root;password=sa;pooling=yes;Database=NorthwindMySql

i got another error when i use trusted connection and set persist security =true;

thanks

    

    
Comments
    

      
        

          

            
            
              robconery
              Mon Jul 06 00:32:10 -0700 2009
              | link
              
            
          
          

            
It's "user id"

          

          

            Comment

            It's "user id"

             or cancel
          
        
      
        

          

            
            
              robconery
              Mon Jul 06 00:32:49 -0700 2009
              | link
              
            
          
          

            
Not sure why you'd use trusted connection - this MySQL right?

          

          

            Comment

            Not sure why you'd use trusted connection - this MySQL right?

             or cancel
          
        
      
        

          

            
            
              vhakti
              Mon Jul 06 20:39:59 -0700 2009
              | link
              
            
          
          

            
Ok, userid works fine using mysqlconnector simply but anyway i changed the keyword to user id and right! the error vanished... but now :( some issue...i see that inside the folder called ActiveRecord there are a file SQLServer.ttinclude but i am using MySql  so how can i get it works? i've tried to do it but cant get it works..sorry!

          

          

            Comment

            Ok, userid works fine using mysqlconnector simply but anyway i changed the keyword to user id and right! the error vanished... but now :( some issue...i see that inside the folder called ActiveRecord there are a file SQLServer.ttinclude but i am using MySql  so how can i get it works? i've tried to do it but cant get it works..sorry!

             or cancel
          
        
      
        

          

            
            
              robconery
              Tue Jul 07 12:42:26 -0700 2009
              | link
              
            
          
          

            
There is a "Using Templates" document in there that you might want to read :). You replace SQLServer.ttinclude with MySQL.ttinclude that's in the Template Providers folder.

          

          

            Comment

            There is a "Using Templates" document in there that you might want to read :). You replace SQLServer.ttinclude with MySQL.ttinclude that's in the Template Providers folder. 

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
7.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
        MySQL.ttinclude
      
      
        2 comments
        Created 5 months ago by vhakti
        
          
        
      
    

    

      Title

      

      Body

      I've tried to change to this new release, i am using mysql 5.0 and i did all it says in docs to setting up my project but...Not lucky! :( ...the project doesnt compile because an error with MySQL.ttinclude ..
the project wont generate it dicatates....


help or something 

thanks

       or cancel
    
  

  

    

      
I've tried to change to this new release, i am using mysql 5.0 and i did all it says in docs to setting up my project but...Not lucky! :( ...the project doesnt compile because an error with MySQL.ttinclude ..

the project wont generate it dicatates....

help or something

thanks

    

    
Comments
    

      
        

          

            
            
              robconery
              Sun Jul 05 18:29:47 -0700 2009
              | link
              
            
          
          

            
I need to repro the problem; I can't do a thing with what you've told me.

          

          

            Comment

            I need to repro the problem; I can't do a thing with what you've told me.

             or cancel
          
        
      
        

          

            
            
              robconery
              Mon Jul 06 12:24:25 -0700 2009
              | link
              
            
          
          

            
closing.

          

          

            Comment

            closing.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
6.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        ChangeTypeTo<T>() extension method returns object
      
      
        4 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      It would be nice to have this cast to and return T since it's specified in the method signature. 

       or cancel
    
  

  

    

      
It would be nice to have this cast to and return T since it's specified in the method signature.

    

    
Comments
    

      
        

          

            
            
              robconery
              Sun Jul 05 13:05:36 -0700 2009
              | link
              
            
          
          

            
Need more - don't know what you mean.

          

          

            Comment

            Need more - don't know what you mean.

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 13:09:11 -0700 2009
              | link
              
            
          
          

            
I would like to change this:

private static T Get<T>(string key) {
    return (T)ConfigurationManager.AppSettings[key].ChangeTypeTo<T>();
}


To this by moving the (T) cast into ChangeTypeTo():

private static T Get<T>(string key) {
    return ConfigurationManager.AppSettings[key].ChangeTypeTo<T>();
}


          

          

            Comment

            I would like to change this:

    private static T Get<T>(string key) {
        return (T)ConfigurationManager.AppSettings[key].ChangeTypeTo<T>();
    }

To this by moving the (T) cast into ChangeTypeTo<T>():

    private static T Get<T>(string key) {
        return ConfigurationManager.AppSettings[key].ChangeTypeTo<T>();
    }

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 13:10:55 -0700 2009
              | link
              
            
          
          

            
Nevermind, I thought the old Utility.ChangeType() did this, but it doesn't. So no big deal.

          

          

            Comment

            Nevermind, I thought the old Utility.ChangeType() did this, but it doesn't. So no big deal.

             or cancel
          
        
      
        

          

            
            
              robconery
              Sun Jul 05 15:35:23 -0700 2009
              | link
              
            
          
          

            
Closing...

          

          

            Comment

            Closing...

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
5.
      

        
        -1 votes
      
    

    

      

      

    

    

      

        
          

            

              
Accepted
x
            
          
        
        Generated stored procedure methods do not take nullable objects
      
      
        2 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      This is a simple change in Settings.ttinclude to include the ? after the parameter type, but I thought it should be included in the default template.

       or cancel
    
  

  

    

      
This is a simple change in Settings.ttinclude to include the ? after the parameter type, but I thought it should be included in the default template.

    

    
Comments
    

      
        

          

            
            
              robconery
              Sun Jul 05 13:05:05 -0700 2009
              | link
              
            
          
          

            
Eek - thanks

          

          

            Comment

            Eek - thanks

             or cancel
          
        
      
        

          

            
            
              robconery
              Mon Jul 06 12:36:00 -0700 2009
              | link
              
            
          
          

            
There's no way to tell if a param is nullable using our schema fetchers so I'll default it to nullable, which seems weird, but I think it's ok.

          

          

            Comment

            There's no way to tell if a param is nullable using our schema fetchers so I'll default it to nullable, which seems weird, but I think it's ok.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
4.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        .Add() doesn't set primary key property to returned value from insert
      
      
        9 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      This may be by design but it's different than 2.x. Inserting does not update the PK column with the new ID generated. I know .Add() returns the new value but it would nice to not have to manually assign it.

       or cancel
    
  

  

    

      
This may be by design but it's different than 2.x. Inserting does not update the PK column with the new ID generated. I know .Add() returns the new value but it would nice to not have to manually assign it.

    

    
Comments
    

      
        

          

            
            
              robconery
              Sun Jul 05 13:04:45 -0700 2009
              | link
              
            
          
          

            
Can you be more specific? The SimpleRepo does just this - what scenario are you talking about?

          

          

            Comment

            Can you be more specific? The SimpleRepo does just this - what scenario are you talking about?

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 13:06:38 -0700 2009
              | link
              
            
          
          

            
var db = new DatabaseNameDB();
var repo = new SubSonicRepository<Tag>(db);

Tag tag = new Tag();
tag.Label = "SubSonic";
tag.UserId = 1;

var result = repo.Add(tag);
// result = new ID
// tag.TagId = 0


          

          

            Comment

                var db = new DatabaseNameDB();
    var repo = new SubSonicRepository<Tag>(db);

    Tag tag = new Tag();
    tag.Label = "SubSonic";
    tag.UserId = 1;

    var result = repo.Add(tag);
    // result = new ID
    // tag.TagId = 0

             or cancel
          
        
      
        

          

            
            
              robconery
              Sun Jul 05 15:35:59 -0700 2009
              | link
              
            
          
          

            
Are you using the the Linq Templates?

          

          

            Comment

            Are you using the the Linq Templates?

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 15:37:33 -0700 2009
              | link
              
            
          
          

            
Yes

          

          

            Comment

            Yes

             or cancel
          
        
      
        

          

            
            
              robconery
              Sun Jul 05 15:46:43 -0700 2009
              | link
              
            
          
          

            
Aha! OK thanks I get it :). I'll try to deal with this in the coming few days but if you get a chance to fork/push - that would rock. I'll put you on commit (been meaning to).

          

          

            Comment

            Aha! OK thanks I get it :). I'll try to deal with this in the coming few days but if you get a chance to fork/push - that would rock. I'll put you on commit (been meaning to).

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 20:28:13 -0700 2009
              | link
              
            
          
          

            
I added a patch for this. Didn't find a unit test for SubSonicRepository so it is currently untested.

          

          

            Comment

            I added a patch for this. Didn't find a unit test for SubSonicRepository so it is currently untested.

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 20:28:34 -0700 2009
              | link
              
            
          
          

            
I did test it working with a SQL 2008 DB though.

          

          

            Comment

            I did test it working with a SQL 2008 DB though.

             or cancel
          
        
      
        

          

            
            
              nathanb
              Tue Jul 07 19:36:55 -0700 2009
              | link
              
            
          
          

            
Is this also related to varchar PK?  I'm getting the same thing in ActiveRecord templates. But my manually set PK isn't returned after save because it uses SCOPE_IDENTITY. Repo.Add() returns null and resets my entity id.



          

          

            Comment

            Is this also related to varchar PK?  I'm getting the same thing in ActiveRecord templates. But my manually set PK isn't returned after save because it uses SCOPE_IDENTITY. Repo.Add() returns null and resets my entity id. 


             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Wed Jul 08 09:05:23 -0700 2009
              | link
              
            
          
          

            
This issue isn't related to that. I would create a new one (if you haven't already) and make sure to specify the problem is with ActiveRecord. There just needs to be a check put in place to make sure the PK column is a SCOPE_IDENTITY compatible type before being set.

          

          

            Comment

            This issue isn't related to that. I would create a new one (if you haven't already) and make sure to specify the problem is with ActiveRecord. There just needs to be a check put in place to make sure the PK column is a SCOPE_IDENTITY compatible type before being set.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
3.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
Linq Parser
x
            
          
        
        != null doesn't generate correct SQL
      
      
        2 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      See: http://screencast.com/t/27v18Os0

       or cancel
    
  

  

    

      
See: http://screencast.com/t/27v18Os0

    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 04 00:03:36 -0700 2009
              | link
              
            
          
          

            
Thanks

          

          

            Comment

            Thanks

             or cancel
          
        
      
        

          

            
            
              robconery
              Sat Jul 04 00:20:17 -0700 2009
              | link
              
            
          
          

            
Found the bug and fixed - thank you!@

          

          

            Comment

            Found the bug and fixed - thank you!@

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
2.
      

        
        0 votes
      
    

    

      

      

    

    

      

        
          

            

              
T4 Templates
x
            
          
        
        3.0 Download has out-of-date Classes.tt file
      
      
        3 comments
        Created 5 months ago by johnsheehan
        
          
        
      
    

    

      Title

      

      Body

      It's missing the changes checked in in r529 on Google code (it still calls .GetRepo which doesn't exist)

       or cancel
    
  

  

    

      
It's missing the changes checked in in r529 on Google code (it still calls .GetRepo which doesn't exist)

    

    
Comments
    

      
        

          

            
            
              robconery
              Sat Jul 04 00:00:55 -0700 2009
              | link
              
            
          
          

            
Thanks!

          

          

            Comment

            Thanks!

             or cancel
          
        
      
        

          

            
            
              robconery
              Sat Jul 04 00:02:07 -0700 2009
              | link
              
            
          
          

            
I can't find this - can you tell me where?

          

          

            Comment

            I can't find this - can you tell me where?

             or cancel
          
        
      
        

          

            
            
              johnsheehan
              Sun Jul 05 05:31:23 -0700 2009
              | link
              
            
          
          

            
Very strange. I just redownloaded it and the templates are up to date. The original download file I have called SubSonic_3_Final.zip has outdated templates.

          

          

            Comment

            Very strange. I just redownloaded it and the templates are up to date. The original download file I have called SubSonic_3_Final.zip has outdated templates.

             or cancel
          
        
      

      

        
        
        

          

            
            
            
          
          

            Parsed with GitHub Flavored Markdown
          
        
      
    
  

  

    

      
      
1.
      

        
        1 vote
      
    

    

      

      

    

    

      

        
        Test issue
      
      
        3 comments
        Created 5 months ago by robconery
        
          
        
      
    

    

      Title

      

      Body

      Just want to see how this issue tracker stacks up

       or cancel
    
  

  

    

      
Just want to see how this issue tracker stacks up

    

    
Comments
    

      
        

          

            
            
              robconery
              Thu Jul 02 23:49:04 -0700 2009
              | link
              
            
          
          

            
Hmmm - so far it seems pretty simplistic

          

          

            Comment

            Hmmm - so far it seems pretty simplistic

             or cancel
          
        
      
        

          

            
            
              robconery
              Thu Jul 02 23:49:28 -0700 2009
              | link
              
            
          
          

            
  
Hi