{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":279488921,"defaultBranch":"master","name":"auth","ownerLogin":"supabase","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-07-14T05:14:31.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/54469796?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716376251.0","currentOid":""},"activityList":{"items":[{"before":"7d2b27bd30c2bfcd3e326f7170953b2b4a7a2a06","after":"920be6f3809fd9525e03858222cbeeca6073686e","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-23T18:53:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: remove TODO","shortMessageHtmlLink":"fix: remove TODO"}},{"before":"b1d213ebbb0da155aca3fb32af784fbbb0bd0ada","after":"7d2b27bd30c2bfcd3e326f7170953b2b4a7a2a06","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-23T18:44:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: remove semconv http user agent keys","shortMessageHtmlLink":"fix: remove semconv http user agent keys"}},{"before":"60df2a42e3e68401b375c0a7d0b0bd54afbdb148","after":"b1d213ebbb0da155aca3fb32af784fbbb0bd0ada","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-23T17:09:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: remove comments","shortMessageHtmlLink":"fix: remove comments"}},{"before":"e38ac79f7fb6ad33b39078dd37e458a13d330528","after":"60df2a42e3e68401b375c0a7d0b0bd54afbdb148","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-23T17:00:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: reinstate metrics","shortMessageHtmlLink":"fix: reinstate metrics"}},{"before":"f265e59afb658533ee0a9e34a9c3de0e6afb7b4e","after":"e38ac79f7fb6ad33b39078dd37e458a13d330528","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-22T12:27:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: remove user-agent checks","shortMessageHtmlLink":"fix: remove user-agent checks"}},{"before":null,"after":"b954a485096cddfd1eef4d582034a99eff95fa6f","ref":"refs/heads/release/2.152.0","pushedAt":"2024-05-22T11:10:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"chore(master): release 2.152.0 (#1574)\n\n:robot: I have created a release *beep* *boop*\r\n---\r\n\r\n\r\n##\r\n[2.152.0](https://github.com/supabase/auth/compare/v2.151.0...v2.152.0)\r\n(2024-05-22)\r\n\r\n\r\n### Features\r\n\r\n* new timeout writer implementation\r\n([#1584](https://github.com/supabase/auth/issues/1584))\r\n([72614a1](https://github.com/supabase/auth/commit/72614a1fce27888f294772b512f8e31c55a36d87))\r\n* remove legacy lookup in users for one_time_tokens (phase II)\r\n([#1569](https://github.com/supabase/auth/issues/1569))\r\n([39ca026](https://github.com/supabase/auth/commit/39ca026035f6c61d206d31772c661b326c2a424c))\r\n* update chi version\r\n([#1581](https://github.com/supabase/auth/issues/1581))\r\n([c64ae3d](https://github.com/supabase/auth/commit/c64ae3dd775e8fb3022239252c31b4ee73893237))\r\n* update openapi spec with identity and is_anonymous fields\r\n([#1573](https://github.com/supabase/auth/issues/1573))\r\n([86a79df](https://github.com/supabase/auth/commit/86a79df9ecfcf09fda0b8e07afbc41154fbb7d9d))\r\n\r\n\r\n### Bug Fixes\r\n\r\n* improve logging structure\r\n([#1583](https://github.com/supabase/auth/issues/1583))\r\n([c22fc15](https://github.com/supabase/auth/commit/c22fc15d2a8383e95a2364f383dfa7dce5f5df88))\r\n* sms verify should update is_anonymous field\r\n([#1580](https://github.com/supabase/auth/issues/1580))\r\n([e5f98cb](https://github.com/supabase/auth/commit/e5f98cb9e24ecebb0b7dc88c495fd456cc73fcba))\r\n* use api_external_url domain as localname\r\n([#1575](https://github.com/supabase/auth/issues/1575))\r\n([ed2b490](https://github.com/supabase/auth/commit/ed2b4907244281e4c54aaef74b1f4c8a8e3d97c9))\r\n\r\n---\r\nThis PR was generated with [Release\r\nPlease](https://github.com/googleapis/release-please). See\r\n[documentation](https://github.com/googleapis/release-please#release-please).\r\n\r\nCo-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(master): release 2.152.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2284634668\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1574\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1574/hovercard\" href=\"https://github.com/supabase/auth/pull/1574\">#1574</a>)"}},{"before":"fdde5a7433239481bf919aae81dbb1ad5ed7ba1d","after":null,"ref":"refs/heads/release-please--branches--master","pushedAt":"2024-05-22T11:07:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"}},{"before":"72614a1fce27888f294772b512f8e31c55a36d87","after":"b954a485096cddfd1eef4d582034a99eff95fa6f","ref":"refs/heads/master","pushedAt":"2024-05-22T11:07:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"chore(master): release 2.152.0 (#1574)\n\n:robot: I have created a release *beep* *boop*\r\n---\r\n\r\n\r\n##\r\n[2.152.0](https://github.com/supabase/auth/compare/v2.151.0...v2.152.0)\r\n(2024-05-22)\r\n\r\n\r\n### Features\r\n\r\n* new timeout writer implementation\r\n([#1584](https://github.com/supabase/auth/issues/1584))\r\n([72614a1](https://github.com/supabase/auth/commit/72614a1fce27888f294772b512f8e31c55a36d87))\r\n* remove legacy lookup in users for one_time_tokens (phase II)\r\n([#1569](https://github.com/supabase/auth/issues/1569))\r\n([39ca026](https://github.com/supabase/auth/commit/39ca026035f6c61d206d31772c661b326c2a424c))\r\n* update chi version\r\n([#1581](https://github.com/supabase/auth/issues/1581))\r\n([c64ae3d](https://github.com/supabase/auth/commit/c64ae3dd775e8fb3022239252c31b4ee73893237))\r\n* update openapi spec with identity and is_anonymous fields\r\n([#1573](https://github.com/supabase/auth/issues/1573))\r\n([86a79df](https://github.com/supabase/auth/commit/86a79df9ecfcf09fda0b8e07afbc41154fbb7d9d))\r\n\r\n\r\n### Bug Fixes\r\n\r\n* improve logging structure\r\n([#1583](https://github.com/supabase/auth/issues/1583))\r\n([c22fc15](https://github.com/supabase/auth/commit/c22fc15d2a8383e95a2364f383dfa7dce5f5df88))\r\n* sms verify should update is_anonymous field\r\n([#1580](https://github.com/supabase/auth/issues/1580))\r\n([e5f98cb](https://github.com/supabase/auth/commit/e5f98cb9e24ecebb0b7dc88c495fd456cc73fcba))\r\n* use api_external_url domain as localname\r\n([#1575](https://github.com/supabase/auth/issues/1575))\r\n([ed2b490](https://github.com/supabase/auth/commit/ed2b4907244281e4c54aaef74b1f4c8a8e3d97c9))\r\n\r\n---\r\nThis PR was generated with [Release\r\nPlease](https://github.com/googleapis/release-please). See\r\n[documentation](https://github.com/googleapis/release-please#release-please).\r\n\r\nCo-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(master): release 2.152.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2284634668\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1574\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1574/hovercard\" href=\"https://github.com/supabase/auth/pull/1574\">#1574</a>)"}},{"before":"b32dbd80333b4155ad6b56e37221e6ee430a3c05","after":"fdde5a7433239481bf919aae81dbb1ad5ed7ba1d","ref":"refs/heads/release-please--branches--master","pushedAt":"2024-05-22T09:06:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"chore(master): release 2.152.0","shortMessageHtmlLink":"chore(master): release 2.152.0"}},{"before":"5fb7163afb7dee0edc41254713fa77dc9831714e","after":null,"ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-22T09:05:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hf","name":"Stojan Dimitrovski","path":"/hf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/295870?s=80&v=4"}},{"before":"39ca026035f6c61d206d31772c661b326c2a424c","after":"72614a1fce27888f294772b512f8e31c55a36d87","ref":"refs/heads/master","pushedAt":"2024-05-22T09:05:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hf","name":"Stojan Dimitrovski","path":"/hf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/295870?s=80&v=4"},"commit":{"message":"feat: new timeout writer implementation (#1584)\n\n#1529 introduced timeout middleware, but it appears from working in the\r\nwild it has some race conditions that are not particularly helpful.\r\n\r\nThis PR rewrites the implementation to get rid of race conditions, at\r\nthe expense of slightly higher RAM usage. It follows the implementation\r\nof `http.TimeoutHandler` closely.\r\n\r\n---------\r\n\r\nCo-authored-by: Kang Ming <kang.ming1996@gmail.com>","shortMessageHtmlLink":"feat: new timeout writer implementation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2302578096\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1584\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1584/hovercard\" href=\"https://github.com/supabase/auth/pull/1584\">#1584</a>)"}},{"before":"b82ab8cc9fe165b757a5b2204e3e1dcdb839cb54","after":"f265e59afb658533ee0a9e34a9c3de0e6afb7b4e","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-21T15:16:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: format","shortMessageHtmlLink":"fix: format"}},{"before":null,"after":"b82ab8cc9fe165b757a5b2204e3e1dcdb839cb54","ref":"refs/heads/j0/upgrade_otel_deps","pushedAt":"2024-05-21T15:00:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"feat: upgrade otel","shortMessageHtmlLink":"feat: upgrade otel"}},{"before":null,"after":"00d38f96fd729805d01dfd76d44befab2b250426","ref":"refs/heads/j0/remove_unused_ctx","pushedAt":"2024-05-21T12:36:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"J0","name":"Joel Lee","path":"/J0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8011761?s=80&v=4"},"commit":{"message":"fix: remove unused code","shortMessageHtmlLink":"fix: remove unused code"}},{"before":"d45058fff32dacbe633fa25a49c60cb766eb895d","after":"5fb7163afb7dee0edc41254713fa77dc9831714e","ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-20T15:54:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"fix: save snapshot of header map when WriteHeader is called","shortMessageHtmlLink":"fix: save snapshot of header map when WriteHeader is called"}},{"before":"0f6cf8febf029b17ad45ffa9b8d1c63b7a858959","after":"d45058fff32dacbe633fa25a49c60cb766eb895d","ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-20T15:29:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"chore: timeoutMiddleware doesn't need to be a method","shortMessageHtmlLink":"chore: timeoutMiddleware doesn't need to be a method"}},{"before":"d4f8ca586a3f04d3f7f444c74f68e708628c5cbe","after":"0f6cf8febf029b17ad45ffa9b8d1c63b7a858959","ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-20T15:25:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"fix: call http redirect once in email change verify","shortMessageHtmlLink":"fix: call http redirect once in email change verify"}},{"before":"d734f150bcc565b48fde282e01b182ad8bc58bfc","after":"d4f8ca586a3f04d3f7f444c74f68e708628c5cbe","ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-17T14:38:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hf","name":"Stojan Dimitrovski","path":"/hf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/295870?s=80&v=4"},"commit":{"message":"feat: new timeout writer implementation","shortMessageHtmlLink":"feat: new timeout writer implementation"}},{"before":null,"after":"d734f150bcc565b48fde282e01b182ad8bc58bfc","ref":"refs/heads/hf/fix-timeout-writer","pushedAt":"2024-05-17T12:08:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hf","name":"Stojan Dimitrovski","path":"/hf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/295870?s=80&v=4"},"commit":{"message":"feat: new timeout writer implementation","shortMessageHtmlLink":"feat: new timeout writer implementation"}},{"before":null,"after":"17d5dab5ee98ae8e24dd0b4f91d3ebd7f51a4057","ref":"refs/heads/km/fix-content-length-exceeded-errors","pushedAt":"2024-05-17T09:37:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"fix: handle timeout after ServeHttp has completed","shortMessageHtmlLink":"fix: handle timeout after ServeHttp has completed"}},{"before":"c301dbd6ef43d0f3638613083aff61257858b26d","after":"b32dbd80333b4155ad6b56e37221e6ee430a3c05","ref":"refs/heads/release-please--branches--master","pushedAt":"2024-05-17T07:24:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"chore(master): release 2.152.0","shortMessageHtmlLink":"chore(master): release 2.152.0"}},{"before":"08de25465e1e8683b056fdcfda01a7a9b15ea8bc","after":null,"ref":"refs/heads/hf/phase-ii-ott","pushedAt":"2024-05-17T07:24:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"}},{"before":"c64ae3dd775e8fb3022239252c31b4ee73893237","after":"39ca026035f6c61d206d31772c661b326c2a424c","ref":"refs/heads/master","pushedAt":"2024-05-17T07:24:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"feat: remove legacy lookup in users for one_time_tokens (phase II) (#1569)\n\nRemoves legacy lookups in `auth.users` for when a corresponding entry in\r\n`one_time_tokens` is not found.\r\n\r\nPhase II of the refactor, based on #1558, to be released after it's\r\ndeployed for a few days.\r\n\r\n---------\r\n\r\nCo-authored-by: Kang Ming <kang.ming1996@gmail.com>","shortMessageHtmlLink":"feat: remove legacy lookup in users for one_time_tokens (phase II) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2277892129\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1569\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1569/hovercard\" href=\"https://github.com/supabase/auth/pull/1569\">#…</a>"}},{"before":"aeec777b87677be5d54fa3db3dc32e5f807b9b70","after":null,"ref":"refs/heads/km/update-chi-version","pushedAt":"2024-05-17T07:23:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"}},{"before":"c22fc15d2a8383e95a2364f383dfa7dce5f5df88","after":"c64ae3dd775e8fb3022239252c31b4ee73893237","ref":"refs/heads/master","pushedAt":"2024-05-17T07:23:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"feat: update chi version (#1581)\n\n## What kind of change does this PR introduce?\r\n* Upgrades [chi](https://github.com/go-chi/chi) from v4 to v5","shortMessageHtmlLink":"feat: update chi version (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2293489933\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1581\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1581/hovercard\" href=\"https://github.com/supabase/auth/pull/1581\">#1581</a>)"}},{"before":"d7c009340da29ca9d9af055838b425a13972feca","after":"aeec777b87677be5d54fa3db3dc32e5f807b9b70","ref":"refs/heads/km/update-chi-version","pushedAt":"2024-05-16T16:38:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"Merge branch 'master' into km/update-chi-version","shortMessageHtmlLink":"Merge branch 'master' into km/update-chi-version"}},{"before":"55393c48754c64262fbd26a54c54a18760128ca7","after":"08de25465e1e8683b056fdcfda01a7a9b15ea8bc","ref":"refs/heads/hf/phase-ii-ott","pushedAt":"2024-05-16T16:34:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"chore: remove test variants from verify test","shortMessageHtmlLink":"chore: remove test variants from verify test"}},{"before":"f08c905be4104f2e1656b173c0704e5e1c4fe3b2","after":"c301dbd6ef43d0f3638613083aff61257858b26d","ref":"refs/heads/release-please--branches--master","pushedAt":"2024-05-16T13:08:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"chore(master): release 2.152.0","shortMessageHtmlLink":"chore(master): release 2.152.0"}},{"before":"f26ab6e471fa03da2fa5d1614fd8ee53c789bdbf","after":null,"ref":"refs/heads/km/fix-logging","pushedAt":"2024-05-16T13:08:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"}},{"before":"e5f98cb9e24ecebb0b7dc88c495fd456cc73fcba","after":"c22fc15d2a8383e95a2364f383dfa7dce5f5df88","ref":"refs/heads/master","pushedAt":"2024-05-16T13:08:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kangmingtay","name":"Kang Ming","path":"/kangmingtay","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28647601?s=80&v=4"},"commit":{"message":"fix: improve logging structure (#1583)\n\n## What kind of change does this PR introduce?\r\n* Remove unformatted logs which do not confirm to JSON\r\n* Previously, we were logging both `time` (not UTC) and `timestamp` (in\r\nUTC) which is redundant. I've opted to remove `timestamp` and just log\r\nthe UTC time as the `time` field, which is supported by logrus\r\n* Previously, the `request_id` was not being logged because it was\r\nunable to retrieve the context properly. Now, the `request_id` field is\r\nadded to every log entry, which allows us to filter by `request_id` to\r\nsee the entire lifecycle of the request\r\n* Previously, panics weren't being handled properly and they were just\r\nlogged as text instead of JSON. The server would return an empty reply,\r\nwhich leads to ugly responses like \"Unexpected token < in JSON...\" if\r\nusing fetch in JS. Now, the server returns a proper 500 error response:\r\n`{\"code\":500,\"error_code\":\"unexpected_failure\",\"msg\":\"Internal Server\r\nError\"}`\r\n* Added tests for `recoverer` and `NewStructuredLogger` to prevent\r\nregression\r\n* Remove \"request started\" log since the `request_id` can be used to\r\nkeep track of the entire request lifecycle. This cuts down on the noise\r\nto signal ratio as well.\r\n\r\n\r\n## Log format\r\n* Panics are now logged like this (note the additional fields like\r\n`panic` and `stack` - which is a dump of the stack trace):\r\n```json\r\n{\r\n  \"component\":\"api\",\r\n  \"duration\":6065700500,\r\n  \"level\":\"info\",\r\n  \"method\":\"GET\",\r\n  \"msg\":\"request completed\",\r\n  \"panic\":\"test panic\",\r\n  \"path\":\"/panic\",\r\n  \"referer\":\"http://localhost:3001\",\r\n  \"remote_addr\":\"127.0.0.1\",\r\n  \"request_id\":\"4cde5f20-2c3c-4645-bc75-52d6231e22e2\",\r\n  \"stack\":\"goroutine 82 [running]:...rest of stack trace omitted for brevity\",\r\n  \"status\":500,\r\n  \"time\":\"2024-05-15T09:37:42Z\"\r\n}\r\n```\r\n\r\n* Requests that call `NewAuditLogEntry` will be logged with the\r\n`auth_event` payload in this format (note that the timestamp field no\r\nlonger exists)\r\n```json\r\n{\r\n  \"auth_event\": {\r\n    \"action\": \"token_refreshed\",\r\n    \"actor_id\": \"733fb34d-a6f2-43e1-976a-8e6a456b6889\",\r\n    \"actor_name\": \"Kang Ming Tay\",\r\n    \"actor_username\": \"kang.ming1996@gmail.com\",\r\n    \"actor_via_sso\": false,\r\n    \"log_type\": \"token\"\r\n  },\r\n  \"component\": \"api\",\r\n  \"duration\": 75945042,\r\n  \"level\": \"info\",\r\n  \"method\": \"POST\",\r\n  \"msg\": \"request completed\",\r\n  \"path\": \"/token\",\r\n  \"referer\": \"http://localhost:3001\",\r\n  \"remote_addr\": \"127.0.0.1\",\r\n  \"request_id\": \"08c7e47b-42f4-44dc-a39b-7275ef5bbb45\",\r\n  \"status\": 200,\r\n  \"time\": \"2024-05-15T09:40:09Z\"\r\n}\r\n```","shortMessageHtmlLink":"fix: improve logging structure (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2297216117\" data-permission-text=\"Title is private\" data-url=\"https://github.com/supabase/auth/issues/1583\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/supabase/auth/pull/1583/hovercard\" href=\"https://github.com/supabase/auth/pull/1583\">#1583</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUlsF9AA","startCursor":null,"endCursor":null}},"title":"Activity · supabase/auth"}