Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor #22557 [VarDumper] Add iconv dependency (julienfalque)
This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Add iconv dependency | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Alternative to #20927. I still think adding `@requires extension iconv` to the related tests would be nice though: on some PHP setups the iconv extension is not available by default, those tests will fail and result in red errors when running the test suite, even when working on something unrelated. The test would still run on CI so it's fine IMO. Should I add `ext-iconv` and/or `symfony/polyfill` to `require-dev`? /cc @nicolas-grekas Commits ------- 13f1707 Add iconv extension to suggested dependencies
- Loading branch information