Skip to content

Commit

Permalink
minor #34230 [HttpKernel][DataCollectorInterface] Ease compatibility …
Browse files Browse the repository at this point in the history
…(fancyweb)

This PR was submitted for the 3.4 branch but it was merged into the 4.3 branch instead.

Discussion
----------

[HttpKernel][DataCollectorInterface] Ease compatibility

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/pull/33065/files#r342109866
| License       | MIT
| Doc PR        | -

To ease data collectors being compatible from 4.3 to 5.0.

Commits
-------

761df46 [HttpKernel][DataCollectorInterface] Ease compatibility
  • Loading branch information
nicolas-grekas committed Nov 5, 2019
2 parents a56ac78 + 761df46 commit 1a573c3
Showing 1 changed file with 3 additions and 1 deletion.
Expand Up @@ -24,8 +24,10 @@ interface DataCollectorInterface extends ResetInterface
{
/**
* Collects data for the given Request and Response.
*
* @param \Throwable|null $exception
*/
public function collect(Request $request, Response $response, \Exception $exception = null);
public function collect(Request $request, Response $response/*, \Throwable $exception = null*/);

/**
* Returns the name of the collector.
Expand Down

0 comments on commit 1a573c3

Please sign in to comment.