Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Process] Fixed ProcessFailedException not populating exception messa…
…ge due to a missing sprintf parameter
- Loading branch information
Showing
2 changed files
with
81 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
src/Symfony/Component/Process/Tests/ProcessFailedExceptionTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Process\Tests; | ||
|
||
use Symfony\Component\Process\Process, | ||
Symfony\Component\Process\Exception\ProcessFailedException; | ||
|
||
/** | ||
* @author Sebastian Marek <proofek@gmail.com> | ||
*/ | ||
class ProcessFailedExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
/** | ||
* tests ProcessFailedException throws exception if the process was successful | ||
*/ | ||
public function testProcessFailedExceptionThrowsException() | ||
{ | ||
$process = $this->getMock( | ||
'Symfony\Component\Process\Process', | ||
array('isSuccessful'), | ||
array('php') | ||
); | ||
$process->expects($this->once()) | ||
->method('isSuccessful') | ||
->will($this->returnValue(true)); | ||
|
||
$this->setExpectedException( | ||
'\InvalidArgumentException', | ||
'Expected a failed process, but the given process was successful.' | ||
); | ||
$exception = new ProcessFailedException($process); | ||
} | ||
|
||
/** | ||
* tests ProcessFailedException uses information from process output | ||
* to generate exception message | ||
*/ | ||
public function testProcessFailedExceptionPopulatesInformationFromProcessOutput() | ||
{ | ||
$cmd = 'php'; | ||
$output = "Command output"; | ||
$errorOutput = "FATAL: Unexpected error"; | ||
|
||
$process = $this->getMock( | ||
'Symfony\Component\Process\Process', | ||
array('isSuccessful', 'getOutput', 'getErrorOutput'), | ||
array($cmd) | ||
); | ||
$process->expects($this->once()) | ||
->method('isSuccessful') | ||
->will($this->returnValue(false)); | ||
$process->expects($this->once()) | ||
->method('getOutput') | ||
->will($this->returnValue($output)); | ||
$process->expects($this->once()) | ||
->method('getErrorOutput') | ||
->will($this->returnValue($errorOutput)); | ||
|
||
$exception = new ProcessFailedException($process); | ||
|
||
$this->assertEquals( | ||
"The command \"$cmd\" failed.\n\nOutput:\n================\n{$output}\n\nError Output:\n================\n{$errorOutput}", | ||
$exception->getMessage() | ||
); | ||
} | ||
} |