added a configuraiton to allow the profiler to be enabled only when a…

…n exception occurs
symfony · Aug 31, 2010 · 60ea1ee · 60ea1ee
1 parent 1e1a411
commit 60ea1ee
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/WebExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/WebExtension.php
@@ -81,6 +81,12 @@ public function configLoad($config, ContainerBuilder $container)
                     $loader->load('profiling.xml');
                     $loader->load('collectors.xml');
                 }
+
+                if (isset($config['profiler']['only-exceptions'])) {
+                    $container->setParameter('profiler_listener.only_exceptions', $config['profiler']['only-exceptions']);
+                } elseif (isset($config['profiler']['only_exceptions'])) {
+                    $container->setParameter('profiler_listener.only_exceptions', $config['profiler']['only_exceptions']);
+                }
             } elseif ($container->hasDefinition('profiler')) {
                 $container->getDefinition('profiling')->clearTags();
             }

diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.xml
@@ -10,6 +10,7 @@
         <parameter key="profiler.storage.file">%kernel.cache_dir%/profiler.db</parameter>
         <parameter key="profiler.storage.lifetime">86400</parameter>
         <parameter key="profiler_listener.class">Symfony\Component\HttpKernel\Profiler\ProfilerListener</parameter>
+        <parameter key="profiler_listener.only_exceptions">false</parameter>
     </parameters>
 
     <services>
@@ -27,6 +28,7 @@
         <service id="profiler_listener" class="%profiler_listener.class%">
             <tag name="kernel.listener" />
             <argument type="service" id="profiler" />
+            <argument>%profiler_listener.only_exceptions%</argument>
         </service>
     </services>
 </container>
diff --git a/src/Symfony/Component/HttpKernel/Profiler/ProfilerListener.php b/src/Symfony/Component/HttpKernel/Profiler/ProfilerListener.php
@@ -25,15 +25,18 @@ class ProfilerListener
 {
     protected $profiler;
     protected $exception;
+    protected $onlyException;
 
     /**
      * Constructor.
      *
-     * @param Profiler $profiler A Profiler instance
+     * @param Profiler $profiler      A Profiler instance
+     * @param Boolean  $onlyException true if the profiler only collects data when an exception occurs, false otherwise
      */
-    public function __construct(Profiler $profiler)
+    public function __construct(Profiler $profiler, $onlyException = false)
     {
         $this->profiler = $profiler;
+        $this->onlyException = $onlyException;
     }
 
     /**
@@ -77,6 +80,10 @@ public function handleResponse(Event $event, Response $response)
             return $response;
         }
 
+        if ($this->onlyException && null === $this->exception) {
+            return $response;
+        }
+
         $this->profiler->collect($event->getParameter('request'), $response, $this->exception);
         $this->exception = null;