Skip to content

Commit

Permalink
minor #32909 [PhpUnitBridge] Remove deprecated methods assertArraySub…
Browse files Browse the repository at this point in the history
…set (jderusse)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Remove deprecated methods assertArraySubset

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        |

This PR removes the 2 occurrences of assertArraySubset

Commits
-------

114ec6c Remove deprecated methods assertArraySubset
  • Loading branch information
nicolas-grekas committed Aug 3, 2019
2 parents 8890be6 + 114ec6c commit 6604a3e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -70,6 +70,6 @@ public function testDefaultJsonLoginBadRequest()

$this->assertSame(400, $response->getStatusCode());
$this->assertSame('application/json', $response->headers->get('Content-Type'));
$this->assertArraySubset(['error' => ['code' => 400, 'message' => 'Bad Request']], json_decode($response->getContent(), true));
$this->assertSame(['error' => ['code' => 400, 'message' => 'Bad Request']], json_decode($response->getContent(), true));
}
}
Expand Up @@ -54,7 +54,7 @@ public function testNormalize()
->expects($this->once())
->method('normalize')
->willReturnCallback(function ($data) {
$this->assertArraySubset(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], $data);
$this->assertSame(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], array_diff_key($data, ['qux' => '']));

return 'string_object';
})
Expand Down

0 comments on commit 6604a3e

Please sign in to comment.