Skip to content

Commit

Permalink
minor #29502 [Serializer] change timezone to fix tests on Windows (xa…
Browse files Browse the repository at this point in the history
…bbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] change timezone to fix tests on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

As I understand the failing tests timezones have changed in Russia in 2016, but this is not reflected in the timezone database used on AppVeyor. Since the tests do not depend on a particular timezone (it's
only important for it to be different from UTC) we should safely be able to switch to another timezone.

Commits
-------

01a27e5 change timezone to fix tests on Windows
  • Loading branch information
nicolas-grekas committed Dec 8, 2018
2 parents 9e84e0f + 01a27e5 commit 6f5356c
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -143,14 +143,14 @@ public function normalizeUsingTimeZonePassedInContextAndExpectedFormatWithMicros
);

yield array(
'2018-12-01T21:03:06.067634',
'2018-12-01T19:03:06.067634',
'Y-m-d\TH:i:s.u',
\DateTime::createFromFormat(
'Y-m-d\TH:i:s.u',
'2018-12-01T18:03:06.067634',
new \DateTimeZone('UTC')
),
new \DateTimeZone('Europe/Moscow'),
new \DateTimeZone('Europe/Berlin'),
);
}

Expand Down

0 comments on commit 6f5356c

Please sign in to comment.