Skip to content

Commit

Permalink
feature #19997 inlined some CSS (fabpot)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.2-dev branch.

Discussion
----------

inlined some CSS

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This PR has several goals:

* It fixes the discrepancy between where CSS files were stored (FrameworkBundle) and where there were used (TwigBundle);

* It removes the need to install the assets to get exceptions (think Silex, micro-kernel-based-edition, ...);

* It makes things consistent with how we already manage images for exceptions (they are inlined);

* It makes things consistent with how we manage assets for the web profiler.

Commits
-------

f354638 inlined some CSS
  • Loading branch information
fabpot committed Sep 21, 2016
2 parents 167c14f + f354638 commit 8993c8c
Show file tree
Hide file tree
Showing 6 changed files with 340 additions and 337 deletions.
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
3.2.0
-----

* The `Resources/public/css/*.css` files have been removed (they are now inlined in TwigBundle)
* The `Controller::getUser()` method has been deprecated and will be removed in
Symfony 4.0; typehint the security user object in the action instead.
* Added possibility to prioritize form type extensions with `'priority'` attribute on tags `form.type_extension`
Expand Down
138 changes: 0 additions & 138 deletions src/Symfony/Bundle/FrameworkBundle/Resources/public/css/body.css

This file was deleted.

128 changes: 0 additions & 128 deletions src/Symfony/Bundle/FrameworkBundle/Resources/public/css/exception.css

This file was deleted.

This file was deleted.

0 comments on commit 8993c8c

Please sign in to comment.