[BrowserKit] Throw exception on invalid cookie expiration timestamp

symfony · Jan 6, 2014 · 8df535d · 8df535d
1 parent 146e666
commit 8df535d
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/Symfony/Component/BrowserKit/Cookie.php b/src/Symfony/Component/BrowserKit/Cookie.php
@@ -81,14 +81,22 @@ public function __construct($name, $value, $expires = null, $path = null, $domai
      *
      * @return string The HTTP representation of the Cookie
      *
+     * @throws \UnexpectedValueException
+     *
      * @api
      */
     public function __toString()
     {
         $cookie = sprintf('%s=%s', $this->name, $this->rawValue);
 
         if (null !== $this->expires) {
-            $cookie .= '; expires='.substr(\DateTime::createFromFormat('U', $this->expires, new \DateTimeZone('GMT'))->format(self::$dateFormats[0]), 0, -5);
+            $dateTime = \DateTime::createFromFormat('U', $this->expires, new \DateTimeZone('GMT'));
+
+            if ($dateTime === false) {
+                throw new \UnexpectedValueException(sprintf('The cookie expiration time "%s" is not valid.'), $this->expires);
+            }
+
+            $cookie .= '; expires='.substr($dateTime->format(self::$dateFormats[0]), 0, -5);
         }
 
         if ('' !== $this->domain) {