Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
bug #15906 Forbid serializing a Crawler (stof)
This PR was merged into the 2.3 branch. Discussion ---------- Forbid serializing a Crawler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Unserializing a Crawler instance creates DOM elements in an invalid state, making the Crawler unusable. While working on #15849, I figured out that DomCrawler actually inherits ``Serializable`` from its ``SplObjectStorage`` parent, and so I tried to serialize and unserialize one. The answer is that it does not work. This is what happens when trying to call ``parents`` on it for instance: ``` Symfony\Component\DomCrawler\Crawler::parents(): Invalid State Error ``` Commits ------- 12733cb Forbid serializing a Crawler
- Loading branch information