[DependencyInjection] PhpDumper, fixes #2730

symfony · Jan 6, 2012 · 9441c46 · 9441c46
1 parent 3e9d937
commit 9441c46
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -648,14 +648,16 @@ class $class extends $baseClass
      */
     private function addConstructor()
     {
+        $arguments = $this->container->getParameterBag()->all() ? 'new ParameterBag($this->getDefaultParameters())' : null;
+
         $code = <<<EOF
 
     /**
      * Constructor.
      */
     public function __construct()
     {
-        parent::__construct(new ParameterBag(\$this->getDefaultParameters()));
+        parent::__construct($arguments);
 
 EOF;
 

diff --git a/tests/Symfony/Tests/Component/DependencyInjection/Fixtures/php/services1-1.php b/tests/Symfony/Tests/Component/DependencyInjection/Fixtures/php/services1-1.php
@@ -20,6 +20,6 @@ class Container extends AbstractContainer
      */
     public function __construct()
     {
-        parent::__construct(new ParameterBag($this->getDefaultParameters()));
+        parent::__construct();
     }
 }
diff --git a/tests/Symfony/Tests/Component/DependencyInjection/Fixtures/php/services1.php b/tests/Symfony/Tests/Component/DependencyInjection/Fixtures/php/services1.php
@@ -20,6 +20,6 @@ class ProjectServiceContainer extends Container
      */
     public function __construct()
     {
-        parent::__construct(new ParameterBag($this->getDefaultParameters()));
+        parent::__construct();
     }
 }