Skip to content

Commit

Permalink
minor #29980 [Process] disable transient test on Windows (nicolas-gre…
Browse files Browse the repository at this point in the history
…kas)

This PR was merged into the 4.2 branch.

Discussion
----------

[Process] disable transient test on Windows

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This test makes our Windows CI red 80% of the time, let's disable it until someone can have a deeper look.
PIng @Nek- , help wanted.

Commits
-------

399fee6 [Process] disable transient test on Windows
  • Loading branch information
nicolas-grekas committed Jan 24, 2019
2 parents 61bf16c + 399fee6 commit adf1e6f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/Symfony/Component/Process/Tests/ProcessTest.php
Expand Up @@ -135,6 +135,10 @@ public function testStopWithTimeoutIsActuallyWorking()

public function testWaitUntilSpecificOutput()
{
if ('\\' === \DIRECTORY_SEPARATOR) {
$this->markTestIncomplete('This test is too transient on Windows, help wanted to improve it');
}

$p = $this->getProcess([self::$phpBin, __DIR__.'/KillableProcessWithOutput.php']);
$p->start();

Expand Down

0 comments on commit adf1e6f

Please sign in to comment.