changed priority meaning to be more intuitive

symfony · Jan 14, 2011 · b47cf79 · b47cf79
1 parent e41df3d
commit b47cf79
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/security.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/security.xml
@@ -154,7 +154,7 @@
         </service>
 
         <service id="security.firewall" class="%security.firewall.class%" public="false">
-            <tag name="kernel.listener" priority="128" />
+            <tag name="kernel.listener" priority="-128" />
             <argument type="service" id="security.firewall.map" />
         </service>
         <service id="security.firewall.map" class="%security.firewall.map.class%" public="false" />

diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/web.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/web.xml
@@ -46,7 +46,7 @@
         </service>
 
         <service id="exception_listener" class="%exception_listener.class%" public="false">
-            <tag name="kernel.listener" priority="128" />
+            <tag name="kernel.listener" priority="-128" />
             <argument>%exception_listener.controller%</argument>
             <argument type="service" id="logger" on-invalid="null" />
         </service>

diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/toolbar.xml b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/toolbar.xml
@@ -11,7 +11,7 @@
 
     <services>
         <service id="debug.toolbar" class="%debug.toolbar.class%" public="false">
-            <tag name="kernel.listener" priority="128" />
+            <tag name="kernel.listener" priority="-128" />
             <argument type="service" id="controller_resolver" />
             <argument>%debug.toolbar.intercept_redirects%</argument>
         </service>

diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcher.php b/src/Symfony/Component/EventDispatcher/EventDispatcher.php
@@ -24,6 +24,8 @@ class EventDispatcher
     /**
      * Connects a listener to a given event name.
      *
+     * Listeners with a higher priority are executed first.
+     *
      * @param string  $name      An event name
      * @param mixed   $listener  A PHP callable
      * @param integer $priority  The priority (between -10 and 10 -- defaults to 0)
@@ -148,7 +150,7 @@ public function getListeners($name)
 
         $listeners = array();
         $all = $this->listeners[$name];
-        ksort($all);
+        krsort($all);
         foreach ($all as $l) {
             $listeners = array_merge($listeners, $l);
         }