Skip to content

Commit

Permalink
minor #35770 [Notifier] Remove not needed argument $bus in BrowserCha…
Browse files Browse the repository at this point in the history
…nnel::notify(...) (jschaedl)

This PR was merged into the 5.0 branch.

Discussion
----------

[Notifier] Remove not needed argument $bus in BrowserChannel::notify(...)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | - <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

The `BrowserChannel::notify(...)` method defines a fourth nullable argument `$bus` which is not part of the `ChannelInterface` and also not used in the implementation. So I think it was added by mistake and can be removed.

Commits
-------

ab4123c [Notifier] Remove not needed argument $bus in BrowserChannel::notify()
  • Loading branch information
fabpot committed Feb 18, 2020
2 parents 05f71d3 + ab4123c commit bd42f12
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/Symfony/Component/Notifier/Channel/BrowserChannel.php
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Component\Notifier\Channel;

use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Messenger\MessageBusInterface;
use Symfony\Component\Notifier\Notification\Notification;
use Symfony\Component\Notifier\Recipient\Recipient;

Expand All @@ -30,7 +29,7 @@ public function __construct(RequestStack $stack)
$this->stack = $stack;
}

public function notify(Notification $notification, Recipient $recipient, string $transportName = null, MessageBusInterface $bus = null): void
public function notify(Notification $notification, Recipient $recipient, string $transportName = null): void
{
if (null === $request = $this->stack->getCurrentRequest()) {
return;
Expand Down

0 comments on commit bd42f12

Please sign in to comment.