Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #35254 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the…
… passthru() commands fails (mpdude) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Some commands executed by the `simple-phpunit` script are not checked for success. For example [here](https://travis-ci.org/twigphp/Twig/jobs/634110681), Composer fails with the message ``` [InvalidArgumentException] Could not find package phpunit/phpunit with version 7.5.* in a version inst allable using your PHP version 7.0.25. ``` Yet, the `simple-phpunit` script happily continues, going over failing `chdir()`, `file_get_contents()` and `include()` calls and eventually returns a successful `0` exit code. So CI tests look OK when in fact PHPUnit was not even downloaded. Commits ------- 576e185 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
- Loading branch information