From dae19422ecfda69dcb3d41316a0c7a990da58dad Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 7 Apr 2015 13:59:04 +0200 Subject: [PATCH] [Process] Fix volatile test --- .../Process/Tests/AbstractProcessTest.php | 14 ++++---------- .../Stopwatch/Tests/StopwatchEventTest.php | 2 ++ 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php index 2b9c36d08a73..7e26976d62ac 100644 --- a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php +++ b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php @@ -800,9 +800,6 @@ public function testCheckTimeoutOnStartedProcess() $this->assertFalse($process->isSuccessful()); } - /** - * @group idle-timeout - */ public function testIdleTimeout() { $process = $this->getProcess('php -r "sleep(3);"'); @@ -820,21 +817,18 @@ public function testIdleTimeout() } } - /** - * @group idle-timeout - */ public function testIdleTimeoutNotExceededWhenOutputIsSent() { - $process = $this->getProcess('php -r "echo \'foo\'; sleep(1); echo \'foo\'; sleep(1); echo \'foo\'; sleep(1); "'); + $process = $this->getProcess(sprintf('php -r %s', escapeshellarg('$n = 30; while ($n--) {echo "foo\n"; usleep(100000); }'))); $process->setTimeout(2); - $process->setIdleTimeout(1.5); + $process->setIdleTimeout(1); try { $process->run(); $this->fail('A timeout exception was expected.'); } catch (ProcessTimedOutException $ex) { - $this->assertTrue($ex->isGeneralTimeout()); - $this->assertFalse($ex->isIdleTimeout()); + $this->assertTrue($ex->isGeneralTimeout(), 'A general timeout is expected.'); + $this->assertFalse($ex->isIdleTimeout(), 'No idle timeout is expected.'); $this->assertEquals(2, $ex->getExceededTimeout()); } } diff --git a/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php b/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php index 7ff294299162..ff4519686ffd 100644 --- a/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php +++ b/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php @@ -76,6 +76,7 @@ public function testDuration() $event->start(); usleep(100000); $event->stop(); + usleep(50000); $event->start(); usleep(100000); $event->stop(); @@ -93,6 +94,7 @@ public function testDurationBeforeStop() $event->start(); usleep(100000); $event->stop(); + usleep(50000); $event->start(); usleep(100000); $this->assertEquals(100, $event->getDuration(), null, self::DELTA);