[HttpFoundation] Allow Cache-Control headers on StreamedResponse

symfony · Nov 2, 2014 · dd7a9b6 · dd7a9b6
1 parent e19680f
commit dd7a9b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/src/Symfony/Component/HttpFoundation/StreamedResponse.php b/src/Symfony/Component/HttpFoundation/StreamedResponse.php
@@ -79,16 +79,6 @@ public function setCallback($callback)
         $this->callback = $callback;
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function prepare(Request $request)
-    {
-        $this->headers->set('Cache-Control', 'no-cache');
-
-        return parent::prepare($request);
-    }
-
     /**
      * {@inheritdoc}
      *

diff --git a/src/Symfony/Component/HttpFoundation/Tests/StreamedResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/StreamedResponseTest.php
@@ -34,7 +34,6 @@ public function testPrepareWith11Protocol()
 
         $this->assertEquals('1.1', $response->getProtocolVersion());
         $this->assertNotEquals('chunked', $response->headers->get('Transfer-Encoding'), 'Apache assumes responses with a Transfer-Encoding header set to chunked to already be encoded.');
-        $this->assertEquals('no-cache, private', $response->headers->get('Cache-Control'));
     }
 
     public function testPrepareWith10Protocol()
@@ -47,7 +46,6 @@ public function testPrepareWith10Protocol()
 
         $this->assertEquals('1.0', $response->getProtocolVersion());
         $this->assertNull($response->headers->get('Transfer-Encoding'));
-        $this->assertEquals('no-cache, private', $response->headers->get('Cache-Control'));
     }
 
     public function testPrepareWithHeadRequest()
@@ -58,6 +56,15 @@ public function testPrepareWithHeadRequest()
         $response->prepare($request);
     }
 
+    public function testPrepareWithCacheHeaders()
+    {
+        $response = new StreamedResponse(function () { echo 'foo'; }, 200, array('Cache-Control' => 'max-age=600, public'));
+        $request = Request::create('/', 'GET');
+
+        $response->prepare($request);
+        $this->assertEquals('max-age=600, public', $response->headers->get('Cache-Control'));
+    }
+
     public function testSendContent()
     {
         $called = 0;