bug #14246 [Filesystem] dumpFile() non atomic

symfony · Dec 31, 2015 · e4015d5 · e4015d5
1 parent 6b13708
commit e4015d5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -477,9 +477,9 @@ public function dumpFile($filename, $content, $mode = 0666)
             throw new IOException(sprintf('Failed to write file "%s".', $filename));
         }
 
-        $this->rename($tmpFile, $filename, true);
         if (null !== $mode) {
-            $this->chmod($filename, $mode);
+            $this->chmod($tmpFile, $mode);
         }
+        $this->rename($tmpFile, $filename, true);
     }
 }