Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ClassLoader] added support for PHP 5.4 traits
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5a23db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That condition, surely, won't be true for any version of PHP 5.3, as function_exists('trait_exists') will always be false pre 5.4?
Will submit a PR, anyway.
e5a23db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ach, submitted one, but there's already a PR: #2254. The Symfony community works fast! :)
e5a23db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found docs about trait_exists on php.net, therefore the question here: wont trait_exists have a second parameter to suppress classloading?
e5a23db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@staabm: good catch. fixed now.