Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
moved the container aware HTTP kernel to the HttpKernel component
- Loading branch information
Showing
4 changed files
with
156 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\HttpKernel\DependencyInjection; | ||
|
||
use Symfony\Component\HttpFoundation\Request; | ||
use Symfony\Component\HttpFoundation\Response; | ||
use Symfony\Component\HttpKernel\HttpKernelInterface; | ||
use Symfony\Component\HttpKernel\HttpKernel; | ||
use Symfony\Component\HttpKernel\Controller\ControllerResolverInterface; | ||
use Symfony\Component\EventDispatcher\EventDispatcherInterface; | ||
use Symfony\Component\DependencyInjection\ContainerInterface; | ||
|
||
/** | ||
* This HttpKernel is used to manage scope changes of the DI container. | ||
* | ||
* @author Fabien Potencier <fabien@symfony.com> | ||
* @author Johannes M. Schmitt <schmittjoh@gmail.com> | ||
*/ | ||
class ContainerAwareHttpKernel extends HttpKernel | ||
{ | ||
protected $container; | ||
|
||
/** | ||
* Constructor. | ||
* | ||
* @param EventDispatcherInterface $dispatcher An EventDispatcherInterface instance | ||
* @param ContainerInterface $container A ContainerInterface instance | ||
* @param ControllerResolverInterface $controllerResolver A ControllerResolverInterface instance | ||
*/ | ||
public function __construct(EventDispatcherInterface $dispatcher, ContainerInterface $container, ControllerResolverInterface $controllerResolver) | ||
{ | ||
parent::__construct($dispatcher, $controllerResolver); | ||
|
||
$this->container = $container; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQUEST, $catch = true) | ||
{ | ||
$request->headers->set('X-Php-Ob-Level', ob_get_level()); | ||
|
||
$this->container->enterScope('request'); | ||
$this->container->set('request', $request, 'request'); | ||
|
||
try { | ||
$response = parent::handle($request, $type, $catch); | ||
} catch (\Exception $e) { | ||
$this->container->leaveScope('request'); | ||
|
||
throw $e; | ||
} | ||
|
||
$this->container->leaveScope('request'); | ||
|
||
return $response; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
src/Symfony/Component/HttpKernel/Tests/RenderingStrategy/DefaultRenderingStrategyTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\HttpKernel\Tests\RenderingStrategy; | ||
|
||
use Symfony\Component\HttpKernel\HttpKernelInterface; | ||
use Symfony\Component\HttpKernel\HttpKernel; | ||
use Symfony\Component\HttpKernel\RenderingStrategy\DefaultRenderingStrategy; | ||
use Symfony\Component\HttpFoundation\Response; | ||
use Symfony\Component\HttpFoundation\Request; | ||
use Symfony\Component\EventDispatcher\EventDispatcher; | ||
|
||
class DefaultRenderingStrategyTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
protected function setUp() | ||
{ | ||
if (!class_exists('Symfony\Component\EventDispatcher\EventDispatcher')) { | ||
$this->markTestSkipped('The "EventDispatcher" component is not available'); | ||
} | ||
|
||
if (!class_exists('Symfony\Component\HttpFoundation\Request')) { | ||
$this->markTestSkipped('The "HttpFoundation" component is not available'); | ||
} | ||
} | ||
|
||
public function testExceptionInSubRequestsDoesNotMangleOutputBuffers() | ||
{ | ||
$resolver = $this->getMock('Symfony\\Component\\HttpKernel\\Controller\\ControllerResolverInterface'); | ||
$resolver | ||
->expects($this->once()) | ||
->method('getController') | ||
->will($this->returnValue(function () { | ||
ob_start(); | ||
echo 'bar'; | ||
throw new \RuntimeException(); | ||
})) | ||
; | ||
$resolver | ||
->expects($this->once()) | ||
->method('getArguments') | ||
->will($this->returnValue(array())) | ||
; | ||
|
||
$kernel = new HttpKernel(new EventDispatcher(), $resolver); | ||
$renderer = new DefaultRenderingStrategy($kernel); | ||
|
||
// simulate a main request with output buffering | ||
ob_start(); | ||
echo 'Foo'; | ||
|
||
// simulate a sub-request with output buffering and an exception | ||
$renderer->render('/', Request::create('/'), array('ignore_errors' => true)); | ||
|
||
$this->assertEquals('Foo', ob_get_clean()); | ||
} | ||
} |