technoweenie / attachment_fu

When using attachment_fu alongside Yard, launching the Rails server throws an error that constant Technoweenie::AttachmentFu can not be found. It is failing on:

ActiveRecord::Base.send(:extend, Technoweenie::AttachmentFu::ActMethods)

When using attachment_fu alongside Shoulda, the same error is thrown when attempting to run tests.

In "init.rb", only TempFile and Geometry are required. Adding the following resolves the aforementioned issue, and should be added to the repo:

require 'technoweenie/attachment_fu'
Dir.glob(File.join(File.dirname(__FILE__), 'lib/backends/*.rb')).each {|f| require f }
Dir.glob(File.join(File.dirname(__FILE__), 'lib/processors/*.rb')).each {|f| require f }

Attachment_fu generates lots of tempfiles in tmp/attachment_fu, which are never deleted until the process exits. This is a problem with long running processes, which can generate tons of tempfiles. When attachment_fu is done with a tempfile, it should be proactively deleted in order to conserve disk space.

With GD2 processor, the image file is not well loaded and the format can't be determine.

Here is the patch http://gist.github.com/169214

I have two classes, one which manages the "child" images and one for the "parent" images.

In the parent image class I have:

class Photo < ActiveRecord::Base
  has_attachment :content_type => :image,
    :storage => :file_system,
    :size => 1..5.megabytes,
    :thumbnails => { :thumb => 'c100x100' },
    :thumbnail_class => ChildPhoto,
    :path_prefix => "Photos"

  validates_as_attachment
end

And in the child class:

class ChildPhoto < ActiveRecord::Base
  has_attachment :content_type => :image,
    :storage => :file_system,
    :path_prefix => "Photos",

  validates_as_attachment
end

I've removed the :belongs_to stuff because mine is quite funky and gets in the way of reading :)

Anyways, this is code for a friend's photography portfolio and so obviously the images can be quite large when first uploaded. The issue, though, is that I left the size parameter as the default for the child class as I figured thumbnails wouldn't be very large at all. However, the image size is checked before the resize operation and so the child class throws its toys out of the pram because it has an image that is larger than it is expecting. Is this expected behavior? The solution, obviously, is to also apply the :size option to the ChildImage class, but this feels wrong to me...

If there is a model saved without a file uploaded and model.destroy is called the following error can occur:

TypeError (can't convert nil into String)

I've found a few instances and simple fixes.

http://github.com/technoweenie/attachment_fu/blob/master/lib/technoweenie/attachment_fu/backends/file_system_backend.rb#LID92

        logger.info "Exception destroying  #{full_filename.inspect}: [#{$!.class.name}] #{$1.to_s}"

http://github.com/technoweenie/attachment_fu/blob/master/lib/technoweenie/attachment_fu/backends/file_system_backend.rb#LID91
Suggested fix, change the contents of the rescue on line 91 to the following:

        if $1
          logger.info "Exception destroying  #{full_filename.inspect}: [#{$!.class.name}] #{$1.to_s}"
        else
          logger.info "Exception destroying file: no filename"
        end
        logger.warn $!.backtrace.collect { |b| " > #{b}" }.join("\n")

http://github.com/technoweenie/attachment_fu/blob/master/lib/technoweenie/attachment_fu.rb#L365

  # Gets an array of the currently used temp paths. Defaults to a copy of #full_filename.
  def temp_paths
    @temp_paths ||= (new_record? || !respond_to?(:full_filename) || !File.exist?(full_filename) ?
      [] : [copy_to_temp_file(full_filename)])
  end

fixed:

  # Gets an array of the currently used temp paths.  Defaults to a copy of #full_filename.
  def temp_paths
    if self.filename
      @temp_paths ||= (new_record? || !respond_to?(:full_filename) || !File.exist?(full_filename) ?
        [] : [copy_to_temp_file(full_filename)])
    else
      []
    end
  end

http://github.com/technoweenie/attachment_fu/blob/master/lib/technoweenie/attachment_fu/backends/file_system_backend.rb#L21

    def full_filename(thumbnail = nil)
      file_system_path = (thumbnail ? thumbnail_class : self).attachment_options[:path_prefix].to_s
      File.join(RAILS_ROOT, file_system_path, *partitioned_path(thumbnail_name_for(thumbnail)))
    end

fixed:

    def full_filename(thumbnail = nil)
      if (self.filename)
        file_system_path = (thumbnail ? thumbnail_class : self).attachment_options[:path_prefix].to_s
        File.join(RAILS_ROOT, file_system_path, *partitioned_path(thumbnail_name_for(thumbnail)))
      end
    end