2dab082d0e1382eb0bc6a143bef6db8deebfd812 Pratik Naik pratiknaik@gmail.com http://github.com/technoweenie/rails/commit/3cb89257b4d7bd706c642e0838909ed13019f557 3cb89257b4d7bd706c642e0838909ed13019f557 2009-04-20T05:56:28-07:00 2009-04-20T05:51:11-07:00 Ensure JoinAssociation uses aliased table name when multiple associations have hash conditions on the same table bff43f96613ccd6ee2064ecfd2e91a37ab9787ac Pratik Naik pratiknaik@gmail.com 5f95347af583d2e2a67631da02e0293679991612 Frederick Cheung frederick.cheung@gmail.com http://github.com/technoweenie/rails/commit/2dab082d0e1382eb0bc6a143bef6db8deebfd812 2dab082d0e1382eb0bc6a143bef6db8deebfd812 2009-04-01T07:51:10-07:00 2008-12-10T12:57:19-08:00 Don't use the transaction instance method so that people with has_one/belongs_to :transaction aren't fubared [#1551 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> d66a3afff89ea0be1cafb5657f829eb963614eeb Pratik Naik pratiknaik@gmail.com b6ad4bd0a23f4fcb7201b512445fdb0da33a73bd Jeremy Kemper jeremy@bitsweat.net http://github.com/technoweenie/rails/commit/5f95347af583d2e2a67631da02e0293679991612 5f95347af583d2e2a67631da02e0293679991612 2009-03-10T23:11:51-07:00 2009-03-10T23:11:05-07:00 Don't duplicate :order from scope and options, it makes mysql do extra work 3883638067e200b597d00b20f6a17cfab24f2257 Jeremy Kemper jeremy@bitsweat.net 763effcb6d6f3145540797d68dda32f539b1d499 Sam Granieri sam@samgranieri.com http://github.com/technoweenie/rails/commit/b6ad4bd0a23f4fcb7201b512445fdb0da33a73bd b6ad4bd0a23f4fcb7201b512445fdb0da33a73bd 2009-02-25T09:39:10-08:00 2009-02-22T19:24:53-08:00 Ruby 1.9 compat: silence a warning about regexp languages [#2050 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> ebb3c7369cc0f8731146235ce69b8b5eea9f5214 Jeremy Kemper jeremy@bitsweat.net a9aa18fdcdf3146ccbdecff71e52015f26a0f0b7 51eb04c84c40bd9cdfeda3b14fa7048773329cba rick technoweenie@gmail.com http://github.com/technoweenie/rails/commit/763effcb6d6f3145540797d68dda32f539b1d499 763effcb6d6f3145540797d68dda32f539b1d499 2009-02-25T09:11:58-08:00 2009-02-25T09:11:58-08:00 Merge branch '2-2-stable' of git@github.com:rails/rails into 2-2-stable 364f330936757e13f8784495f6d8909e77cd0a9b rick technoweenie@gmail.com e5c211c5eb6e8f1651130b7aa0a5291e5d184ab4 Diego Algorta diego@oboxodo.com http://github.com/technoweenie/rails/commit/a9aa18fdcdf3146ccbdecff71e52015f26a0f0b7 a9aa18fdcdf3146ccbdecff71e52015f26a0f0b7 2009-02-25T09:10:40-08:00 2009-02-12T22:07:39-08:00 Fixed bug that makes named_scopes _forgot_ current scope Signed-off-by: rick <technoweenie@gmail.com> [#1960 #1677 state:resolved] 82a45818235f7ea9784b76c38e909989ca612322 rick technoweenie@gmail.com ce41582d276ccc25f338c11ebfb9a59f4c918ecb Andrew White andyw@pixeltrix.co.uk http://github.com/technoweenie/rails/commit/51eb04c84c40bd9cdfeda3b14fa7048773329cba 51eb04c84c40bd9cdfeda3b14fa7048773329cba 2009-02-21T18:41:16-08:00 2009-02-21T18:41:16-08:00 Remove hardcoded number_of_capturesin ControllerSegment to allow regexp requirements with capturing parentheses dd1a71410e601471157134de75e6a45eaff5783f Michael Koziarski michael@koziarski.com 0f93f8c4c87792c2fc0ffb044040e336edf0c43a Andrew White andyw@pixeltrix.co.uk http://github.com/technoweenie/rails/commit/ce41582d276ccc25f338c11ebfb9a59f4c918ecb ce41582d276ccc25f338c11ebfb9a59f4c918ecb 2009-02-21T18:38:05-08:00 2009-01-16T01:16:18-08:00 Fix requirements regexp for path segments Signed-off-by: Michael Koziarski <michael@koziarski.com> b4eece3edc6b6a25cce976c294b817e6f20fd35e Michael Koziarski michael@koziarski.com 518389d1ef41f8c4116bc844bad44356c7aa4f9d Jeremy Kemper jeremy@bitsweat.net http://github.com/technoweenie/rails/commit/0f93f8c4c87792c2fc0ffb044040e336edf0c43a 0f93f8c4c87792c2fc0ffb044040e336edf0c43a 2009-02-20T18:42:48-08:00 2009-02-20T18:42:48-08:00 Update changelog for URI.unescape fix [#2033 state:committed] 4711e4e651eb2a8d7d5e808af46c06438c103065 Jeremy Kemper jeremy@bitsweat.net faf7986bae995d147eadc2ea8bdd1835cdf7c15c Jeremy Kemper jeremy@bitsweat.net http://github.com/technoweenie/rails/commit/518389d1ef41f8c4116bc844bad44356c7aa4f9d 518389d1ef41f8c4116bc844bad44356c7aa4f9d 2009-02-20T18:38:32-08:00 2009-02-20T18:38:18-08:00 Broaden URI.unescape fix to all affected 1.9.x by checking for broken behavior instead of specific patchlevel 111ceae2bce222bf819f4645e76dcd705aea9311 Jeremy Kemper jeremy@bitsweat.net 99341a2d80a3ff516ae1e5f217340c6adec2b39b moro moronatural@gmail.com http://github.com/technoweenie/rails/commit/faf7986bae995d147eadc2ea8bdd1835cdf7c15c faf7986bae995d147eadc2ea8bdd1835cdf7c15c 2009-02-20T18:31:48-08:00 2009-02-15T02:35:08-08:00 fix test data, should specify encoding to use multibyte chars on Ruby 1.9 Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 68674de063daac07b420900b5fcc199c99205be1 Jeremy Kemper jeremy@bitsweat.net a8f32e1c86d73623cf93cdcf1683a23e3af47ce3 Jeremy Kemper jeremy@bitsweat.net http://github.com/technoweenie/rails/commit/99341a2d80a3ff516ae1e5f217340c6adec2b39b 99341a2d80a3ff516ae1e5f217340c6adec2b39b 2009-02-20T18:26:32-08:00 2009-02-20T18:25:02-08:00 URI.unescape fix removes the old unescape method a47eed3361951c7842ffdba3bc4a932c718faf59 Jeremy Kemper jeremy@bitsweat.net 3d15e1a7b5c996baf11728ed32945b0d27418b1a moro moronatural@gmail.com http://github.com/technoweenie/rails/commit/a8f32e1c86d73623cf93cdcf1683a23e3af47ce3 a8f32e1c86d73623cf93cdcf1683a23e3af47ce3 2009-02-20T18:26:22-08:00 2009-02-15T02:34:04-08:00 Ruby 1.9.1p0's URI.decode() bug fix backport to fix Ruby 1.9.1p0 bug on [ruby-dev:38005]. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 0cc5345ab86ff1eb3d587646d7db47faf35f3e14 Jeremy Kemper jeremy@bitsweat.net 13bf5c5a6ae510cd17f05ac24cad5df9dda42342 Bruno Duyé brunetton@gmail.com http://github.com/technoweenie/rails/commit/3d15e1a7b5c996baf11728ed32945b0d27418b1a 3d15e1a7b5c996baf11728ed32945b0d27418b1a 2009-02-19T19:01:55-08:00 2009-02-19T19:01:18-08:00 Make atomic_write() puts the check_file in the cache dir, not in application root [#1962 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 7cd30e52f4761d2e3fea54c4938c11b7084e8c5b Joshua Peek josh@joshpeek.com b0792a3e7be88e3060af19bab01cd3d26d347e4c Akira Matsuda ronnie@dio.jp http://github.com/technoweenie/rails/commit/13bf5c5a6ae510cd17f05ac24cad5df9dda42342 13bf5c5a6ae510cd17f05ac24cad5df9dda42342 2009-02-17T11:59:49-08:00 2009-02-14T11:09:50-08:00 Ruby 1.9 compat: fix JSON decoding to work properly with multibyte values [#1969 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 675ef8c18247cdab4a0eb4c9f4403f6b90660fc9 Jeremy Kemper jeremy@bitsweat.net 96687ad8a9430829910c2146959da15ef0ed016d Joshua Sierles joshua@37signals.com http://github.com/technoweenie/rails/commit/b0792a3e7be88e3060af19bab01cd3d26d347e4c b0792a3e7be88e3060af19bab01cd3d26d347e4c 2009-02-12T11:24:36-08:00 2009-02-12T11:24:36-08:00 Allow memcache-client versions > 1.5.x to override bundled version Signed-off-by: Joshua Peek <josh@joshpeek.com> 6694f046ff2bad313da53a63c38b7b0d60638543 Joshua Peek josh@joshpeek.com 30560593e7213f2c8855bf5ec722ddc8cd1335a2 Jeremy Kemper jeremy@bitsweat.net http://github.com/technoweenie/rails/commit/96687ad8a9430829910c2146959da15ef0ed016d 96687ad8a9430829910c2146959da15ef0ed016d 2009-02-10T11:10:12-08:00 2009-02-10T11:10:12-08:00 Add missing test for parsing a multivalued query string 36d02ca94d05fbd63beadead7315bf136054c0cf Jeremy Kemper jeremy@bitsweat.net 3c006d428b3d3d306185f620cce3821b1bdb636f David Heinemeier Hansson david@loudthinking.com http://github.com/technoweenie/rails/commit/30560593e7213f2c8855bf5ec722ddc8cd1335a2 30560593e7213f2c8855bf5ec722ddc8cd1335a2 2009-02-06T05:38:41-08:00 2009-02-06T05:38:41-08:00 Fixed syntax error [#1894 state:committed] 2372f36c95e0102dabf32b87b5af8388001f1e93 David Heinemeier Hansson david@loudthinking.com be4ecc2e64cee529922f5cc5a49c56e444e5d869 Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/3c006d428b3d3d306185f620cce3821b1bdb636f 3c006d428b3d3d306185f620cce3821b1bdb636f 2009-02-05T16:34:16-08:00 2009-02-05T16:34:00-08:00 Handle every error that can come out of the Iconv branch by rescuing and returning nil [#1195 state:committed] Conflicts: activesupport/lib/active_support/inflector.rb c57cbfbb7f1eb9f04b6acd16a18ee0b107a005f5 Michael Koziarski michael@koziarski.com 0c4a126b16165a7bb0eb937825574342bcf5338b Daniel Guettler daniel.guettler@gmail.com http://github.com/technoweenie/rails/commit/be4ecc2e64cee529922f5cc5a49c56e444e5d869 be4ecc2e64cee529922f5cc5a49c56e444e5d869 2009-02-05T14:10:10-08:00 2009-02-05T14:10:10-08:00 check for template with specified extension but without template handler extension [#1798 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 7460598bd3123658ea96bb0a70a69f47b417d45e Joshua Peek josh@joshpeek.com e5c211c5eb6e8f1651130b7aa0a5291e5d184ab4 Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/0c4a126b16165a7bb0eb937825574342bcf5338b 0c4a126b16165a7bb0eb937825574342bcf5338b 2009-01-28T20:08:08-08:00 2009-01-28T20:07:29-08:00 Move to use pg instead of postgres on the CI server 9aa69b49ab014a808ee594deda7b0f98d82c047f Michael Koziarski michael@koziarski.com b081059913403d626ee1572dec4115aed2048912 Dov Murik dov.murik@gmail.com http://github.com/technoweenie/rails/commit/e5c211c5eb6e8f1651130b7aa0a5291e5d184ab4 e5c211c5eb6e8f1651130b7aa0a5291e5d184ab4 2009-01-26T12:56:31-08:00 2009-01-26T06:10:00-08:00 Mysql#reconnect is set according to the 'reconnect' key in the connection spec. The 'reconenct' boolean option is read from the connection specification and is used to set the reconnect attribute of Mysql. The default is false in order not to change existing application behaviour. Also, reconnect is set AFTER real_connect is called, so its value sticks (the mysql gem sets reconnect to false inside real_connect). Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1797 state:committed] 1ac333b3c5449270178cb345b4166426c398fd45 Michael Koziarski michael@koziarski.com 827efe1a087e30dd065eb563f09d69926f7b2330 Stephen Bannasch stephen.bannasch@gmail.com http://github.com/technoweenie/rails/commit/b081059913403d626ee1572dec4115aed2048912 b081059913403d626ee1572dec4115aed2048912 2009-01-25T19:09:38-08:00 2008-12-27T12:37:47-08:00 Adding AR tests for JDBC connections New connections: jdbcmysql jdbcpostgresql jdbcsqlite3 jdbcderby jdbch2 jdbchsqldb jdbcpostgresql To test you will need the native database installed (if one is required), activerecord-jdbc-adapter and the specific activerecord-jdbc<database>-adapter for the database you are testing. Run the tests like this: jruby -S rake test_jdbcmysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1685 state:committed] e040fc1394cabb9f92a4844dec650dff6eed907d Michael Koziarski michael@koziarski.com b75e2f3321dc4c18f62dc4c26bd22a037263f0d6 Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/827efe1a087e30dd065eb563f09d69926f7b2330 827efe1a087e30dd065eb563f09d69926f7b2330 2009-01-21T16:44:33-08:00 2009-01-21T16:44:33-08:00 Bring back relative_url_root but deprecate it c41176e26968a6e30db55a42a3dad153cc66fb9b Michael Koziarski michael@koziarski.com 97bc170a79e81851e8f2e744c688e3993ccad70c Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/b75e2f3321dc4c18f62dc4c26bd22a037263f0d6 b75e2f3321dc4c18f62dc4c26bd22a037263f0d6 2009-01-20T17:59:17-08:00 2009-01-20T17:59:17-08:00 Rationalise the session options to one hash, prevents rack or integration tests from seeing incorrect defaults d1ea56ba3fee9f6b6417297b0707a8d456f9335b Michael Koziarski michael@koziarski.com 7c147e94e66530a8314bc5d836df412fd749d55b Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/97bc170a79e81851e8f2e744c688e3993ccad70c 97bc170a79e81851e8f2e744c688e3993ccad70c 2009-01-17T17:30:51-08:00 2009-01-17T17:30:51-08:00 Fix has_and_belongs_to_many_associations tests. #1738 Conflicts: activerecord/test/cases/helper.rb 6798a31a855543359f13b3118ff57abe639a7176 Michael Koziarski michael@koziarski.com 9606bc883292102faaff0e3046855521d36131ef lukeludwig ludwig@tstmedia.com http://github.com/technoweenie/rails/commit/7c147e94e66530a8314bc5d836df412fd749d55b 7c147e94e66530a8314bc5d836df412fd749d55b 2009-01-16T21:10:32-08:00 2009-01-16T11:04:19-08:00 Cache columns for has_and_belongs_to_many associations This avoids repeatedly calling SHOW COLUMNS when the association is queried [#1738 state:committed] 4467998cd6a0e077ea81e09ca3f0053db39c8641 Michael Koziarski michael@koziarski.com 5664f24973b1d4f8db7e78b73482eaebf36cf0ab Carlos Kozuszko carlos@insignia4u.com http://github.com/technoweenie/rails/commit/9606bc883292102faaff0e3046855521d36131ef 9606bc883292102faaff0e3046855521d36131ef 2009-01-15T13:01:18-08:00 2009-01-04T14:22:53-08:00 Fixing bug on ActiveRecord::Dirty#field_changed? for nullable numeric columns, NULL gets stored in database for blank (i.e. '') values. Only integer columns were considered. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1692 state:committed] d0c2aead0d259eaf82c8ef2adc0e927e64c700fe Michael Koziarski michael@koziarski.com b0091097bce6497f1301e961c8b5af3e627d4cec Nicholas Dainty nick@npad.co.uk http://github.com/technoweenie/rails/commit/5664f24973b1d4f8db7e78b73482eaebf36cf0ab 5664f24973b1d4f8db7e78b73482eaebf36cf0ab 2009-01-11T11:57:57-08:00 2009-01-10T06:09:29-08:00 TimeWithZone#xmlschema accepts optional fraction_digits argument [#1725 state:resolved] 190d559b2c0cc0244cbc996af9b9e2fccfcd5cbf gbuesing gbuesing@gmail.com e7e34a47ac4d3e2e00f0acfc88b38bfa33415b38 Michael Koziarski michael@koziarski.com http://github.com/technoweenie/rails/commit/b0091097bce6497f1301e961c8b5af3e627d4cec b0091097bce6497f1301e961c8b5af3e627d4cec 2009-01-06T21:17:49-08:00 2009-01-06T21:17:49-08:00 Spam people with commit rights on test failures. c1fe9420eab8f1a7fbde6ba77ada62cedc243ea1 Michael Koziarski michael@koziarski.com