tekkub / cork

Click here to lend your support to: cork and make a donation at www.pledgie.com !

WoW Addon - Generic reminder framework — Read more

Sort by: Priority | Votes | Last Updated

Loading…

1.

1 vote

New module proposal
3 comments Created 8 months ago by Adirelle

Title

Body
Here you can find a little module that helps gathering "shattered items" into bigger ones, mainly intended to gather crystallized shards into eternal ones. http://paste.wowace.com/okhryt1x2fzqj4al/
or cancel

Here you can find a little module that helps gathering "shattered items" into bigger ones, mainly intended to gather crystallized shards into eternal ones.

http://paste.wowace.com/okhryt1x2fzqj4al/

Comments

tekkub Mon Apr 20 14:06:40 -0700 2009 | link

Oh interesting. I assume it only recommends combining if bagspace will improve (i.e. you have 20+ of a crystallized item, or an existing partial stack of the eternal)?

Comment
Oh interesting. I assume it only recommends combining if bagspace will improve (i.e. you have 20+ of a crystallized item, or an existing partial stack of the eternal)?
or cancel

Adirelle Mon Apr 20 15:11:42 -0700 2009 | link

It combines them as soon as they are enough of them to do so. But actually crystalled shards have a stack size of 10 so it always improves bag space. This is more arguable for Lesser Cosmic Essences but I think you already have combined items most of time.

The count thresholds are stored as values of the ITEMS table.

Comment
It combines them as soon as they are enough of them to do so. But actually crystalled shards have a stack size of 10 so it always improves bag space. This is more arguable for Lesser Cosmic Essences but I think you already have combined items most of time. The count thresholds are stored as values of the ITEMS table.
or cancel

tekkub Mon Apr 20 16:30:58 -0700 2009 | link

Yea true, you don't lose any bagspace from the elements, but you might not always gain it. Essences it would be a minor pain, but not a huge deal. I'll get it merged whenever I get a chance, might even add in more items.

Comment
Yea true, you don't lose any bagspace from the elements, but you might not always gain it. Essences it would be a minor pain, but not a huge deal. I'll get it merged whenever I get a chance, might even add in more items.
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

One-click party buffs, range check
3 comments Created 6 months ago by rulez

Title

Body
It would be awesome and take all the annoyances of buffing away for me, if the following behavior could be implemented for the one-click feature: If some party/raid members are outside of buffing range and some are inside and need the same buff, group buffs should only be applied if the number of members in range needing the buff is 2 or more, otherwise if only one member is in range or myself needing a buff, single buffs should be used. Members outside of buffing range needing a buff should not block one-click buffing as it does often currently, or even worse, keep on wasting reagents by repeatably trying to apply group buffs to members out of range (like other similar addons do). A nice to have would be the possibility to rebuff before a buff runs out, e.g. 1 minute (configurable per buff). Many thanks in advance if this is possible!
or cancel

It would be awesome and take all the annoyances of buffing away for me, if the following behavior could be implemented for the one-click feature:

If some party/raid members are outside of buffing range and some are inside and need the same buff, group buffs should only be applied if the number of members in range needing the buff is 2 or more, otherwise if only one member is in range or myself needing a buff, single buffs should be used.
Members outside of buffing range needing a buff should not block one-click buffing as it does often currently, or even worse, keep on wasting reagents by repeatably trying to apply group buffs to members out of range (like other similar addons do).

A nice to have would be the possibility to rebuff before a buff runs out, e.g. 1 minute (configurable per buff).

Many thanks in advance if this is possible!

Comments

tekkub Wed Jun 24 14:08:02 -0700 2009 | link

Range is checked, there is an issue with Blizzy's API that reports units as in range when they are not, I cannot fix that.

I will never add pre-buffing, tracking buff times is complexity that I'm just not willing to add to the addon.

Comment
Range is checked, there is an issue with Blizzy's API that reports units as in range when they are not, I cannot fix that. I will never add pre-buffing, tracking buff times is complexity that I'm just not willing to add to the addon.
or cancel

tekkub Wed Jun 24 20:25:32 -0700 2009 | link

Ah, they did fix range check, BUT they return 0 or 1, not true or false... 0 is true in lua, so my code was thinking everything was in range.... ugh... those bastards...

Comment
Ah, they did fix range check, BUT they return 0 or 1, not true or false... 0 is true in lua, so my code was thinking everything was in range.... ugh... those bastards...
or cancel

rulez Thu Jun 25 02:51:23 -0700 2009 | link

Thanks for looking into it :)

Comment
Thanks for looking into it :)
or cancel

Parsed with GitHub Flavored Markdown
3.

0 votes

Checkboxes going nuts upon respec.
1 comment Created 6 months ago by Pusikas

Title

Body
Tried Cork on my Paladin yesterday. I did not want it to remind me of blessings, and I deactivated them while in my tank spec. Worked as expected - the blessings disappeared from the reminder list. Then I switched spec to healer, and the blessing reminders were back again. I went to the options, but the checkbox for the blessings module was like I had left it: not checked. So, this time I had to check the blessings module to make them disappear from the reminder list, which is kinda confusing. Looks like the checkboxes do not reflect the actual settings after a spec-switch anymore.
or cancel

Tried Cork on my Paladin yesterday. I did not want it to remind me of blessings, and I deactivated them while in my tank spec. Worked as expected - the blessings disappeared from the reminder list.
Then I switched spec to healer, and the blessing reminders were back again. I went to the options, but the checkbox for the blessings module was like I had left it: not checked. So, this time I had to check the blessings module to make them disappear from the reminder list, which is kinda confusing.
Looks like the checkboxes do not reflect the actual settings after a spec-switch anymore.

Comments

tekkub Wed Jun 24 14:08:53 -0700 2009 | link

Settings are saved per-spec now, if you change things in one spec they will not apply to the other spec.

Comment
Settings are saved per-spec now, if you change things in one spec they will not apply to the other spec.
or cancel

Parsed with GitHub Flavored Markdown
4.

0 votes

Dire Bear Form should be the last buff that cork tries to apply
2 comments Created 6 months ago by Pusikas

Title

Body
Tried Cork on my druid tank, and it reminds me to switch into bear form, which is nice. But I tried the automatic buffing on mousewheel, and bear form is among the first things it tries to buff. So if there is, say, thorns and bear form on the reminder list, and I use the mousewheel, Cork buffs like this: Dire Bear Form, Thorns (leaving ebar form), Dire Bear Form (again). Maybe you could somehow make sure that cork only tries to shapeshift, if the is nothing else on the reminder list.
or cancel

Tried Cork on my druid tank, and it reminds me to switch into bear form, which is nice. But I tried the automatic buffing on mousewheel, and bear form is among the first things it tries to buff. So if there is, say, thorns and bear form on the reminder list, and I use the mousewheel, Cork buffs like this:
Dire Bear Form, Thorns (leaving ebar form), Dire Bear Form (again).
Maybe you could somehow make sure that cork only tries to shapeshift, if the is nothing else on the reminder list.

Comments

tekkub Wed Jun 24 14:10:07 -0700 2009 | link

The problem here is I cannot control the order buffs are applied without major changes to the design. I might, however, be able to tweak the fursuit module to only cast if no other needs are present.

Comment
The problem here is I cannot control the order buffs are applied without major changes to the design. I might, however, be able to tweak the fursuit module to only cast if no other needs are present.
or cancel

tekkub Wed Jun 24 18:31:37 -0700 2009 | link

OCD, that be me. Closed by c8bba32

Comment
OCD, that be me. Closed by c8bba32eadc156dd6b97dd48169e1dabd6f1d5fd
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

Shaman/Warlock Weapon Buffs
8 comments Created 6 months ago by Jimmerz28

Title

Body
Would it be possible to allow support to Cork for displaying when Shaman (Earthliving, Windfury, Flametongue, Icebrand, Rockbiter) / Warlock (Spellstone, Firestone) weapon buffs run out? Thanks for the great addon!
or cancel

Would it be possible to allow support to Cork for displaying when Shaman (Earthliving, Windfury, Flametongue, Icebrand, Rockbiter) / Warlock (Spellstone, Firestone) weapon buffs run out?

Thanks for the great addon!

Comments

tekkub Wed Jun 24 14:12:18 -0700 2009 | link

This has been a longstanding issue with Blizzard's API. The weapon buff icons poll for the buff OnUpdate (every rendered frame)... there are no events fried consistently when the weapon buff is applied or wears off. I really don't like polling for a buff, it feels oh so dirty, so I've not made this module...

It's on the todo, just not likely to be done until I find a way to do it without constant polling.

Comment
This has been a longstanding issue with Blizzard's API. The weapon buff icons poll for the buff OnUpdate (every rendered frame)... there are no events fried consistently when the weapon buff is applied or wears off. I *really* don't like polling for a buff, it feels oh so dirty, so I've not made this module... It's on the todo, just not likely to be done until I find a way to do it without constant polling.
or cancel

tekkub Wed Jun 24 23:48:28 -0700 2009 | link

Shaman's in, will look at locks later. I assume a two-step process is needed for locks? Create stone if you don't have one, use stone if you do?

Comment
Shaman's in, will look at locks later. I assume a two-step process is needed for locks? Create stone if you don't have one, use stone if you do?
or cancel

tekkub Thu Jun 25 00:06:23 -0700 2009 | link

Meh, fuckit, I've got a lock on the PTR and it's mostly a copy-paste jorb.

Comment
Meh, fuckit, I've got a lock on the PTR and it's mostly a copy-paste jorb.
or cancel

tekkub Thu Jun 25 00:06:35 -0700 2009 | link

Warlock temp enchant module too!

Closed by 41d5675

Comment
Warlock temp enchant module too! Closed by 41d5675eb135bdad17f52b7745be237e6b147cb3
or cancel

Jimmerz28 Thu Jun 25 12:35:31 -0700 2009 | link

Ooo sweet! I'll check it out now!

Comment
Ooo sweet! I'll check it out now!
or cancel

Jimmerz28 Thu Jun 25 17:54:03 -0700 2009 | link

Warlock weapon buff works perfectly. The shaman one, however, does not show up. The two bars in the cork menu (I assume one for MH and one for OH) show up and I can select which weapon buff I want, but they do not show up as being needed on the cork screen. I buffed my weapon and right clicked it off and changed weapons to make sure but they still did not show up. Thanks!

Comment
Warlock weapon buff works perfectly. The shaman one, however, does not show up. The two bars in the cork menu (I assume one for MH and one for OH) show up and I can select which weapon buff I want, but they do not show up as being needed on the cork screen. I buffed my weapon and right clicked it off and changed weapons to make sure but they still did not show up. Thanks!
or cancel

tekkub Thu Jun 25 19:37:07 -0700 2009 | link

Any errors? I coded it on the PTR (only place I could get a shaman and lock to test with)... but the code should work on 3.1

Comment
Any errors? I coded it on the PTR (only place I could get a shaman and lock to test with)... but the code should work on 3.1
or cancel

ambethia Tue Sep 08 13:10:34 -0700 2009 | link

Main hand buffing works, but the off hand for enhancement shamans never gets rebuffed.

Comment
Main hand buffing works, but the off hand for enhancement shamans never gets rebuffed.
or cancel

Parsed with GitHub Flavored Markdown
6.

0 votes

reminder list oddities
2 comments Created 6 months ago by Pusikas

Title

Body
The reminder list can be a bit annoying when it tells you to buff things that can't be buffed or when I am in a vehicle. The flame leviathan fight is a good example. It tells me to buff people that sit in a vehicle and tells me to buff vehicles that are not buffable. Possible workarounds might be not to show the reminder list while oneself is in a vehicle. Also, I bound the ,-key to cork, and I saw some strange behaviour while using it. While on my paladin, the reminder list showed me missing a food buff and Righteous Fury. When I hit the ,-key, cork buffed me Greater Blessing of Sanctuary. Additional key-hitting did not buff me anything and Righteous Fury did not disappear from the list until I rebuffed it by hand.
or cancel

The reminder list can be a bit annoying when it tells you to buff things that can't be buffed or when I am in a vehicle. The flame leviathan fight is a good example. It tells me to buff people that sit in a vehicle and tells me to buff vehicles that are not buffable.
Possible workarounds might be not to show the reminder list while oneself is in a vehicle.

Also, I bound the ,-key to cork, and I saw some strange behaviour while using it. While on my paladin, the reminder list showed me missing a food buff and Righteous Fury. When I hit the ,-key, cork buffed me Greater Blessing of Sanctuary. Additional key-hitting did not buff me anything and Righteous Fury did not disappear from the list until I rebuffed it by hand.

Comments

tekkub Wed Jun 24 14:14:19 -0700 2009 | link

Hiding when in a vehicle is probably the best option, however there's the case of the demolisher in Wintergrasp where you CAN cast if you're in the front seats. Now, you're likely to have Cork off in WG, but are there other vehicles where you can sit in them and cast? I'm not in Ulduar, nor do I do the battlegrounds (which is of course where vehicles seem to be used the most).

Comment
Hiding when in a vehicle is probably the best option, however there's the case of the demolisher in Wintergrasp where you CAN cast if you're in the front seats. Now, you're likely to have Cork off in WG, but are there other vehicles where you can sit in them and cast? I'm not in Ulduar, nor do I do the battlegrounds (which is of course where vehicles seem to be used the most).
or cancel

tekkub Sat Jul 25 20:00:46 -0700 2009 | link

Closed pending feedback.

Comment
Closed pending feedback.
or cancel

Parsed with GitHub Flavored Markdown
7.

1 vote

LastBuffedBuffer Template UnitAura 3.1 update
2 comments Created 6 months ago by Sano

Title

Body
As of 3.1 UnitAura no longer returns the isMine boolean, but rather the casting unit. Totally dry coded, but this should fix the problem(is there a way to attach diff files?): http://paste.wowace.com/838/
or cancel

As of 3.1 UnitAura no longer returns the isMine boolean, but rather the casting unit. Totally dry coded, but this should fix the problem(is there a way to attach diff files?):

http://paste.wowace.com/838/

Comments

tekkub Sun Sep 20 23:32:02 -0700 2009 | link

UnitAura doesn't do isMine anymore

Closed by 5b57fbf

Comment
UnitAura doesn't do isMine anymore Closed by 5b57fbfd1d6a908c50085395f9091a94b27df3b9
or cancel

tekkub Sun Sep 20 23:32:29 -0700 2009 | link

Protip: patches rarely apply cleanly, and forking on GitHub is trivially easy.

Comment
Protip: patches rarely apply cleanly, and forking on GitHub is trivially easy.
or cancel

Parsed with GitHub Flavored Markdown
8.

1 vote

Cork buff macro not working for priest buffs
1 comment Created 6 months ago by pris

Title

Body
Macro for priest buffs isnt working as far as I can tell. I hit it completely unbuffed and nothing happens. Doesnt seem to work in groups either. Tried modifying the threshold and nothing happens. Has this been modified to be a raid only mod?
or cancel

Macro for priest buffs isnt working as far as I can tell. I hit it completely unbuffed and nothing happens. Doesnt seem to work in groups either. Tried modifying the threshold and nothing happens. Has this been modified to be a raid only mod?

Comments

tekkub Sat Jul 25 20:02:10 -0700 2009 | link

Works fine for me. Is the tooltip showing any missing buffs?

Comment
Works fine for me. Is the tooltip showing any missing buffs?
or cancel

Parsed with GitHub Flavored Markdown
9.

0 votes

3.1.0.23-Beta: Extra "player" unitID shown
2 comments Created 5 months ago by HunterZ

Title

Body
For some reason, an extra "player" label is showing with the top item on the Cork frame whenever something is being shown. It's appearing above the place where the normal "player" label is shown. Update: I'm setting the "player" label by itself sometimes now too. Disabling the show UnitID option makes it disappear, but of course that's suboptimal since it turns off all the UnitID labels that are supposed to be there as well.
or cancel

For some reason, an extra "player" label is showing with the top item on the Cork frame whenever something is being shown. It's appearing above the place where the normal "player" label is shown.

Update: I'm setting the "player" label by itself sometimes now too.

Disabling the show UnitID option makes it disappear, but of course that's suboptimal since it turns off all the UnitID labels that are supposed to be there as well.

Comments

HunterZ Mon Jul 27 07:55:21 -0700 2009 | link

Oops, I meant that I'm seeing the "player" label by itself sometimes.

Comment
Oops, I meant that I'm *seeing* the "player" label by itself sometimes.
or cancel

tekkub Sun Sep 20 23:33:26 -0700 2009 | link

Hrm.. I've never encountered this, but I also have unitIDs off.

Comment
Hrm.. I've never encountered this, but I also have unitIDs off.
or cancel

Parsed with GitHub Flavored Markdown
10.

2 votes

Well Fed Macro Drop Target not working
2 comments Created 5 months ago by ergh99

Title

Body
The first attempt in a play session pops open the empty text box as if the button was clicked and generates the following message: [2009/07/28 03:18:27-106-x1]: Cork-3.1.0.23\modules\WellFed.lua:54: Usage: <unnamed>:SetText("text") Cork-3.1.0.23\modules\WellFed.lua:54: in function <Interface\AddOns\Cork\modules\WellFed.lua:54> <in C code>: in function `Show' Cork-3.1.0.23\modules\WellFed.lua:63: in function <Interface\AddOns\Cork\modules\WellFed.lua:63> Subsequent attempts exhibit the same "click" behavior but do not generate an error. Neither method auto-generates a macro. Tested with Edible Fern by Hodox of Moonrunner
or cancel
The first attempt in a play session pops open the empty text box as if the button was clicked and generates the following message:
[2009/07/28 03:18:27-106-x1]: Cork-3.1.0.23\modules\WellFed.lua:54: Usage: :SetText("text") Cork-3.1.0.23\modules\WellFed.lua:54: in function <Interface\AddOns\Cork\modules\WellFed.lua:54>
: in function `Show'
Cork-3.1.0.23\modules\WellFed.lua:63: in function <Interface\AddOns\Cork\modules\WellFed.lua:63>

Subsequent attempts exhibit the same "click" behavior but do not generate an error. Neither method auto-generates a macro.

Tested with Edible Fern by Hodox of Moonrunner

Comments
Zidomo Wed Jul 29 21:14:23 -0700 2009 | link
Identical bug here. Cork 3.1.0.23-Beta, USEnglish client/server, WoW 3.1.3 live. Click the "Macro" button on the right side directly across from the "Well Fed" checkbox (and I had it checked), nothing happens and the above error is thrown up. Here it is again from BugGrabber:

["message"] = "Cork-3.1.0.23\modules\WellFed.lua:54: Usage: :SetText("text")\nCork-3.1.0.23\modules\WellFed.lua:54: in function <Interface\AddOns\Cork\modules\WellFed.lua:54>\n: in function `Show'\nCork-3.1.0.23\modules\WellFed.lua:63: in function <Interface\AddOns\Cork\modules\WellFed.lua:63>\n\n ---"

["type"] = "error" ["counter"] = 1

The other "Macro" button in options--on the right side across from the word "Modules"--makes a macro & provides a droppable icon on your mouse cursor without issues.
Comment
Identical bug here. Cork 3.1.0.23-Beta, USEnglish client/server, WoW 3.1.3 live. Click the "Macro" button on the right side directly across from the "Well Fed" checkbox (and I had it checked), nothing happens and the above error is thrown up. Here it is again from BugGrabber: ["message"] = "Cork-3.1.0.23\\modules\\WellFed.lua:54: Usage: <unnamed>:SetText(\"text\")\nCork-3.1.0.23\\modules\\WellFed.lua:54: in function <Interface\\AddOns\\Cork\\modules\\WellFed.lua:54>\n<in C code>: in function `Show'\nCork-3.1.0.23\\modules\\WellFed.lua:63: in function <Interface\\AddOns\\Cork\\modules\\WellFed.lua:63>\n\n ---" ["type"] = "error" ["counter"] = 1 The other "Macro" button in options--on the right side across from the word "Modules"--makes a macro & provides a droppable icon on your mouse cursor without issues.
or cancel
tekkub Thu Sep 24 00:02:21 -0700 2009 | link

Default blank macro would be a good thing.

Closed by d802b52

Comment
Default blank macro would be a good thing. Closed by d802b52495d0606d907be4a186ab54a2b149401a
or cancel

Parsed with GitHub Flavored Markdown
11.

0 votes

Missing Rogue buffs
2 comments Created 4 months ago by Muiric

Title

Body
Please could you add Slice and Dice and Hunger for Blood for rogues?
or cancel

Please could you add Slice and Dice and Hunger for Blood for rogues?

Comments

tekkub Sun Aug 09 12:50:25 -0700 2009 | link

Cork really isn't designed for short-term in-combat buffs I'm afraid. The entire design is built around 1-click buffing, which simply doesn't work in combat.

Comment
Cork really isn't designed for short-term in-combat buffs I'm afraid. The entire design is built around 1-click buffing, which simply doesn't work in combat.
or cancel

Muiric Mon Aug 10 01:01:59 -0700 2009 | link

Fair enough I'll continue to search for something simple to do this, worth a shot asking though. ;)

Comment
Fair enough I'll continue to search for something simple to do this, worth a shot asking though. ;)
or cancel

Parsed with GitHub Flavored Markdown
12.

0 votes

Errors when party/raid member joins
0 comments Created 4 months ago by Muiric

Title

Body
Whenever someone joins the party/raid who is not in range I get the below error. Not certain if this is a known issue or a conflict, but thought that I'd better report it just in case. *** Error Message *** Message: Interface\AddOns\Cork\modules\PaladinBlessings.lua:73: attempt to concatenate local 'class' (a nil value) Time: 08/11/09 20:37:10 Count: 2 Stack: [string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:18: in function <[string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:4> (tail call): ? Interface\AddOns\Cork\modules\PaladinBlessings.lua:73: in function <Interface\AddOns\Cork\modules\PaladinBlessings.lua:69> Interface\AddOns\Cork\templates\RaidBuffer.lua:84: in function <Interface\AddOns\Cork\templates\RaidBuffer.lua:84> [string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4> [C]: ? [string "safecall Dispatcher[1]"]:13: in function `?' ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire' Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:118> Locals: No locals to dump
or cancel

Whenever someone joins the party/raid who is not in range I get the below error. Not certain if this is a known issue or a conflict, but thought that I'd better report it just in case.

Error Message

Message: Interface\AddOns\Cork\modules\PaladinBlessings.lua:73: attempt to concatenate local 'class' (a nil value)
Time: 08/11/09 20:37:10
Count: 2
Stack: [string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:18: in function <[string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:4>
(tail call): ? Interface\AddOns\Cork\modules\PaladinBlessings.lua:73: in function <Interface\AddOns\Cork\modules\PaladinBlessings.lua:69>
Interface\AddOns\Cork\templates\RaidBuffer.lua:84: in function <Interface\AddOns\Cork\templates\RaidBuffer.lua:84>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4> [C]: ? [string "safecall Dispatcher[1]"]:13: in function ?' ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in functionFire' Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:118>

Locals: No locals to dump

Comments

Parsed with GitHub Flavored Markdown
13.

0 votes

Could we get an in-combat check for the display added to this?
2 comments Created 3 months ago by Zidomo

Title

Body
This is a great, lightweight alternative to other persistently buggy and/or bloated buff check mods (ZOMGBuffs, SmartBuff, Buffwatch++, etc.). Except for one thing. The (way too large) Cork buff alert frames alerting and/or not going away in combat. Due to its current behavior, I (and I'm sure others) can't use the mod. Could likely live with the alert frames being as large as they are if they only displayed out of combat. But when people/pets/mage-mirror-images/etc. that are missing buffs prompt the alert frames to come up in combat, its a bit too much. So either a (preferable) don't-display-in-combat option and/or a change to the alert frames to make them a lot smaller (i.e. a single "icon" frame like SmartBuff & ZOMGBuffs have, etc. or similar) would be a big improvement. Other than this, the mod is perfect :).
or cancel

This is a great, lightweight alternative to other persistently buggy and/or bloated buff check mods (ZOMGBuffs, SmartBuff, Buffwatch++, etc.).

Except for one thing. The (way too large) Cork buff alert frames alerting and/or not going away in combat. Due to its current behavior, I (and I'm sure others) can't use the mod.

Could likely live with the alert frames being as large as they are if they only displayed out of combat. But when people/pets/mage-mirror-images/etc. that are missing buffs prompt the alert frames to come up in combat, its a bit too much.

So either a (preferable) don't-display-in-combat option and/or a change to the alert frames to make them a lot smaller (i.e. a single "icon" frame like SmartBuff & ZOMGBuffs have, etc. or similar) would be a big improvement. Other than this, the mod is perfect :).

Comments

tekkub Sun Sep 20 23:25:20 -0700 2009 | link

Sorry but the design is intended to be annoying, to make it go away you cast the needed buffs. If pets are a problem, turn them off.

Comment
Sorry but the design is intended to be annoying, to make it go away you cast the needed buffs. If pets are a problem, turn them off.
or cancel

Zidomo Mon Sep 21 10:22:33 -0700 2009 | link

Sorry to hear. Buff reminders for others being annoying may be fine out of combat, but its certainly not appropriate in combat, whether a player, pet or anything else. Ah well, will have to use/recommend-to-others something else.

Comment
Sorry to hear. Buff reminders for others being annoying may be fine out of combat, but its certainly not appropriate in combat, whether a player, pet or anything else. Ah well, will have to use/recommend-to-others something else.
or cancel

Parsed with GitHub Flavored Markdown
14.

1 vote

Wheel scrolling
3 comments Created 3 months ago by senryo

Title

Body
Can you add wheel scrolling by pressing down right mouse button when using "Bind mouse wheel"?
or cancel

Can you add wheel scrolling by pressing down right mouse button when using "Bind mouse wheel"?

Comments

tekkub Sun Sep 20 23:26:12 -0700 2009 | link

The game doesn't let you bind the right click like that.

Comment
The game doesn't let you bind the right click like that.
or cancel

senryo Mon Sep 21 16:08:58 -0700 2009 | link

I think you misunderstood me. I meant something like "Camera Zoom!" here - http://www.wowinterface.com/downloads/info9499-O-Wheely-BuffsandMacrosonyourMousewheel.html
I need it because food macro doesn't work for me and thus blocking zoom with mousewheel.
ErrorLog:
Interface\AddOns\Cork\modules\WellFed.lua:54: Usage: :SetText("text")
Count: 1

Call Stack:
(tail call): ? [C]: ? [C]: in function SetText' Interface\AddOns\Cork\modules\WellFed.lua:54: in function <Interface\AddOns\Cork\modules\WellFed.lua:54><br/> [C]: in functionShow' Interface\AddOns\Cork\modules\WellFed.lua:63: in function <Interface\AddOns\Cork\modules\WellFed.lua:63>

This shows when i try to make food macro.

Comment
I think you misunderstood me. I meant something like "Camera Zoom!" here - http://www.wowinterface.com/downloads/info9499-O-Wheely-BuffsandMacrosonyourMousewheel.html I need it because food macro doesn't work for me and thus blocking zoom with mousewheel. ErrorLog: Interface\AddOns\Cork\modules\WellFed.lua:54: Usage: <unnamed>:SetText("text") Count: 1 Call Stack: (tail call): ? [C]: ? [C]: in function `SetText' Interface\AddOns\Cork\modules\WellFed.lua:54: in function <Interface\AddOns\Cork\modules\WellFed.lua:54> [C]: in function `Show' Interface\AddOns\Cork\modules\WellFed.lua:63: in function <Interface\AddOns\Cork\modules\WellFed.lua:63> This shows when i try to make food macro.
or cancel

tekkub Wed Sep 23 23:53:05 -0700 2009 | link

Hrm... I see what they're doing but it would require significant changes to my code to make that work. If I fix the well fed bug, would that be sufficient?

Comment
Hrm... I see what they're doing but it would require significant changes to my code to make that work. If I fix the well fed bug, would that be sufficient?
or cancel

Parsed with GitHub Flavored Markdown
15.

0 votes

LDB Support
1 comment Created 3 months ago by predhme

Title

Body
Is it possible to use an LDB display for cork? Possibly have the display text be the amount of missing buffs? Just a thought?
or cancel

Is it possible to use an LDB display for cork? Possibly have the display text be the amount of missing buffs? Just a thought?

Comments

tekkub Sat Sep 26 01:30:53 -0700 2009 | link

I have no plans for this, cork isn't intended to be an always-up display.

Comment
I have no plans for this, cork isn't intended to be an always-up display.
or cancel

Parsed with GitHub Flavored Markdown
16.

0 votes

Brewfest Modules
1 comment Created 3 months ago by Wobin

Title

Body
I have one for the ram riding and the tankard tossing, mostly to take advantage of the mousewheel binding so we don't get RSI clicking the damn thing. Pull request sent. I hope it all worked with random githubbing and everything.
or cancel

I have one for the ram riding and the tankard tossing, mostly to take advantage of the mousewheel binding so we don't get RSI clicking the damn thing. Pull request sent. I hope it all worked with random githubbing and everything.

Comments

tekkub Thu Sep 24 15:09:17 -0700 2009 | link

Haha, that so doesn't belong in Cork and I think you know it. You should rip out everything else and make this into it's own little standalone addon specifically for brewfest. Hell maybe even something along the lines of I Has Macro LOL using Cork's base engine... that could be useful actually...

Comment
Haha, that *so* doesn't belong in Cork and I think you know it. You should rip out everything else and make this into it's own little standalone addon specifically for brewfest. Hell maybe even something along the lines of I Has Macro LOL using Cork's base engine... that could be useful actually...
or cancel

Parsed with GitHub Flavored Markdown
17.

0 votes

Pally power syncing
2 comments Created 3 months ago by predhme

Title

Body
Not sure if you would even dare to try and implement this, but cork has proven to be a much nicer solution for me to independently track buffs, auras, and seals (instead of pally power or zomgbuffs). It would be nice if it synced up with other pally's :)
or cancel

Not sure if you would even dare to try and implement this, but cork has proven to be a much nicer solution for me to independently track buffs, auras, and seals (instead of pally power or zomgbuffs). It would be nice if it synced up with other pally's :)

Comments

predhme Fri Sep 25 09:13:52 -0700 2009 | link

PaladinBuffer has a decent syncing module. Probably could pull from that

Comment
[PaladinBuffer](http://github.com/Shadowed/PaladinBuffer/blob/master/sync.lua) has a decent syncing module. Probably could pull from that
or cancel

tekkub Fri Sep 25 14:16:35 -0700 2009 | link

I won't add syncing, sorry. It's unnecessary complexity, I find "hey Otherpally, you grab kings and judge light" works just fine. Blessings and judgements aren't the complex nightmare they used to be... back then syncing was needed, now it's not.

Comment
I won't add syncing, sorry. It's unnecessary complexity, I find "hey Otherpally, you grab kings and judge light" works just fine. Blessings and judgements aren't the complex nightmare they used to be... back then syncing was needed, now it's not.
or cancel

Parsed with GitHub Flavored Markdown
18.

0 votes

new caster nil check for lastbuffedbuffer template
1 comment Created 3 months ago by Sano

Title

Body
forked fix here: http://github.com/Sano/cork/blob/master/templates/LastBuffedBuffer.lua
or cancel

forked fix here:

http://github.com/Sano/cork/blob/master/templates/LastBuffedBuffer.lua

Comments

tekkub Sat Sep 26 01:29:10 -0700 2009 | link

Nilly Willy

Closed by 15050e9

Comment
Nilly Willy Closed by 15050e99743444ba99cd7bb75729b1b5430d7c03
or cancel

Parsed with GitHub Flavored Markdown
19.

0 votes

"Show toolip in BG" checkbox not updated
1 comment Created 2 months ago by Adirelle

Title

Body
When opening the configuration GUI, the "Show toolip in BG" checkbox is not updated according to the settings. Easily fixed using this : http://github.com/Adirelle/cork/commit/df8caeb330736cb02e12000ba5b233e8ea451241
or cancel

When opening the configuration GUI, the "Show toolip in BG" checkbox is not updated according to the settings.

Easily fixed using this : http://github.com/Adirelle/cork/commit/df8caeb330736cb02e12000ba5b233e8ea451241

Comments

tekkub Mon Oct 05 19:30:19 -0700 2009 | link

Pull't

Comment
Pull't
or cancel

Parsed with GitHub Flavored Markdown
20.

0 votes

reapply before actually expiring
2 comments Created 2 months ago by predhme

Title

Body
when applying buffs to other members of the raid/group or even solo. it would be nice to have cork rebuff before the buff actually expires. ie. recast blessing of wisdom when there is < 1 minute on the timer.
or cancel

when applying buffs to other members of the raid/group or even solo. it would be nice to have cork rebuff before the buff actually expires. ie. recast blessing of wisdom when there is < 1 minute on the timer.

Comments

tekkub Mon Oct 19 13:17:58 -0700 2009 | link

I'm not going to start tracking buff times, that's far too complicated for this addon. If people want rebuffs, I tell them to just cancel the buff so that it shows up on my side.

Comment
I'm not going to start tracking buff times, that's far too complicated for this addon. If people want rebuffs, I tell them to just cancel the buff so that it shows up on my side.
or cancel

predhme Mon Oct 19 13:23:10 -0700 2009 | link

what about at least for self buffs?

Comment
what about at least for self buffs?
or cancel

Parsed with GitHub Flavored Markdown
21.

0 votes

Molten Armor
1 comment Created about 1 month ago by leks0d

Title

Body
Seems Molten Armor buff check is broken. Version: 3.2.0.26-Beta
or cancel

Seems Molten Armor buff check is broken.
Version: 3.2.0.26-Beta

Comments

EthanCentaurai Thu Nov 26 13:03:15 -0800 2009 | link

How is it broken? Addon authours are not psychic and saying "is broken" won't do anyone any help.

Comment
How is it broken? Addon authours are not psychic and saying "is broken" won't do anyone any help.
or cancel

Parsed with GitHub Flavored Markdown
22.

0 votes

Trueshot Aura module should recognize equivalent Shaman and DK buffs
1 comment Created about 1 month ago by HunterZ

Title

Body
Thanks to Blizzard's asinine logic, Shamans' Unleashed Rage and DKs' Abominable Might proc/crit-based buffs temporarily overwrite/suppress Hunters' supposedly persistent Trueshot Aura (all 3 buffs give +10% AP). As a result, Cork erroneously notifies me that I need to re-cast TSA when UR/AM is active even though TSA is merely being suppressed and will automatically return once UR/AM fades. Other than the fact that it would appear to be a nontrivial change, Cork's TSA module ought to recognize that TSA cannot be cast when UR or AM is active and suppress its warning accordingly.
or cancel

Thanks to Blizzard's asinine logic, Shamans' Unleashed Rage and DKs' Abominable Might proc/crit-based buffs temporarily overwrite/suppress Hunters' supposedly persistent Trueshot Aura (all 3 buffs give +10% AP). As a result, Cork erroneously notifies me that I need to re-cast TSA when UR/AM is active even though TSA is merely being suppressed and will automatically return once UR/AM fades.

Other than the fact that it would appear to be a nontrivial change, Cork's TSA module ought to recognize that TSA cannot be cast when UR or AM is active and suppress its warning accordingly.

Comments

tekkub Sat Nov 14 22:57:45 -0800 2009 | link

Add exclusions to self buffer... fix hunter trueshot (doesn't stack with unleashed rage or abom might)

Closed by fafeddf

Comment
Add exclusions to self buffer... fix hunter trueshot (doesn't stack with unleashed rage or abom might) Closed by fafeddf406bfedaa613754c1ea92773cd0c1c086
or cancel

Parsed with GitHub Flavored Markdown
23.

0 votes

Horn of Winter and Totems
1 comment Created about 1 month ago by EthanCentaurai

Title

Body
The Death Knigget's ability "Horn of Winter" does not stack and is overwritten by the Shaman's ability "Strength of Earth Totem". Can you add a check for this similar to the Trueshot Aura check? Thanks.
or cancel

The Death Knigget's ability "Horn of Winter" does not stack and is overwritten by the Shaman's ability "Strength of Earth Totem". Can you add a check for this similar to the Trueshot Aura check?

Thanks.

Comments

tekkub Fri Nov 27 15:51:39 -0800 2009 | link

Horn of Winter and Strength of Earth dun stack

Closed by c67bb47

Comment
Horn of Winter and Strength of Earth dun stack Closed by c67bb4726317b1c399d0a1975c5e90cfc8255346
or cancel

Parsed with GitHub Flavored Markdown
26.

0 votes

Shaman weapon buffs do not work for items restricted to offhand
2 comments Created 16 days ago by jf647

Title

Body
For enhancement shaman, Cork does not remind them to buff their off-hand weapon if that weapon is limited to off-hand usage. The issue is the comparison in OnUpdate of ShamanWeapon.lua: the mainhand check can be paraphrased as "if there's something that looks like a weapon in the mainhand, buff it". The offhand check is subtley different, more like "if there's a one-handed weapon in the offhand, buff it". This works to not attempt to buff a shield or a trout, but fails to buff anything that is specifically marked as offhand (because that has a different slot name returned by GetItemInfo(). I've created a patch, which can be found at http://nadt.net/stuff/ShamanWeapon.lua.patch What this does it compare the slot location of the offhand against both INVTYPE_WEAPON and INVTYPE_OFFHANDWEAPON. I've tested this by getting two one-handed daggers and a pair of fist weapons (which are restricted to main/off use). With the release version, Cork offers to buff both the daggers, but only the mainhand fist weapon. With my patched version, Cork offers to buff all four weapons. My patch also makes the mainhand check work the same as the offhand check (undoing the short-circuit that admittedly allowed mainhand restricted weapons to work so far). This just feels cleaner to me, but the patch will work if you only take the chunk that modifies the offhand weapon check. Cheers
or cancel

For enhancement shaman, Cork does not remind them to buff their off-hand weapon if that weapon is limited to off-hand usage.

The issue is the comparison in OnUpdate of ShamanWeapon.lua: the mainhand check can be paraphrased as "if there's something that looks like a weapon in the mainhand, buff it". The offhand check is subtley different, more like "if there's a one-handed weapon in the offhand, buff it". This works to not attempt to buff a shield or a trout, but fails to buff anything that is specifically marked as offhand (because that has a different slot name returned by GetItemInfo().

I've created a patch, which can be found at

http://nadt.net/stuff/ShamanWeapon.lua.patch

What this does it compare the slot location of the offhand against both INVTYPE_WEAPON and INVTYPE_OFFHANDWEAPON.

I've tested this by getting two one-handed daggers and a pair of fist weapons (which are restricted to main/off use). With the release version, Cork offers to buff both the daggers, but only the mainhand fist weapon. With my patched version, Cork offers to buff all four weapons.

My patch also makes the mainhand check work the same as the offhand check (undoing the short-circuit that admittedly allowed mainhand restricted weapons to work so far). This just feels cleaner to me, but the patch will work if you only take the chunk that modifies the offhand weapon check.

Cheers

Comments

tekkub Sun Dec 20 13:54:57 -0800 2009 | link

sigh patch files never work without excess effort. You should just fork here on GitHub, that always works painlessly.

Comment
*sigh* patch files never work without excess effort. You should just fork here on GitHub, that always works painlessly.
or cancel

tekkub Sun Dec 20 14:07:11 -0800 2009 | link

Fix shaman offhands that are offhand only

Closed by c97c4d3

Comment
Fix shaman offhands that are offhand *only* Closed by c97c4d3147ab4288de1299ead5b10402df0ead1f
or cancel

Parsed with GitHub Flavored Markdown
27.

0 votes

Giant Darkwater Clam
1 comment Created 15 days ago by senryo

Title

Body
Can you add support for Giant Darkwater Clam - http://www.wowhead.com/?item=45909?
or cancel

Can you add support for Giant Darkwater Clam - http://www.wowhead.com/?item=45909?

Comments

tekkub Sun Dec 20 14:07:11 -0800 2009 | link

New clam

Closed by 5065486

Comment
New clam Closed by 506548620884b377167e78482201ba22a63c1e3d
or cancel

Parsed with GitHub Flavored Markdown
28.

0 votes

Fished crates
3 comments Created 15 days ago by senryo

Title

Body
Can you add support for autoopening fished crates similar to clamshells?
or cancel

Can you add support for autoopening fished crates similar to clamshells?

Comments

tekkub Sun Dec 20 13:43:40 -0800 2009 | link

Could you link my to a list of them on wowhead or such? I don't really fish much.

Comment
Could you link my to a list of them on wowhead or such? I don't really fish much.
or cancel

senryo Mon Dec 21 09:39:30 -0800 2009 | link

Dented Crate - http://www.wowhead.com/?item=6351
Waterlogged Crate - http://www.wowhead.com/?item=6352
Sealed Crate - http://www.wowhead.com/?item=6357
Heavy Crate - http://www.wowhead.com/?item=13874
Curious Crate - http://www.wowhead.com/?item=27513
Heavy Supply Crate - http://www.wowhead.com/?item=27481
Reinforced Crate - http://www.wowhead.com/?item=44475

Maybe there are some more but i can't remember.

Comment
Dented Crate - http://www.wowhead.com/?item=6351 Waterlogged Crate - http://www.wowhead.com/?item=6352 Sealed Crate - http://www.wowhead.com/?item=6357 Heavy Crate - http://www.wowhead.com/?item=13874 Curious Crate - http://www.wowhead.com/?item=27513 Heavy Supply Crate - http://www.wowhead.com/?item=27481 Reinforced Crate - http://www.wowhead.com/?item=44475 Maybe there are some more but i can't remember.
or cancel

tekkub Thu Dec 24 14:41:22 -0800 2009 | link

Add fished crates

Closed by 471c7b7

Comment
Add fished crates Closed by 471c7b7229cd85429cb5ed4443d069b380814ee6
or cancel

Parsed with GitHub Flavored Markdown
29.

0 votes

Warlock Soulstone / Rogue Poisons?
1 comment Created 11 days ago by Mookus

Title

Body
Hiya - was wondering if you had any plans to include reminders for Warlock's "Soulstone Resurrection" buff and/or Rogue main- and off-hand poisons? Great AddOn, very useful!
or cancel

Hiya - was wondering if you had any plans to include reminders for Warlock's "Soulstone Resurrection" buff and/or Rogue main- and off-hand poisons?

Great AddOn, very useful!

Comments

tekkub Sun Dec 20 13:43:09 -0800 2009 | link

Soulstone I've gotten working locally, it'll go out soon enough. I do not play rogue, and never will, so someone else would have to write that module. There is a shaman module that can likely be adapted.

Comment
Soulstone I've gotten working locally, it'll go out soon enough. I do not play rogue, and never will, so someone else would have to write that module. There is a shaman module that can likely be adapted.
or cancel

Parsed with GitHub Flavored Markdown
24.

0 votes

Exclude vehciles from tooltip
1 comment Created 19 days ago by rulez

Title

Body
Any chance to exclude vehicles from the tooltip? For example the horses you use for the quest Taking The Battle To The Enemy. You can't even buff them ;).
or cancel

Any chance to exclude vehicles from the tooltip? For example the horses you use for the quest Taking The Battle To The Enemy. You can't even buff them ;).

Comments

rulez Wed Dec 09 09:38:54 -0800 2009 | link

The quest name should of course be "Battle Before the Citadel".

Comment
The quest name should of course be "Battle Before the Citadel".
or cancel

Parsed with GitHub Flavored Markdown
25.

0 votes

Flask of the North
0 comments Created 19 days ago by rulez

Title

Body
Please include the Flask of the North (id=47499), thanks :).
or cancel

Please include the Flask of the North (id=47499), thanks :).

Comments

Parsed with GitHub Flavored Markdown
30.

0 votes

Pull request - mana gems
0 comments Created 8 days ago by tekkub

Title

Body
> I've never used this before, but hopefully I'm doing it right. You can merge in my changes to add support for refilling mana gems when they've been used. http://github.com/fryguy1013/cork/tree/master
or cancel

I've never used this before, but hopefully I'm doing it right. You can merge in my changes to add support for refilling mana gems when they've been used.

http://github.com/fryguy1013/cork/tree/master

Comments

Parsed with GitHub Flavored Markdown