tekkub / GoodNewsEveryone

I'm voting against this. This is hardly a reactive ability.

Yeah, sure... Lightweave is "a chance to increase your spell power by 295 for 15 sec when casting a spell."

Meaning... recast all your DoTs 'cuz they'll tick for a LOT more. Sorry but it is reactive.

I'm aware of that. But in most cases it's a loss of DPS to refresh DoTs that haven't run out.

Brain > all. I want to be warned that something procced (Lightweave in this case), then I'll decide if I have to use it or not. I have 12 seconds to use it... thus it's nice if something (GNE in this case) helps me to take the right decisions.

Cheers :)

Of course. I do understand your intent and find it perfectly valid per say. I wasn't berating you, but I don't think this is within the scope of GNE.

Have a nice one :-)

I took the liberty of incorporating this change in my fork. If tekkub finds this change should be in GNE, it'll be pulled, I guess.

I'm kinda up in the air on this one... I can see arguments for it being reactive (dots) and for it not (I have no dots to cast)... obviously the ideal situation would be to have a config, but I'm always wary of introducing a config panel.

So the question is this, for what classes is this reactive and which are passive? I'm not really much of a DPSer, but as a healer I'd generally consider this passive.

Shadow Priests and Affliction Warlocks I'd say. With my Affliction 'Lock I usually ignore this. With the Priest I could imagine reacting to this to refresh SW:P.

I have tested the Lightweave Embroidery Proc in my fork for two days and, boy is it annoying. I keep my vote: Not within the scope of GNE (in its current state). I understand that it's useful for a few, but annoying for many.

I have a friend mage that is using it. Just put the code for it in GNE... commented. Who wants to use it, can uncomment the line. The easiest configuration possible, ever. And those that doesn't know how to uncomment a line... well, probably they're not using GNE anyway.

Rune Strike won't be added because it is covered by the Blizzard scrolling combat text. Tek has said before anything covered by that won't be added to GNE. However, you can add whatever you wan to the GNE table, it's pretty easy.

ok maybe i dont understand but the only way blizz's SCT can see it is if its used. now if you dont have the action on your bar you will be unable to tell that its able to be used. As it is an ability that you will make a choice on useing as with rime or KM i believe it should be added.

You are confused, but its ok. XD To use the scrolling combat text in Blizzard, you don't have to even have action bars showing. It will actually tell you when Rune Strike is available to be used.

Press "esc" then click "Interface" then "Game" at the top left. Scroll down to "Combat Text" then on the right side, click "Enable My Floating Combat Text." Now this is where you want to select or deselect options, but for Rune Strike to be shown, make sure "Reactive Spells and Abilities" is checked. Now when Rune Strike is available to be used, "Rune Strike Ready" will scroll on your screen, or something similar. This is why Tek won't add Rune Strike to GNE.

Hope this helps you out!