@@ -321,8 +321,19 @@ var greasemonkeyService = { if (!GM_apiLeakCheck("GM_openInTab")) { return undefined; } - var newTab = chromeWin.openNewTabWith( - url, safeContentWin.document, null, null, null, null); + + var info = Cc["@mozilla.org/xre/app-info;1"] + .getService(Components.interfaces.nsIXULAppInfo); + if (parseFloat(info.version, 10) < 3.0) { + // Pre FF 3.0 wants the URL as the second argument. + var newTab = chromeWin.openNewTabWith( + url, safeContentWin.document.location.href, null, null, null, null); + } else { + // Post FF 3.0 wants the document as the second argument. + var newTab = chromeWin.openNewTabWith( + url, safeContentWin.document, null, null, null, null); + } + // Source: // http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4448 var newWindow = chromeWin.gBrowser components/greasemonkey.js 37ff12ad1c9f95492b73d6152f604ecb2dae45fc Anthony Lieuallen arantius@gmail.com http://github.com/teramako/greasemonkey-for-prism/commit/8cd73827a13f4296fada705ee2f8330e43de64ec 8cd73827a13f4296fada705ee2f8330e43de64ec 2009-09-20T08:20:05-07:00 2009-09-20T08:20:05-07:00 Pass the proper arguments for various FF versions. Detect which version of firefox we are running in, and pass the proper arguments to openNewTabWith(), as it changed across version 2 and 3. Fixes #1003 d43abf0408295ef439327b353b69c8ac559e8f20 Anthony Lieuallen arantius@gmail.com