Clean usage of assert.h

Remove unneeded include statements, remove conditional statements and replace the remaining assert.h by their standard C++ variant cassert. Signed-off-by: Stefan Weil <sw@weilnetz.de>
tesseract-ocr · Jun 21, 2018 · 112aeb9 · 112aeb9
1 parent 629a10b
commit 112aeb9
Show file tree

Hide file tree

Showing 32 changed files with 123 additions and 202 deletions.
diff --git a/src/ccmain/adaptions.cpp b/src/ccmain/adaptions.cpp
@@ -1,9 +1,9 @@
 /**********************************************************************
  * File:        adaptions.cpp  (Formerly adaptions.c)
  * Description: Functions used to adapt to blobs already confidently
- *					identified
- * Author:		Chris Newton
- * Created:		Thu Oct  7 10:17:28 BST 1993
+ *              identified
+ * Author:      Chris Newton
+ * Created:     Thu Oct  7 10:17:28 BST 1993
  *
  * (C) Copyright 1992, Hewlett-Packard Ltd.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,18 +18,15 @@
  *
  **********************************************************************/
 
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
-#include          <ctype.h>
-#include          <string.h>
-#include          "tessbox.h"
-#include          "tessvars.h"
-#include          "memry.h"
-#include          "reject.h"
-#include          "control.h"
-#include          "stopper.h"
-#include          "tesseractclass.h"
+#include <ctype.h>
+#include <string.h>
+#include "tessbox.h"
+#include "tessvars.h"
+#include "memry.h"
+#include "reject.h"
+#include "control.h"
+#include "stopper.h"
+#include "tesseractclass.h"
 
 // Include automatically generated configuration file if running autoconf.
 #ifdef HAVE_CONFIG_H

diff --git a/src/ccmain/applybox.cpp b/src/ccmain/applybox.cpp
@@ -18,11 +18,8 @@
  **********************************************************************/
 
 #include <ctype.h>
-#include <string.h>
-#ifdef __UNIX__
-#include <assert.h>
 #include <errno.h>
-#endif
+#include <string.h>
 #include "allheaders.h"
 #include "boxread.h"
 #include "chopper.h"

diff --git a/src/ccmain/control.cpp b/src/ccmain/control.cpp
@@ -27,11 +27,10 @@
 #include <string.h>
 #include <cmath>
 #ifdef __UNIX__
-#include <assert.h>
 #include <unistd.h>
-#include <errno.h>
 #endif
 #include <ctype.h>
+#include <errno.h>
 #include "callcpp.h"
 #include "control.h"
 #include "docqual.h"

diff --git a/src/ccmain/output.cpp b/src/ccmain/output.cpp
@@ -17,12 +17,11 @@
  *
  **********************************************************************/
 
-#include <string.h>
 #include <ctype.h>
+#include <errno.h>
+#include <string.h>
 #ifdef __UNIX__
-#include          <assert.h>
-#include          <unistd.h>
-#include          <errno.h>
+#include <unistd.h>
 #endif
 #include "helpers.h"
 #include "tessvars.h"

diff --git a/src/ccmain/reject.cpp b/src/ccmain/reject.cpp
@@ -17,21 +17,18 @@
  *
  **********************************************************************/
 
-#include          "tessvars.h"
-#ifdef __UNIX__
-#include          <assert.h>
-#include          <errno.h>
-#endif
-#include          "scanutils.h"
-#include          <ctype.h>
-#include          <string.h>
-#include          "genericvector.h"
-#include          "reject.h"
-#include          "control.h"
-#include          "docqual.h"
-#include          "globaloc.h"  // For err_exit.
-#include          "globals.h"
-#include          "helpers.h"
+#include "tessvars.h"
+#include "scanutils.h"
+#include <ctype.h>
+#include <errno.h>
+#include <string.h>
+#include "genericvector.h"
+#include "reject.h"
+#include "control.h"
+#include "docqual.h"
+#include "globaloc.h"  // For err_exit.
+#include "globals.h"
+#include "helpers.h"
 
 #include "tesseractclass.h"
 

diff --git a/src/ccstruct/blread.cpp b/src/ccstruct/blread.cpp
@@ -1,8 +1,8 @@
 /**********************************************************************
  * File:        blread.cpp  (Formerly pdread.c)
  * Description: Friend function of BLOCK to read the uscan pd file.
- * Author:		Ray Smith
- * Created:		Mon Mar 18 14:39:00 GMT 1991
+ * Author:      Ray Smith
+ * Created:     Mon Mar 18 14:39:00 GMT 1991
  *
  * (C) Copyright 1991, Hewlett-Packard Ltd.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,13 +17,10 @@
  *
  **********************************************************************/
 
-#include          <stdlib.h>
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
-#include          "scanutils.h"
-#include          "fileerr.h"
-#include          "blread.h"
+#include <stdlib.h>
+#include "scanutils.h"
+#include "fileerr.h"
+#include "blread.h"
 
 #define UNLV_EXT  ".uzn"  // unlv zone file
 

diff --git a/src/ccstruct/coutln.cpp b/src/ccstruct/coutln.cpp
@@ -1,8 +1,8 @@
 /**********************************************************************
  * File:        coutln.cpp  (Formerly coutline.c)
  * Description: Code for the C_OUTLINE class.
- * Author:                  Ray Smith
- * Created:                 Mon Oct 07 16:01:57 BST 1991
+ * Author:      Ray Smith
+ * Created:     Mon Oct 07 16:01:57 BST 1991
  *
  * (C) Copyright 1991, Hewlett-Packard Ltd.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,9 +19,6 @@
 
 #include <algorithm>
 #include <string.h>
-#ifdef __UNIX__
-#include <assert.h>
-#endif
 
 #include "coutln.h"
 

diff --git a/src/ccstruct/pageres.cpp b/src/ccstruct/pageres.cpp
@@ -21,13 +21,12 @@
  ** limitations under the License.
  *
  **********************************************************************/
-#include          <stdlib.h>
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
-#include          "blamer.h"
-#include          "pageres.h"
-#include          "blobs.h"
+
+#include <stdlib.h>
+#include <cassert>
+#include "blamer.h"
+#include "pageres.h"
+#include "blobs.h"
 
 ELISTIZE (BLOCK_RES)
 CLISTIZE (BLOCK_RES) ELISTIZE (ROW_RES) ELISTIZE (WERD_RES)

diff --git a/src/ccstruct/polyaprx.cpp b/src/ccstruct/polyaprx.cpp
@@ -17,14 +17,11 @@
  *
  **********************************************************************/
 
-#include          <stdio.h>
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
+#include <stdio.h>
 #define FASTEDGELENGTH    256
-#include          "polyaprx.h"
-#include          "params.h"
-#include          "tprintf.h"
+#include "polyaprx.h"
+#include "params.h"
+#include "tprintf.h"
 
 #define EXTERN
 

diff --git a/src/ccstruct/ratngs.h b/src/ccstruct/ratngs.h
@@ -20,7 +20,7 @@
 #ifndef           RATNGS_H
 #define           RATNGS_H
 
-#include <assert.h>
+#include <cassert>
 
 #include "clst.h"
 #include "elst.h"

diff --git a/src/ccstruct/rejctmap.h b/src/ccstruct/rejctmap.h
@@ -41,9 +41,6 @@ OF THIS IMPLIED TEMPORAL ORDERING OF THE FLAGS!!!!
 #ifndef           REJCTMAP_H
 #define           REJCTMAP_H
 
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
 #include <memory>
 #include "bits16.h"
 #include "errcode.h"

diff --git a/src/ccstruct/split.cpp b/src/ccstruct/split.cpp
@@ -36,10 +36,6 @@
 
 #include <algorithm>
 
-#ifdef __UNIX__
-#include <assert.h>
-#endif
-
 /*----------------------------------------------------------------------
               V a r i a b l e s
 ----------------------------------------------------------------------*/

diff --git a/src/ccutil/strngs.cpp b/src/ccutil/strngs.cpp
@@ -1,8 +1,8 @@
 /**********************************************************************
  * File:        strngs.cpp  (Formerly strings.c)
  * Description: STRING class functions.
- * Author:          Ray Smith
- * Created:         Fri Feb 15 09:13:30 GMT 1991
+ * Author:      Ray Smith
+ * Created:     Fri Feb 15 09:13:30 GMT 1991
  *
  * (C) Copyright 1991, Hewlett-Packard Ltd.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,7 +19,7 @@
 
 #include "strngs.h"
 
-#include <assert.h>
+#include <cassert>
 
 #include "errcode.h"
 #include "genericvector.h"

diff --git a/src/classify/adaptmatch.cpp b/src/classify/adaptmatch.cpp
@@ -55,13 +55,11 @@
 #include "werd.h"
 
 #include <algorithm>
+#include <cassert>
 #include <cstdio>
 #include <cstring>
 #include <cstdlib>
 #include <cmath>
-#ifdef __UNIX__
-#include <assert.h>
-#endif
 
 #define ADAPT_TEMPLATE_SUFFIX ".a"
 

diff --git a/src/cutil/callcpp.cpp b/src/cutil/callcpp.cpp
@@ -1,8 +1,8 @@
 /**********************************************************************
  * File:        callcpp.cpp
  * Description: extern C interface calling C++ from C.
- * Author:		Ray Smith
- * Created:		Sun Feb 04 20:39:23 MST 1996
+ * Author:      Ray Smith
+ * Created:     Sun Feb 04 20:39:23 MST 1996
  *
  * (C) Copyright 1996, Hewlett-Packard Co.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -22,18 +22,15 @@
 #include "config_auto.h"
 #endif
 
-#include          "errcode.h"
-#ifdef __UNIX__
-#include          <assert.h>
+#include "errcode.h"
 #include <stdarg.h>
-#endif
-#include          <time.h>
-#include          "memry.h"
-#include          "scrollview.h"
-#include          "params.h"
-#include          "callcpp.h"
-#include          "tprintf.h"
-#include          "host.h"
+#include <time.h>
+#include "memry.h"
+#include "scrollview.h"
+#include "params.h"
+#include "callcpp.h"
+#include "tprintf.h"
+#include "host.h"
 #include "unichar.h"
 
 #include <memory>

diff --git a/src/cutil/callcpp.h b/src/cutil/callcpp.h
@@ -1,8 +1,8 @@
 /**********************************************************************
  * File:        callcpp.h
  * Description: extern C interface calling C++ from C.
- * Author:		Ray Smith
- * Created:		Sun Feb 04 20:39:23 MST 1996
+ * Author:      Ray Smith
+ * Created:     Sun Feb 04 20:39:23 MST 1996
  *
  * (C) Copyright 1996, Hewlett-Packard Co.
  ** Licensed under the Apache License, Version 2.0 (the "License");
@@ -20,9 +20,6 @@
 #ifndef CALLCPP_H
 #define CALLCPP_H
 
-#ifndef __UNIX__
-#include <assert.h>
-#endif
 #include "host.h"
 #include "params.h"
 #include "unichar.h"

diff --git a/src/cutil/danerror.cpp b/src/cutil/danerror.cpp
@@ -22,9 +22,6 @@
 #include "danerror.h"
 #include "tprintf.h"
 #include "globaloc.h"
-#ifdef __UNIX__
-#include "assert.h"
-#endif
 
 #include <cstdio>
 

diff --git a/src/textord/fpchop.cpp b/src/textord/fpchop.cpp
@@ -17,16 +17,13 @@
  *
  **********************************************************************/
 
-#ifdef __UNIX__
-#include          <assert.h>
-#endif
-#include          "stderr.h"
-#include          "blobbox.h"
-#include          "statistc.h"
-#include          "drawtord.h"
-#include          "tovars.h"
-#include          "topitch.h"
-#include          "fpchop.h"
+#include "stderr.h"
+#include "blobbox.h"
+#include "statistc.h"
+#include "drawtord.h"
+#include "tovars.h"
+#include "topitch.h"
+#include "fpchop.h"
 
 // Include automatically generated configuration file if running autoconf.
 #ifdef HAVE_CONFIG_H