Commit
- Loading branch information
There are no files selected for viewing
12 comments
on commit 421e3e4
There was a problem hiding this comment.
@stweil fileio is used for training only. if it is part for tesseract lib, it cause build problem for older android version.
There was a problem hiding this comment.
fileio is also used by most unittests. make check now fails. Maybe there is another way how we can avoid the build problems for older Android versions. Which errors do you get there?
There was a problem hiding this comment.
See this discussion for a possible solution. @zdenop, if you agree, I'd revert your commit and some follow-up commits to restore the previous state (working unit tests, broken Android builds), so we can try that different solution for Android.
There was a problem hiding this comment.
If libtess is able to live without fileio, it definitely MUST be moved out.
To any place (training or unittests or both or be rewritten or whatever).
There was a problem hiding this comment.
FYI: 32bit is passed now, 64 won't - I've just made some sw changes.
I'll restore it during couple of days.
https://ci.appveyor.com/project/zdenop/tesseract/builds/26525170
There was a problem hiding this comment.
Yes, I fixed sw.c for the current code. There still remains the problem with the unittests which are currently broken. A simple solution would be to require a training build for all unittests. Then fileio can stay part of the training code. Previously a lot of unittests could be run without training code. I have no quick other solution and would prefer to spend my time on code which improves Tesseract OCR instead of handling build problems. @Shreeshrii, what do you think? Would it be acceptable to run any unittest only after a training build?
There was a problem hiding this comment.
Maybe just create small support static lib for unit tests & training tools with fileio.h/cpp?
There was a problem hiding this comment.
There was a problem hiding this comment.
Now make check can be built again. More tests depend on a training build, but there remain some which also work without training code.
There was a problem hiding this comment.
Feel free to change any build things/source files. I'll update sw accordingly, just ping me, if I miss it.
(But please update cmake on your own, I'll make sw changes based on that.)
There was a problem hiding this comment.
FYI: 32bit is passed now, 64 won't - I've just made some sw changes.
I'll restore it during couple of days.https://ci.appveyor.com/project/zdenop/tesseract/builds/26525170
Funny that build is not broken as I thought.
There was a problem hiding this comment.
small sw update:
- Added
-static-dependenciesoption, it will build all deps inside libtess (but also it will put libtess inside tess.exe =\ - First working linux build is here (after full 3 stages build - like compilers are built - gcc/clang). I'll check tess build there later.
- I've almost have macos build. (Build is there, running, but exceptions are not caught.)
So if you'd like to test sw on other platforms, having single consistent experience, it will be possible soon enough.
@egorpugin, why was fileio removed here? It looks like this causes a build failure in latest Tesseract: https://ci.appveyor.com/project/stweil/tesseract/build/job/uj34kah2x7ghn6tr.