Issues - thenduks/flot

thenduks / flot

Description:

A fork of the (awesome) 'flot' jQuery graphing/charting library.

Sort by: Priority | Votes | Last Updated

Loading…

2.

0 votes

@rfunduk
x

bug
x

Implement proper binary search in hover support.
4 comments Created 7 months ago by thenduks

Title

Body
Splitting the data in half is good, but a real binary search would scale much better.
or cancel

Splitting the data in half is good, but a real binary search would scale much better.

Comments

thenduks Thu May 07 09:37:09 -0700 2009 | link

Implement proper binary search in hover support.

by rfunduk

Comment
**Implement proper binary search in hover support.** by rfunduk
or cancel

thenduks Thu May 07 09:37:11 -0700 2009 | link

Implement proper binary search in hover support.

i implemented this (and apparently deleted without ever saving). it actually doesnt speed up the labels noticeably!

the slowness seems to be because every time there is a mousemove event, the entire image is redrawn.

this is because onMouseMove calls cleanup() which calls draw(). i dont know why the draw() call is in cleanup.... i removed it and cant see the difference.

if draw() is not called every time, it might make sense to do binsearch. and i can do that as i’ve done it once...

by brentp

Comment
**Implement proper binary search in hover support.** i implemented this (and apparently deleted without ever saving). it actually doesnt speed up the labels noticeably! the slowness seems to be because every time there is a mousemove event, the entire image is redrawn. this is because onMouseMove calls cleanup() which calls draw(). i dont know why the draw() call is in cleanup.... i removed it and cant see the difference. if draw() is not called every time, it _might_ make sense to do binsearch. and i can do that as i’ve done it once... by brentp
or cancel

thenduks Thu May 07 09:37:14 -0700 2009 | link

Implement proper binary search in hover support.

cleanup() needs to be called, here’s why:

When you hover over a point you get a callback in which you normally call highlightSelected(...). This draws a ’fake’ data series with one point at the location of your hover on the graph which needs to be ’removed’ whenever you move the mouse so you dont leave those points all over the graph. This could probably be re-organized a little bit (and is being reorganized in the 1.0 ’refactoring’) to only cleanup in certain situations/less often. But the problem is that you want to remove the highlighted point when you move out of range of the point OR to another point, so it’s a bit more complex than it seems.

I think binary search will speed up the searching quite a bit for huge datasets and hardly at all for datasets of less than, say, 100 data points.

by rfunduk

Comment
**Implement proper binary search in hover support.** cleanup() needs to be called, here’s why: When you hover over a point you get a callback in which you normally call highlightSelected(...). This draws a ’fake’ data series with one point at the location of your hover on the graph which needs to be ’removed’ whenever you move the mouse so you dont leave those points all over the graph. This could probably be re-organized a little bit (and is being reorganized in the 1.0 ’refactoring’) to only cleanup in certain situations/less often. But the problem is that you want to remove the highlighted point when you move out of range of the point OR to another point, so it’s a bit more complex than it seems. I think binary search will speed up the searching quite a bit for huge datasets and hardly at all for datasets of less than, say, 100 data points. by rfunduk
or cancel

thenduks Thu May 07 09:37:16 -0700 2009 | link

Implement proper binary search in hover support.

i see. here’s a start of binary search, works for time series. probably should require some flags in opts. see commit message:

http://github.com/brentp/flot/commit/f2c8ccd622cd54fbddfa2cdb8f74bb173e6f0ca5

by brentp

Comment
**Implement proper binary search in hover support.** i see. here’s a start of binary search, works for time series. probably should require some flags in opts. see commit message: http://github.com/brentp/flot/commit/f2c8ccd622cd54fbddfa2cdb8f74bb173e6f0ca5 by brentp
or cancel

Parsed with GitHub Flavored Markdown
4.

0 votes

@rfunduk
x

bug
x

Hints support in IE
3 comments Created 7 months ago by thenduks

Title

Body
Cryptic errors and no hints are displayed in IE. Working on it. [original LH ticket](http://thenduks.lighthouseapp.com/projects/14510/tickets/4) This ticket has 0 attachment(s).
or cancel

Cryptic errors and no hints are displayed in IE. Working on it.

original LH ticket

This ticket has 0 attachment(s).

Comments

thenduks Thu May 07 09:38:01 -0700 2009 | link

Hints support in IE

This would be awesome to get working.

by Ryan

Comment
**Hints support in IE** This would be awesome to get working. by Ryan
or cancel

thenduks Thu May 07 09:38:03 -0700 2009 | link

Hints support in IE

The real problem is that hover support in IE is painful due to it’s non-support of the canvas element. The excanvas library does a great job of faking it, but it slows it down like mad. Not to mention IE’s javascript engine in general is pitiful.

So when I use the library at work (a big reason I forked it in the first place) I just don’t enable hovering in IE at all and handle click events instead. Showing a tooltip on click is counter-intuitive at best -- so it’s just not a priority for me.

In the most recent revision I’ve just disabled it for IE. But this is a temporary measure. I do want to get the actual tooltip displayable in IE, and leave it up to the user whether or not to actually enable it. In short, eventually the tooltips will only draw if you have hovering enabled, and I personally recommend strongly against doing so in IE :)

by rfunduk

Comment
**Hints support in IE** The real problem is that hover support in IE is painful due to it’s non-support of the canvas element. The excanvas library does a great job of faking it, but it slows it down like mad. Not to mention IE’s javascript engine in general is pitiful. So when I use the library at work (a big reason I forked it in the first place) I just don’t enable hovering in IE at all and handle click events instead. Showing a tooltip on click is counter-intuitive at best -- so it’s just not a priority for me. In the most recent revision I’ve just disabled it for IE. But this is a temporary measure. *I do want to get the actual tooltip displayable in IE*, and leave it up to the user whether or not to actually enable it. In short, eventually the tooltips will only draw if you have hovering enabled, and I personally recommend strongly against doing so in IE :) by rfunduk
or cancel

thenduks Thu May 07 09:38:06 -0700 2009 | link

Hints support in IE

It really would be best to allow the tooltip to be shown whenever the user wants (say, on click, not just on hover). So this is definitely a priority.

by rfunduk

Comment
**Hints support in IE** It really would be best to allow the tooltip to be shown whenever the user wants (say, on click, not just on hover). So this is definitely a priority. by rfunduk
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

@rfunduk
x

bug
x

New axis label implementation pretty broken
0 comments Created 7 months ago by thenduks

Title

Body
y axis labels: In IE it looks ok but it’s positioned wrong. In Firefox 2 there’s some sort of weird difference in the SVG stuff that’s causing scroll bars to appear in strange places. Firefox 3 looks great. Opera, unknown at this time. [original LH ticket](http://thenduks.lighthouseapp.com/projects/14510/tickets/9) This ticket has 0 attachment(s).
or cancel

y axis labels:

In IE it looks ok but it’s positioned wrong.

In Firefox 2 there’s some sort of weird difference in the SVG stuff that’s causing scroll bars to appear in strange places.

Firefox 3 looks great.

Opera, unknown at this time.

original LH ticket

This ticket has 0 attachment(s).

Comments

Parsed with GitHub Flavored Markdown
1.

0 votes

@rfunduk
x

feature
x

Allow buffers to be set with options
0 comments Created 7 months ago by thenduks

Title

Body
It would be nice if the buffers/margins of the canvas were optional. This makes it more ideal for displaying small-scale charts such as sparklines and other embedded graphics. I’ve modified my code to do this but also modified some other things. This really just entails doing the following: buffers: { top: 2, right: 2, bottom: 2, left: 2 } also removing the constants and then doing a find/replace on the buffers usage in the code. I don’t think right now it’s possible to do left and top buffers (you would use the autoscaleMargin instead) but it might be a nice to allow a fixed amount of bufferage there as well.
or cancel
It would be nice if the buffers/margins of the canvas were optional. This makes it more ideal for displaying small-scale charts such as sparklines and other embedded graphics. I’ve modified my code to do this but also modified some other things. This really just entails doing the following:
```
buffers: { top: 2, right: 2, bottom: 2, left: 2 }
```
also removing the constants and then doing a find/replace on the buffers usage in the code.

I don’t think right now it’s possible to do left and top buffers (you would use the autoscaleMargin instead) but it might be a nice to allow a fixed amount of bufferage there as well.
Comments

Parsed with GitHub Flavored Markdown
6.

1 vote

User defined properties via prototype cause failure
0 comments Created about 1 month ago by jakewendt

Title

Body
I just noticed that if I define any properties on the Array class using prototype ... Array.prototype.foo = function() { return 'bar' } ... plotting fails and Firebug shows ... res[i].data is undefined if( options.sortData ) res[i].data.sort( sortData ); I found that this is caused by the for/in loop around line 180. I replaced for( var i in res ) { with for(i=0;i<res.length;i++) { and the problem went away. The problem was due to the for/in including the user defined properties rather than just looping through the data. Of course, while the plotting now works, then the user defined properties no longer did so I replaced the second for/in loop for( var j in res[i].data ) { with for( j=0;j<res[i].data.length;j++ ) { and all was well. I tested all of the examples with the change and there appeared to be no adverse effects.
or cancel
I just noticed that if I define any properties on the Array class using prototype ...
```
Array.prototype.foo = function() { return 'bar' }
```
... plotting fails and Firebug shows ...
```
res[i].data is undefined
if( options.sortData ) res[i].data.sort( sortData );
```
I found that this is caused by the for/in loop around line 180. I replaced
```
for( var i in res ) {
```
with
```
for(i=0;i<res.length;i++) {
```
and the problem went away. The problem was due to the for/in including the user defined properties rather than just looping through the data. Of course, while the plotting now works, then the user defined properties no longer did so I replaced the second for/in loop
```
for( var j in res[i].data ) {
```
with
```
for( j=0;j<res[i].data.length;j++ ) {
```
and all was well. I tested all of the examples with the change and there appeared to be no adverse effects.
Comments

Parsed with GitHub Flavored Markdown