New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability fixes for Oracle #165
Conversation
Um, I don't understand. I developed the Oracle tutorial, including a section that deploys reworked (and therefore including |
I'm able to reproduce the error on both windows and linux (Ubuntu). It
On 22/05/2014 5:18 PM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP |
Hrm. I used the Developer days VM, and connected with the x86 instant client on OS X, which was 11.1. Maybe that makes a difference? Also, I thought Sqitch spooled the script into SQL_Plus by piping the script into SQL_Plus:
Am I missing something? |
I looked into it a bit further.
On 22/05/2014 9:19 PM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP Pythian - Love your data Tel: +1 613 565 8696 x 1292 |
Ah, right. So, could the |
That would also work. I went this way to give us another chance to run On 22/05/2014 10:13 PM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP Pythian - Love your data Tel: +1 613 565 8696 x 1292 |
Include fixes from David for Issue#166 (possible failed rollback)
Reading this thread, I'm wondering if it works if you quote the file name or escape the |
Using ESCCHAR should work in Oracle client versions 11.1 and up On 02/06/2014 5:14 PM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP |
Bah, alas, no, |
Instead of just relying on `ESCCHAR`, because that's only available on SQL*Plus 11.1 or higher, and we claim to support 8.4.0! So we instead create a temporary directory, which is deleted on exit, and either symlink to that directory, or copy the contents of the file (on Windows). Should be a better solution to issue #165.
Yeah, this seems to work. For reference, most of my tests are on Windows 7, Oracle client 12. |
Thanks. Can you also give it a try on your Ubuntu system, if you still have it lying around? Thanks! |
Glad you asked. I'm hitting the error again. It looks like it won't On 03/06/2014 11:02 AM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP Pythian - Love your data Tel: +1 613 565 8696 x 1292 |
Hrm. I just tried it. Created a symlink and ran sqlplus 11.1 and pointed it at the symlink and it ran fine. You on 10.x still? What is the error message you get? |
I was using 11.2 for that. I ran another test, and the symlink works if symlink abs_path($file), $alias; On 03/06/2014 7:46 PM, David E. Wheeler wrote:
Timothy Procter, P.Eng., CSDP Pythian - Love your data Tel: +1 613 565 8696 x 1292 |
Wait, what? It should always be an absolute path. That's what File::Temp provides. Will have to dig some more, I guess. |
Hope this is the final nail in the coffin for #165.
PASS - works for me now. |
Phew, thanks! |
Can we include these 2 fixes in the next release?