From fbae9f63076d8379746eaef40d4baf74929fc4a8 Mon Sep 17 00:00:00 2001 From: Lance Ball Date: Mon, 30 Nov 2015 12:09:10 -0500 Subject: [PATCH] Default ajax request method should be GET. Don't forget to send(). --- ribbon-webapp/runtime/src/main/resources/ribbon.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ribbon-webapp/runtime/src/main/resources/ribbon.js b/ribbon-webapp/runtime/src/main/resources/ribbon.js index 022c8c5a24..fd9cac9d10 100644 --- a/ribbon-webapp/runtime/src/main/resources/ribbon.js +++ b/ribbon-webapp/runtime/src/main/resources/ribbon.js @@ -27,6 +27,8 @@ var ribbon = (function() { // Set relevant headers if (settings.method === 'POST') { settings.headers['Content-Type'] = 'application/json'; + } else if (!settings.method) { + settings.method = 'GET'; } if (!keycloak) { @@ -70,7 +72,8 @@ var ribbon = (function() { // set the state change handler and make the http request request.onreadystatechange = changeState(request, deferredResponse); request.open(settings.method, settings.url); - request.send(settings.data); + if (settings.data) request.send(settings.data); + else request.send(); // return a deferred promise return deferredResponse; @@ -118,6 +121,7 @@ var ribbon = (function() { function getJSON(serviceName, path, data) { return ajax( serviceName, path, { + method: 'GET', data: data }); }