From 3ebe0fa577b1f0294906d8668691842e6ccccfbd Mon Sep 17 00:00:00 2001 From: Joe Ferris Date: Wed, 21 Mar 2012 19:11:50 -0400 Subject: [PATCH] Rename confusing method --- src/Connection.cpp | 7 +++---- src/Connection.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Connection.cpp b/src/Connection.cpp index 72a1fcb1..f9dbf5bc 100644 --- a/src/Connection.cpp +++ b/src/Connection.cpp @@ -25,7 +25,6 @@ Connection::Connection(QTcpSocket *socket, WebPage *page, QObject *parent) : connect(m_page, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool))); } - void Connection::commandReady(QString commandName, QStringList arguments) { m_queuedCommand = m_commandFactory->createCommand(commandName.toAscii().constData(), arguments); if (m_page->isLoading()) @@ -46,7 +45,7 @@ void Connection::startCommand() { SLOT(finishCommand(Response *))); m_runningCommand->start(); } else { - pageLoadFailed(); + writePageLoadFailure(); } } @@ -64,13 +63,13 @@ void Connection::pendingLoadFinished(bool success) { if (m_pageSuccess) { writeResponse(m_pendingResponse); } else { - pageLoadFailed(); + writePageLoadFailure(); } } } } -void Connection::pageLoadFailed() { +void Connection::writePageLoadFailure() { m_pageSuccess = true; QString message = m_page->failureString(); writeResponse(new Response(false, message)); diff --git a/src/Connection.h b/src/Connection.h index eef5e87c..07aaec74 100644 --- a/src/Connection.h +++ b/src/Connection.h @@ -23,7 +23,7 @@ class Connection : public QObject { private: void startCommand(); void writeResponse(Response *response); - void pageLoadFailed(); + void writePageLoadFailure(); QTcpSocket *m_socket; Command *m_runningCommand;