From c26c71f892299b9b2cb74d45a212d7b36ecd927a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wojciech=20Wn=C4=99trzak?= Date: Thu, 27 Oct 2011 21:45:21 +0200 Subject: [PATCH 1/2] failing spec for big letters in factory name passed as symbol --- spec/factory_girl/factory_spec.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/spec/factory_girl/factory_spec.rb b/spec/factory_girl/factory_spec.rb index e534d3473..17aa797c4 100644 --- a/spec/factory_girl/factory_spec.rb +++ b/spec/factory_girl/factory_spec.rb @@ -229,6 +229,12 @@ its(:human_names) { should == ["happy user"] } end + context "factory name with big letters" do + subject { FactoryGirl::Factory.new(:LoL) } + its(:names) { should == [:LoL] } + its(:human_names) { should == ["lol"] } + end + context "factory name with aliases" do subject { FactoryGirl::Factory.new(:happy_user, :aliases => [:gleeful_user, :person]) } its(:names) { should == [:happy_user, :gleeful_user, :person] } From 33371964fdd07d209381d3bcc9b0422f632f12b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wojciech=20Wn=C4=99trzak?= Date: Thu, 27 Oct 2011 21:45:37 +0200 Subject: [PATCH 2/2] do not change factory name when passed as symbol --- lib/factory_girl/factory.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/factory_girl/factory.rb b/lib/factory_girl/factory.rb index 14046c944..f23cb8298 100644 --- a/lib/factory_girl/factory.rb +++ b/lib/factory_girl/factory.rb @@ -8,7 +8,7 @@ class Factory def initialize(name, options = {}) #:nodoc: assert_valid_options(options) - @name = name.to_s.underscore.to_sym + @name = name.is_a?(Symbol) ? name : name.to_s.underscore.to_sym @parent = options[:parent] @aliases = options[:aliases] || [] @traits = options[:traits] || []