Reported by Joe Ferris

Proxy objects are responsible for returning values of previously defined attributes, but you can't reference "id" and other attributes that conflict with methods on Object.

Proxy should either undefine these methods so that method_missing is called, or directly delegate them to #get.

Reported by George Ogata

Hi,

I’ve found h-lame’s after_{build,create} callbacks a very useful addition to factory_girl. Only thing is his changes are on an old commit. I’ve merged his patch with your head in my fork [1], and was hoping you’d merge it in.

[1] http://github.com/george-ogata/factory_girl/tree/master

Reported by Erik

The method variable_name_to_class_name has code that translates, say, 'active_record/base' to ActiveRecord::Base. But when I tried to use this, I got a 'wrong constant name' error, because constant names can't contain colons.

You can just supply a :class option, but it would be easier not to. I'm planning to fix the code and document the shortcut.

Here's my fix: http://github.com/eostrom/factory_girl/tree/guess_classes_in_modules

Reported by Peter Suschlik

Branch on github: http://github.com/splattael/factory_girl/tree/global_default_strategy

It's like :default_strategy option but for all factories:

Factory.global_default_strategy = :build

Factory.define(:post) {}
...
Factory(:post) # => like Factory.build(:post)

No need for :default_strategy => :build every time.

Note:
I don't like the name global_default_strategy.
Factory.default_strategy = :build would be nicer but I didn't want to hack up the current default_strategy method.

Reported by Vladimir Andrijevik

Hi folks!

First off, I love factory_girl. Very well done, and thank you!

I'm writing to you about a weird issue I found with has_many associations in factories. I've tried to make this example as minimalistic as possible:

in test/factories.rb

Factory.define(:team) do |team|
  team.sequence(:name) { |n| "Team #{n}"}
end

Factory.define(:user) do |user|
  user.sequence(:name) { |n| "User #{n}"}
  user.association(:team)
end

Factory.define(:team_with_users, :parent => :team) do |team|
  team.users { |users| [users.association(:user)] }
end

With these factories defined, trying to create a team with users in the tests looks like this:

team = Factory(:team_with_users)

  Team Create (0.5ms)   INSERT INTO "teams" ("name", "updated_at", "created_at") VALUES('Team 1', '2009-05-11 17:12:47', '2009-05-11 17:12:47')
  User Create (0.4ms)   INSERT INTO "users" ("name", "team_id", "updated_at", "created_at") VALUES('User 1', 996332878, '2009-05-11 17:12:47', '2009-05-11 17:12:47')
  Team Create (0.4ms)   INSERT INTO "teams" ("name", "updated_at", "created_at") VALUES('Team 2', '2009-05-11 17:12:47', '2009-05-11 17:12:47')

#

As you can see, two teams are created, and the user object is associated with the wrong team. However, calling team.users will show the user object (because it's set with the users= setter), but on team.reload the users association appears empty.

team.users
[#]

team.reload.users
[]

Reported by Alex Rothenberg

When I have a model class defined within a module FactoryGirl was unable to find the class correctly because it was not traversing down the module hierarchy.

The fix along with a spec that fails before and passes after are at http://github.com/alexrothenberg/factory_girl/commits/factories_for_classes_with_modules_patch

My scenario is that I have a model defined in a module

module BlogModels
  class Comment < ActiveRecord::Base
  end
end

and want to define a factory for it like this

Factory.define 'blog_models/comment' do |comment|
end

It fails with this error

1)
NameError in 'Factory a factory defined with a module name should load the class defined inside the module'
wrong constant name GroupingOfModels::Comment
/Users/alexrothenberg/ruby/github/factory_girl/spec/../lib/factory_girl/factory.rb:304:in `const_get'
/Users/alexrothenberg/ruby/github/factory_girl/spec/../lib/factory_girl/factory.rb:304:in `class_for'
/Users/alexrothenberg/ruby/github/factory_girl/spec/../lib/factory_girl/factory.rb:58:in `build_class'
./spec/factory_girl/factory_spec.rb:306:

Patching the class_for method in factory.rb to go down the module hierarchy as it loads the class fixes the problem.

I hope this is not too much information in the ticket but I thought it was better to err with too much rather than too little :)

Thanks
Alex

When factory girl is loaded, this code does nothing when run in the rails console:

ActiveRecord::Base.logger = Logger.new(STDOUT)

The expected behavior should be that ActiveRecord SQL statements are logged in the rails console. Factory_girl should not change this behavior.

When creating a factory that has a parent defined, attributes defined in blocks don't have scope to parent attributes because the parent's attributes haven't been added to the factory yet.

I've created a branch that resolves this incorrect behavior: http://github.com/joshuaclayton/factory_girl/commits/parent-attributes-in-attribute-blocks

Singleton factories are useful for creating unique instances, such as a fixed set of movie genres. The branch at http://github.com/roderickvd/factory_girl/tree/singletons adds the following syntax to do just that:

# Defines a new singleton
Factory.define :comedy, :class => Genre, :singleton => true do |g|
  g.name 'Comedy'
end

Because the singleton option is set on the factory, it works seamlessly for associations and all strategies.

Reopening issue 12.

Ran into some trouble when trying to use factory sequences with spork + autospec—dozens of "Validation failed: Name has already been taken" errors. Changing Factory.find_definitions to use load instead of require takes care of the issue.

If anyone has a better suggestion, I'm open to it. If not, please consider merging this: http://github.com/jdhollis/factory_girl/commit/08fae46d01ad3faa7ecfc320e38f4696ac026041

The branch is here: http://github.com/jdhollis/factory_girl/tree/load-instead-of-require

I've created a branch which makes the stubbing strategy more friendly for non-AR classes.
http://github.com/sandro/factory_girl/tree/stub_for_non_ar_objects

The main issue is that the stubbing proxy calls #new which won't work if #initialize takes requires arguments. The fix is to fall back to #allocate when #new fails.

Hi,

There is a typo in README.rdoc. "startegy" instead of "strategy." Here is the commit you can pull in: akahn/factory_girl@8afb333

Cheers,
Alex

Factory.define :building, :class => Building::Mothership do |m|
m.x 0 m.x_end { |r| r.x + r.instance_variable_get("@instance").class.property('width') } end

It would be nice to just be able to

Factory.define :building, :class => Building::Mothership do |m|
m.x 0 m.x_end { |r, options| r.x + options[:class].property('width') } end

ActiveRecord and DataMapper share a significant amount of API. Enough at least to allow factory_girl to work with both. The following patch maintains compatibility.

please pull me

Problem: a factory define that has a parent seems to be failing because the parent isn't loaded yet.

Example:

test/factories/person.rb
  Factory.define :person do |p|
    p.name 'Joe'
  end

test/factories/person_with_extras.rb
  Factory.define :person_with_extras, :parent => :person do |p|
    p.age 21
  end

Using the code above gives this error: No such factory: person.

Is it correct that a factory can have a parent like this, in a different file?

When I look in the gem factory.rb, it seems that the load order is inconsistent on line 276:

  Dir[File.join(path, '*.rb')].each do |file|

I would expect at least for the files to be in alphabetic order:

  - Dir[File.join(path, '*.rb')].each do |file|
  + Dir[File.join(path, '*.rb')].sort.each do |file|

Is there something obvious that I'm missing?

Or is it supposed to be this way?

Could the Thoughtbot team at least add the "sort" to the file list?

Much obliged,
Joel Parker Henderson
joelparkerhenderson@gmail.com

http://github.com/erikh/factory_girl

Patch adds proxy-specific Factory.define options.

Patch adds a :singleton_on attribute to Factory.define; see README.rdoc for use-case information, but the basic gist is that when going through the create proxy, the value of the :singleton_on parameter is used on the generated instance to find a target, which is then searched for in the model the instance was created from. If an object is found, it is used instead of creating a new one, and then saved.

Tests added, pull request sent, working in real-world scenarios already.

Hi,

Just to point out the need to add lib/factory_girl/attribute/callback.rb file to the one included into gemspec, after Nate patch.

Commit's here: http://github.com/ook/factory_girl/commit/b7c6fb724e8f569d2452d1a1de75178af583ac69

I took a crack at it:
http://github.com/r00k/factory_girl/tree/update_readme_with_callbacks

It looks like you switched to Gemcutter for the 1.2.3 release, but the README still has installation instructions pointing to thoughtbot-factory_girl on GitHub. I forked and fixed it:

chrisk/factory_girl@8a4c1c0

The commit is tagged readme_gemcutter for easy merging.

We've got quite a few namespaced models in our codebase, and so far we've had no troubles specifying factories for them like so:

factory :namespace_foo, :class => Namespace::Foo do |nsf|
  nsf.foo 'foo'
  nsf.bar 'bar'
end

However now working with Spork in our specs, I'm trying to prevent the constants from being loaded so early, so I changed all the constants to strings.

factory :namespace_foo, :class => 'Namespace::Foo' do |nsf|
  nsf.foo 'foo'
  nsf.bar 'bar'
end

But now all my factories break with NameError Exception: wrong constant name

This is just a simple matter of changing the way that factory_girl calls Object#const_get. I'm forking and I'll link a branch with the fix shortly.

I've been bitten a few times recently by accidentally defining two factories with the same name. Factory_girl accepts this silently. I think an error is warranted: I can't think of a scenario where users are benefited by this ability and doing it inadvertently is likely to break things.

Here's my implementation. Attempting to define a second factory with the same name raises a DuplicateDefinitionError:
http://github.com/r00k/factory_girl/tree/disallow_duplicate_factory_definitions