thoughtbot / paperclip

Reported by Randy Reddig

The HTML 4.01 spec permits multipart form data with an omitted filename.

Rack parses this correctly, and passes a hash describing a file using Rack::Tempfile:

{:type=>"application/octet-stream", 
:head=>"Content-Disposition: form-data; name="profile_image"\r\nContent-Type: application/octet-stream\r\nContent-Transfer-Encoding: binary\r\n", 
:tempfile=>#, 
:name=>"profile_image"}

The original_filename method that Paperclip injects into File returns nil, which fails at attachment.rb:79:

instance_write(:file_name, uploaded_file.original_filename.strip.gsub(/[^\w\d\.\-]+/, '_'))

I suppose a reasonable fix would be to use the tempfile’s filename as a substitute for the missing filename field.

RAILS_ENV is now depreciated with Rails 3 coming out, it is now favorable to use Rails.env instead.

Reported by Peter Suschlik

I've added I18n support for error messages:
http://github.com/splattael/paperclip/tree/translate_error_message

Now you can define translations for the errors messages in e.g. your YAML locale file:

en:
  paperclip:
    errors:
      attachment:
        size: "Invalid file size"
        content_type: "Unsupported content type"
        presence: "Cant' be blank"

I fear my tests are a bit messy... I'm new to shoulda :/

Nevertheless, I hope you like the patch :)

Reported by Andrew

I have forked and patched paperclip on github at http://github.com/andrewtimberlake/paperclip/commit/5b2f2e6fb6abf9625cbf50cd59f86267cfc0a83d

This change allows you to set a hash for s3_permissions like
:s3_permissions => {:original => 'private', :thumb => 'public-read'} This is useful for a situation where a cropped thumbnail needs to be quick to download but the original file needs to be protected (and it's download might be managed through the web app itself instead of directly off S3)
You can also set a :default key in your permissions hash which will apply to all styles except those specifically stated.

The original functionality is unchanged as s3_permissions can still accept a string which will apply to all styles.

Includes tests

Reported by Adam Grant

My Paperclip::VERSION == "2.2.9.2"

If you create a new ActiveRecord object, assign an attachment to it, clear out that attachment, and then try and save the record, the Storage#flush_writes method balks because queued_for_write was never cleared.

Example:

===============================================

class Asset < ActiveRecord::Base
   has_attached_file :data
end

asset = Asset.new
asset.data = File.new("some/path", "r")
asset.data.clear
asset.data.save!

TypeError: can't convert nil into String
    from ../vendor/plugins/paperclip/lib/paperclip/storage.rb:41:in `dirname'
    from ../vendor/plugins/paperclip/lib/paperclip/storage.rb:41:in `flush_writes'
    from ../vendor/plugins/paperclip/lib/paperclip/storage.rb:39:in `each'
    from ../vendor/plugins/paperclip/lib/paperclip/storage.rb:39:in `flush_writes'
    from ../vendor/plugins/paperclip/lib/paperclip/attachment.rb:142:in `save'
    from ../vendor/plugins/paperclip/lib/paperclip/attachment.rb:165:in `destroy'
==========================================

My solution is this: modify the clear method to reset the @queued_for_write variable:

Index: lib/paperclip/attachment.rb
=================================

--- lib/paperclip/attachment.rb (revision 1679)
+++ lib/paperclip/attachment.rb (working copy)
@@ -153,6 +153,7 @@
     # use #destroy.
     def clear
       queue_existing_for_delete
+      @queued_for_write  = {}
       @errors            = {}
       @validation_errors = nil
     end

I have a test here as well:

Index: test/attachment_test.rb
===================================================================
--- test/attachment_test.rb (revision 1679)
+++ test/attachment_test.rb (working copy)
@@ -514,6 +514,16 @@
       assert_equal nil, @attachment.path(:blah)
     end
 
+    context "with a file assigned but not saved yet" do
+      should "clear out any attached files" do
+        @attachment.assign(@file)
+        assert @attachment.valid?
+        assert !@attachment.queued_for_write.blank?
+        @attachment.clear
+        assert @attachment.queued_for_write.blank?
+      end
+    end    
+
     context "with a file assigned in the database" do
       setup do
         @attachment.stubs(:instance_read).with(:file_name).returns("5k.png")
===================================

Sorry I can't get it into any better patch format (using git and Github and forking) than that. My machine I'm working from is quite limited from the git perspective. It's a simple fix though.

See any problems with this?

Reported by Josh Pencheon

I think it would be really helpful to be able to validate an attachment as an image. At the moment, I'm doing this like this:

 ALLOWED_CONTENT_TYPES = {
    'MS Word'       => 'doc',
    'MS Excel'      => 'xls',
    'MS Powerpoint' => 'ppt',
    'Adobe PDF'     => 'pdf',
    'ZIP'           => 'zip',
    'JPEG'          => 'jpeg',
    'GIF'           => 'gif',
    'PNG'           => 'png',
    'text'          => 'txt'
  }

APPLICATION_REGEXP = %r{^(x-)?application/#{ALLOWED_CONTENT_TYPES.values.join('|')}$}
IMAGE_REGEXP = %r{^(image|(x-)?application)/(x-png|pjpeg|jpeg|jpg|png|gif)$}  
  
validates_attachment_presence :document
validates_attachment_content_type :document, 
    :content_type => [ APPLICATION_REGEXP, IMAGE_REGEXP, 'text/plain' ],
    :message => "must be: #{ALLOWED_CONTENT_TYPES.values.map{|k| '.' + k }.join(' ')}"

Which is ugly, but I'm not sure what to do. However, now I need this functionality in another model, and don't want to duplicate it.

In attachment_fu, I think you can do something like this:

validates_content_type_of_attachment :image

Thanks, Josh

==================

I've had a go at making a patch (it's tested): https://thoughtbot.lighthouseapp.com/attachments/70915/image_validation_additions.diff

Hope it might be helpful!

Reported by James Le Cuirot

I hate it when file plugins force you to have a file_name column when it’s obvious what the filename is going to be – such as when it’s something like :id.csv. This patch allows you to not have the column as long as the :path option doesn’t use :basename or :extension. I’ve added tests but I haven’t tested against S3. This approach is not ideal for S3 anyway because it calls exists? to determine whether a file is attached or not.

http://github.com/chewi/paperclip

Reported by Giovanni Cangiani

Hi,

the to_file method for s3 Storage does not return a File object but an RightAws::S3::Key instead. This is consistent with the comment in the code (in the format most representative of the current storage), but not with what the reprocess! method in Attachment expects (an object that responds to "read" method).

I am willing to submit a patch for this but there are two ways and I'd like to know which one you prefer.
1. actually write the s3_bucket.key.data into a Tempfile and return the file
2. implement read/write methods for RightAws::S3::Key
What do you think ?

Last question. Is there any foundamental reason for chosing RightAWS instead of the usual AWS::S3 ?

Thanks,

giovanni

It would be nice if the gravity in Geometry#cropping was configurable, because you don't always want the weight to be at the center.

I tried using "convert_options" to set the gravity, but it didn't work:
:convert_options => { :normal => "-gravity northwest", :small => '-gravity northwest' }

This hack works, but is not configurable either:
http://snippets.aktagon.com/snippets/345-Crop-Gravity-Paperclip

Reported by Philip Hallstrom

Paperclip wasn't generating the thumbnails, but it would copy the original file into place. Worked on one host, not on another, same imagemagick version. When I ran the rake task to regenerate the thumbnails it worked.

Finally figured out that one host had a really small PATH environment that did not include /usr/local/bin (where convert/identify are).

Setting the correct path fixed the problem.

I'm not sure the best way to handle it, but a big note in the documentation or a check in Paperclip.run maybe to ensure that it can be found or some other error thrown.

I see in Paperclip.run where it is supposed to raise an error. I've double checked all my logs and see no mention of that string anywhere so it's getting eaten somewhere.

"Photo C:/DOCUME~1/user/LOCALS~1/Temp/stream.3376.0 is not recognized by the 'identify' command."

The problem is:

For users who have the "wx" env var set (like people with wxWidgets dev environments...)

set wx=FUN
echo "%wx%h"
"FUNh"

So, when processing this:

Paperclip.run("identify", %Q[-format "%wx%h" "#{file}"[0]])

The wrong string is passed to identify. To get around this you can do:

Paperclip.run("identify", %Q[-format ^%wx^%h "#{file}"[0]])

But obviously that would only work on Windows.

There's one more issue, too. If the :command_path has a space in it, Paperclip doesn't quite the path to "identify" properly. I had to change:

command = %Q<#{%Q[#{path_for_command(cmd)} #{params}].gsub(/\s+/, " ")}>

to:

command = %Q<#{%Q["#{path_for_command(cmd)}" #{params}].gsub(/\s+/, " ")}>

(I have a patch ready at http://github.com/alainravet/paperclip/tree/keep_old_files )

Usage :

has_attached_file :avatar,   
    :keep_old_files => true.

Effect:
disable the automatic deletion of the existing files (original + resized) each time you clear or update the attachment.

Usecase : images in emails.
We send notifications by emails and they include images (ex: users avatars).
If an image is updated at a later time on the server (ex: a user changes his avatar), we don't want those emails to look broken because the old images files don't exist anymore.

Reported by mat:

We used paperclip in our project. In production it worked great (Debian box). On our OSX boxes in development it worked great until we switched to Phusion (aka mod_rails). When running under Phusion we'd get this error:

ActionView::TemplateError (can't convert Array into String) on line #4 of vendor/plugins/active_scaffold/frontends/default/views/_form_messages.rhtml:
1: <%= render :partial => 'messages' %>
2: 
3: <% unless @record.nil? %>
4:     <%= error_messages_for 'record' %>
5: <% end %>

    vendor/plugins/active_scaffold/lib/extensions/error_messages.rb:18:in `+'
    vendor/plugins/active_scaffold/lib/extensions/error_messages.rb:18:in `as_full_messages'

This error is caused by our ActiveScaffold horking on an error thrown by paperclip. Paperclip is failing because ImageMagick is returning nothing - just a blank - because the environment variable $MAGICK_HOME isn't set. You see it's difficult to set the environment variables ImageMagick needs in Phusion (see http://code.google.com/p/phusion-passenger/issues/detail?id=81). There are two solutions:

1. Install ImageMagick in your /usr/bin folder using Ports
   
2. Hack apache to run a special Ruby with environment variables defined (see http://code.google.com/p/phusion-passenger/issues/detail?id=81)

Neither one of these work for us. Ports is problematic (long story) and the apache hack means we would have to run a different config for development and production.

Instead we developed a very small patch to paperclip that introduces a new parameter MAGICK_HOME alongside COMMAND_PATH. With this patch, on any Phusion box you can avoid installing ImageMagick into the /usr/bin folder and instead do this:

• Apply the patch included in this ticket
• Download and uncompress Image Magick into somewhere convenient. We put it in /usr/local/imagemagick
• Add this as an initializer in $PROJECT/config/initializers/paperclip.rb:

# config/initializers/paperclip.rb
if RAILS_ENV == "development"
 Paperclip.options[:command_path] = '/usr/local/imagemagick/bin'
 Paperclip.options[:magick_home] = '/usr/local/imagemagick'
end

Don't forget to restart your project after you do the above.

Our patch may be lacking in some way, it seems to work for us so far.

EDIT: Here's the correct patch for this:

Index: paperclip.rb
===================================================================
--- paperclip.rb    (revision 236)
+++ paperclip.rb    (working copy)
@@ -57,7 +57,8 @@
       @options ||= {
         :whiny_thumbnails  => true,
         :image_magick_path => nil,
-        :command_path      => nil
+        :command_path      => nil,
+        :magick_home       => nil
       }
     end
 
@@ -70,6 +71,9 @@
     end
 
     def run cmd, params = "", expected_outcodes = 0
+      if options[:magick_home]
+        ENV['MAGICK_HOME'] = options[:magick_home]
+      end
       output = `#{%Q[#{path_for_command(cmd)} #{params} 2>#{bit_bucket}].gsub(/\s+/, " ")}`
       unless [expected_outcodes].flatten.include?($?.exitstatus)
         raise PaperclipCommandLineError, "Error while running #{cmd}"

Reported by minter

I've added support for Rackspace/Mosso Cloud Files, an S3 competitor, in my github fork (http://github.com/minter/paperclip/tree/master). I've included tests, based off of the existing S3 tests.

The Cloud Files support requires the Cloud Files Ruby gem, currently available at http://www.mosso.com/cloudfiles.jsp but hopefully soon in a more standard location.

I'm hoping this will be a useful addition to Paperclip, giving users another option for hosting their data in a cloud environment.

Reported by sam:

Hi,

The latest version of of paperclip (as of 2009-05-21) has a major issue with S3 storage. Attempts to do anything related to paths or URLs (so basically everything) result in a SystemStackError: stack level too deep.

Here's a sample of output:

SystemStackError: stack level too deep
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/storage.rb:149:in `s3_path_url'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `send'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `gsub'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `interpolate'
    from /Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/attribute_methods.rb:211:in `inject'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `each'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `inject'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:391:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:103:in `url'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:46:in `url'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `send'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `gsub'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `interpolate'
... 6074 levels...
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `inject'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:391:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:112:in `path'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/storage.rb:149:in `s3_path_url'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `send'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:31:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `gsub'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:30:in `interpolate'
    from /Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/attribute_methods.rb:211:in `inject'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `each'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `inject'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/interpolations.rb:29:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:391:in `interpolate'
    from /Users/sam/workspace/FloresFrescas.com/vendor/plugins/paperclip/lib/paperclip/attachment.rb:103:in `url'

I'm guessing this has something to do with the new default style code. When I reverted to a version of the plugin from March (commit a1b39cc65) I had no problems. I've not tried any other revisions.

Cheers,
sam

Okay, I managed to stumble upon a fix. Simply by adding the :path to the has_attached_file it operates as it should do. I didn't realise this was a requirement, but after testing older versions and getting problems with saving to S3 I found adding :path was the only way to get anything to work.

Cheers, sam

I've tried to implement this in my fork (http://github.com/korobkov/paperclip ). Appreciate any comment or help with this.

Reported by Dave Krupinski

When using paperclip in STI models each subclass contains all validations defined in any of the subclasses.

Example:

Asset < ActiveRecord::Base has_attached_file :image has_attached_file :video end

Video < Asset validates_attachment_presence :video end

Image < Asset validates_attachment_presence :image end

Image and Video will incorrectly require the presence of both a video and an image.

Reported by Marshall Sontag

The Problem:

I recently decided to move all of my assets, including paperclip attachments, to S3/Cloudfront. To take advantage of Rails' built-in support for multiple asset hosts, I created 4 CNAME subdomains (assets0.domain.com, assets1.domain.com, etc) that all forwarded to Cloudfront. However, because Paperclip was set to s3 storage, it would only return an S3-based URL, or it would allow me to specify only a single CNAME host. I could not use Rails' built-in asset_host settings to serve my assets.

The Solution:

Rails' built-in image_tag helper (more specifically, the image_path helper) will use the asset_host setting in your environment (if set) to calculate what the URL should be. In order to do this, it needs to be handed a relative URL (i.e. "photos/1/image.jpg"). Paperclip is not currently equipped to return a relative URL when using S3 Storage, so it needs this ability. Toward this end, I created a 4th option for the S3 :url setting (which I have called :asset_host) that returns a relative path so that Rails can do the proper URL calculation.

The Patch:

Fresh commit, complete with leading slash and 2 different asset host settings. One with bucket for S3, one without bucket for Cloudfront:

http://github.com/marshmallowcreme/paperclip/tree/master

Reported by Anthony Underwood

Most of my applications have roots which are a sub_url of the root url (In passenger I use RailsBaseURI /app_name)

Therefore in my environment.rb file I use the line

config.action_controller.relative_url_root = app_name

paperclip assets do not seem to take consideration of this config.

for example, asset.url generates:

/datas/1/original/Pic.jpg?1226756334

rather than

app_name/datas/1/original/Pic.jpg?1226756334

I have tried with the latest version of paperclip which prepends system before datas but there is no inclusion of the app_name sub_url

this could be fixed by something like :url => "#{ActionController::Base.relative_url_root}/system/:attachment/:id/:style/:basename.:extension"

line 9 of lib/paperclip/attachment.rb

Is this something that could be looked into please?

Thanks Anthony

The uploads processed by http://brainspl.at/articles/2008/07/20/nginx-upload-module are faster, but the upload format isn't the same.

Reported by Alain Ravet

(with Rails 2.1, and the Paperclip VERSION = "2.2.9.2")

step 1 :

  class Foo < ActiveRecord::Base
     has_attached_file :photo
  end

step 2 (in the console) :

  > Foo.new(:photo => 'fake.gif').photo_changed?

  NoMethodError: undefined method `photo_changed?' for #
 from /Users/jdoe/vooruit/r/vooruit-be/vendor/rails/activerecord/lib/active_record/attribute_methods.rb:251:in `method_missing'

I've checked the code and the method is correct:

# Returns the timestamp as defined by the <attachment>_updated_at field
def timestamp attachment, style
  attachment.instance_read(:updated_at).to_s
end

When using it:

Contest.last.videobrief.path => "videobriefs/90/2009-12-04 07:02:43 -0800_original.flv" Contest.last.videobrief.url => "http://d3pqlvx29u0inx.cloudfront.net/videobriefs/90/2009-12-04 07:02:43 -0800_original.flv?1259938963" Contest.last.videobrief.updated_at => 1259938963 Contest.last.videobrief.updated_at.to_s => "1259938963" Contest.last.videobrief_updated_at
=> Fri, 04 Dec 2009 07:02:43 PST -08:00 Contest.last.videobrief.updated_at
=> 1259938963 Contest.last.videobrief_updated_at => Fri, 04 Dec 2009 07:02:43 PST -08:00 Contest.last.videobrief.updated_at => 1259938963

It seems like the interpolations code isn't used.

Reported by Kelly Felkins

My model has this declaration: has_attached_file :entity, :styles => { :small => ["400x400>", :png] }

I have a model spec that creates a model object and saves it. The attachment is a pdf file. This was failing with something like "...6192.0 is not recognized by the 'identify' command". This appears to work fine in development mode.

Apparently imagemagick relies on ghostscript when dealing with pdf files. Paperclip would issue the identify command prefixed with a command_path. Then identify would attempt a gs, but the gs command is not in the path.

My quick fix was to add the command_path to the path before issuing the identify command, like this:

export PATH=/opt/local/bin:$PATH;identify...

$ identify --version Version: ImageMagick 6.4.9-6 2009-03-08 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2009 ImageMagick Studio LLC $ gs --version 8.64

Reported by Dylan Markow

Using S3, it doesn't seem that copying attachments from one record to another works. The comments in attachment.rb state that "In addition to form uploads, you can also assign another Paperclip attachment: new_user.avatar = old_user.avatar", but when I try this, the second record's attachment remains empty and nothing gets uploaded to amazon's servers.

a = Post.find(1)
b = Post.find(2)
a.attachment_file_name
# => "Attachment.pdf"
b.attachment_file_name
# => nil
b.attachment = a.attachment
b.save
b.attachment_file_name
# => nil

Reported by thibaut Assus

In file lib/paperclip/upfile.rb Module Upfile method content_type I was wondering if it was possible to add our proper mime types (as mp3) It would be wonderful !

Reported by Karl-Heinz Köther:

Hi,

I built a small application (one model, paperclip 2.2.5) on Ubuntu HardyHeron (4.08).

class Clip < ActiveRecord::Base
  has_attached_file :photo, :styles => { :small => "300x300>" },
   :url => "/assets/photos/:id/:style/:basename.:extension",
   :path => ":rails_root/public/assets/photos/:id/:style/:basename.:extension"
end

With the standard C-Ruby 1.8.6 and Rails 2.2.2 it works fine.

But the same Code with JRuby I got an error when I want to save a record.

My environment: JDK 1.6.0_11 or 1.6.0_12, JRuby 1.1.6, Rails 2.2.2

From the logs:

Errno::EACCES in ClipsController#create 
Permission denied - Permission denied - /tmp/stream20090216-8069-1r49ujo-0 or /home/[...]/PaperClip_JRuby/public/assets/photos/1/original/rails.png

/opt/JRuby/khk/jruby-1.1.6-22/lib/ruby/1.8/fileutils.rb:505:in `mv'
/opt/JRuby/khk/jruby-1.1.6-22/lib/ruby/1.8/fileutils.rb:1395:in `fu_each_src_dest'
/opt/JRuby/khk/jruby-1.1.6-22/lib/ruby/1.8/fileutils.rb:1411:in `fu_each_src_dest0'
/opt/JRuby/khk/jruby-1.1.6-22/lib/ruby/1.8/fileutils.rb:1393:in `fu_each_src_dest'
/opt/JRuby/khk/jruby-1.1.6-22/lib/ruby/1.8/fileutils.rb:494:in `mv'
vendor/plugins/paperclip/lib/paperclip/storage.rb:44:in `flush_writes'
vendor/plugins/paperclip/lib/paperclip/storage.rb:40:in `each'
vendor/plugins/paperclip/lib/paperclip/storage.rb:40:in `flush_writes'
vendor/plugins/paperclip/lib/paperclip/attachment.rb:152:in `save'
vendor/plugins/paperclip/lib/paperclip.rb:299:in `save_attached_files'
vendor/plugins/paperclip/lib/paperclip.rb:292:in `each_attachment'
vendor/plugins/paperclip/lib/paperclip.rb:291:in `each'
vendor/plugins/paperclip/lib/paperclip.rb:291:in `each_attachment'
vendor/plugins/paperclip/lib/paperclip.rb:298:in `save_attached_files'
[...]

Thanks for help

karl-heinz

Reported by Toni Reina

Hi,

At present, the option :whiny_thumbnails hasn't relevance. In a line 41 in attachment.rb, there are a @whiny = options[:whiny_thumbnails] || options[:whiny] and how options[:whiny] by default is true, false || true = true.

Thanks

Reported by Dmitry Smalko

Is it possible to configure paperclip to make it move files from /tmp to store location instead of copy?

Problem is that large file takes too much time to copy. For example 1.4Gb file needs about 80sec to copy and SWFUpload goes timeout.

[...]

iostream.rb:

def to_tempfile tempfile = Tempfile.new("stream") 
  tempfile.binmode self.stream_to(tempfile) 
end

changes to..

def to_tempfile 
  self.rewind self 
end

On large files it works many times faster

When uploading a photo for a model with paperclip, everything would act like it was working properly including no errors in the log files. I had used the following initialization configuration

Paperclip.options[:command_path] = "/opt/local/bin"
Paperclip.options[:whiny_thumbnails] = true
Paperclip.options[:log] = true

and here is the relevant section of the 'working' logs.

[paperclip] Paperclip attachment photo on Staff initialized.
[paperclip] Assigning # to photo
[paperclip] Writing attributes for photo
[paperclip] Post-processing photo
[paperclip] Processing thumb # in the thumbnail processor.
[paperclip] Processing large # in the thumbnail processor.

Everything would look like it was working fine but no files where saved or created where they should have been. After some messing around I decided to symlink the composite, identify and convert binaries to /usr/bin from the configured macports directory and comment out the command_path option in the initializer. This seems to have fixed the problem as files are now created and displayed properly.

Is this a bug in using command_path or is there another issue? This is on OS X 10.5 using apache+passenger and macports to install imagemagick

This was using paperclip 2.2.8 and I had defined the command path in config/initializers/paperclip.rb

Reported by Giovanni Cangiani

I'm using rjcrop
to crop paperclip images. This worked great in Rails' 2.2.2 development environment, but as soon as I went into production mode, Paperclip didn't crop the images anymore.

This is what happens:

  @thing = Thing.find(1)
  @thing.update_attributes({:crop_x=>10, :crop_y=>20, :crop_w=>130, :crop_h=>85})
  @thing.paperclip_image.reprocess!

It seems that Paperclip doesn't recognize the change of these instance variables (they are not in the DB, the variables are being set through attr_accessor) and thus does not see a need to reprocess the images.

A solution I found is to set config.cache_classes = false in config/environments/production.rb (it defaults to true). Some links about similar problems can be found here.

Well, maybe this is something that can be solved, I'm not quite sure…

If no styles are defined, no processing is run as paperclip does not process the original file by default. If there is a processor specified but no styles, the user should be warned so there is some indication of why they are not seeing their processor working.

Reported by Max Lapshin

I had to get out real width and height of generated pictures and also I wanted to delete the whole directory of attachment after deleting image.

That is why I added following methods (with tests): width, heigth, dir.

http://gist.github.com/124427

Reported by Andrew Vit

Paperclip often doesn't fit the 1:1 user.avatar and person.portrait paradigm. I'm contributing a small but hopefully useful patch for the following scenario:

class Album < ActiveRecord::Base
  has_many :photos
end

class Photo < ActiveRecord::Base
  has_attached_file :photo
end

To get the url for an album photo, we need to reach into the paperclip attachment attribute of the photo model, which looks messy because the photo model and the attachment should just represent the same thing:

photo = album.photos.first

# Ok, this example is purposefully confusing:
photo.photo.url

# But it doesn't really matter what we call the attachment,
# It's still some potentially confusing method chaining:
photo.attachment.url
photo.image.url
photo.file.url
photo.upload.url

# Much clearer would be just:
photo.url

This simple patch adds the following syntax:

class AlbumPhoto < ActiveRecord::Base
  has_attached_file :photo
  delegate_attachment_methods_for :photo
end

The following methods would be available directly on the model:

photo.url
photo.path
photo.content_type
photo.original_filename
photo.size

Patch: http://gist.github.com/124434

Reported by David Lowenfels

has_attached_file :image, :styles => { :original => "300x>" },
                            :url => "/attachments/:class/:id/:style_:basename.:extension",
                            :path => ":rails_root/public/attachments/:class/:id/:style_:basename.:extension"

:path is not mentioned in the docs for has_attached_file, only in attachment.rb I was surprised that I had to explicitly set :path (upload path) in order to get this to work properly. The POLS thing to do would be to set :path => ":rails_root/public#{:url}" if path is not explicitly supplied.

Reported by Edward Ocampo-Gooding

I’m using paperclip rev 28a8305 and running into some unexpected behaviour with regards to whiny_thumbnail:

When ImageMagick is not installed, and whiny_thumbnail is set to true, I expected to have an error raised during resizing, but instead get this when inspecting the model’s errors:

@errors={"screenshot"=>["/var/folders/Il/IlmxVjfXGIOwab7U1JE4-E+++TI/-Tmp-/stream.18183.0 is not recognized by the 'identify' command.", "/var/folders/Il/IlmxVjfXGIOwab7U1JE4-E+++TI/-Tmp-/stream.18183.0 is not recognized by the 'identify' command."]}

I added an assertion in my unit tests to look for this sort of thing and deal with it (spouting a message instructing the user to install ImageMagick), but I’d like to avoid this hack.

What do you say to patching this behaviour and making it more apparent and clear what has to be done to fix the error?