Comments for thoughtbot's shoulda  

This is one of those little things that makes a man happy. Thanks Joe.

The new name conveys what is actually happening. The old name of should_protect_attributes never conveyed this, and for that matter, neither does attr_protected or attr_accessible.

This was also done to more easily name the new should_allow_mass_assignment_of macro that was committed here

For more info, see Ticket #106 in LH.

I wasn’t thinking should_attr_accesible. I was really thinking that the old name was better.

My random opinion is that should_attr_accesible and should_attr_protected sound kinda crappy.

Also, it seems that you have to list all your columns because there’s no difference in how attr_accessible and attr_protected are tested. I’d like these a bit more:

• should_white_list_mass_assignement_to :blah
• should_black_list_mass_assignement_to :blah

Isn’t this going backwards form the recent deprecations. All the others have been moving to look more like what would be typed in the model, but this one is moving away form that. What is the reason?

I don’t even use RSpec and I’m happy. You made me smile. Of course I did just look at this http://github.com/rails/rails/commit/66ee5890c5f21995b7fe0c486547f1287afe2b55

The commit has since been removed.

For the record, this was Matt Lins (mlins) commit. I screwed up the ownership while resolving conflicts during a cherry-pick. My bad.

The commit has since been removed.

Dan, just for future reference, this shoulda.gemspec file is auto-generated via rake gemspec. The version is derived from Thoughbot::Context::VERSION.

This was a mistake (and has been reverted), but we are going to be deprecating should_be_restful. See the discussion here: http://thoughtbot.lighthouseapp.com/projects/5807-shoulda/tickets/78-deprecate-should_be_restful#ticket-78-8

Why was should_be_restful removed?

Fixed. See: http://github.com/thoughtbot/shoulda/commit/c60fa4be85af2c8273460c7fc0881847b4dbd171

brandonarbini, I just created a ticket to track the fix for this.

Unfortunately, this breaks shoulda on edge rails. default_error_messages are run through I18n now. I haven’t tried it, but I believe the older method will still work.

This should be fixed now, if not, bring it to the google group:

http://groups.google.com/group/shoulda

There was a thread earlier about the same problem:

http://groups.google.com/group/shoulda/browse_frm/thread/e446a2e49ee3e443

when I modify tasks/shoulda.rake from require 'shoulda/tasks' to require "#{RAILS_ROOT}/vendor/plugins/shoulda/lib/shoulda/tasks.rb" ,things should be ok……

rake aborted! no such file to load — shoulda/tasks

?

Doh, good catch Joe!

Good call on the docs. I completely forgot to consider it when adding the feature.