@@ -46,7 +46,7 @@ module Shoulda # :nodoc: private def assigned_value? - !assigned_value.blank? + !assigned_value.nil? end def cleared_value? lib/shoulda/action_controller/matchers/set_session_matcher.rb @@ -70,6 +70,7 @@ class PostsControllerTest < ActionController::TestCase should_set_session(:mischief) { nil } should_set_session(:special) { '$2 off your next purchase' } should_set_session(:special_user_id) { @user.id } + should_set_session(:false_var) { false } should_fail do should_set_session(:special_user_id) { 'value' } end test/functional/posts_controller_test.rb @@ -4,7 +4,10 @@ class SetSessionMatcherTest < ActionController::TestCase # :nodoc: context "a controller that sets a session variable" do setup do - @controller = build_response { session[:var] = 'value' } + @controller = build_response do + session[:var] = 'value' + session[:false_var] = false + end end should "accept assigning to that variable" do @@ -26,6 +29,10 @@ class SetSessionMatcherTest < ActionController::TestCase # :nodoc: should "accept assigning nil to another variable" do assert_accepts set_session(:other).to(nil), @controller end + + should "accept assigning false to that variable" do + assert_accepts set_session(:false_var).to(false), @controller + end end end test/matchers/controller/set_session_matcher_test.rb @@ -12,6 +12,7 @@ class PostsController < ApplicationController headers['Content-Type'] = 'application/rss+xml' session[:special] = '$2 off your next purchase' session[:special_user_id] = @user.id + session[:false_var] = false head :ok end end test/rails_root/app/controllers/posts_controller.rb 78e23479f43323dcab2e4fe1f8f06739d4c84eba Larry Marburger larry@marburger.cc http://github.com/thoughtbot/shoulda/commit/272ad4ee1df0e54861112d1a5a81e32729f4ede0 272ad4ee1df0e54861112d1a5a81e32729f4ede0 2009-05-07T20:43:47-07:00 2009-03-10T09:41:00-07:00 Fixed set_session not matching false values. [#174 state:resolved] 91518a430b46b64672d0adddab55e51e9e6d5967 Joe Ferris joe.r.ferris@gmail.com