New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
augment method for chi-squared test #138
Conversation
Thanks for proposing this, it would be an excellent addition to the package. It would be a huge improvement over wrangling the output from |
If you're up for it amidst all the other |
Dear @alexpghayes , I have rebased the pull request and I have tried to follow your vignette https://github.com/tidyverse/broom/blob/master/vignettes/adding-tidiers.Rmd Some comments:
Anyway, please let me known what are the changes you expect before an eventual integration of the PR. I prefer to finalise that one and to be sure to have understood all the elements you expect before preparing the other PR we discussed. Best regards |
OK. I have rebased once again the PR from upstream/master and re-run Let me know if any additional changes are required in the PR. Regards |
Wow, this is fantastic feedback! I'll update the vignette on adding new tidiers later today -- thank you so much! Everything you've done is totally reasonable. I'll try to get |
I completely understand. Regarding the vignette (as I'm sure it will be a question for several occasional developers), it would be great if it could specified:
I do not know if it is important to explain all that process with the corresponding git commands. A link to https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request could be useful or a dedicated paragraph in the vignette. Regards |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
cf. https://github.com/dgrtwo/broom/issues/136