Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for survdiff objects #147

Merged
merged 5 commits into from Nov 19, 2017
Merged

Methods for survdiff objects #147

merged 5 commits into from Nov 19, 2017

Conversation

mbojan
Copy link
Contributor

@mbojan mbojan commented Jul 12, 2016

As issue'd #145 . I have only ran tests in test-survdiff.R, mainly because of #146 .

@dgrtwo
Copy link
Collaborator

dgrtwo commented Jul 12, 2016

Nice, thank you!

I'll merge once you or I have finished out the TODO in the docs.

@mbojan
Copy link
Contributor Author

mbojan commented Jul 13, 2016

Heh, sorry. I'll fix the TODOs. :) Developer's haste.

@mbojan
Copy link
Contributor Author

mbojan commented Jul 13, 2016

Done. Seems to pass the check with --no-tests (for some reason I am not able to install rstanarm) and the tests in test-survdiff.R.

@mbojan
Copy link
Contributor Author

mbojan commented Feb 7, 2017

I have rebased against current master. The CI seem to fail because of faulty examples of tidy.orcutt. Running RCMD check on my machine (skipping some of the dependencies) completes OK.

@dgrtwo dgrtwo merged commit 6c7bc02 into tidymodels:master Nov 19, 2017
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants