Omit rows with all NA in confint_tidy() #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion at #324, I re-ran all the problematic examples and as far as I can tell they all work as intended (omitting NA rows). The exception is
confint_tidy()
. I tried adding the same code for rank-deficient models fromprocess_lm()
, but some tidiers callconfint_tidy()
with objects that are not regression models, and therefore lack components likerank
andqr
(e.g. bbmle). So instead I checked for NA rows in the result, and eliminate those.The only issue I can see is that there is no way to tell which rows were eliminated, because
confint_tidy()
just returns two columns with the confidence intervals. This is quite different from othertidy()
results which always include the names of the relevant terms.