Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: use new approximate keys function when result is 0 (#5403) #5414

Merged
merged 5 commits into from Sep 7, 2019
Merged

raftstore: use new approximate keys function when result is 0 (#5403) #5414

merged 5 commits into from Sep 7, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 6, 2019

cherry-pick #5403 to release-3.0

Signed-off-by: root you1474600@gmail.com

What have you changed?

Please explain in detail what the changes are in this PR and why they are needed:

  • Summarize your change
    When the new get_region_approximate_keys_cf function return 0, the get_region_approximate_keys function will downgrade to use the old get_range_entries_and_versions function. For this situation, 0 should be returned.

  • Describe any limitations of the current code (optional)
    Add a test but the the test also passed using old get_range_entries_and_versions function.

What is the type of the changes?

Pick one of the following and delete the others:

  • Bugfix (a change which fixes an issue)

How is the PR tested?

Add a test function raftstore::coprocessor::split_check::keys::tests::test_region_approximate_keys_sub_region.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

Refer to a related PR or issue link (optional)

#5306

@you06
use new approximate keys function when result is 0
91a202c 
Signed-off-by: root <you1474600@gmail.com>
@you06
remove marks
c27a16d 
Signed-off-by: root <you1474600@gmail.com>
@you06
make the tests pass range propreties but failed in mvcc properties
3fd109d 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
format code
28baf1b 
Signed-off-by: you06 <you1474600@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 6, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 6, 2019
Merged
@sre-bot sre-bot added type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick labels Sep 6, 2019
Connor1996
Connor1996 approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@you06
fix path bug
a14a8d3 
Signed-off-by: root <you1474600@gmail.com>
@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=release-3.0

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=master

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/integration-compatibility-test /integration-ddl-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=master

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test

@H-ZeX
Copy link
Contributor

H-ZeX commented Sep 6, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

2 similar comments
@H-ZeX
Copy link
Contributor

H-ZeX commented Sep 6, 2019 •
edited

/run-integration-cop-push-down-test tidb-test=pr/883

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

@you06
Copy link
Contributor

you06 commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=pr/883

@you06
Copy link
Contributor

you06 commented Sep 7, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

1 similar comment
@you06
Copy link
Contributor

you06 commented Sep 7, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

@you06 you06 merged commit 304cc7d into tikv:release-3.0 Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@AndreMouche AndreMouche Awaiting requested review from AndreMouche

Assignees
No one assigned
Labels
type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sre-bot @you06 @zhouqiang-cl @H-ZeX @hicqu @Connor1996