jack

A port of Rack for the JavaScript JSGI web server interface — Read more

Sort by: Priority | Votes | Last Updated

Loading…

14.

0 votes

pull-request
x

pull-request
x

Response.redirect throws exception
1 comment Created about 1 month ago by gmosx

Title

Body
pull-request patch: http://github.com/gmosx/jack/commit/a05b47bf961f05ee8510c1357d6c5fa97f69d836
or cancel

pull-request

patch:
http://github.com/gmosx/jack/commit/a05b47bf961f05ee8510c1357d6c5fa97f69d836

Comments

tlrobinson Thu Nov 19 16:09:46 -0800 2009 | link

SHA: 672f632

Comment
SHA: 672f632c0b1ef6bdfd3da72e3b90f85f3e23ec41
or cancel

Parsed with GitHub Flavored Markdown
13.

0 votes

pull-request
x

Response Constructor and ContentLength middleware set inappropriate headers for 304 responses
3 comments Created about 1 month ago by nrstott

Title

Body
Content-Type should not be set if the status passed into the constructor is a 304. ContentLength Middleware should not add a Content-Length to a 304 response. Here is a commit fixing these issues: http://github.com/nrstott/jack/commit/70604c18b569fd644dcf9b730a6846fb47a630d9
or cancel

Content-Type should not be set if the status passed into the constructor is a 304.

ContentLength Middleware should not add a Content-Length to a 304 response.

Here is a commit fixing these issues:
http://github.com/nrstott/jack/commit/70604c18b569fd644dcf9b730a6846fb47a630d9

Comments

tlrobinson Thu Nov 19 16:39:51 -0800 2009 | link

SHA: 35419c0

Comment
SHA: 35419c0
or cancel

nrstott Thu Nov 19 16:58:07 -0800 2009 | link

what is this SHA?

Comment
what is this SHA?
or cancel

tlrobinson Thu Nov 19 17:18:55 -0800 2009 | link

Oops. SHA: 35419c0

Comment
Oops. SHA: 35419c0c7e684e9d10d6aab3ccc9b890b7410e08
or cancel

Parsed with GitHub Flavored Markdown
10.

1 vote

pull-request
x

session improvements
3 comments Created 2 months ago by gmosx

Title

Body
- explicit session deserialization - only serialize dirty sessions.
or cancel
- explicit session deserialization
- only serialize dirty sessions.
Comments

tlrobinson Wed Oct 14 18:07:59 -0700 2009 | link

Is this a pull request? If so please link to to the commit.

Comment
Is this a pull request? If so please link to to the commit.
or cancel

gmosx Wed Oct 14 22:50:25 -0700 2009 | link

the commit is here:
http://github.com/gmosx/jack/commit/0e3c11d16a29555ec8de571fd6e6c12d4b55b10d

Comment
the commit is here: http://github.com/gmosx/jack/commit/0e3c11d16a29555ec8de571fd6e6c12d4b55b10d
or cancel

tlrobinson Thu Nov 19 16:40:29 -0800 2009 | link

SHA: 18179f6

Comment
SHA: 18179f6f79bc59b6d5f01680ea03c1dc9554d279
or cancel

Parsed with GitHub Flavored Markdown
4.

0 votes

s/platform/engine/g
8 comments Created 4 months ago by tschaub

Title

Body
Since http://github.com/tlrobinson/narwhal/commit/a18eaf5eb105fb5a93957e2950962a6aa3decbd7, jackup doesn't run. Replacing system.platform with system.engine looks to fix things.
or cancel

Since http://github.com/tlrobinson/narwhal/commit/a18eaf5eb105fb5a93957e2950962a6aa3decbd7, jackup doesn't run. Replacing system.platform with system.engine looks to fix things.

Comments

isaacs Mon Aug 10 14:03:52 -0700 2009 | link

Fixed by http://github.com/isaacs/jack/commit/580d9240d89ea931b475916568952dcb72bba63f

Comment
Fixed by http://github.com/isaacs/jack/commit/580d9240d89ea931b475916568952dcb72bba63f
or cancel

isaacs Mon Aug 10 14:17:49 -0700 2009 | link

Whoops, looks like tlrobinson already pushed the change to fix this.

Comment
Whoops, looks like tlrobinson already pushed the change to fix this.
or cancel

tlrobinson Mon Aug 10 14:23:03 -0700 2009 | link

Yup, fixed by http://github.com/tlrobinson/jack/commit/63df3933e29187d34bc1eb8ba529ec3977894e1d from Kris.

Comment
Yup, fixed by http://github.com/tlrobinson/jack/commit/63df3933e29187d34bc1eb8ba529ec3977894e1d from Kris.
or cancel

tschaub Mon Aug 10 14:28:56 -0700 2009 | link

So that leaves one system.platform in http://github.com/tlrobinson/jack/blob/745c51cd8a256a70ef2efe8b28929dd14595287b/lib/jack/handler/fastcgi.js#L1

Comment
So that leaves one system.platform in http://github.com/tlrobinson/jack/blob/745c51cd8a256a70ef2efe8b28929dd14595287b/lib/jack/handler/fastcgi.js#L1
or cancel

tlrobinson Mon Aug 10 14:51:08 -0700 2009 | link

Whoops, fixed by http://github.com/tlrobinson/jack/commit/d279fdd776cc7818ef2292ee7dcc7457dcd33d87

Comment
Whoops, fixed by http://github.com/tlrobinson/jack/commit/d279fdd776cc7818ef2292ee7dcc7457dcd33d87
or cancel

tschaub Mon Aug 10 14:51:43 -0700 2009 | link

Cool. In with http://github.com/isaacs/jack/commit/11bd27067239fef2e0661661ab57988e1a438e4a

Thanks again.

Comment
Cool. In with http://github.com/isaacs/jack/commit/11bd27067239fef2e0661661ab57988e1a438e4a Thanks again.
or cancel

tschaub Mon Aug 10 14:53:14 -0700 2009 | link

/me scratches head and walks away confused by git again

Comment
/me scratches head and walks away confused by git again
or cancel

tlrobinson Mon Aug 10 15:07:36 -0700 2009 | link

Oops I made the change myself instead of merging in Isaacs' fix. That's probably why you're confused.

Comment
Oops I made the change myself instead of merging in Isaacs' fix. That's probably why you're confused.
or cancel

Parsed with GitHub Flavored Markdown
3.

1 vote

Jack: ERROR: ReferenceError: "file" is not defined.
3 comments Created 5 months ago by isaacs

Title

Body
I'm getting this error in Jack's file.js module. To reproduce: 1. Start the example site. jackup jack/examples/example.js 2. Create an "example.txt" file at jack/examples/example.txt 3. Navigate the browser to http://localhost:8080/example.txt Browser shows blank page, log in the terminal shows ERROR: ReferenceError: "file" is not defined. Seems to be related to File = require("file") on line 3 of jack/lib/jack/file.js
or cancel
I'm getting this error in Jack's file.js module. To reproduce:
1. Start the example site. jackup jack/examples/example.js
2. Create an "example.txt" file at jack/examples/example.txt
3. Navigate the browser to http://localhost:8080/example.txt
Browser shows blank page, log in the terminal shows ERROR: ReferenceError: "file" is not defined.

Seems to be related to File = require("file") on line 3 of jack/lib/jack/file.js
Comments

tschaub Wed Aug 05 09:06:06 -0700 2009 | link

Seeing same issue here (making the Static middlewear unusable).

Comment
Seeing same issue here (making the Static middlewear unusable).
or cancel

tlrobinson Mon Aug 10 14:23:42 -0700 2009 | link

Fixed by http://github.com/tlrobinson/jack/commit/745c51cd8a256a70ef2efe8b28929dd14595287b (I think)

Comment
Fixed by http://github.com/tlrobinson/jack/commit/745c51cd8a256a70ef2efe8b28929dd14595287b (I think)
or cancel

tschaub Mon Aug 10 14:43:35 -0700 2009 | link

Works for me. Thanks!

Comment
Works for me. Thanks!
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

Response.redirect
4 comments Created 5 months ago by gmosx

Title

Body
Deprecate in favor of the Redirect middleware?
or cancel

Deprecate in favor of the Redirect middleware?

Comments

kriskowal Fri Jul 31 09:57:30 -0700 2009 | link

I think it should rather be fixed. The Redirect middleware is useful for permanent redirects, but the Response.redirect is more useful for dynamic, parametric redirects. Maybe the default HTTP status could reflect that.

Comment
I think it should rather be fixed. The Redirect middleware is useful for permanent redirects, but the Response.redirect is more useful for dynamic, parametric redirects. Maybe the default HTTP status could reflect that.
or cancel

tlrobinson Mon Aug 10 14:20:13 -0700 2009 | link

I agree with Kris.

Comment
I agree with Kris.
or cancel

gmosx Mon Aug 24 01:29:25 -0700 2009 | link

I provided a fix for this method

Comment
I provided a fix for this method
or cancel

tlrobinson Mon Aug 24 20:36:40 -0700 2009 | link

Thanks, got it.

Comment
Thanks, got it.
or cancel

Parsed with GitHub Flavored Markdown
1.

0 votes

-s server doesn't work
0 comments Created 6 months ago by peller

Title

Body
line 115 of jackup should read var server = options.server
or cancel

line 115 of jackup should read var server = options.server

Comments

Parsed with GitHub Flavored Markdown