tlrobinson / jack forked from 280north/jack
- Source
- Commits
- Network (3)
- Issues (9)
- Downloads (3)
- Wiki (1)
- Graphs
-
Branch:
master
-
1 comment Created about 1 month ago by gmosxpull-requestxResponse.redirect throws exceptionpull-requestxpull-request
patch:
http://github.com/gmosx/jack/commit/a05b47bf961f05ee8510c1357d6c5fa97f69d836Comments
-
3 comments Created about 1 month ago by nrstottResponse Constructor and ContentLength middleware set inappropriate headers for 304 responsespull-requestxContent-Type should not be set if the status passed into the constructor is a 304.
ContentLength Middleware should not add a Content-Length to a 304 response.
Here is a commit fixing these issues:
http://github.com/nrstott/jack/commit/70604c18b569fd644dcf9b730a6846fb47a630d9Comments
tlrobinson
Thu Nov 19 16:39:51 -0800 2009
| link
SHA: 35419c0
tlrobinson
Thu Nov 19 17:18:55 -0800 2009
| link
Oops. SHA: 35419c0
-
- explicit session deserialization
- only serialize dirty sessions.
Comments
tlrobinson
Wed Oct 14 18:07:59 -0700 2009
| link
Is this a pull request? If so please link to to the commit.
the commit is here:
http://github.com/gmosx/jack/commit/0e3c11d16a29555ec8de571fd6e6c12d4b55b10d
tlrobinson
Thu Nov 19 16:40:29 -0800 2009
| link
SHA: 18179f6
-
Since http://github.com/tlrobinson/narwhal/commit/a18eaf5eb105fb5a93957e2950962a6aa3decbd7, jackup doesn't run. Replacing system.platform with system.engine looks to fix things.
Comments
Whoops, looks like tlrobinson already pushed the change to fix this.
tlrobinson
Mon Aug 10 14:23:03 -0700 2009
| link
Yup, fixed by http://github.com/tlrobinson/jack/commit/63df3933e29187d34bc1eb8ba529ec3977894e1d from Kris.
So that leaves one system.platform in http://github.com/tlrobinson/jack/blob/745c51cd8a256a70ef2efe8b28929dd14595287b/lib/jack/handler/fastcgi.js#L1
tlrobinson
Mon Aug 10 14:51:08 -0700 2009
| link
Cool. In with http://github.com/isaacs/jack/commit/11bd27067239fef2e0661661ab57988e1a438e4a
Thanks again.
/me scratches head and walks away confused by git again
tlrobinson
Mon Aug 10 15:07:36 -0700 2009
| link
Oops I made the change myself instead of merging in Isaacs' fix. That's probably why you're confused.
-
Jack: ERROR: ReferenceError: "file" is not defined.
3 comments Created 5 months ago by isaacsI'm getting this error in Jack's file.js module. To reproduce:
- Start the example site. jackup jack/examples/example.js
- Create an "example.txt" file at jack/examples/example.txt
- Navigate the browser to http://localhost:8080/example.txt
Browser shows blank page, log in the terminal shows ERROR: ReferenceError: "file" is not defined.
Seems to be related to File = require("file") on line 3 of jack/lib/jack/file.js
Comments
Seeing same issue here (making the Static middlewear unusable).
tlrobinson
Mon Aug 10 14:23:42 -0700 2009
| link
- Start the example site. jackup jack/examples/example.js
-
Deprecate in favor of the Redirect middleware?
Comments
I think it should rather be fixed. The Redirect middleware is useful for permanent redirects, but the Response.redirect is more useful for dynamic, parametric redirects. Maybe the default HTTP status could reflect that.
tlrobinson
Mon Aug 10 14:20:13 -0700 2009
| link
I agree with Kris.
tlrobinson
Mon Aug 24 20:36:40 -0700 2009
| link
Thanks, got it.
-
line 115 of jackup should read var server = options.server
Comments





SHA: 672f632