@@ -35,6 +35,7 @@ #endif #include <fcntl.h> +#include <stdio.h> #include <stdlib.h> #include <unistd.h> @@ -56,15 +57,33 @@ int daemonize(int nochdir, int noclose) if (setsid() == -1) return (-1); - if (nochdir == 0) - (void)chdir("/"); + if (nochdir == 0) { + if(chdir("/") != 0) { + perror("chdir"); + return (-1); + } + } if (noclose == 0 && (fd = open("/dev/null", O_RDWR, 0)) != -1) { - (void)dup2(fd, STDIN_FILENO); - (void)dup2(fd, STDOUT_FILENO); - (void)dup2(fd, STDERR_FILENO); - if (fd > STDERR_FILENO) - (void)close(fd); + if(dup2(fd, STDIN_FILENO) < 0) { + perror("dup2 stdin"); + return (-1); + } + if(dup2(fd, STDOUT_FILENO) < 0) { + perror("dup2 stdout"); + return (-1); + } + if(dup2(fd, STDERR_FILENO) < 0) { + perror("dup2 stderr"); + return (-1); + } + + if (fd > STDERR_FILENO) { + if(close(fd) < 0) { + perror("close"); + return (-1); + } + } } return (0); } daemon.c ad00048ad5373ad62c96c47845c3221ab47eaa7e Dustin Sallings dustin@spy.net http://github.com/tmaesaka/memcached/commit/2c196ed6cacfd3eea845a3b9a5758a698096d97b 2c196ed6cacfd3eea845a3b9a5758a698096d97b 2009-01-20T11:23:14-08:00 2009-01-19T15:45:38-08:00 Build fixes for ubuntu 8.10/64. gcc seems to have been wise to all of the syscalls being cast to void to avoid doing real result checking in unlikely errors. dda6ba0ad959dc58e60f95f4f5f14952fae8ff1c Dustin Sallings dustin@spy.net