@@ -34,7 +34,8 @@ window.addEventListener('load', function(e){ }, false); function share(){ - var item = new get_current_item(); + var item = get_current_item(); + if(!item) return; // for Tombloo var ctx = update({ document : doc, @@ -84,13 +85,28 @@ function addClass(e, cl){ : (e.className = cl); } function get_current_item(){ + var item = { + parent: null, + body: null, + target: null, + feed: { + channel: { + link: null + } + } + }, link; try { - this.parent = $x('id("current-entry")/descendant::div[contains(concat(" ", normalize-space(@class), " "), " entry-container ")]'); - this.body = $x('id("current-entry")/descendant::div[contains(concat(" ", normalize-space(@class), " "), " item-body ")]'); - this.target = $x('id("current-entry")/descendant::a[contains(concat(" ", normalize-space(@class), " "), " entry-title-link ")]'); - this.feed = { channel:{ } }; - this.feed.channel.link = decodeURIComponent($x('id("current-entry")/descendant::a[contains(concat(" ", normalize-space(@class), " "), " entry-source-title ")]').href.replace(/^.*\/(?=http)/, '')); + item.parent = $x('id("current-entry")/descendant::div[contains(concat(" ", normalize-space(@class), " "), " entry-container ")]') || null; + item.body = $x('id("current-entry")/descendant::div[contains(concat(" ", normalize-space(@class), " "), " item-body ")]') || null; + item.target = $x('id("current-entry")/descendant::a[contains(concat(" ", normalize-space(@class), " "), " entry-title-link ")]') || null; + link = $x('id("current-entry")/descendant::a[contains(concat(" ", normalize-space(@class), " "), " entry-source-title ")]') || null; + if(link && link.href) item.feed.channel.link = decodeURIComponent(link.href.replace(/^.*\/(?=http)/, '')); + if(!item.parent || !item.body || !item.target || !item.feed.channel.link){ + throw 'get_current_item error'; + } else { + return item; + } } catch (e) { - alert(e); + return null; } } greasemonkey/googlereadertombloo.user.js 6cdce2525da1f1ec89a0e424f9f34b5ab775f525 Constellation utatane.tea@gmail.com http://github.com/to/tombloo/commit/c352b289a0a6855c63b2a647936a3ce302ad98ad c352b289a0a6855c63b2a647936a3ce302ad98ad 2009-01-19T04:44:24-08:00 2009-01-19T04:44:24-08:00 * fix error on getting item from GoogleReader (GoogleReader + Tombloo) Fix get_current_item function not to raise error. a99590073a489f1c1d282087b87f462fe546bad1 Constellation utatane.tea@gmail.com