@@ -158,8 +158,10 @@ class XmlNode
if c.is_a?(REXML::CData)
return @element.replace_child(c,new_cdata)
end
- end
+ end
@element << new_cdata
+ rescue RuntimeError => e
+ @element << REXML::Text.new(e.message)
end
def cdata
lib/xml_node.rb
@@ -64,7 +64,7 @@ class TestXmlNode < Test::Unit::TestCase
end
def test_generate_nice_xml
- assert_equal "<?xml version='1.0'?>\n<feed>\n <element>test</element>\n <element/>\n</feed>", XmlNode.new('feed') { |n| n << XmlNode.new('element', 'test'); n << XmlNode.new('element') }.to_xml
+ assert_equal "<?xml version='1.0'?>\n<feed>\n<element>\ntest\n</element>\n<element/>\n</feed>", XmlNode.new('feed') { |n| n << XmlNode.new('element', 'test'); n << XmlNode.new('element') }.to_xml
end
def test_add_array_of_nodes
@@ -78,6 +78,12 @@ class TestXmlNode < Test::Unit::TestCase
def test_nil
assert_equal '<nil/>', XmlNode.new('nil', nil).to_s
+ end
+
+ def test_fail_by_stating_error_when_cdata_is_nested
+ a = XmlNode.new('root')
+ a.cdata = ']]>'
+ assert_equal "<?xml version='1.0'?>\n<root>\nIllegal character ']]>' in raw string "]]>"\n</root>", a.to_xml
end
test/test_generating.rb
@@ -35,9 +35,16 @@ class TestXmlNode < Test::Unit::TestCase
assert_equal '1', xml.find(:first, '//elem').text
end
+ def test_find_first
+ xml = XmlNode.parse('<feed><elem>1</elem><elem>2</elem><elem>3</elem></feed>')
+ assert_equal '1', xml.find(:first, '//elem').text
+ end
+
def test_find_all
xml = XmlNode.parse('<feed><elem>1</elem><elem>2</elem><elem>3</elem></feed>')
assert_equal ['1', '2', '3'], xml.find(:all, '//elem').collect(&:text)
- end
+ end
+
+
end
\ No newline at end of file
test/test_parsing.rb
8cce3d86f733e6e8d14d2db102943513c67ec6b6
Tobias Lütke
tobi@jadedpixel.com
http://github.com/tobi/xml_node/commit/f9fb74b22468c638ffa327850b396a002c428cd1
f9fb74b22468c638ffa327850b396a002c428cd1
2008-07-07T09:57:35-07:00
2008-07-07T09:57:35-07:00
Handle nested CData sections by stating the error in the resulting XML
56de66ff5e69360af0444bb7a5da13a7e1ef7e94
Tobias Lütke
tobi@jadedpixel.com