Skip to content

Commit

Permalink
crypto: user - fix memory leak in crypto_reportstat
Browse files Browse the repository at this point in the history
In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
leaked if crypto_reportstat_alg() fails. Required release for skb is
added.

Fixes: cac5818 ("crypto: user - Implement a generic crypto statistics")
Cc: <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Navidem authored and herbertx committed Oct 10, 2019
1 parent ffdde59 commit c03b04d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion crypto/crypto_user_stat.c
Expand Up @@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);

if (err)
if (err) {
kfree_skb(skb);
return err;
}

return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}
Expand Down

0 comments on commit c03b04d

Please sign in to comment.